Re: [libvirt] [PATCH v2] qemu: Fix serial stub console allocation
On Thu, Jun 01, 2017 at 14:57:59 +0200, Erik Skultety wrote: > When adding the aliased serial stub console, the structure wasn't > properly allocated (VIR_ALLOC instead of virDomainChrDefNew) which then > resulted in SIGSEGV in virDomainChrSourceIsEqual during a serial device > coldplug. > > https://bugzilla.redhat.com/show_bug.cgi?id=1434278 > > Signed-off-by: Erik Skultety> --- > src/qemu/qemu_hotplug.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) ACK, we do the same (crazy) thing in virDomainDefAddConsoleCompat signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2] qemu: Fix serial stub console allocation
On Thu, Jun 01, 2017 at 02:57:59PM +0200, Erik Skultety wrote: > When adding the aliased serial stub console, the structure wasn't > properly allocated (VIR_ALLOC instead of virDomainChrDefNew) which then > resulted in SIGSEGV in virDomainChrSourceIsEqual during a serial device > coldplug. > > https://bugzilla.redhat.com/show_bug.cgi?id=1434278 > > Signed-off-by: Erik Skultety> --- > src/qemu/qemu_hotplug.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > ping Erik -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list