Re: [libvirt] [PATCH v2 0/2] qemu: cpu: fix "full" CPU to include all "reported" CPU features

[Jiri Denemark]

On Wed, Apr 18, 2018 at 12:14:35 +0300, Nikolay Shirokovskiy wrote:
> 
> 
> On 18.04.2018 12:11, Jiri Denemark wrote:
> > On Wed, Apr 11, 2018 at 11:57:30 +0300, Nikolay Shirokovskiy wrote:
> >> diff from v1:
> >> - add test data for CPU for which issue was triggered
> >>
> >> Patch 1 adds tests for CPU on which problem was detected. However we
> >> don't test  case which have
> >> issue.
> >>
> >> Patch 2 is actual fix.
> >>
> >> Nikolay Shirokovskiy (2):
> >>   cputest: New test for Intel Core i5-650
> >>   qemu: cpu: fix "full" CPU to include all "reported" CPU features
> > 
> > Oh I see. Thanks for the CPU data which helped me understand what
> > problem you are fixing. The patch is indeed correct, but I can't push it
> > since it is missing the Signed-off-by line. You can either resubmit the
> > patches with SoB line added or just reply with the SoB line here and
> > I'll update the patches before pushing.
> > 
> > Series
> > 
> > Reviewed-by: Jiri Denemark 
> > 
> 
> Ahhh, keep forgetting SoB.
> 
> Signed-off-by: Nikolay Shirokovskiy 

Thanks, I updated the patches and pushed them.

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/2] qemu: cpu: fix "full" CPU to include all "reported" CPU features

[Nikolay Shirokovskiy]

On 18.04.2018 12:11, Jiri Denemark wrote:
> On Wed, Apr 11, 2018 at 11:57:30 +0300, Nikolay Shirokovskiy wrote:
>> diff from v1:
>> - add test data for CPU for which issue was triggered
>>
>> Patch 1 adds tests for CPU on which problem was detected. However we
>> don't test  case which have
>> issue.
>>
>> Patch 2 is actual fix.
>>
>> Nikolay Shirokovskiy (2):
>>   cputest: New test for Intel Core i5-650
>>   qemu: cpu: fix "full" CPU to include all "reported" CPU features
> 
> Oh I see. Thanks for the CPU data which helped me understand what
> problem you are fixing. The patch is indeed correct, but I can't push it
> since it is missing the Signed-off-by line. You can either resubmit the
> patches with SoB line added or just reply with the SoB line here and
> I'll update the patches before pushing.
> 
> Series
> 
> Reviewed-by: Jiri Denemark 
> 

Ahhh, keep forgetting SoB.

Signed-off-by: Nikolay Shirokovskiy 

Thanx!

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/2] qemu: cpu: fix "full" CPU to include all "reported" CPU features

[Jiri Denemark]

On Wed, Apr 11, 2018 at 11:57:30 +0300, Nikolay Shirokovskiy wrote:
> diff from v1:
> - add test data for CPU for which issue was triggered
> 
> Patch 1 adds tests for CPU on which problem was detected. However we
> don't test  case which have
> issue.
> 
> Patch 2 is actual fix.
> 
> Nikolay Shirokovskiy (2):
>   cputest: New test for Intel Core i5-650
>   qemu: cpu: fix "full" CPU to include all "reported" CPU features

Oh I see. Thanks for the CPU data which helped me understand what
problem you are fixing. The patch is indeed correct, but I can't push it
since it is missing the Signed-off-by line. You can either resubmit the
patches with SoB line added or just reply with the SoB line here and
I'll update the patches before pushing.

Series

Reviewed-by: Jiri Denemark 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list