subject:"Re\: \[libvirt\] \[dbus PATCH\] APIs should appear in aplhabetical order in all files."

Re: [libvirt] [dbus PATCH] APIs should appear in aplhabetical order in all files.

2018-04-12 Thread Katerina Koukiou

On Thu, 2018-04-12 at 11:42 +0200, Katerina Koukiou wrote:
> In C and XML files the order is:
> 1) properties
> 2) methods
> 3) signals
> All of them sorted in their category alphabetically.
> 
> Signed-off-by: Katerina Koukiou 
> ---
>  data/org.libvirt.Connect.xml |  12 +--
>  data/org.libvirt.Domain.xml  |  54 ++--
>  src/connect.c|   2 +-
>  src/domain.c | 200 +--
> 
>  4 files changed, 134 insertions(+), 134 deletions(-)
> 
> diff --git a/data/org.libvirt.Connect.xml
> b/data/org.libvirt.Connect.xml
> index 5b49ed9..55260cc 100644
> --- a/data/org.libvirt.Connect.xml
> +++ b/data/org.libvirt.Connect.xml
> @@ -25,12 +25,6 @@
>  value="See https://libvirt.org/html/libvirt-libvirt-host.htm
> l#virConnectGetVersion"/>;
>  
> -
> -   -value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virConnectListAllDomains"/>;
> -  
> -  
> -
>  
>  value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainCreateXML"/>;
> @@ -73,6 +67,12 @@
>
>
>  
> +
> +   +value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virConnectListAllDomains"/>;
> +  
> +  
> +
>  
>  value="See https://libvirt.org/html/libvirt-libvirt-network.
> html#virConnectListAllNetworks"/>;
> diff --git a/data/org.libvirt.Domain.xml
> b/data/org.libvirt.Domain.xml
> index 7679018..78378bb 100644
> --- a/data/org.libvirt.Domain.xml
> +++ b/data/org.libvirt.Domain.xml
> @@ -3,25 +3,25 @@
>  
>  
>
> -
> +
> -value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainGetName"/>;
> +value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainIsActive"/>;
>  
> -
> +
> -value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainGetUUIDString"/>;
> +value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainGetAutostart"/>;
>  
>  
>  value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainGetID"/>;
>  
> -
> +
> -value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainGetOSType"/>;
> +value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainGetName"/>;
>  
> -
> +
> -value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainIsActive"/>;
> +value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainGetOSType"/>;
>  
>  
> @@ -31,21 +31,19 @@
>  value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainGetState"/>;
>  
> -
> +
> -value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainGetAutostart"/>;
> +value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainGetUUIDString"/>;
>  
> -
> +
> -value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainGetVcpusFlags"/>;
> +value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainCreateWithFlags"/>;
>
> -  
>  
> -
> +
> -value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainGetXMLDesc"/>;
> +value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainDestroyFlags"/>;
>
> -  
>  
>  
> @@ -54,15 +52,17 @@
>
>
>  
> -
> +
> -value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainShutdownFlags"/>;
> +value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainGetVcpusFlags"/>;
>
> +  
>  
> -
> +
> -value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainDestroyFlags"/>;
> +value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainGetXMLDesc"/>;
>
> +  
>  
>  
> @@ -74,23 +74,23 @@
>  value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainReset"/>;
>
>  
> -
> +
> -value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainCreateWithFlags"/>;
> -  
> +value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainResume"/>;
>  
> -
> +
> -value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainUndefineFlags"/>;
> +value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainShutdownFlags"/>;
>
>  
>  
>  value="See https://libvirt.org/html/libvirt-libvirt-domain.h
> tml#virDomainSuspend"/>;
>  
>

Re: [libvirt] [dbus PATCH] APIs should appear in aplhabetical order in all files.

2018-04-09 Thread Katerina Koukiou

On Mon, 2018-04-09 at 17:45 +0200, Pavel Hrdina wrote:
> On Mon, Apr 09, 2018 at 05:10:48PM +0200, Katerina Koukiou wrote:
> > In C and XML files the order is:
> > 1) properties
> > 2) methods
> > 3) signals
> > All of them sorted in their category alphabetically.
> > 
> > Signed-off-by: Katerina Koukiou 
> > ---
> >  data/org.libvirt.Connect.xml |  12 +--
> >  data/org.libvirt.Domain.xml  |  54 ++--
> >  src/connect.c|   2 +-
> >  src/domain.c | 200 +
> > --
> >  4 files changed, 134 insertions(+), 134 deletions(-)
> 
> I would split it into two patches, one per each file to make the diff
> less crazy.  I'm also considering to split it per every
> property/method
> move to make the diff clean and obvious that it's a simple
> move.  It's
> easy to miss something.

Ok I 'll split per property/method and repost. I agree the patch is not
readable.

> 
> > diff --git a/data/org.libvirt.Connect.xml
> > b/data/org.libvirt.Connect.xml
> > index 5b49ed9..55260cc 100644
> > --- a/data/org.libvirt.Connect.xml
> > +++ b/data/org.libvirt.Connect.xml
> > @@ -25,12 +25,6 @@
> > >  value="See https://libvirt.org/html/libvirt-libvirt-host.h
> > tml#virConnectGetVersion"/>;
> >  
> > -
> > -   > -value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virConnectListAllDomains"/>;
> > -  
> > -  
> > -
> >  
> > >  value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainCreateXML"/>;
> > @@ -73,6 +67,12 @@
> >
> >
> >  
> > +
> > +   > +value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virConnectListAllDomains"/>;
> > +  
> > +  
> > +
> >  
> > >  value="See https://libvirt.org/html/libvirt-libvirt-networ
> > k.html#virConnectListAllNetworks"/>;
> > diff --git a/data/org.libvirt.Domain.xml
> > b/data/org.libvirt.Domain.xml
> > index 7679018..78378bb 100644
> > --- a/data/org.libvirt.Domain.xml
> > +++ b/data/org.libvirt.Domain.xml
> > @@ -3,25 +3,25 @@
> >  
> >  
> >
> > -
> > +
> > > -value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainGetName"/>;
> > +value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainIsActive"/>;
> >  
> > -
> > +
> > > -value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainGetUUIDString"/>;
> > +value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainGetAutostart"/>;
> >  
> >  
> > >  value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainGetID"/>;
> >  
> > -
> > +
> > > -value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainGetOSType"/>;
> > +value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainGetName"/>;
> >  
> > -
> > +
> > > -value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainIsActive"/>;
> > +value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainGetOSType"/>;
> >  
> >  
> > > @@ -31,21 +31,19 @@
> > >  value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainGetState"/>;
> >  
> > -
> > +
> > > -value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainGetAutostart"/>;
> > +value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainGetUUIDString"/>;
> >  
> > -
> > +
> > > -value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainGetVcpusFlags"/>;
> > +value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainCreateWithFlags"/>;
> >
> > -  
> >  
> > -
> > +
> > > -value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainGetXMLDesc"/>;
> > +value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainDestroyFlags"/>;
> >
> > -  
> >  
> >  
> > > @@ -54,15 +52,17 @@
> >
> >
> >  
> > -
> > +
> > > -value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainShutdownFlags"/>;
> > +value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainGetVcpusFlags"/>;
> >
> > +  
> >  
> > -
> > +
> > > -value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainDestroyFlags"/>;
> > +value="See https://libvirt.org/html/libvirt-libvirt-domain
> > .html#virDomainGetXMLDesc"/>;
> >
> > +  
> >  
> >  
> > > @@ -74,23 +74,23 @@
> >

Re: [libvirt] [dbus PATCH] APIs should appear in aplhabetical order in all files.

2018-04-09 Thread Pavel Hrdina

On Mon, Apr 09, 2018 at 05:10:48PM +0200, Katerina Koukiou wrote:
> In C and XML files the order is:
> 1) properties
> 2) methods
> 3) signals
> All of them sorted in their category alphabetically.
> 
> Signed-off-by: Katerina Koukiou 
> ---
>  data/org.libvirt.Connect.xml |  12 +--
>  data/org.libvirt.Domain.xml  |  54 ++--
>  src/connect.c|   2 +-
>  src/domain.c | 200 
> +--
>  4 files changed, 134 insertions(+), 134 deletions(-)

I would split it into two patches, one per each file to make the diff
less crazy.  I'm also considering to split it per every property/method
move to make the diff clean and obvious that it's a simple move.  It's
easy to miss something.

> diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
> index 5b49ed9..55260cc 100644
> --- a/data/org.libvirt.Connect.xml
> +++ b/data/org.libvirt.Connect.xml
> @@ -25,12 +25,6 @@
>  value="See 
> https://libvirt.org/html/libvirt-libvirt-host.html#virConnectGetVersion"/>
>  
> -
> -   -value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virConnectListAllDomains"/>
> -  
> -  
> -
>  
>  value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainCreateXML"/>
> @@ -73,6 +67,12 @@
>
>
>  
> +
> +   +value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virConnectListAllDomains"/>
> +  
> +  
> +
>  
>  value="See 
> https://libvirt.org/html/libvirt-libvirt-network.html#virConnectListAllNetworks"/>
> diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
> index 7679018..78378bb 100644
> --- a/data/org.libvirt.Domain.xml
> +++ b/data/org.libvirt.Domain.xml
> @@ -3,25 +3,25 @@
>  
>  
>
> -
> +
> -value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetName"/>
> +value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainIsActive"/>
>  
> -
> +
> -value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetUUIDString"/>
> +value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetAutostart"/>
>  
>  
>  value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetID"/>
>  
> -
> +
> -value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetOSType"/>
> +value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetName"/>
>  
> -
> +
> -value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainIsActive"/>
> +value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetOSType"/>
>  
>  
> @@ -31,21 +31,19 @@
>  value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetState"/>
>  
> -
> +
> -value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetAutostart"/>
> +value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetUUIDString"/>
>  
> -
> +
> -value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetVcpusFlags"/>
> +value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainCreateWithFlags"/>
>
> -  
>  
> -
> +
> -value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetXMLDesc"/>
> +value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainDestroyFlags"/>
>
> -  
>  
>  
> @@ -54,15 +52,17 @@
>
>
>  
> -
> +
> -value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainShutdownFlags"/>
> +value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetVcpusFlags"/>
>
> +  
>  
> -
> +
> -value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainDestroyFlags"/>
> +value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetXMLDesc"/>
>
> +  
>  
>  
> @@ -74,23 +74,23 @@
>  value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainReset"/>
>
>  
> -
> +
> -value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainCreateWithFlags"/>
> -  
> +value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainResume"/>
>  
> -
> +
> -value="See 
> https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainUndefineFlags"/>
> +value="See 
>

Re: [libvirt] [dbus PATCH] APIs should appear in aplhabetical order in all files.

Re: [libvirt] [dbus PATCH] APIs should appear in aplhabetical order in all files.

Re: [libvirt] [dbus PATCH] APIs should appear in aplhabetical order in all files.

3 matches

Site Navigation

Mail list logo

Footer information