Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
On Mon, Apr 02, 2012 at 10:42:21AM -0400, Laine Stump wrote: On 04/02/2012 06:43 AM, Philipp Hahn wrote: The patch still aplies, but sending new version as you requested. Still compiles (with minor problems regarding undefined IFLA_PORT_MAX and broken libnl on my Debian-Squeeze here) What is the version of libnl? Different versions of libnl are unfortunately not API compatible. libvirt's libnl usage has been developed for / tested with libnl 1.1. This is what's being used in Debian. Ubuntu builds againt libnl 3 AFAIK. Cheers, -- Guido -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
Hi Laine, On Tue, Apr 03, 2012 at 08:27:39PM +0200, Guido Günther wrote: On Tue, Apr 03, 2012 at 09:22:56AM +0200, Philipp Hahn wrote: Hello, On Tuesday 27 March 2012 18:30:17 Guido Günther wrote: On Mon, Mar 26, 2012 at 10:32:23AM +0800, Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. ... Please give it a try ! Stability and portability feedback are really welcome as we didn't had a release in Feb and the risk of having something messed up is slightly higher than usual ! Looks good so far on Debian's autobuilders: https://buildd.debian.org/status/package.php?p=libvirtsuite=experimental Compiling 0.9.11-rc on a Debian-Squeeze (EGLIBC 2.11.3-2, Kernel 2.6.32-52, gcc 4.4.5-8.) fails with CC libvirt_util_la-virnetdevbandwidth.lo util/virnetdev.c:1220: error: 'IFLA_VF_MAX' undeclared here (not in a function) The following patch fixes that for me: --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -1215,7 +1215,7 @@ virNetDevGetVirtualFunctionInfo(const char *vfname ATTRIBUTE_UNUSED, return -1; } #endif /* !__linux__ */ -#if defined(__linux__) defined(HAVE_LIBNL) +#if defined(__linux__) defined(HAVE_LIBNL) defined(IFLA_VF_MAX) This looks reasonable to me since this isn't available in Debian Squeeze's kernel headers and I don't think it's worth a separate configure check since we'd only check for IFLA_VF_MAX there. Can I go ahead and push this change? Cheers, -- Guido -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
On Fri, Apr 13, 2012 at 02:13:59PM +0200, Guido Günther wrote: Hi Laine, On Tue, Apr 03, 2012 at 08:27:39PM +0200, Guido Günther wrote: On Tue, Apr 03, 2012 at 09:22:56AM +0200, Philipp Hahn wrote: Hello, On Tuesday 27 March 2012 18:30:17 Guido Günther wrote: On Mon, Mar 26, 2012 at 10:32:23AM +0800, Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. ... Please give it a try ! Stability and portability feedback are really welcome as we didn't had a release in Feb and the risk of having something messed up is slightly higher than usual ! Looks good so far on Debian's autobuilders: https://buildd.debian.org/status/package.php?p=libvirtsuite=experimental Compiling 0.9.11-rc on a Debian-Squeeze (EGLIBC 2.11.3-2, Kernel 2.6.32-52, gcc 4.4.5-8.) fails with CC libvirt_util_la-virnetdevbandwidth.lo util/virnetdev.c:1220: error: 'IFLA_VF_MAX' undeclared here (not in a function) The following patch fixes that for me: --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -1215,7 +1215,7 @@ virNetDevGetVirtualFunctionInfo(const char *vfname ATTRIBUTE_UNUSED, return -1; } #endif /* !__linux__ */ -#if defined(__linux__) defined(HAVE_LIBNL) +#if defined(__linux__) defined(HAVE_LIBNL) defined(IFLA_VF_MAX) This looks reasonable to me since this isn't available in Debian Squeeze's kernel headers and I don't think it's worth a separate configure check since we'd only check for IFLA_VF_MAX there. Can I go ahead and push this change? ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
Hello Guido,
Am Freitag 13 April 2012 15:10:49 schrieb Guido Günther:
könntest Du das als richtigen Patch schicken, dann apply ich das.
[Guido asks me to send a full patch, so he can apply it.]
Sure, see the attached patch.
Sincerely
Philipp
--
Philipp Hahn Open Source Software Engineer h...@univention.de
Univention GmbHbe open. fon: +49 421 22 232- 0
Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99
http://www.univention.de/
From 800a2689ea22842abebdff8568f105ca28dfad15 Mon Sep 17 00:00:00 2001
From: Philipp Hahn h...@univention.de
Date: Fri, 13 Apr 2012 15:43:58 +0200
Subject: [PATCH] virnetdev: Check for defined IFLA_VF_*
To: libvir-list@redhat.com
The linux-2.6.32 kernel header does not yet define IFLA_VF_MAX and others,
which breaks compiling a new libvirt on old systems like Debian Squeeze.
(I also have to add --without-macvtap --disable-werror --without-virtualport to
./configure to get it to compile.)
Signed-off-by: Philipp Hahn h...@univention.de
---
src/util/virnetdev.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index ec7435a..460aa83 100644
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -1215,7 +1215,7 @@ virNetDevGetVirtualFunctionInfo(const char *vfname ATTRIBUTE_UNUSED,
return -1;
}
#endif /* !__linux__ */
-#if defined(__linux__) defined(HAVE_LIBNL)
+#if defined(__linux__) defined(HAVE_LIBNL) defined(IFLA_VF_MAX)
static struct nla_policy ifla_vf_policy[IFLA_VF_MAX+1] = {
[IFLA_VF_MAC] = { .type = NLA_UNSPEC,
--
1.7.2.5
signature.asc
Description: This is a digitally signed message part.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
On Fri, Apr 13, 2012 at 03:52:46PM +0200, Philipp Hahn wrote:
Hello Guido,
Am Freitag 13 April 2012 15:10:49 schrieb Guido Günther:
könntest Du das als richtigen Patch schicken, dann apply ich das.
[Guido asks me to send a full patch, so he can apply it.]
Sure, see the attached patch.
Pushed. Thanks!
-- Guido
Sincerely
Philipp
--
Philipp Hahn Open Source Software Engineer h...@univention.de
Univention GmbHbe open. fon: +49 421 22 232- 0
Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99
http://www.univention.de/
From 800a2689ea22842abebdff8568f105ca28dfad15 Mon Sep 17 00:00:00 2001
From: Philipp Hahn h...@univention.de
Date: Fri, 13 Apr 2012 15:43:58 +0200
Subject: [PATCH] virnetdev: Check for defined IFLA_VF_*
To: libvir-list@redhat.com
The linux-2.6.32 kernel header does not yet define IFLA_VF_MAX and others,
which breaks compiling a new libvirt on old systems like Debian Squeeze.
(I also have to add --without-macvtap --disable-werror --without-virtualport
to
./configure to get it to compile.)
Signed-off-by: Philipp Hahn h...@univention.de
---
src/util/virnetdev.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index ec7435a..460aa83 100644
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -1215,7 +1215,7 @@ virNetDevGetVirtualFunctionInfo(const char *vfname
ATTRIBUTE_UNUSED,
return -1;
}
#endif /* !__linux__ */
-#if defined(__linux__) defined(HAVE_LIBNL)
+#if defined(__linux__) defined(HAVE_LIBNL) defined(IFLA_VF_MAX)
static struct nla_policy ifla_vf_policy[IFLA_VF_MAX+1] = {
[IFLA_VF_MAC] = { .type = NLA_UNSPEC,
--
1.7.2.5
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
Hello,
On Tuesday 27 March 2012 18:30:17 Guido Günther wrote:
On Mon, Mar 26, 2012 at 10:32:23AM +0800, Daniel Veillard wrote:
As scheduled, we are entering the freeze for 0.9.11.
...
Please give it a try ! Stability and portability feedback are really
welcome as we didn't had a release in Feb and the risk of having
something messed up is slightly higher than usual !
Looks good so far on Debian's autobuilders:
https://buildd.debian.org/status/package.php?p=libvirtsuite=experimental
Compiling 0.9.11-rc on a Debian-Squeeze (EGLIBC 2.11.3-2, Kernel 2.6.32-52,
gcc 4.4.5-8.) fails with
CC libvirt_util_la-virnetdevbandwidth.lo
util/virnetdev.c:1220: error: 'IFLA_VF_MAX' undeclared here (not in a
function)
The following patch fixes that for me:
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -1215,7 +1215,7 @@ virNetDevGetVirtualFunctionInfo(const char *vfname
ATTRIBUTE_UNUSED,
return -1;
}
#endif /* !__linux__ */
-#if defined(__linux__) defined(HAVE_LIBNL)
+#if defined(__linux__) defined(HAVE_LIBNL) defined(IFLA_VF_MAX)
static struct nla_policy ifla_vf_policy[IFLA_VF_MAX+1] = {
[IFLA_VF_MAC] = { .type = NLA_UNSPEC,
I also have to explicitly disable -Werror (error about 'const', 'pure' and an
undeclared 'inline' function in netlink/object.h), virtualport and
macvtap(also IFLA_VF_*), since configure doesn't disable them automatically:
./configure --without-macvtap --disable-werror --without-virtualport
Without those options I get:
...
checking whether compiler handles -Wno-suggest-attribute=pure... yes
checking whether compiler handles -Wno-suggest-attribute=const... yes
...
checking whether to compile with macvtap support... yes
checking whether MACVLAN_MODE_PASSTHRU is declared... no
checking whether to compile with virtual port support... no
checking for LIBNL... yes
There was some discussion some time ago on libvirt about puting the check for
IFLA_VF_* in configure instead of in the *.c files, but I haven't found a
patch yet.
Sincerely
Philipp
--
Philipp Hahn Open Source Software Engineer h...@univention.de
Univention GmbHbe open. fon: +49 421 22 232- 0
Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99
http://www.univention.de/
signature.asc
Description: This is a digitally signed message part.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
2012/4/2 Maxim Sditanov feni...@rambler.ru 2012/4/2 Jiri Denemark jdene...@redhat.com On Sat, Mar 31, 2012 at 21:35:50 -0400, Laine Stump wrote: On 03/31/2012 07:56 AM, Daniel Veillard wrote: I just made the second release candidate ftp://libvirt.org/libvirt/libvirt-0.9.11-rc2.tar.gz along with the rpms and tagged the git tree. It seems to work okay in my limited testing. If all goes well I would probably push on Tuesday, A gentoo user reported in irc (#virt on irc.oftc.net) earlier today that builds were failing for him on a fresh checkout from git: feniksa hi, when i compile libvirt on my gentoo i get warning: cc1: warning: unrecognized command line option -Wno-suggest-attribute=const cc1: warning: unrecognized command line option -Wno-suggest-attribute=pure feniksa gcc (Gentoo 4.5.3-r2 p1.1, pie-0.4.7) 4.5.3 feniksa last part of conf: http://pastebin.com/gnT4Y2Ba and compile log http://pastebin.com/FcSwshzS It's important to note that those warnings never show up on their own. They are only printed in case there is something else the compiler warns about (libnl header issue covered by gentoo bug #366561 in this case). Yes, this warning present in gentoo libnl-1.1-r2 and patch doesn't present in gentoo main tree. I will try to contact with gentoo maintainer and ask to make some activity. And I remember seeing it since these gcc options were introduced several releases ago. This option present in gcc 4.5.3 (i made test on hello world). No warning about unrecognized params with another files. Also, other files compile without warning. You can see it on this part of log: http://pastebin.com/wPnLJ1Fx (verbose build mode) I think, this is not problem of libvirt Good news. gentoo applied patch to upstream for libnl-1.1 https://bugs.gentoo.org/show_bug.cgi?id=366561 This patch will enable ability to build libvirt on gentoo with -Wwarning=error by default, without crutches -- With best wishes, Feniks Gordon Freeman -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
On Tue, Apr 03, 2012 at 09:22:56AM +0200, Philipp Hahn wrote:
Hello,
On Tuesday 27 March 2012 18:30:17 Guido Günther wrote:
On Mon, Mar 26, 2012 at 10:32:23AM +0800, Daniel Veillard wrote:
As scheduled, we are entering the freeze for 0.9.11.
...
Please give it a try ! Stability and portability feedback are really
welcome as we didn't had a release in Feb and the risk of having
something messed up is slightly higher than usual !
Looks good so far on Debian's autobuilders:
https://buildd.debian.org/status/package.php?p=libvirtsuite=experimental
Compiling 0.9.11-rc on a Debian-Squeeze (EGLIBC 2.11.3-2, Kernel 2.6.32-52,
gcc 4.4.5-8.) fails with
CC libvirt_util_la-virnetdevbandwidth.lo
util/virnetdev.c:1220: error: 'IFLA_VF_MAX' undeclared here (not in a
function)
The following patch fixes that for me:
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -1215,7 +1215,7 @@ virNetDevGetVirtualFunctionInfo(const char *vfname
ATTRIBUTE_UNUSED,
return -1;
}
#endif /* !__linux__ */
-#if defined(__linux__) defined(HAVE_LIBNL)
+#if defined(__linux__) defined(HAVE_LIBNL) defined(IFLA_VF_MAX)
This looks reasonable to me since this isn't available in Debian
Squeeze's kernel headers and I don't think it's worth a separate
configure check since we'd only check for IFLA_VF_MAX there.
Cheers,
-- Guido
static struct nla_policy ifla_vf_policy[IFLA_VF_MAX+1] = {
[IFLA_VF_MAC] = { .type = NLA_UNSPEC,
I also have to explicitly disable -Werror (error about 'const', 'pure' and an
undeclared 'inline' function in netlink/object.h), virtualport and
macvtap(also IFLA_VF_*), since configure doesn't disable them automatically:
./configure --without-macvtap --disable-werror --without-virtualport
Without those options I get:
...
checking whether compiler handles -Wno-suggest-attribute=pure... yes
checking whether compiler handles -Wno-suggest-attribute=const... yes
...
checking whether to compile with macvtap support... yes
checking whether MACVLAN_MODE_PASSTHRU is declared... no
checking whether to compile with virtual port support... no
checking for LIBNL... yes
There was some discussion some time ago on libvirt about puting the check for
IFLA_VF_* in configure instead of in the *.c files, but I haven't found a
patch yet.
Sincerely
Philipp
--
Philipp Hahn Open Source Software Engineer h...@univention.de
Univention GmbHbe open. fon: +49 421 22 232- 0
Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99
http://www.univention.de/
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
Hello Daniel, On Saturday 31 March 2012 13:53:32 you wrote: On Mon, Mar 26, 2012 at 09:18:53AM +0200, Philipp Hahn wrote: On Monday 26 March 2012 04:32:23 Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. I think most API additions are now commited to git upstream (please raise your voice quickly if you see something missing !) My change to correct the handling of the Xen-HV RTC clock is still waiting for review (since before 0.9.10). Urgh, could you rebase it and repost ? Sorry I only discovered your reply ! If it's a bit big it may be a bit hard to push before 0.9.11 but I will make a point to push it just after if that's not possible before ! The patch still aplies, but sending new version as you requested. Still compiles (with minor problems regarding undefined IFLA_PORT_MAX and broken libnl on my Debian-Squeeze here) Thank you for your work. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHbe open. fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99 http://www.univention.de/ signature.asc Description: This is a digitally signed message part. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
On 01.04.2012 03:35, Laine Stump wrote: On 03/31/2012 07:56 AM, Daniel Veillard wrote: I just made the second release candidate ftp://libvirt.org/libvirt/libvirt-0.9.11-rc2.tar.gz along with the rpms and tagged the git tree. It seems to work okay in my limited testing. If all goes well I would probably push on Tuesday, A gentoo user reported in irc (#virt on irc.oftc.net) earlier today that builds were failing for him on a fresh checkout from git: feniksa hi, when i compile libvirt on my gentoo i get warning: cc1: warning: unrecognized command line option -Wno-suggest-attribute=const cc1: warning: unrecognized command line option -Wno-suggest-attribute=pure feniksa gcc (Gentoo 4.5.3-r2 p1.1, pie-0.4.7) 4.5.3 feniksa last part of conf: http://pastebin.com/gnT4Y2Ba and compile log http://pastebin.com/FcSwshzS feniksa laine: 2 weeks ago i didn't see this warning. Now i pull from master sources and get this warning. But, this is only because i am using gcc 4.5.3 (this is latest gcc version in gentoo OS). I haven't looked at any of this code before, but it looks to me like ql_WARN_ADD() in gnulib must not be doing the right thing, and is adding the option even though the compiler apparently doesn't support it. This probably didn't crop up before because full warnings weren't turned on in the build until March 27 in commit 851117bd. That commit does things different for builds of git trees vs. tarballs, so I don't know if this failure will affect builds of release tarballs (I asked feniksa to try a build of the rc2 tarball, but he hasn't responded yet). I use x86_64-pc-linux-gnu-4.6.2 and don't see those warnings. However, configure is checking whether compiler handles those parameters. So maybe it's a autotools bug? Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
On Sat, Mar 31, 2012 at 21:35:50 -0400, Laine Stump wrote: On 03/31/2012 07:56 AM, Daniel Veillard wrote: I just made the second release candidate ftp://libvirt.org/libvirt/libvirt-0.9.11-rc2.tar.gz along with the rpms and tagged the git tree. It seems to work okay in my limited testing. If all goes well I would probably push on Tuesday, A gentoo user reported in irc (#virt on irc.oftc.net) earlier today that builds were failing for him on a fresh checkout from git: feniksa hi, when i compile libvirt on my gentoo i get warning: cc1: warning: unrecognized command line option -Wno-suggest-attribute=const cc1: warning: unrecognized command line option -Wno-suggest-attribute=pure feniksa gcc (Gentoo 4.5.3-r2 p1.1, pie-0.4.7) 4.5.3 feniksa last part of conf: http://pastebin.com/gnT4Y2Ba and compile log http://pastebin.com/FcSwshzS It's important to note that those warnings never show up on their own. They are only printed in case there is something else the compiler warns about (libnl header issue covered by gentoo bug #366561 in this case). And I remember seeing it since these gcc options were introduced several releases ago. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
2012/4/2 Jiri Denemark jdene...@redhat.com On Sat, Mar 31, 2012 at 21:35:50 -0400, Laine Stump wrote: On 03/31/2012 07:56 AM, Daniel Veillard wrote: I just made the second release candidate ftp://libvirt.org/libvirt/libvirt-0.9.11-rc2.tar.gz along with the rpms and tagged the git tree. It seems to work okay in my limited testing. If all goes well I would probably push on Tuesday, A gentoo user reported in irc (#virt on irc.oftc.net) earlier today that builds were failing for him on a fresh checkout from git: feniksa hi, when i compile libvirt on my gentoo i get warning: cc1: warning: unrecognized command line option -Wno-suggest-attribute=const cc1: warning: unrecognized command line option -Wno-suggest-attribute=pure feniksa gcc (Gentoo 4.5.3-r2 p1.1, pie-0.4.7) 4.5.3 feniksa last part of conf: http://pastebin.com/gnT4Y2Ba and compile log http://pastebin.com/FcSwshzS It's important to note that those warnings never show up on their own. They are only printed in case there is something else the compiler warns about (libnl header issue covered by gentoo bug #366561 in this case). Yes, this warning present in gentoo libnl-1.1-r2 and patch doesn't present in gentoo main tree. I will try to contact with gentoo maintainer and ask to make some activity. And I remember seeing it since these gcc options were introduced several releases ago. This option present in gcc 4.5.3 (i made test on hello world). No warning about unrecognized params with another files. Also, other files compile without warning. You can see it on this part of log: http://pastebin.com/wPnLJ1Fx (verbose build mode) I think, this is not problem of libvirt -- With best wishes, Maxim Sditanov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
On 04/02/2012 06:43 AM, Philipp Hahn wrote: The patch still aplies, but sending new version as you requested. Still compiles (with minor problems regarding undefined IFLA_PORT_MAX and broken libnl on my Debian-Squeeze here) What is the version of libnl? Different versions of libnl are unfortunately not API compatible. libvirt's libnl usage has been developed for / tested with libnl 1.1. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
2012/4/1 Maxim Sditanov feni...@rambler.ru 2012/4/1 Feniks Gordon Freeman feni...@rambler.ru 2012/4/1 Feniks Gordon Freeman feni...@rambler.ru 2012/4/1 Laine Stump la...@laine.org On 03/31/2012 07:56 AM, Daniel Veillard wrote: I just made the second release candidate ftp://libvirt.org/libvirt/libvirt-0.9.11-rc2.tar.gz along with the rpms and tagged the git tree. It seems to work okay in my limited testing. If all goes well I would probably push on Tuesday, A gentoo user reported in irc (#virt on irc.oftc.net) earlier today that builds were failing for him on a fresh checkout from git: feniksa hi, when i compile libvirt on my gentoo i get warning: cc1: warning: unrecognized command line option -Wno-suggest-attribute=const cc1: warning: unrecognized command line option -Wno-suggest-attribute=pure feniksa gcc (Gentoo 4.5.3-r2 p1.1, pie-0.4.7) 4.5.3 feniksa last part of conf: http://pastebin.com/gnT4Y2Ba and compile log http://pastebin.com/FcSwshzS feniksa laine: 2 weeks ago i didn't see this warning. Now i pull from master sources and get this warning. But, this is only because i am using gcc 4.5.3 (this is latest gcc version in gentoo OS). I haven't looked at any of this code before, but it looks to me like ql_WARN_ADD() in gnulib must not be doing the right thing, and is adding the option even though the compiler apparently doesn't support it. This probably didn't crop up before because full warnings weren't turned on in the build until March 27 in commit 851117bd. That commit does things different for builds of git trees vs. tarballs, so I don't know if this failure will affect builds of release tarballs (I asked feniksa to try a build of the rc2 tarball, but he hasn't responded yet). I compiled rc2 (ftp://libvirt.org/libvirt/libvirt-0.9.11-rc2.tar.gz) Same problem present in release candidate rc2 cc1: warning: unrecognized command line option -Wno-suggest-attribute=const cc1: warning: unrecognized command line option -Wno-suggest-attribute=pure -- With best wishes, Maxim Sditanov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
On Mon, Mar 26, 2012 at 09:18:53AM +0200, Philipp Hahn wrote: Hello, On Monday 26 March 2012 04:32:23 Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. I think most API additions are now commited to git upstream (please raise your voice quickly if you see something missing !) My change to correct the handling of the Xen-HV RTC clock is still waiting for review (since before 0.9.10). Urgh, could you rebase it and repost ? Sorry I only discovered your reply ! If it's a bit big it may be a bit hard to push before 0.9.11 but I will make a point to push it just after if that's not possible before ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
On Mon, Mar 26, 2012 at 10:32:23AM +0800, Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. I think most API additions are now commited to git upstream (please raise your voice quickly if you see something missing !) I have made a release candidate 1 tarball (and associated rpms) at ftp://libvirt.org/libvirt/libvirt-0.9.11-rc1.tar.gz and the git tree is tagged. I think I will make an release candidate 2 tarball on Wednesday, and I'm hoping for a final release on Friday, or maybe Monday if there are issues found. Please give it a try ! Stability and portability feedback are really welcome as we didn't had a release in Feb and the risk of having something messed up is slightly higher than usual ! Thanks everybody for the feedback, sorry I have been sick this week, and didn't pushed rc2 mid week as scheduled. I juts made the second release candidate ftp://libvirt.org/libvirt/libvirt-0.9.11-rc2.tar.gz along with the rpms and tagged the git tree. It seems to work okay in my limited testing. If all goes well I would probably push on Tuesday, thanks in advance ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
On 03/31/2012 07:56 AM, Daniel Veillard wrote: I just made the second release candidate ftp://libvirt.org/libvirt/libvirt-0.9.11-rc2.tar.gz along with the rpms and tagged the git tree. It seems to work okay in my limited testing. If all goes well I would probably push on Tuesday, A gentoo user reported in irc (#virt on irc.oftc.net) earlier today that builds were failing for him on a fresh checkout from git: feniksa hi, when i compile libvirt on my gentoo i get warning: cc1: warning: unrecognized command line option -Wno-suggest-attribute=const cc1: warning: unrecognized command line option -Wno-suggest-attribute=pure feniksa gcc (Gentoo 4.5.3-r2 p1.1, pie-0.4.7) 4.5.3 feniksa last part of conf: http://pastebin.com/gnT4Y2Ba and compile log http://pastebin.com/FcSwshzS feniksa laine: 2 weeks ago i didn't see this warning. Now i pull from master sources and get this warning. But, this is only because i am using gcc 4.5.3 (this is latest gcc version in gentoo OS). I haven't looked at any of this code before, but it looks to me like ql_WARN_ADD() in gnulib must not be doing the right thing, and is adding the option even though the compiler apparently doesn't support it. This probably didn't crop up before because full warnings weren't turned on in the build until March 27 in commit 851117bd. That commit does things different for builds of git trees vs. tarballs, so I don't know if this failure will affect builds of release tarballs (I asked feniksa to try a build of the rc2 tarball, but he hasn't responded yet). -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
On Mon, Mar 26, 2012 at 10:32:23AM +0800, Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. I think most API additions are now commited to git upstream (please raise your voice quickly if you see something missing !) I have made a release candidate 1 tarball (and associated rpms) at ftp://libvirt.org/libvirt/libvirt-0.9.11-rc1.tar.gz and the git tree is tagged. I think I will make an release candidate 2 tarball on Wednesday, and I'm hoping for a final release on Friday, or maybe Monday if there are issues found. Please give it a try ! Stability and portability feedback are really welcome as we didn't had a release in Feb and the risk of having something messed up is slightly higher than usual ! Looks good so far on Debian's autobuilders: https://buildd.debian.org/status/package.php?p=libvirtsuite=experimental Cheers, -- Guido thanks in advance, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
Jim Fehlig wrote: Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. I think most API additions are now commited to git upstream (please raise your voice quickly if you see something missing !) I have made a release candidate 1 tarball (and associated rpms) at ftp://libvirt.org/libvirt/libvirt-0.9.11-rc1.tar.gz and the git tree is tagged. I think I will make an release candidate 2 tarball on Wednesday, and I'm hoping for a final release on Friday, or maybe Monday if there are issues found. Please give it a try ! Stability and portability feedback are really welcome as we didn't had a release in Feb and the risk of having something messed up is slightly higher than usual ! Some initial observations on a sles11sp2 host Xen 4.1.2 using xl toolstack (xend disabled): # virsh list error: Failed to reconnect to the hypervisor error: no valid connection error: unable to connect to 'localhost:8000': Connection refused qemu/kvm 0.15.1: # virsh capabilities | grep guest # It is late here. I'll take a look at both of these issues tomorrow. Hmm, strange. I can't reproduce either of these issues today :-/. Looks good now with TCK mostly passing. Regards, Jim -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
On Tue, Mar 27, 2012 at 11:45:35AM -0600, Jim Fehlig wrote: Jim Fehlig wrote: Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. I think most API additions are now commited to git upstream (please raise your voice quickly if you see something missing !) I have made a release candidate 1 tarball (and associated rpms) at ftp://libvirt.org/libvirt/libvirt-0.9.11-rc1.tar.gz and the git tree is tagged. I think I will make an release candidate 2 tarball on Wednesday, and I'm hoping for a final release on Friday, or maybe Monday if there are issues found. Please give it a try ! Stability and portability feedback are really welcome as we didn't had a release in Feb and the risk of having something messed up is slightly higher than usual ! Some initial observations on a sles11sp2 host Xen 4.1.2 using xl toolstack (xend disabled): # virsh list error: Failed to reconnect to the hypervisor error: no valid connection error: unable to connect to 'localhost:8000': Connection refused qemu/kvm 0.15.1: # virsh capabilities | grep guest # It is late here. I'll take a look at both of these issues tomorrow. Hmm, strange. I can't reproduce either of these issues today :-/. Looks good now with TCK mostly passing. Okay, thanks for the feedback ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
Hello, On Monday 26 March 2012 04:32:23 Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. I think most API additions are now commited to git upstream (please raise your voice quickly if you see something missing !) My change to correct the handling of the Xen-HV RTC clock is still waiting for review (since before 0.9.10). Sincerely Philipp -- Philipp Hahn Open Source Software Engineer h...@univention.de Univention GmbHbe open. fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99 http://www.univention.de/ signature.asc Description: This is a digitally signed message part. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Start of freeze for libvirt-0.9.11 and availability of rc1
Daniel Veillard wrote: As scheduled, we are entering the freeze for 0.9.11. I think most API additions are now commited to git upstream (please raise your voice quickly if you see something missing !) I have made a release candidate 1 tarball (and associated rpms) at ftp://libvirt.org/libvirt/libvirt-0.9.11-rc1.tar.gz and the git tree is tagged. I think I will make an release candidate 2 tarball on Wednesday, and I'm hoping for a final release on Friday, or maybe Monday if there are issues found. Please give it a try ! Stability and portability feedback are really welcome as we didn't had a release in Feb and the risk of having something messed up is slightly higher than usual ! Some initial observations on a sles11sp2 host Xen 4.1.2 using xl toolstack (xend disabled): # virsh list error: Failed to reconnect to the hypervisor error: no valid connection error: unable to connect to 'localhost:8000': Connection refused qemu/kvm 0.15.1: # virsh capabilities | grep guest # It is late here. I'll take a look at both of these issues tomorrow. Regards, Jim -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
