[Lift] Re: Build Broken?
I don't know how others feel, but I would like all bugs, even for unit tests, to go through issue tracking and review board. Mostly this is so that we have good documentation of what is happening to the codebase and why. Derek On Sat, Nov 7, 2009 at 11:45 AM, Joni Freeman freeman.j...@gmail.comwrote: Thanks for the test results. It looked like a charset problem in unit test. I changed the assertion in test to use more robust case class comparison instead of String comparison. Please let us know if this fixes the build on your machine. Committers, I pushed this small fix directly into master, skipping Review Board. Please let me know if this is not allowed even if the change is very small and just for unit tests. Cheers Joni On 7 marras, 07:22, aw anth...@whitford.com wrote: OK, found Hudson: http://hudson.scala-tools.org/job/Lift/ But now if that isn't broken, why is my fresh clone failing? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: Build Broken?
Build is working now. Thanks! --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: Build Broken?
Hi, Can you send me surefire test result file at: lift-base/lift-json/target/surefire-reports/TEST- net.liftweb.json.XmlExamplesTest.xml All tests pass on my machine (Ubuntu 8.10, jdk1.6.0_10, Maven 2.0.9), but I will investigate why it fails on your setup. You can send the file directly to me, not sure if Google Groups accepts attachments. Cheers Joni On 7 marras, 07:22, aw anth...@whitford.com wrote: OK, found Hudson: http://hudson.scala-tools.org/job/Lift/ But now if that isn't broken, why is my fresh clone failing? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: Build Broken?
Thanks for the test results. It looked like a charset problem in unit test. I changed the assertion in test to use more robust case class comparison instead of String comparison. Please let us know if this fixes the build on your machine. Committers, I pushed this small fix directly into master, skipping Review Board. Please let me know if this is not allowed even if the change is very small and just for unit tests. Cheers Joni On 7 marras, 07:22, aw anth...@whitford.com wrote: OK, found Hudson: http://hudson.scala-tools.org/job/Lift/ But now if that isn't broken, why is my fresh clone failing? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
