[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5943 Convert stencil to skyline directly

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- **Needs**:  -->  
- **Patch**: new --> review
- **Type**:  -->  
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5943] Convert stencil to skyline directly**

**Status:** Started
**Created:** Sun Apr 26, 2020 12:13 PM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 02, 2020 09:43 PM UTC
**Owner:** Han-Wen Nienhuys


Gets rid of more intermediate storage.

Benchmarks show that this is performance neutral.

https://codereview.appspot.com/555760043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5959 skyline: minor performance tweaks

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 



---

** [issues:#5959] skyline: minor performance tweaks**

**Status:** Started
**Created:** Sat May 02, 2020 09:39 PM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 02, 2020 09:39 PM UTC
**Owner:** nobody


https://codereview.appspot.com/559950045


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5940 Split glyph contours in up/down segments for skylines

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
rebase

https://codereview.appspot.com/569700043


---

** [issues:#5940] Split glyph contours in up/down segments for skylines**

**Status:** Started
**Created:** Sun Apr 26, 2020 07:43 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 02, 2020 07:36 AM UTC
**Owner:** Han-Wen Nienhuys


This reduces the amount of skyline input coming from glyph outlines by
2x.

benchmark for arguments: input/regression/mozart-hrn-3
raw data: {'ff2061b518': [2.72, 2.69, 2.71], 'e8212e15e2': [2.7, 2.68, 2.69]}

Version ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.02
  med diff -0.738007 % (e8212e15e2 is faster)


benchmark for arguments: -I carver MSDM
raw data: {'ff2061b518': [51.83, 51.99, 52.05], 'e8212e15e2': [51.27, 51.2, 
51.48]}

ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.72
  med diff -1.384882 % (e8212e15e2 is faster)

https://codereview.appspot.com/569700043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5951 Calculate skylines only once.

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
diffs


Attachments:

- [Screenshot from 2020-05-02 
06-53-26.png](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/cb56e06b72/3cfe/attachment/Screenshot%20from%202020-05-02%2006-53-26.png)
 (111.0 kB; image/png)
- [Screenshot from 2020-05-02 
06-53-49.png](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/cb56e06b72/3cfe/attachment/Screenshot%20from%202020-05-02%2006-53-49.png)
 (257.2 kB; image/png)


---

** [issues:#5951] Calculate skylines only once.**

**Status:** Started
**Created:** Fri May 01, 2020 05:52 PM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 02, 2020 06:17 AM UTC
**Owner:** Han-Wen Nienhuys


Before, Axis_group_interface::skyline_spacing() would call the
function add_interior_skylines(), which recursed into
VerticalAxisGroups.  This caused staff-skylines to be computed twice:
once as part of the Staff's VerticalAxisGroup, and once to compute
the skyline for System.

Instead, in Axis_group_interface::skyline_spacing(), compute the
vertical-skylines for all constituent elements.  Since the property is
subject to caching, the Staff skyline is only computed once.

To make this work

* Add flags to the NoteColumn using Axis_group_interface::add_element

* add vertical-skylines callbacks for NoteColumn and
  NoteCollision, which are also X,Y Axis groups.

* declare add-stem-support for bass figures (or the digits are meshed
  in with stems that stick out of the staff.)

* calculate a skyline for BassFigureAlignment, otherwise, the skyline
  is computed from the extent of the alignment, which is inaccurate if
  some bass figures have accidentals.

Formatting impact:

* ottava-edge.ly - the ottava bracket meshes better with the stem,
  leading to tighter spacing.

Timing impact

ac49229cdf - Calculate skylines only once.
  baseline: eaf40071f5 Use vectors rather than lists for skylines.
  args: -I carver MSDM
  memory: med diff 1916 (stddevs 103 135, n=5)
  memory: med diff 0.2 % (ac49229cdf is fatter)
  time: med diff -0.37 (stddevs 0.08 0.14, n=5)
  time: med diff -0.8 % (ac49229cdf is faster)

https://codereview.appspot.com/553980043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5957 Remove ly:lexer-keywords command

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 



---

** [issues:#5957] Remove ly:lexer-keywords command**

**Status:** Started
**Created:** Sat May 02, 2020 10:19 AM UTC by David Kastrup
**Last Updated:** Sat May 02, 2020 10:19 AM UTC
**Owner:** nobody


Remove ly:lexer-keywords command

It has been unused since its inception.  If it were to be retained, it
would make more sense to remove its (sole) argument since it was effectively
being ignored (other than that the presence of a Lexer guarantees that the
keyword table has been initialised).  Supporting member function
Lily_lexer::keyword_list is removed alongside.

http://codereview.appspot.com/559960060


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5956 Compute SVG skyline based on original data

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- Description has changed:

Diff:







- **assigned_to**: Han-Wen Nienhuys
- **Needs**:  -->  
- **Patch**: new --> needs_work
- **Comment**:

Patch does not apply to current master.



---

** [issues:#5956] Compute SVG skyline based on original data**

**Status:** Started
**Created:** Sat May 02, 2020 09:46 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 02, 2020 09:46 AM UTC
**Owner:** Han-Wen Nienhuys


Since stencil data is used as input to formatting decisions, this
will make SVG output more similar to PS/PDF output.

https://codereview.appspot.com/559950044


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5941 Create skylines directly from glyph outlines.

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
rebase

https://codereview.appspot.com/561730043


---

** [issues:#5941] Create skylines directly from glyph outlines.**

**Status:** Started
**Created:** Sun Apr 26, 2020 07:44 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 02, 2020 09:49 PM UTC
**Owner:** Han-Wen Nienhuys


This avoids creating garbage for the intermediate Scheme data to
transport the glyph outlines.

Benchmark:

benchmark for arguments: input/regression/mozart-hrn-3.ly
raw data: {'ac8eaa37ee': [2.73, 2.7, 2.73], '893552a691': [2.7, 2.71, 2.71]}
  med diff -0.732601 % (893552a691 is faster)

benchmark for arguments: -I carver MSDM
raw data: {'ac8eaa37ee': [52.43, 52.41, 52.17], '893552a691': [52.47, 52.33, 
52.18]}
893552a691 - Create skylines directly from glyph outlines.
  med diff -0.152643 % (893552a691 is faster)

(for Carver score, the difference is at noise)

https://codereview.appspot.com/561730043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5957 Remove ly:lexer-keywords command

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- Description has changed:

Diff:







- **Needs**:  -->  
- **Patch**: new --> review
- **Comment**:

Passes make,  make check and a full make doc.



---

** [issues:#5957] Remove ly:lexer-keywords command**

**Status:** Started
**Created:** Sat May 02, 2020 10:19 AM UTC by David Kastrup
**Last Updated:** Sat May 02, 2020 10:19 AM UTC
**Owner:** David Kastrup


Remove ly:lexer-keywords command

It has been unused since its inception.  If it were to be retained, it
would make more sense to remove its (sole) argument since it was effectively
being ignored (other than that the presence of a Lexer guarantees that the
keyword table has been initialised).  Supporting member function
Lily_lexer::keyword_list is removed alongside.

http://codereview.appspot.com/559960060


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5949 Use GhostScript API instead of forking

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
Add option to use Ghostscript API instead of forking

http://codereview.appspot.com/548030043


---

** [issues:#5949] Use GhostScript API instead of forking**

**Status:** Started
**Created:** Thu Apr 30, 2020 07:12 PM UTC by Jonas Hahnfeld
**Last Updated:** Sat May 02, 2020 09:45 AM UTC
**Owner:** Jonas Hahnfeld


Use GhostScript API instead of forking

This is much more efficient than the current scheme when converting
many PostScript files, for example when building the documentation.
For the Notation Reference, lilypond-book now takes ~2m30s instead
of 5m to compile all snippets from the notation.tely file. Other
manuals benefit less, but still the time for 'make doc' on my system
improves by one third from around 33m to 22m.

An alternative would have been to always call gsapi_init_with_args
with the same arguments used until now. This indeed works and avoids
the overhead of forking, but the instance cannot be reused. Calling
gsapi_new_instance -> gsapi_init_with_args -> gsapi_delete_instance
for every conversion still means a lot of overhead and a prototype
suggested only a small gain compared to the previous solution.

http://codereview.appspot.com/548030043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5949 Add option to use Ghostscript API instead of forking

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- **Needs**:  -->  
- **Patch**: new --> needs_work
- **Type**:  -->  
- **Comment**:

Patch doesn't apply to current master



---

** [issues:#5949] Add option to use Ghostscript API instead of forking**

**Status:** Started
**Created:** Thu Apr 30, 2020 07:12 PM UTC by Jonas Hahnfeld
**Last Updated:** Sat May 02, 2020 10:48 AM UTC
**Owner:** Jonas Hahnfeld


Add option to use Ghostscript API instead of forking

This is much more efficient than the current scheme when converting
many PostScript files, for example when building the documentation.
For the Notation Reference, lilypond-book now takes ~2m30s instead
of 5m to compile all snippets from the notation.tely file. Other
manuals benefit less, but still the time for 'make doc' on my system
improves by one third from around 33m to 22m.

An alternative would have been to always call gsapi_init_with_args
with the same arguments used until now. This indeed works and avoids
the overhead of forking, but the instance cannot be reused. Calling
gsapi_new_instance -> gsapi_init_with_args -> gsapi_delete_instance
for every conversion still means a lot of overhead and a prototype
suggested only a small gain compared to the previous solution.

This is not the default because recent versions of Ghostscript are
distributed under the AGPL and it's unclear what the implications of
linking to the library is.

http://codereview.appspot.com/548030043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
Compute SVG skyline based on original data

Since stencil data is used as input to formatting decisions, this
will make SVG output more similar to PS/PDF output.

https://codereview.appspot.com/545970043


---

** [issues:#3778] SVG backend: Use bounding box as skylines for markup**

**Status:** Started
**Created:** Sun Jan 05, 2014 05:39 AM UTC by Anonymous
**Last Updated:** Sat May 02, 2020 09:47 AM UTC
**Owner:** Kevin Barry
**Attachments:**

- 
[document.svg](https://sourceforge.net/p/testlilyissues/issues/3778/attachment/document.svg)
 (4.4 kB; image/svg+xml)


https://codereview.appspot.com/582010043

Use bounding box as skylines for markup in svg backend

As there is no routine for determining skylines for utf-8-string
stencils, they normally fall back to the grob's bounding box, which is
fine. However, when there is a mixture of utf-8-string and other types
of stencil (which have associated skyline functions) in a single grob,
the entire grob gets a skyline determined only from the non-utf-8-string
stencils. This sometimes causes the text portion of such mixed grobs
(e.g. metronome marks) to collide with other grobs.

While looping over the stencils, check for utf-8-string and if found,
clear the skylines and break out of the loop. Empty skylines forces a
fallback to the grob's bounding box, which restores the behaviour from
before the patch to improve skyline approximations (issue 2148). This
does not fix the issue that there is no routine for determining skylines
for utf-8-strings when the backend is svg, but it does at least remove
the collisions without changing the behaviour in non-broken situations.

Add a suitable (svg backend) regression test.



***

Originally reported 
[here.](http://lists.gnu.org/archive/html/lilypond-user/2014-01/msg00213.html)

the tempo marking in the SVG output is both lower, so that it collides with the 
stem of the A, and also has insufficient space between the equals sign and the 
preceding quarter note:


:::TeX
\version "2.18.0"

\relative c'' {
  \tempo 4=76
  a4
}



---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5923 Use a hash table for the lexer keywords

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
Han-Wen, David, shall we close this as Issue 5946 is now in staging?


---

** [issues:#5923] Use a hash table for the lexer keywords**

**Status:** Started
**Created:** Mon Apr 20, 2020 08:10 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 02, 2020 05:04 AM UTC
**Owner:** Han-Wen Nienhuys


Get rid of unused function ly:lexer-keywords.

https://codereview.appspot.com/549920043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5949 Add option to use Ghostscript API instead of forking

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
add license information

http://codereview.appspot.com/548030043


---

** [issues:#5949] Add option to use Ghostscript API instead of forking**

**Status:** Started
**Created:** Thu Apr 30, 2020 07:12 PM UTC by Jonas Hahnfeld
**Last Updated:** Sat May 02, 2020 10:48 AM UTC
**Owner:** Jonas Hahnfeld


Add option to use Ghostscript API instead of forking

This is much more efficient than the current scheme when converting
many PostScript files, for example when building the documentation.
For the Notation Reference, lilypond-book now takes ~2m30s instead
of 5m to compile all snippets from the notation.tely file. Other
manuals benefit less, but still the time for 'make doc' on my system
improves by one third from around 33m to 22m.

An alternative would have been to always call gsapi_init_with_args
with the same arguments used until now. This indeed works and avoids
the overhead of forking, but the instance cannot be reused. Calling
gsapi_new_instance -> gsapi_init_with_args -> gsapi_delete_instance
for every conversion still means a lot of overhead and a prototype
suggested only a small gain compared to the previous solution.

This is not the default because recent versions of Ghostscript are
distributed under the AGPL and it's unclear what the implications of
linking to the library is.

http://codereview.appspot.com/548030043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5958 output-distance: create PNG files in batch

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- **Needs**:  -->  
- **Patch**: new --> review
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5958] output-distance: create PNG files in batch**

**Status:** Started
**Created:** Sat May 02, 2020 12:34 PM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 02, 2020 12:34 PM UTC
**Owner:** Han-Wen Nienhuys


https://codereview.appspot.com/567530052


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5923 Use a hash table for the lexer keywords

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- **Patch**: push --> abandoned



---

** [issues:#5923] Use a hash table for the lexer keywords**

**Status:** Started
**Created:** Mon Apr 20, 2020 08:10 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 02, 2020 10:05 AM UTC
**Owner:** Han-Wen Nienhuys


Get rid of unused function ly:lexer-keywords.

https://codereview.appspot.com/549920043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5952 Use axis indexing to clarify different behaviors for X/Y skylines

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- **summary**: Remove if/else for shift/raise -->  Use axis indexing to clarify 
different behaviors for X/Y skylines 
- Description has changed:

Diff:



--- old
+++ new
@@ -1,3 +1,3 @@
-Shift (horizontal) and raise (vertical) movements are commutative
+Use axis indexing to clarify different behaviors for X/Y skylines
 
 https://codereview.appspot.com/573770043






---

** [issues:#5952]  Use axis indexing to clarify different behaviors for X/Y 
skylines **

**Status:** Started
**Created:** Fri May 01, 2020 08:17 PM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 02, 2020 06:37 AM UTC
**Owner:** Han-Wen Nienhuys


Use axis indexing to clarify different behaviors for X/Y skylines

https://codereview.appspot.com/573770043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- **Patch**: countdown --> review
- **Comment**:

Seems that Hanwen wants some more discussion on this (see Rietveld) setting 
back to review.



---

** [issues:#3778] SVG backend: Use bounding box as skylines for markup**

**Status:** Started
**Created:** Sun Jan 05, 2014 05:39 AM UTC by Anonymous
**Last Updated:** Sat May 02, 2020 05:07 AM UTC
**Owner:** Kevin Barry
**Attachments:**

- 
[document.svg](https://sourceforge.net/p/testlilyissues/issues/3778/attachment/document.svg)
 (4.4 kB; image/svg+xml)


https://codereview.appspot.com/582010043

Use bounding box as skylines for markup in svg backend

As there is no routine for determining skylines for utf-8-string
stencils, they normally fall back to the grob's bounding box, which is
fine. However, when there is a mixture of utf-8-string and other types
of stencil (which have associated skyline functions) in a single grob,
the entire grob gets a skyline determined only from the non-utf-8-string
stencils. This sometimes causes the text portion of such mixed grobs
(e.g. metronome marks) to collide with other grobs.

While looping over the stencils, check for utf-8-string and if found,
clear the skylines and break out of the loop. Empty skylines forces a
fallback to the grob's bounding box, which restores the behaviour from
before the patch to improve skyline approximations (issue 2148). This
does not fix the issue that there is no routine for determining skylines
for utf-8-strings when the backend is svg, but it does at least remove
the collisions without changing the behaviour in non-broken situations.

Add a suitable (svg backend) regression test.



***

Originally reported 
[here.](http://lists.gnu.org/archive/html/lilypond-user/2014-01/msg00213.html)

the tempo marking in the SVG output is both lower, so that it collides with the 
stem of the A, and also has insufficient space between the equals sign and the 
preceding quarter note:


:::TeX
\version "2.18.0"

\relative c'' {
  \tempo 4=76
  a4
}



---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5951 Calculate skylines only once.

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- **Patch**: new --> review



---

** [issues:#5951] Calculate skylines only once.**

**Status:** Started
**Created:** Fri May 01, 2020 05:52 PM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 02, 2020 06:18 AM UTC
**Owner:** Han-Wen Nienhuys


Before, Axis_group_interface::skyline_spacing() would call the
function add_interior_skylines(), which recursed into
VerticalAxisGroups.  This caused staff-skylines to be computed twice:
once as part of the Staff's VerticalAxisGroup, and once to compute
the skyline for System.

Instead, in Axis_group_interface::skyline_spacing(), compute the
vertical-skylines for all constituent elements.  Since the property is
subject to caching, the Staff skyline is only computed once.

To make this work

* Add flags to the NoteColumn using Axis_group_interface::add_element

* add vertical-skylines callbacks for NoteColumn and
  NoteCollision, which are also X,Y Axis groups.

* declare add-stem-support for bass figures (or the digits are meshed
  in with stems that stick out of the staff.)

* calculate a skyline for BassFigureAlignment, otherwise, the skyline
  is computed from the extent of the alignment, which is inaccurate if
  some bass figures have accidentals.

Formatting impact:

* ottava-edge.ly - the ottava bracket meshes better with the stem,
  leading to tighter spacing.

Timing impact

ac49229cdf - Calculate skylines only once.
  baseline: eaf40071f5 Use vectors rather than lists for skylines.
  args: -I carver MSDM
  memory: med diff 1916 (stddevs 103 135, n=5)
  memory: med diff 0.2 % (ac49229cdf is fatter)
  time: med diff -0.37 (stddevs 0.08 0.14, n=5)
  time: med diff -0.8 % (ac49229cdf is faster)

https://codereview.appspot.com/553980043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5955 Polyphony followed with a grace note isn’t beamed

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 



---

** [issues:#5955] Polyphony followed with a grace note isn’t beamed**

**Status:** Accepted
**Created:** Sat May 02, 2020 08:53 AM UTC by Valentin Villenave
**Last Updated:** Sat May 02, 2020 08:53 AM UTC
**Owner:** nobody
**Attachments:**

- 
[document.preview.png](https://sourceforge.net/p/testlilyissues/issues/5955/attachment/document.preview.png)
 (11.5 kB; image/png)


This may be a duplicate, but I couldn’t find that exact one in the many, many 
grace-related known bugs.


%% Reported on -user-fr: 
https://lists.gnu.org/archive/html/lilypond-user-fr/2020-05/msg00029.html

\version "2.20" %% I don’t think it has ever worked, though

{
  \time 2/4
  b'8 a' \grace a'16 g'4
  %% These are beamed normally:
  << {b'8 a'} \\ {c'4} >> g'4
  %% These _should_ be beamed:
  << {b'8 a'} \\ {c'4} >> \grace a'16 g'4
  %% Moving the grace note in the next bar:
  r4 << {b'8 a'} \\ {c'4} >> \grace a'16 g'2
}



---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5956 Compute SVG skyline based on original data

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 



---

** [issues:#5956] Compute SVG skyline based on original data**

**Status:** Started
**Created:** Sat May 02, 2020 09:46 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 02, 2020 09:46 AM UTC
**Owner:** nobody


Since stencil data is used as input to formatting decisions, this
will make SVG output more similar to PS/PDF output.

https://codereview.appspot.com/559950044


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5941 Create skylines directly from glyph outlines.

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- **Needs**:  -->  
- **Patch**: new --> review
- **Type**:  -->  
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5941] Create skylines directly from glyph outlines.**

**Status:** Started
**Created:** Sun Apr 26, 2020 07:44 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 02, 2020 07:34 AM UTC
**Owner:** Han-Wen Nienhuys


This avoids creating garbage for the intermediate Scheme data to
transport the glyph outlines.

Benchmark:

benchmark for arguments: input/regression/mozart-hrn-3.ly
raw data: {'ac8eaa37ee': [2.73, 2.7, 2.73], '893552a691': [2.7, 2.71, 2.71]}
  med diff -0.732601 % (893552a691 is faster)

benchmark for arguments: -I carver MSDM
raw data: {'ac8eaa37ee': [52.43, 52.41, 52.17], '893552a691': [52.47, 52.33, 
52.18]}
893552a691 - Create skylines directly from glyph outlines.
  med diff -0.152643 % (893552a691 is faster)

(for Carver score, the difference is at noise)

https://codereview.appspot.com/561730043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5951 Calculate skylines only once.

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- Description has changed:

Diff:







- **Needs**:  -->  
- **Type**:  -->  
- **Comment**:

Passes make, make check and a full make doc.

Reg test diffs attached



---

** [issues:#5951] Calculate skylines only once.**

**Status:** Started
**Created:** Fri May 01, 2020 05:52 PM UTC by Han-Wen Nienhuys
**Last Updated:** Fri May 01, 2020 10:10 PM UTC
**Owner:** Han-Wen Nienhuys


Before, Axis_group_interface::skyline_spacing() would call the
function add_interior_skylines(), which recursed into
VerticalAxisGroups.  This caused staff-skylines to be computed twice:
once as part of the Staff's VerticalAxisGroup, and once to compute
the skyline for System.

Instead, in Axis_group_interface::skyline_spacing(), compute the
vertical-skylines for all constituent elements.  Since the property is
subject to caching, the Staff skyline is only computed once.

To make this work

* Add flags to the NoteColumn using Axis_group_interface::add_element

* add vertical-skylines callbacks for NoteColumn and
  NoteCollision, which are also X,Y Axis groups.

* declare add-stem-support for bass figures (or the digits are meshed
  in with stems that stick out of the staff.)

* calculate a skyline for BassFigureAlignment, otherwise, the skyline
  is computed from the extent of the alignment, which is inaccurate if
  some bass figures have accidentals.

Formatting impact:

* ottava-edge.ly - the ottava bracket meshes better with the stem,
  leading to tighter spacing.

Timing impact

ac49229cdf - Calculate skylines only once.
  baseline: eaf40071f5 Use vectors rather than lists for skylines.
  args: -I carver MSDM
  memory: med diff 1916 (stddevs 103 135, n=5)
  memory: med diff 0.2 % (ac49229cdf is fatter)
  time: med diff -0.37 (stddevs 0.08 0.14, n=5)
  time: med diff -0.8 % (ac49229cdf is faster)

https://codereview.appspot.com/553980043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5943 Convert stencil to skyline directly

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
rebase

https://codereview.appspot.com/555760043


---

** [issues:#5943] Convert stencil to skyline directly**

**Status:** Started
**Created:** Sun Apr 26, 2020 12:13 PM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 02, 2020 07:31 AM UTC
**Owner:** Han-Wen Nienhuys


Gets rid of more intermediate storage.

Benchmarks show that this is performance neutral.

https://codereview.appspot.com/555760043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5947 Add `-dfont-ps-resdir` option to embed fonts to PDFs later

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

I've pushed to staging.

commit 2ff485fd858d55263ca46db431793943f8c993f1
Date:   Mon Apr 27 23:52:53 2020 +0900

Issue5947/2: Doc: Add `-dfont-ps-resdir` option to running.itely

commit 3ada4bbab00f1ad91bbf78ab4c63324b4e539d10
Date:   Mon Apr 27 23:52:33 2020 +0900

Issue5947/1: Add `-dfont-ps-resdir` option to embed fonts to PDFs later



---

** [issues:#5947] Add `-dfont-ps-resdir` option to embed fonts to PDFs later**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Tue Apr 28, 2020 12:42 PM UTC by Masamichi Hosoda
**Last Updated:** Sat May 02, 2020 05:04 AM UTC
**Owner:** Masamichi Hosoda


Add `-dfont-ps-resdir` option to embed fonts to PDFs later

A similar purpose option, `-dfont-export-dir` exports fonts
as individual PostScript files for font embedding later.
However it cannot embed CID fonts to PDFs with Ghostscript 9.26 and later.

This `-dfont-ps-resdir` option creates
a subset of PostScript resource directory
in the directory specified by the option.
The directory contains symbolic links to font files
that Ghostscript can use to embed the fonts to PDFs later.
This method can embed CID fonts, even with Ghostscript 9.26 and later.

This `-dfont-ps-resdir` option skips TrueType fonts
because garbled characters occur same as `-dfont-export-dir` option.
Unlike `-dfont-export-dir` option,
it skips OTC (OpenType Collection/CFF) font files
because Ghostscript cannot handle them directly.

Simple usage:

```
$ lilypond -dfont-ps-resdir=resdir -dgs-never-embed-fonts foo.ly
$ gs -q -dBATCH -dNOPAUSE -sDEVICE=pdfwrite \
 -I resdir -I resdir/Font \
 -sOutputFile=foo.embedded.pdf foo.pdf
```

Note:
It is better not to specify the directory
that contains the name `Resource` because it has a special meaning
when specified with the -I option for Ghostscript.

http://codereview.appspot.com/577900043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5938 Thread skyline construction through stencil interpretation

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

~~~
commit 267e894e79fe5ce238c4db40f2a760511eead001
Author: Han-Wen Nienhuys 
AuthorDate: Sat Apr 25 12:10:59 2020 +0200
Commit: Han-Wen Nienhuys 
CommitDate: Sat May 2 09:26:21 2020 +0200

Thread skyline construction through stencil interpretation
~~~



---

** [issues:#5938] Thread skyline construction through stencil interpretation**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Sat Apr 25, 2020 11:42 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 02, 2020 05:09 AM UTC
**Owner:** Han-Wen Nienhuys


Before, we'd convert stencils to a combination of boxes and buildings,
and afterwards convert those to skylines.

The new approach has the following advantages:

* We can convert stencils to line segments directly, allowing for more
  precise outlines, and reduced memory overhead

* We can treat line thicknesses much more simply: we just extend line
  segments by 0.5 thicknesses on either side, and add them .5
  thickness up and down.

A next improvement is to thread Lazy_skyline_pair through to the glyph
outline generation. This would let us cut back on memory use for path
storage, and reduce the number of paths by 2x (the orientation of the
outline segments tells us if they are for the up or down skyline.)

Formatting impact:

The regtest shows 114 differences. The improved skylines lead to
slightly denser formatting, both horizontally and vertically. In
particular, some accidental configurations become very cramped (eg
accidental-placement.ly)

Timing impact: TODO

https://codereview.appspot.com/581960043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5949 Add option to use Ghostscript API instead of forking

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- **summary**: Use GhostScript API instead of forking --> Add option to use 
Ghostscript API instead of forking
- Description has changed:

Diff:



--- old
+++ new
@@ -1,4 +1,4 @@
-Use GhostScript API instead of forking
+Add option to use Ghostscript API instead of forking
 
 This is much more efficient than the current scheme when converting
 many PostScript files, for example when building the documentation.
@@ -14,4 +14,8 @@
 for every conversion still means a lot of overhead and a prototype
 suggested only a small gain compared to the previous solution.
 
+This is not the default because recent versions of Ghostscript are
+distributed under the AGPL and it's unclear what the implications of
+linking to the library is.
+
 http://codereview.appspot.com/548030043



- **Needs**:  -->  
- **Type**:  -->  



---

** [issues:#5949] Add option to use Ghostscript API instead of forking**

**Status:** Started
**Created:** Thu Apr 30, 2020 07:12 PM UTC by Jonas Hahnfeld
**Last Updated:** Sat May 02, 2020 09:45 AM UTC
**Owner:** Jonas Hahnfeld


Add option to use Ghostscript API instead of forking

This is much more efficient than the current scheme when converting
many PostScript files, for example when building the documentation.
For the Notation Reference, lilypond-book now takes ~2m30s instead
of 5m to compile all snippets from the notation.tely file. Other
manuals benefit less, but still the time for 'make doc' on my system
improves by one third from around 33m to 22m.

An alternative would have been to always call gsapi_init_with_args
with the same arguments used until now. This indeed works and avoids
the overhead of forking, but the instance cannot be reused. Calling
gsapi_new_instance -> gsapi_init_with_args -> gsapi_delete_instance
for every conversion still means a lot of overhead and a prototype
suggested only a small gain compared to the previous solution.

This is not the default because recent versions of Ghostscript are
distributed under the AGPL and it's unclear what the implications of
linking to the library is.

http://codereview.appspot.com/548030043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5940 Split glyph contours in up/down segments for skylines

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- **Needs**:  -->  
- **Patch**: new --> needs_work
- **Type**:  -->  
- **Comment**:

Patch does not apply to current master.



---

** [issues:#5940] Split glyph contours in up/down segments for skylines**

**Status:** Started
**Created:** Sun Apr 26, 2020 07:43 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 02, 2020 07:36 AM UTC
**Owner:** Han-Wen Nienhuys


This reduces the amount of skyline input coming from glyph outlines by
2x.

benchmark for arguments: input/regression/mozart-hrn-3
raw data: {'ff2061b518': [2.72, 2.69, 2.71], 'e8212e15e2': [2.7, 2.68, 2.69]}

Version ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.02
  med diff -0.738007 % (e8212e15e2 is faster)


benchmark for arguments: -I carver MSDM
raw data: {'ff2061b518': [51.83, 51.99, 52.05], 'e8212e15e2': [51.27, 51.2, 
51.48]}

ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.72
  med diff -1.384882 % (e8212e15e2 is faster)

https://codereview.appspot.com/569700043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5954 Doc: Usage - update text about Open/LibreOffice

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
Issue 5954: update OOoLilyPond info in usage manual

OOoLilyPond is in active development, contrary to what is stated in the
usage manual. Update the description accordingly. Update the link to
point to the current webpage.

https://codereview.appspot.com/583840059


---

** [issues:#5954] Doc: Usage - update text about Open/LibreOffice**

**Status:** Started
**Created:** Sat May 02, 2020 05:02 AM UTC by pkx166h
**Last Updated:** Sat May 02, 2020 09:32 AM UTC
**Owner:** nobody


On 01/05/2020 20:32, Ross Mohn wrote:
> LilyPond Usage Manual v2.20.0 Section 4.4.2 OpenOffice and LibreOffice 
> ,
>  please update the link when clicking on OOoLilyPond from the old 
> http://ooolilypond.sourceforge.net/ to the new 
> https://github.com/openlilylib/LO-ly. Also, replace this text:
>
> 
> Although this is no longer being developed, it appears to still work with 
> version 4.
> 
>
> with this:
>
> 
> OOoLilyPond (OLy) works with recent versions of LibreOffice and OpenOffice. 
> Older versions should work as well. It has even been tested with OpenOffice 
> 2.4 without issues.
> 
>
> Thanks! -Ross 


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5941 Create skylines directly from glyph outlines.

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
rebase

https://codereview.appspot.com/561730043


---

** [issues:#5941] Create skylines directly from glyph outlines.**

**Status:** Started
**Created:** Sun Apr 26, 2020 07:44 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 02, 2020 07:34 AM UTC
**Owner:** Han-Wen Nienhuys


This avoids creating garbage for the intermediate Scheme data to
transport the glyph outlines.

Benchmark:

benchmark for arguments: input/regression/mozart-hrn-3.ly
raw data: {'ac8eaa37ee': [2.73, 2.7, 2.73], '893552a691': [2.7, 2.71, 2.71]}
  med diff -0.732601 % (893552a691 is faster)

benchmark for arguments: -I carver MSDM
raw data: {'ac8eaa37ee': [52.43, 52.41, 52.17], '893552a691': [52.47, 52.33, 
52.18]}
893552a691 - Create skylines directly from glyph outlines.
  med diff -0.152643 % (893552a691 is faster)

(for Carver score, the difference is at noise)

https://codereview.appspot.com/561730043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5953 Further cleanup/regularisation of Callback_wrapper classes and trampolines

2020-05-02 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- Description has changed:

Diff:







- **Needs**:  -->  
- **Patch**: new --> review
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5953] Further cleanup/regularisation of Callback_wrapper classes 
and trampolines**

**Status:** Started
**Created:** Fri May 01, 2020 08:51 PM UTC by David Kastrup
**Last Updated:** Fri May 01, 2020 08:51 PM UTC
**Owner:** David Kastrup


Further cleanup/regularisation of Callback_wrapper classes and trampolines

Contains two commits:

Callback_wrapper:: move trampolines and make_smob to Callbacks class



Make Callback_wrapper a class template

Templating Callback_wrapper on the wrapped argument list avoids a lot
of code repetition.

http://codereview.appspot.com/553980044


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto