[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5689 Refactor enforcement of a single Score context

2020-01-29 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- **labels**:  --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Type**: Enhancement --> Maintainability
- **Comment**:

```text
commit 5e40b2af5005e1fd1d0bee225b55ef544be80631
Author: Dan Eble 
Date:   Fri Jan 17 22:22:33 2020 +0100

Issue 5689: Refactor enforcement of a single Score context

...
```



---

** [issues:#5689] Refactor enforcement of a single Score context**

**Status:** Fixed
**Labels:** Fixed_2_21_0 
**Created:** Fri Jan 24, 2020 11:01 PM UTC by Dan Eble
**Last Updated:** Wed Jan 29, 2020 05:58 AM UTC
**Owner:** Dan Eble


Context::find_create_context () and Context::create_unique_context ()
no longer require special cases to avoid ascending to the Global context
or to create a Score themselves.  Instead, the method that they each
call to create any new context, Context::create_hierarchy (), avoids
creating multiple Scores.

This is still hard-coded in C++ to happen for Score only, but it would
be straightforward to add a context attribute that could be used in ly
code like \accepts and \defaultchild.

https://codereview.appspot.com/551390046


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5689 Refactor enforcement of a single Score context

2020-01-28 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- **Patch**: countdown --> push
- **Comment**:

Patch counted down - please push



---

** [issues:#5689] Refactor enforcement of a single Score context**

**Status:** Started
**Created:** Fri Jan 24, 2020 11:01 PM UTC by Dan Eble
**Last Updated:** Mon Jan 27, 2020 11:28 AM UTC
**Owner:** Dan Eble


Context::find_create_context () and Context::create_unique_context ()
no longer require special cases to avoid ascending to the Global context
or to create a Score themselves.  Instead, the method that they each
call to create any new context, Context::create_hierarchy (), avoids
creating multiple Scores.

This is still hard-coded in C++ to happen for Score only, but it would
be straightforward to add a context attribute that could be used in ly
code like \accepts and \defaultchild.

https://codereview.appspot.com/551390046


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5689 Refactor enforcement of a single Score context

2020-01-27 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for Jan 29th



---

** [issues:#5689] Refactor enforcement of a single Score context**

**Status:** Started
**Created:** Fri Jan 24, 2020 11:01 PM UTC by Dan Eble
**Last Updated:** Fri Jan 24, 2020 11:41 PM UTC
**Owner:** Dan Eble


Context::find_create_context () and Context::create_unique_context ()
no longer require special cases to avoid ascending to the Global context
or to create a Score themselves.  Instead, the method that they each
call to create any new context, Context::create_hierarchy (), avoids
creating multiple Scores.

This is still hard-coded in C++ to happen for Score only, but it would
be straightforward to add a context attribute that could be used in ly
code like \accepts and \defaultchild.

https://codereview.appspot.com/551390046


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5689 Refactor enforcement of a single Score context

2020-01-24 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 
- Description has changed:

Diff:







- **Needs**:  -->  
- **Patch**: new --> review
- **Comment**:

passes make, make check and a full make doc



---

** [issues:#5689] Refactor enforcement of a single Score context**

**Status:** Started
**Created:** Fri Jan 24, 2020 11:01 PM UTC by Dan Eble
**Last Updated:** Fri Jan 24, 2020 11:01 PM UTC
**Owner:** Dan Eble


Context::find_create_context () and Context::create_unique_context ()
no longer require special cases to avoid ascending to the Global context
or to create a Score themselves.  Instead, the method that they each
call to create any new context, Context::create_hierarchy (), avoids
creating multiple Scores.

This is still hard-coded in C++ to happen for Score only, but it would
be straightforward to add a context attribute that could be used in ly
code like \accepts and \defaultchild.

https://codereview.appspot.com/551390046


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5689 Refactor enforcement of a single Score context

2020-01-24 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development 



---

** [issues:#5689] Refactor enforcement of a single Score context**

**Status:** Started
**Created:** Fri Jan 24, 2020 11:01 PM UTC by Dan Eble
**Last Updated:** Fri Jan 24, 2020 11:01 PM UTC
**Owner:** nobody


Context::find_create_context () and Context::create_unique_context ()
no longer require special cases to avoid ascending to the Global context
or to create a Score themselves.  Instead, the method that they each
call to create any new context, Context::create_hierarchy (), avoids
creating multiple Scores.

This is still hard-coded in C++ to happen for Score only, but it would
be straightforward to add a context attribute that could be used in ly
code like \accepts and \defaultchild.

https://codereview.appspot.com/551390046


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto