Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

[pierstitus]

Reviewers: ,

Message:
Please review my contribution to this wonderful project. Maybe still in
time for 2.16 :)
On the other hand, it changes quite a bit of the way ledger lines are
handled, and I'm not sure what your policy for new features just before
release is.

Piers

Description:
Add support for custom ledger positions, using two new staff-symbol
properties

See http://code.google.com/p/lilypond/issues/detail?id=1292 for the
proposal.

This also adds support for internal ledger lines, and hence resolves
issue http://code.google.com/p/lilypond/issues/detail?id=1193

A regression test for ledger positions is added.

This causes one change in the current regression tests, namely an
internal ledger line is added to staff-line-positions.ly. I don't think
it is a problem to have internal ledger lines by default.

Please review this at http://codereview.appspot.com/4974075/

Affected files:
  A input/regression/staff-ledger-positions.ly
  M lily/include/staff-symbol.hh
  M lily/ledger-line-spanner.cc
  M lily/staff-symbol.cc
  M scm/define-grob-properties.scm



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Offer to clean up (very) old Tracker issues

[Janek Warchoł]

2011/9/9 Reinhold Kainhofer :
> Am Friday, 9. September 2011, 22:06:07 schrieb Janek Warchoł:
>> > So I am running this pass the 'dev'
>> > group for any other additional suggestions (such as other labels I
>> > could remove/apply, how far forward I should go etc)
>>
>> I think Graham said everything that could come to my mind.
>
> What I would like to have is some kind of area tag. While going through some
> bug reports, I notice that many old reports are dealing slurs or with ties. It
> would make sense to add something like
> Area-Ties
> Area-Slurs
> Area-LilypondBook
> Area-MusicXML
> Area-Gregorian
> Area-Tuplets
> Area-Documentation
> Area-Lyrics
> Area-PageLayout
> Area-Libraries (for external libs like pango, guile, etc.)
> Area-Dynamics
> Area-Webpage
> Area-Installer
> Area-GUIs (or Area-Editors)
> Area-PartCombine
> Area-Font
> Area-SVG
> ...
>
> This would allow us to show only those bugs that belong to a given area, like
> all bugs related to lilypond-book.
>
> Currently, we have some tags (markup, midi, grace, website), but there is no
> real system to those tags.

Maybe...  At least it would be good to make sure that the summary of
the issue contains the key words (and that the key words are used
consistently, for example choose "tie" or "ties", do not use both).

cheers,
Janek

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCH:72-hour countdown to 20110912

[Colin Campbell]

For 22:00 MDT Monday September 12

Issue 1814 : 
Breve with double-line "ears" can collide with accidentals and barlines 
- R 4986042 : include lines in 
breve X-extent


Issue 1871 : 
Several fixes for annotate-spacing - R 4950071 



Cheers,
Colin

--
The human race has one really effective weapon, and that is laughter.
-- Mark Twain

 

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: patches for LilyPond issues 1503 and 1572

[Adam Spiers]

Sorry Janek, I did receive the email but I've been away travelling for
3 months and only just got back.  I would be glad to work with you on
getting these patches finalised and submitted, although please bear
with me over the next few days as I have some other pressing issues to
attend to first.

I think the best way would be if I help you with github because it's
an absolutely beautiful service and IMHO much nicer than emailing
patches once you get used to it.  If you haven't already done so,
please try adding my github repository to your own as a remote:

  git remote add aspiers git://github.com/aspiers/lilypond.git

and then simply fetch or pull the commits from my remote branch:

  git fetch aspiers master

or:

  git pull aspiers master

(pull is equivalent to fetch followed by a merge into your current
branch).

Let me know how you get on (but please be patient if I don't reply
quickly!)

Thanks,
Adam

2011/8/22 Janek Warchoł :
> Hi Adam,
>
> apparently you didn't receive my previous e-mail, so i'm writing again.
> I'd like to help you with your patches about jazz chords display
> (issue 1503, and also you said that you have some patches for 1572).
> It looks like they are being overlooked.  We should upload them to
> Rietveld so that te development team will review them; could you send
> me the patch files?  I tried downloading them from github, but i'm
> unfamiliar with it and got lost.
>
> thanks for your work,
> Janek
>
> 2011/7/29 Janek Warchoł :
>> Hi Adam,
>>
>> On Thu, Jul 28, 2011 at 08:41:31AM, adam.spi...@gmail.com wrote:
>>> Patches are available here, although some are still a work in progress:
>>> https://github.com/aspiers/lilypond/commits/master
>>
>> could you send me patch files directly?  I've never used github and i
>> must admit that i'm lost...  Also, i'm not sure what should be
>> uploaded.
>> If you'd like, i can help you upload these patches yourself, it's not
>> hard (the main problem is how to escape the vi-trap that other people
>> set for us ;P).
>> Are you using Lilydev?
>>
>> thanks for your work!
>> Janek
>

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Cleaned up style (issue 4951062)

[aleksandr . andreev]

Changed code style and glyph names based on the comments of Carl and
lemzwerg.

Carl, is it OK that the group name is kievan, so now we have glyphs like
kievan.s1kievan? Is this how it should be?

Re: "you can see that all coordinates rely on  meta-parameters which
control the appearance"

I'm new to MetaFont, so I'm not sure I know what a meta-parameter is.
lemzwerg, could you or someone else more knowledgeable about MF than me
code up one of these glyphs the LilyPond way as an example? I think if I
see it done once correctly, I'll be able to figure it out.

http://codereview.appspot.com/4951062/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

[Francisco Vila]

Hello all,

2011/9/6 Peekay Ex :
> I need to make a new patch. It's because of a combination of things; I was
> (and am still) waiting on Francisco to know if I can remove the old compound
> meter examples in the snippet refs in the various translation tely files (I
> have asked him for a review a couple of times and emailed directly but had
> no response) and then I was away for a couple of weeks and the patched files
> are now out of sync.

Hello. I've found this in my recycle bin:

Re: Doc: Added \compoundMeter function to NR (issue 4837050)
http://lists.gnu.org/archive/html/lilypond-devel/2011-08/msg01029.html

Message headers include [Reply_to:] to 9 addresses, [To:] to 6
addresses, [Cc:] to 2 more addresses and none of them all is my own
address.  So, I am very sorry to say, it seems you forgot to cc me.  I
read and delete many messages based on the subject line and whether
the message is for me and this didn't, despite of including the word
Francisco in the body.  Sorry for that!

This has been a Very Bad Year (TM) for me and I hope things will
improve slowly from now on.  Thanks for your interest.

As for Rietveld 4837050, I can not oppose to removing references to a
non-existant snippet from translated docs. Thanks for this useful
work.

-- 
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix 456: Also check for laissez-vibrer events attached to single heads inside a chord (issue 4969069)

[tdanielsmusic]

LGTM

http://codereview.appspot.com/4969069/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Offer to clean up (very) old Tracker issues

[Reinhold Kainhofer]

Am Friday, 9. September 2011, 22:06:07 schrieb Janek Warchoł:
> > So I am running this pass the 'dev'
> > group for any other additional suggestions (such as other labels I
> > could remove/apply, how far forward I should go etc)
> 
> I think Graham said everything that could come to my mind.

What I would like to have is some kind of area tag. While going through some 
bug reports, I notice that many old reports are dealing slurs or with ties. It 
would make sense to add something like
Area-Ties
Area-Slurs
Area-LilypondBook
Area-MusicXML
Area-Gregorian
Area-Tuplets
Area-Documentation
Area-Lyrics
Area-PageLayout
Area-Libraries (for external libs like pango, guile, etc.)
Area-Dynamics
Area-Webpage
Area-Installer
Area-GUIs (or Area-Editors)
Area-PartCombine
Area-Font
Area-SVG
...

This would allow us to show only those bugs that belong to a given area, like 
all bugs related to lilypond-book.

Currently, we have some tags (markup, midi, grace, website), but there is no 
real system to those tags.

Cheers,
Reinhold

-- 
--
Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Offer to clean up (very) old Tracker issues

[Janek Warchoł]

2011/9/8 Peekay Ex :
> Hello,
>
> I've had a brief conversation with Graham who agreed in principle and
> asked me to send a mail to dev regarding 'going through' and 'cleaning
> up' old tracker issues.

that's very nice of you!

> So I am running this pass the 'dev'
> group for any other additional suggestions (such as other labels I
> could remove/apply, how far forward I should go etc)

I think Graham said everything that could come to my mind.

cheers,
Janek

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044)

[Janek Warchoł]

2011/9/9  :
> http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py#oldcode691
> scripts/lilypond-book.py:691: + '.%s' % global_options.format)
> On 2011/09/09 19:19:47, janek wrote:
>>
>> Pardon my ignorance, but what the
>> '.%s' %
>> part was doing before?
>
> It simply prepended the "." and the correct file extension to the base
> name (which is the file name without extension).
>
> Granted, writing it as
>  base_file_name + "." + global_options.format
> would have given the same result...

ok, thanks!
Janek

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044)

[percival . music . ca]

http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py
File scripts/lilypond-book.py (right):

http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py#newcode681
scripts/lilypond-book.py:681: chunks = do_file (files[0])
you mean "that do_file BELOW", right?

woah, you're right (line 539).  That's an obscene side effect of the
function!

http://codereview.appspot.com/4996044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044)

[reinhold . kainhofer]

LGTM, although I would also move that code changing
global_options.output_dir from do_file to main, to make things much
clearer!


http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py
File scripts/lilypond-book.py (left):

http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py#oldcode691
scripts/lilypond-book.py:691: + '.%s' % global_options.format)
On 2011/09/09 19:19:47, janek wrote:

Pardon my ignorance, but what the
'.%s' %
part was doing before?


It simply prepended the "." and the correct file extension to the base
name (which is the file name without extension).

Granted, writing it as
  base_file_name + "." + global_options.format
would have given the same result...

http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py
File scripts/lilypond-book.py (right):

http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py#newcode539
scripts/lilypond-book.py:539: global_options.output_dir =
os.path.abspath(global_options.output_dir)
Ouch, that's the real culprit here: Why do we change the GLOBAL options
in the function to process one file? That code should be moved out of
do_file and into main, so the option handling is easier to understand!

http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py#newcode677
scripts/lilypond-book.py:677: relative_output_dir =
global_options.output_dir
On 2011/09/09 19:28:29, Graham Percival wrote:

did you want an
   os.path.relpath()
here or something?  I don't see the point of defining

relative_output_dir

instead of just keeping global_options.output_dir down on line 690.


The Problem is that do_file above CHANGES the global_options.output_dir
to an absolute path...
It took me a while to figure that out, too.

http://codereview.appspot.com/4996044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044)

[percival . music . ca]

http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py
File scripts/lilypond-book.py (right):

http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py#newcode677
scripts/lilypond-book.py:677: relative_output_dir =
global_options.output_dir
did you want an
  os.path.relpath()
here or something?  I don't see the point of defining
relative_output_dir instead of just keeping global_options.output_dir
down on line 690.

http://codereview.appspot.com/4996044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044)

[janek . lilypond]

Hi,

as usual my review will contain only questions...
Please pardon my ignorance, i don't know what this area of the code
does.  However, what your patch does seems reasonable to me.


http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py
File scripts/lilypond-book.py (left):

http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py#oldcode691
scripts/lilypond-book.py:691: + '.%s' % global_options.format)
Pardon my ignorance, but what the
'.%s' %
part was doing before?

http://codereview.appspot.com/4996044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044)

[janek . lilypond]

Reviewers: julien.rioux_gmail.com, Graham Percival,

Message:
By Julien Rioux.

Description:
Fix issue #1852: manuals needs more explicit dependencies.

Dependencies are already being tracker by lilypond-book.py,
which produces .dep files containing make rules. The file
stepmake/stepmake/generic-targets.make includes them into
the build.

The problem is that the .dep files contain errors.

We fix the .dep files produced by lilypond-book.py by
  1) using the relative path to the target file,
  2) using the correct file extension for the target file.

Please review this at http://codereview.appspot.com/4996044/

Affected files:
  M scripts/lilypond-book.py


Index: scripts/lilypond-book.py
diff --git a/scripts/lilypond-book.py b/scripts/lilypond-book.py
index  
b1256529fd247ae6193b906f7e7e7ce8ab15b6cc..0814739b47b890d3278ea66a5d8dc0442fd3fbe4  
100644

--- a/scripts/lilypond-book.py
+++ b/scripts/lilypond-book.py
@@ -674,6 +674,7 @@ def main ():
 else:
 global_options.lily_output_dir =  
os.path.abspath(global_options.output_dir)


+relative_output_dir = global_options.output_dir

 identify ()
 try:
@@ -686,9 +687,8 @@ def main ():

 base_file_name = os.path.splitext (os.path.basename (files[0]))[0]
 dep_file = os.path.join (global_options.output_dir, base_file_name  
+ '.dep')

-final_output_file = os.path.join (global_options.output_dir,
- base_file_name
- + '.%s' % global_options.format)
+final_output_file = os.path.join (relative_output_dir,
+ base_file_name +  
global_options.formatter.default_extension)


 os.chdir (original_dir)
 file (dep_file, 'w').write ('%s: %s'



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

[pkx166h]

Added http://code.google.com/p/lilypond/issues/detail?id=1878

http://codereview.appspot.com/4974075/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046)

[tdanielsmusic]

Hi Mike
I found a visual difference with one of my scores.  I finally tracked
this down to a dependence on the stem direction.  Try this:

SopranoMusic = \relative g' {
  b2 b
  \once \override Staff . BarLine #'allow-span-bar = ##f
  b2 b
}

TenorMusic = \relative a' {
  b2 b |
  b2 b |
}

\score {
  \new GrandStaff <<
\new Staff {
  \new Voice = "Soprano" {
\stemDown
\SopranoMusic
  }
}
\new Lyrics \lyricsto "Soprano" {
  a b long-syllable a
}
\new Staff {
  \new Voice = "Tenor" {
\TenorMusic
  }
}
  >>
}

\score {
  \new GrandStaff <<
\new Staff {
  \new Voice = "Soprano" {
\stemUp
\SopranoMusic
  }
}
\new Lyrics \lyricsto "Soprano" {
  a b long-syllable a
}
\new Staff {
  \new Voice = "Tenor" {
\TenorMusic
  }
}
  >>
}

http://codereview.appspot.com/4917046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

[pierstitus]

http://codereview.appspot.com/4974075/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New Ubuntu PC

[Graham Percival]

On Fri, Sep 09, 2011 at 05:37:03PM +0100, Phil Holmes wrote:
> I've got 2 disks in it - the main one is a standard SATA drive with
> the OS on it.  The other one is an 80 GByte SSD (solid state disk)
> that I bought with the intention of using as my data disk, so that
> compiles, etc., use the fastest disk there is.  My question is - how
> do I set up Ubuntu to use this as my data drive (presumably $HOME).
> I've read stuff about editing fstab, but wonder if this is the best
> way?  Any other pointers would be appreciated.

The easiest way is to set this up during the install.  When you
got to the "partitioning" screen and you presumably clicked on "do
it automatically for me", you missed the option.  :)

However, I'd suggest a slightly different setup: don't use your
SSD drive for your complete $HOME; instead, use it for things that
you specifically want on that drive.  I have a similar setup
(albeit just with disk partitions) on all my computers.

The relevant part of /etc/fstab is:
UUID=27b221e8-ad38-4811-97c4-aabf2cb7f5e4   /main   ext4
defaults,user,exec  0   0
(all one line)

and my $HOME directory contains this:
gperciva@futoi:~$ ls -l
...
lrwxrwxrwx 1 gperciva gperciva   10 2011-08-28 12:41 src ->
/main/src/
...

so whenever I go to $HOME/src/ , I'll actually be in /main

You could easily have separate symlinks for $HOME/lilypond-git/
and any other software you wanted to compile quickly (maybe
$HOME/gub/ ?)


One advantage of this /main/ (or /compile/ or whatever you want to
call it) approach is that it's easy to set up that drive after
installing the main OS, so you won't need to reinstall.

Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fix 456: Also check for laissez-vibrer events attached to single heads inside a chord (issue 4969069)

[joeneeman]

lgtm

http://codereview.appspot.com/4969069/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

New Ubuntu PC

[Phil Holmes]

As I've already discussed with Graham and James, I've just taken delivery of 
a new PC, and have now loaded Ubuntu 10.04 64 bit onto it.  It all seems to 
be working OK, and it boots in about 10 seconds!


I've got 2 disks in it - the main one is a standard SATA drive with the OS 
on it.  The other one is an 80 GByte SSD (solid state disk) that I bought 
with the intention of using as my data disk, so that compiles, etc., use the 
fastest disk there is.  My question is - how do I set up Ubuntu to use this 
as my data drive (presumably $HOME).  I've read stuff about editing fstab, 
but wonder if this is the best way?  Any other pointers would be 
appreciated.


--
Phil Holmes



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

parser.yy et al: Turn \transpose into a music function, make other music functions use ly:pitch? (issue 4991049)

[reinhold . kainhofer]

LGTM


http://codereview.appspot.com/4991049/diff/2001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/4991049/diff/2001/ly/music-functions-init.ly#newcode852
ly/music-functions-init.ly:852: pitch)))
indent (or better, write the whole lambda in one line).

BTW, that's a nice catch that this function can be implemented so easy!

http://codereview.appspot.com/4991049/diff/2001/ly/music-functions-init.ly#newcode876
ly/music-functions-init.ly:876: (if (string? finger) 'text 'digit)
remove tab in the middle of the line;
Use 8 spaces instead of tabs (even if the old code also had tabs. We
want to get away from tabs ASAP).

http://codereview.appspot.com/4991049/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Patch for review: Turn \transpose into a music function, simplify other music functions using ly:pitch? signatures

[David Kastrup]

http://codereview.appspot.com/4991049>

-- 
David Kastrup


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel