Re: Fix 456: Also check for laissez-vibrer events attached to single heads inside a chord (issue 4969069)
Passes make and reg tests http://codereview.appspot.com/4969069/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Fix 380: Try to auto-detect cyclic references in header fields (issue 4951073)
Passes make but fails reg test check: see http://code.google.com/p/lilypond/issues/detail?id=380#c15 for details (keeps the noise down here) James http://codereview.appspot.com/4951073/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: parser.yy et al: Turn \transpose into a music function, make other music functions use ly:pitch? (issue 4991049)
passes make and reg tests http://codereview.appspot.com/4991049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
MusicXML: fix case when some elements have a staff number, while others don't (issue 4991044)
Passes make and reg tests http://codereview.appspot.com/4991044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Cleaned up style (issue 4951062)
Simply have a look how other note heads are implemented, and watch how the shape changes for different design sizes. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Cleaned up style (issue 4951062)
http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)
Passes make and reg tests http://codereview.appspot.com/4974075/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Cleaned up style (issue 4951062)
Can we please have a more meaningful issue title than Cleaned up style, which does not tell me at all what this review is about when I get all those notifications mails. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix 380: Try to auto-detect cyclic references in header fields (issue 4951073)
patch 2 passes make and reg tests http://codereview.appspot.com/4951073/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Offer to clean up (very) old Tracker issues
On Fri, Sep 09, 2011 at 10:41:21PM +0200, Reinhold Kainhofer wrote: What I would like to have is some kind of area tag. While going through some bug reports, I notice that many old reports are dealing slurs or with ties. It would make sense to add something like Area-Ties Area-Slurs I believe that Foo-bar conflicts with Foo-baz. I think that regular tags would be enough, if we wanted to do this. This would allow us to show only those bugs that belong to a given area, like all bugs related to lilypond-book. Currently, we have some tags (markup, midi, grace, website), but there is no real system to those tags. That is true. I'm not certain if it's worth trying to make (and implement) a real system to these tags, though; that's a lot more effort than we're currently thinking of doing on the issues. And I still have some hope that James will return to documentation work at some point, just so that we can have at least one person doing docs! But if you (or anybody) want to make an official list of tags, I'm certainly willing to discuss it. I don't think these tags should duplicate the existing Type- labels, though, so area-documentation should not appear in the list. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Cleaned up style (issue 4951062)
I created https://code.google.com/p/lilypond/issues/detail?id=1873 and called it 'Added glyphs for Kievan Notation' so when this issue is changed can we use the same title? http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Basic LilyPond Cheat Sheet
Dear all, Sometimes it can be very useful -- in particular for new and not so experienced users -- to have the basic LilyPond syntax available compressed on one single sheet. I have created such a cheat sheet that displays the basic lilypond syntax and usage (without any tweaks and overrides) on one single page, while also being visually appealing. The cheat sheet is meant to be a quick summary of the things explained in the learning manual, but does not replace the learning manual. It simply is a quick reminder of all the stuff, once you have read the learning manual. Attached you can find the PDF version of this cheat sheet: http://www.fam.tuwien.ac.at/~reinhold/temp/2011-08-24_LilyPond_CheatSheet_Basic.pdf I also provide nicely printed copies of the cheat sheet for basically my own costs (3€ per sheet + shipping): http://www.edition-kainhofer.com/en/lilypond/details/2111/ These copies are printed borderless on heavier paper and are laminated, so they are waterproof and hold for years. Chers, Reinhold PS: I'm also planning to write a cheat sheet with basic tweaks/overrides and the various paper/header fields. But that might take a while. PS2: For now, the LaTeX source code of the cheat sheet is not available, but I might make it available some time in the future, when I have cleaned up my heavily-customized version of the baposter package I'm using. -- -- Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/ * Financial Actuarial Math., Vienna Univ. of Technology, Austria * http://www.fam.tuwien.ac.at/, DVR: 0005886 * LilyPond, Music typesetting, http://www.lilypond.org ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044)
passes make and reg tests http://codereview.appspot.com/4996044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
On 2011/09/10 12:47:18, J_lowe wrote: I created https://code.google.com/p/lilypond/issues/detail?id=1873 and called it 'Added glyphs for Kievan Notation' so when this issue is changed can we use the same title? I changed the name of the issue. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
On 2011/09/10 10:20:45, lemzwerg wrote: Simply have a look how other note heads are implemented, and watch how the shape changes for different design sizes. OK. What is noteheight# equal to and how is that determined? http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Doc: Added \compoundMeter function to NR (issue 4837050)
Francisco, On Sat, Sep 10, 2011 at 12:36 AM, Francisco Vila paconet@gmail.com wrote: Hello all, 2011/9/6 Peekay Ex pkx1...@gmail.com: I need to make a new patch. It's because of a combination of things; I was (and am still) waiting on Francisco to know if I can remove the old compound meter examples in the snippet refs in the various translation tely files (I have asked him for a review a couple of times and emailed directly but had no response) and then I was away for a couple of weeks and the patched files are now out of sync. Hello. I've found this in my recycle bin: Re: Doc: Added \compoundMeter function to NR (issue 4837050) http://lists.gnu.org/archive/html/lilypond-devel/2011-08/msg01029.html Message headers include [Reply_to:] to 9 addresses, [To:] to 6 addresses, [Cc:] to 2 more addresses and none of them all is my own address. So, I am very sorry to say, it seems you forgot to cc me. I read and delete many messages based on the subject line and whether the message is for me and this didn't, despite of including the word Francisco in the body. Sorry for that! This has been a Very Bad Year (TM) for me and I hope things will improve slowly from now on. Thanks for your interest. ... I figured this was what happened Francisco (I am still getting used to gmail's interface and keep forgetting to reply-all). The problem now is that my code is too old for the current tree and fails when I try to patch. I have been trying to re-do the patch manually but am having a hard time now getting to compile - so I'll keep working on this today (so I am back doing 'doc' again Graham! ;) ) James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Cyclic redundancies with manual beaming
Hi guys,
This perfectly innocent looking snippet spits forth several errors
with current master:
\version 2.15.11
\relative c' {
s2. c8[ c
c8 c]
}
/tmp/tmpJ8GqW5/document.ly:4:8: programming error: cyclic dependency:
calculation-in-progress encountered for #'quantized-positions (Beam)
s2. c8
[ c
/tmp/tmpJ8GqW5/document.ly:4:8: continuing, cross fingers
s2. c8
[ c
/tmp/tmpJ8GqW5/document.ly:4:8: programming error: cyclic dependency:
calculation-in-progress encountered for #'quantized-positions (Beam)
s2. c8
[ c
/tmp/tmpJ8GqW5/document.ly:4:8: continuing, cross fingers
s2. c8
[ c
/tmp/tmpJ8GqW5/document.ly:4:8: programming error: cyclic dependency:
calculation-in-progress encountered for #'quantized-positions (Beam)
s2. c8
[ c
/tmp/tmpJ8GqW5/document.ly:4:8: continuing, cross fingers
s2. c8
[ c
/tmp/tmpJ8GqW5/document.ly:4:8: programming error: cyclic dependency:
calculation-in-progress encountered for #'quantized-positions (Beam)
s2. c8
[ c
/tmp/tmpJ8GqW5/document.ly:4:8: continuing, cross fingers
s2. c8
[ c
I'll try to do a bisect later to narrow it down.
Uh oh, just noticed another one with stem Y-extent too (no manual beam
required here):
\version 2.15.11
\relative c' {
\partial 16
c32 d
}
/tmp/tmp0lpVUz/document.ly:3:2: programming error: cyclic dependency:
calculation-in-progress encountered for #'Y-extent (Stem)
c32 d
/tmp/tmp0lpVUz/document.ly:3:2: continuing, cross fingers
c32 d
/tmp/tmp0lpVUz/document.ly:3:2: programming error: cyclic dependency:
calculation-in-progress encountered for #'quantized-positions (Beam)
c32 d
/tmp/tmp0lpVUz/document.ly:3:2: continuing, cross fingers
c32 d
Cheers,
Neil
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Basic LilyPond Cheat Sheet
2011/9/10 Reinhold Kainhofer reinh...@kainhofer.com: PS2: For now, the LaTeX source code of the cheat sheet is not available, but I might make it available some time in the future, when I have cleaned up my heavily-customized version of the baposter package I'm using. When you make it available, I'd like to translate it into Spanish. I had started a similar project some time ago, but I never finished it. Looks great and very useful; thanks! -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmbadajoz.com ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: New Ubuntu PC
- Original Message - From: Graham Percival gra...@percival-music.ca To: Phil Holmes em...@philholmes.net Cc: Devel lilypond-devel@gnu.org Sent: Friday, September 09, 2011 6:00 PM Subject: Re: New Ubuntu PC On Fri, Sep 09, 2011 at 05:37:03PM +0100, Phil Holmes wrote: I've got 2 disks in it - the main one is a standard SATA drive with the OS on it. The other one is an 80 GByte SSD (solid state disk) that I bought with the intention of using as my data disk, so that compiles, etc., use the fastest disk there is. My question is - how do I set up Ubuntu to use this as my data drive (presumably $HOME). I've read stuff about editing fstab, but wonder if this is the best way? Any other pointers would be appreciated. The easiest way is to set this up during the install. When you got to the partitioning screen and you presumably clicked on do it automatically for me, you missed the option. :) However, I'd suggest a slightly different setup: don't use your SSD drive for your complete $HOME; instead, use it for things that you specifically want on that drive. I have a similar setup (albeit just with disk partitions) on all my computers. The relevant part of /etc/fstab is: UUID=27b221e8-ad38-4811-97c4-aabf2cb7f5e4 /main ext4 defaults,user,exec 0 0 (all one line) and my $HOME directory contains this: gperciva@futoi:~$ ls -l ... lrwxrwxrwx 1 gperciva gperciva 10 2011-08-28 12:41 src - /main/src/ ... so whenever I go to $HOME/src/ , I'll actually be in /main You could easily have separate symlinks for $HOME/lilypond-git/ and any other software you wanted to compile quickly (maybe $HOME/gub/ ?) One advantage of this /main/ (or /compile/ or whatever you want to call it) approach is that it's easy to set up that drive after installing the main OS, so you won't need to reinstall. OK, thanks. Got this working with symlinks as suggested. Only initial problem I experienced was the I could not run lilygit - it complained that lilypond-git/.git was not a directory. I got round this by manually configuring git as described in the CG, and the script now seems to work. I've now followed the instructions for downloading the source and the needed programs from the CG. When I run configure, it says that I need to install fontforge. Is this done with Synaptic, or is it better to use apt, or is there another way? Another problem I'm getting is that I can't see my Windows network. I've downloaded and installed samba and this doesn't seem to help. Is it a magic feature of VirtualBox that makes it work on Lilvdev, or am I missing a different component? -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: New Ubuntu PC
On Sat, Sep 10, 2011 at 05:32:07PM +0100, Phil Holmes wrote: I've now followed the instructions for downloading the source and the needed programs from the CG. When I run configure, it says that I need to install fontforge. Is this done with Synaptic, or is it better to use apt, or is there another way? synaptic or apt (same thing for this purpose) will give you a version of fontforge which will work, but which will give you a warning message. Ignore the warning. You may want to try installing fontforge from scratch just for giggles, though. But that's not necessary to get things going. (at least, it's not necessary not until http://code.google.com/p/lilypond/issues/detail?id=1637 is done) Another problem I'm getting is that I can't see my Windows network. dunno. Google around for ubuntu windows network; I'm sure you'll find tons of stuff. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: New Ubuntu PC
On 11-09-10 10:32 AM, Phil Holmes wrote: - Original Message - From: Graham Percival gra...@percival-music.ca To: Phil Holmes em...@philholmes.net Cc: Devel lilypond-devel@gnu.org Sent: Friday, September 09, 2011 6:00 PM Subject: Re: New Ubuntu PC On Fri, Sep 09, 2011 at 05:37:03PM +0100, Phil Holmes wrote: I've got 2 disks in it - the main one is a standard SATA drive with the OS on it. The other one is an 80 GByte SSD (solid state disk) that I bought with the intention of using as my data disk, so that compiles, etc., use the fastest disk there is. My question is - how do I set up Ubuntu to use this as my data drive (presumably $HOME). I've read stuff about editing fstab, but wonder if this is the best way? Any other pointers would be appreciated. The easiest way is to set this up during the install. When you got to the partitioning screen and you presumably clicked on do it automatically for me, you missed the option. :) However, I'd suggest a slightly different setup: don't use your SSD drive for your complete $HOME; instead, use it for things that you specifically want on that drive. I have a similar setup (albeit just with disk partitions) on all my computers. The relevant part of /etc/fstab is: UUID=27b221e8-ad38-4811-97c4-aabf2cb7f5e4 /main ext4 defaults,user,exec 0 0 (all one line) and my $HOME directory contains this: gperciva@futoi:~$ ls -l ... lrwxrwxrwx 1 gperciva gperciva 10 2011-08-28 12:41 src - /main/src/ ... so whenever I go to $HOME/src/ , I'll actually be in /main You could easily have separate symlinks for $HOME/lilypond-git/ and any other software you wanted to compile quickly (maybe $HOME/gub/ ?) One advantage of this /main/ (or /compile/ or whatever you want to call it) approach is that it's easy to set up that drive after installing the main OS, so you won't need to reinstall. OK, thanks. Got this working with symlinks as suggested. Only initial problem I experienced was the I could not run lilygit - it complained that lilypond-git/.git was not a directory. I got round this by manually configuring git as described in the CG, and the script now seems to work. I've now followed the instructions for downloading the source and the needed programs from the CG. When I run configure, it says that I need to install fontforge. Is this done with Synaptic, or is it better to use apt, or is there another way? Another problem I'm getting is that I can't see my Windows network. I've downloaded and installed samba and this doesn't seem to help. Is it a magic feature of VirtualBox that makes it work on Lilvdev, or am I missing a different component? IIRC, you need to be fairly explicit in the way you see Windows devices, Phil. Have a look at Smb4K, a front-end to Samba. It will allow you to specify things like Windows domains to search, and to store your Windows ID and password. You can also do things like setting up entries in /etc/fstab to automount your Windows shares, using a hidden .smbcredentials file in your $HOME. VBox also allows you to share folders between the real and virtual machines, but I believe that is only for local folders, not networked cheers, Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: New Ubuntu PC
Hello, On Sat, Sep 10, 2011 at 5:58 PM, Colin Campbell c...@shaw.ca wrote: VBox also allows you to share folders between the real and virtual machines, but I believe that is only for local folders, not networked Correct. From the VBox help: Shared folders must physically reside on the host and are then shared with the guest.. However I think Phil was being literal because with the LilyDev build of Ubuntu (which is lucid lemming - or whatever stupid name they called it - 10.04?) it 'just worked' when you were on a Windows Network, so something I guess is different as Mr Kulp (who built the iso for lilydev) didn't seem to do anything special in this respect I think. Regards -- -- James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Cannot run makelsr.py inside 'build' dir
Hello, Subject is self explanatory --snip-- jlowe@jlowe-lilybuntu2:~/lilypond-git/build$ ../scripts/auxiliar/makelsr.py Traceback (most recent call last): File ../scripts/auxiliar/makelsr.py, line 9, in module import langdefs ImportError: No module named langdefs --snip-- If I cd up one dir then I can run it from ~/lilypond-git. Regards -- -- James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Cannot run makelsr.py inside 'build' dir
On Sat, Sep 10, 2011 at 08:18:38PM +0100, Peekay Ex wrote: Subject is self explanatory You're not supposed to run it from the build dir. Line 16-17 USAGE = ''' Usage: makelsr.py [LSR_SNIPPETS_DIR] This script must be run from top of the source tree; To forstall your next question, the answer is lines 69-72. - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
hands off LSR and makelsr.py
Neil has very kindly offered to organize the LSR upgrade from 2.12 to 2.14. http://code.google.com/p/lilypond/issues/detail?id=1776#c33 He noted that the previous update was a disaster which required him to manually remove duplicate docstrings. With that in mind, please don't mess with LSR or run makelsr.py unless he says it's ok. Neil: is it ok to run makelsr.py locally? I think that translators and some programmers need this, but if you're rather deal with it yourself, that's fine. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: hands off LSR and makelsr.py
On 10 September 2011 21:34, Graham Percival gra...@percival-music.ca wrote: Neil: is it ok to run makelsr.py locally? I think that translators and some programmers need this, but if you're rather deal with it yourself, that's fine. Local updates shouldn't pose any problems. Cheers, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
changes in chord names formatting (1503, 1572) (issue 4981052)
Reviewers: adam.spiers,
Message:
Patches from Adam Spiers.
Description:
http://code.google.com/p/lilypond/issues/detail?id=1503
http://code.google.com/p/lilypond/issues/detail?id=1572
1503 - Allow choice of prefix for chord modifiers.
This was previously add, e.g. Cmaj7 add6add9,
but this results in too much clutter and
is rarely used.
Issue 1503 - Allow choice of minor chord modifier.
For example, often it is preferred to use a hyphen
instead of m. This can now be achieved via:
\set minorChordModifier = \markup { - }
add chordInversionSeparator
Issue 1572 and issue 1503 - Allow choice of
chord modifier separator independently of
chord inversion separator, since conventionally
the latter is always a slash (hence the term
slash chords), whereas the former seldom
involves slashes.
Issue 1503 - Recognise Lydian chords
enlarge half-diminished slashed circle symbol
Please review this at http://codereview.appspot.com/4981052/
Affected files:
M ly/chord-modifiers-init.ly
M ly/engraver-init.ly
M scm/chord-ignatzek-names.scm
M scm/define-context-properties.scm
Index: ly/chord-modifiers-init.ly
diff --git a/ly/chord-modifiers-init.ly b/ly/chord-modifiers-init.ly
index
75b804bb051aeb455676df081c5960d03485997a..91cb1e1fc15bd989fc5ed85daf5d68554c4eb20d
100644
--- a/ly/chord-modifiers-init.ly
+++ b/ly/chord-modifiers-init.ly
@@ -27,9 +27,10 @@ ignatzekExceptionMusic = {
c es ges-\markup { \super o } % should be $\circ$ ?
c es ges bes-\markup {
%% f8 is o with slash.
- \super #(ly:export (ly:wide-char-utf-8 #x00f8))
+ \normal-size-super #(ly:export (ly:wide-char-utf-8 #x00f8))
}
c es ges beses-\markup { \super o7 }
+ c e g b fis'-\markup { \super lyd } % Lydian
}
partialJazzMusic = {
Index: ly/engraver-init.ly
diff --git a/ly/engraver-init.ly b/ly/engraver-init.ly
index
a2ba6551f678d11061d13afae9d6bcc90a6946a1..37cd695e383e1147e010123990f1ebb93f0160b4
100644
--- a/ly/engraver-init.ly
+++ b/ly/engraver-init.ly
@@ -641,9 +641,12 @@ automatically when an output definition (a
@code{\score} or
%% chord names:
chordNameFunction = #ignatzek-chord-names
+ minorChordModifier = m
+ additionalPitchPrefix = % was add
majorSevenSymbol = #whiteTriangleMarkup
chordNameLowercaseMinor = ##f
- chordNameSeparator = #(make-simple-markup /)
+ chordNameSeparator = #(make-hspace-markup 0.5)
+ chordInversionSeparator = #(make-simple-markup /)
chordNameExceptions = #ignatzekExceptions
chordNoteNamer = #'()
chordRootNamer = #note-name-markup
Index: scm/chord-ignatzek-names.scm
diff --git a/scm/chord-ignatzek-names.scm b/scm/chord-ignatzek-names.scm
index
696d02fc7af43ab3ae2383f670a51ecc98afde9d..0302f35e82f7ab8472ac1f222f5d3b0515bf3597
100644
--- a/scm/chord-ignatzek-names.scm
+++ b/scm/chord-ignatzek-names.scm
@@ -130,7 +130,8 @@ work than classifying the pitches.
(define (prefix-modifier-markup mod)
(if (and (= 3 (pitch-step mod))
(= FLAT (ly:pitch-alteration mod)))
- (make-simple-markup (if lowercase-root? m))
+ (if lowercase-root? (empty-markup)
+ (ly:context-property context 'minorChordModifier))
(make-simple-markup huh)))
(define (filter-alterations alters)
@@ -168,8 +169,10 @@ work than classifying the pitches.
(make-line-markup total)))
(let* ((sep (ly:context-property context 'chordNameSeparator))
+ (invsep (ly:context-property context 'chordInversionSeparator))
(root-markup (name-root root lowercase-root?))
- (add-markups (map (lambda (x) (glue-word-to-step add x))
+ (add-pitch-prefix (ly:context-property
context 'additionalPitchPrefix))
+ (add-markups (map (lambda (x) (glue-word-to-step add-pitch-prefix x))
addition-pitches))
(filtered-alterations (filter-alterations alteration-pitches))
(alterations (map name-step filtered-alterations))
@@ -183,7 +186,7 @@ work than classifying the pitches.
suffixes
add-markups) sep))
(base-stuff (if (ly:pitch? bass-pitch)
- (list sep (name-note bass-pitch #f))
+ (list invsep (name-note bass-pitch #f))
'(
(set! base-stuff
Index: scm/define-context-properties.scm
diff --git a/scm/define-context-properties.scm
b/scm/define-context-properties.scm
index
e9acd9690713e8924844cda7d0ff90f3f565a16c..e03cd1076b209d8496424cc645e4fbd13b47b432
100644
--- a/scm/define-context-properties.scm
+++ b/scm/define-context-properties.scm
@@ -45,6 +45,8 @@
;; TODO FIXME
(aDueText ,markup? Text to print at a unisono passage.)
+ (additionalPitchPrefix ,string? Text with which to prefix
+additional pitches within a chord name.)
(alignAboveContext ,string? Where to insert newly created context in
vertical alignment.)
Re: patches for LilyPond issues 1503 and 1572
Hi Adam,
2011/9/10 Adam Spiers lilypond-de...@adamspiers.org:
Sorry Janek, I did receive the email but I've been away travelling for
3 months and only just got back.
No problem! I was afraid that your disappearance meant that you lost
interest in these patches.
I would be glad to work with you on
getting these patches finalised and submitted, although please bear
with me over the next few days as I have some other pressing issues to
attend to first.
Of course, there's no rush.
I think the best way would be if I help you with github because it's
an absolutely beautiful service and IMHO much nicer than emailing
patches once you get used to it. If you haven't already done so,
please try adding my github repository to your own as a remote:
git remote add aspiers git://github.com/aspiers/lilypond.git
and then simply fetch or pull the commits from my remote branch:
git fetch aspiers master
or:
git pull aspiers master
(pull is equivalent to fetch followed by a merge into your current
branch).
Let me know how you get on (but please be patient if I don't reply
quickly!)
Done - it was amaznigly painless!
Uploaded to Rietveld: http://codereview.appspot.com/4981052/
One thing: please follow these guidelines concerning commit messages:
http://lilypond.org/doc/v2.15/Documentation/contributor-big-page#commit-messages
I've changed the messages in my repository; i don't know if this
change can cause incompatibilities between our repositories, but if it
does (and we need to be compatible because the patches will probably
have some revisions which i will also have to upload) i attach patch
files created from my repository.
thanks,
Janek
From a65e982b3429f5a4e4786cdc068786622552ee28 Mon Sep 17 00:00:00 2001
From: Adam Spiers lilypond-fr...@adamspiers.org
Date: Thu, 28 Jul 2011 00:51:12 -0700
Subject: [PATCH 1/5] enlarge half-diminished slashed circle symbol
---
ly/chord-modifiers-init.ly |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ly/chord-modifiers-init.ly b/ly/chord-modifiers-init.ly
index 75b804b..eb86644 100644
--- a/ly/chord-modifiers-init.ly
+++ b/ly/chord-modifiers-init.ly
@@ -27,7 +27,7 @@ ignatzekExceptionMusic = {
c es ges-\markup { \super o } % should be $\circ$ ?
c es ges bes-\markup {
%% f8 is o with slash.
- \super #(ly:export (ly:wide-char-utf-8 #x00f8))
+ \normal-size-super #(ly:export (ly:wide-char-utf-8 #x00f8))
}
c es ges beses-\markup { \super o7 }
}
--
1.7.0.4
From 634e5e8cee5176c423dc7106bff437d04c6a3923 Mon Sep 17 00:00:00 2001
From: Adam Spiers lilypond-fr...@adamspiers.org
Date: Thu, 28 Jul 2011 00:51:57 -0700
Subject: [PATCH 2/5] Issue 1503 - Recognise Lydian chords
---
ly/chord-modifiers-init.ly |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/ly/chord-modifiers-init.ly b/ly/chord-modifiers-init.ly
index eb86644..91cb1e1 100644
--- a/ly/chord-modifiers-init.ly
+++ b/ly/chord-modifiers-init.ly
@@ -30,6 +30,7 @@ ignatzekExceptionMusic = {
\normal-size-super #(ly:export (ly:wide-char-utf-8 #x00f8))
}
c es ges beses-\markup { \super o7 }
+ c e g b fis'-\markup { \super lyd } % Lydian
}
partialJazzMusic = {
--
1.7.0.4
From b43dcc12920ad8b26b33f0e1fc52de03e8cdb842 Mon Sep 17 00:00:00 2001
From: Adam Spiers lilypond-fr...@adamspiers.org
Date: Thu, 28 Jul 2011 01:03:31 -0700
Subject: [PATCH 3/5] add chordInversionSeparator
Issue 1572 and issue 1503 - Allow choice of
chord modifier separator independently of
chord inversion separator, since conventionally
the latter is always a slash (hence the term
slash chords), whereas the former seldom
involves slashes.
---
ly/engraver-init.ly |3 ++-
scm/chord-ignatzek-names.scm |3 ++-
scm/define-context-properties.scm |2 ++
3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/ly/engraver-init.ly b/ly/engraver-init.ly
index a2ba655..013f41a 100644
--- a/ly/engraver-init.ly
+++ b/ly/engraver-init.ly
@@ -643,7 +643,8 @@ automatically when an output definition (a @code{\score} or
chordNameFunction = #ignatzek-chord-names
majorSevenSymbol = #whiteTriangleMarkup
chordNameLowercaseMinor = ##f
- chordNameSeparator = #(make-simple-markup /)
+ chordNameSeparator = #(make-hspace-markup 0.5)
+ chordInversionSeparator = #(make-simple-markup /)
chordNameExceptions = #ignatzekExceptions
chordNoteNamer = #'()
chordRootNamer = #note-name-markup
diff --git a/scm/chord-ignatzek-names.scm b/scm/chord-ignatzek-names.scm
index 696d02f..08eb118 100644
--- a/scm/chord-ignatzek-names.scm
+++ b/scm/chord-ignatzek-names.scm
@@ -168,6 +168,7 @@ work than classifying the pitches.
(make-line-markup total)))
(let* ((sep (ly:context-property context 'chordNameSeparator))
+ (invsep (ly:context-property context 'chordInversionSeparator))
(root-markup (name-root root lowercase-root?))
(add-markups (map (lambda (x) (glue-word-to-step add x))
addition-pitches))
@@
Re: changes in chord names formatting (1503, 1572) (issue 4981052)
LGTM http://codereview.appspot.com/4981052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
passes make and reg tests http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: changes in chord names formatting (1503, 1572) (issue 4981052)
LGTM AFAICT, but I am not familiar with chord notation. Presumably there should be some doc changes? These can either be included with this patch or separately. If the latter, please make a new issue for the docs when this is pushed so we don't forget. http://codereview.appspot.com/4981052/diff/1/ly/chord-modifiers-init.ly File ly/chord-modifiers-init.ly (right): http://codereview.appspot.com/4981052/diff/1/ly/chord-modifiers-init.ly#newcode30 ly/chord-modifiers-init.ly:30: \normal-size-super #(ly:export (ly:wide-char-utf-8 #x00f8)) please replace tab with spaces (I know you didn't insert it, but we want to remove tabs in the source ASAP) http://codereview.appspot.com/4981052/diff/1/scm/chord-ignatzek-names.scm File scm/chord-ignatzek-names.scm (right): http://codereview.appspot.com/4981052/diff/1/scm/chord-ignatzek-names.scm#newcode175 scm/chord-ignatzek-names.scm:175: (add-markups (map (lambda (x) (glue-word-to-step add-pitch-prefix x)) tab http://codereview.appspot.com/4981052/diff/1/scm/chord-ignatzek-names.scm#newcode189 scm/chord-ignatzek-names.scm:189: (list invsep (name-note bass-pitch #f)) tabs http://codereview.appspot.com/4981052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
