Re: Fixes heights and pure heights of stems. (issue 4898044)

2012-03-26 Thread Mike Solomon
> Mike,
>  The code in lily/note-collision.cc:219 needs an update to adjust the
> stem beginning (issue 2441).  I tried but I can't find the "pure
> callback for stem beginnings".
> 

ly:stem::pure-calc-stem-begin-position

Lemme know if I can be of help w/ fixing this!

Cheers,
MS

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: rall. and accel stopped working in articulate. (issue 5927044)

2012-03-26 Thread dak

On 2012/03/27 03:49:18, Graham Percival wrote:

LGTM.  You can send this to James for pushing whenever you want,

provided that

it passes Patchy test-patches.



You might prefer to wait a day or two in case any scheme person has

some good

ideas to make it better; partly to increase the patch quality, but

also for your

own education about scheme.


Well, obviously using stuff like map-some-music, fold-some-music would
make things quite more straightforward, efficient and robust, likely
making it easy to avoid using event-chord-wrap!.  But that concerns the
whole script, not just this change.

http://codereview.appspot.com/5927044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Fixes heights and pure heights of stems. (issue 4898044)

2012-03-26 Thread k-ohara5a5a

On 2011/08/14 16:25:28, MikeSol wrote:

Hey all,



This patch fixes a bug in LilyPond that has nagged me for some time:

incorrect

heights and pure heights for stems.



Also, the Stem grob's property list is cleaned up.  It looses three

confusing

properties: length, stem-begin-position, and stem-end-position.  It

also leads

to cleaner overrides: if the user wants to do some work with stem ends

but does

not want to trigger beam calculations, she can work with the pure

callback.

Idem for stem beginnings.



Mike,
  The code in lily/note-collision.cc:219 needs an update to adjust the
stem beginning (issue 2441).  I tried but I can't find the "pure
callback for stem beginnings".

http://codereview.appspot.com/4898044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: rall. and accel stopped working in articulate. (issue 5927044)

2012-03-26 Thread Carl . D . Sorensen

LGTM

http://codereview.appspot.com/5927044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: rall. and accel stopped working in articulate. (issue 5927044)

2012-03-26 Thread graham

LGTM.  You can send this to James for pushing whenever you want,
provided that it passes Patchy test-patches.

You might prefer to wait a day or two in case any scheme person has some
good ideas to make it better; partly to increase the patch quality, but
also for your own education about scheme.

http://codereview.appspot.com/5927044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


new lilypond-auto mailing list for google code issues

2012-03-26 Thread Graham Percival
We have a new mailing list for automatic messages.  All updates to
google code issues are now sent there instead of bug-lilypond.
The reply-to headers for -auto are set to -devel.

https://lists.gnu.org/mailman/listinfo/lilypond-auto

Note that you can get direct emails for issues by "starring" the
issue.  In addition to being sent to your google account directly,
those emails also allow you to add comments to the issue by
replying to the email.

- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


rall. and accel stopped working in articulate. (issue 5927044)

2012-03-26 Thread botialoach
Reviewers: james , thomas morley  
,


Message:
Hi folks,
  Thomas Morley noticed that rall. had stopped causing tempo change in
MIDI output when using articulate.

The patch I uploaded to Rietveld fixes that.

Description:
rall. and accel stopped working in articulate.

According to the the git logs, in February 2011 the way that tempo
changes for MIDI were interpreted changed from just the
tempoWholesPerMinute property to use a TempoChangeEvent.

This broke rall. in articulated MIDI output.

This patch brings the articulate script up-to-date wrt to the way that
tempo changes are signalled, and also adds accel. and poco accel. to
the list of accepted scripts.

Reported-by: Thomas Morley 
Signed-off-by: Peter Chubb 

Please review this at http://codereview.appspot.com/5927044/

Affected files:
  M ly/articulate.ly


Index: ly/articulate.ly
diff --git a/ly/articulate.ly b/ly/articulate.ly
index  
59424e515216b95776e038dadf653566ab25b3cb..4702e2030897ea1c972e6ece95d039b4b92b9cfb  
100644

--- a/ly/articulate.ly
+++ b/ly/articulate.ly
@@ -341,8 +341,18 @@
 ; (ac:accel trillMusic factor))
  )))

-
-
+%
+% Generate a tempoChangeEvent and its associated property setting.
+%
+#(define (ac:tempoChange tempo)
+  (make-sequential-music
+   (list (make-music 'TempoChangeEvent
+ 'metronome-count
+ tempo
+ 'tempo-unit
+ (ly:make-duration 0 0 1 1))
+(context-spec-music
+(make-property-set 'tempoWholesPerMinute  tempo) 'Score

 % If there's an articulation, use it.
 % If in a slur, use (1 . 1) instead.
@@ -414,6 +424,14 @@
 (string= t "rall."))
(loop factor (cons e newelements) tail (cons 'rall actions)))
   ((or
+(string= t "accelerando")
+(string= t "accel")
+(string= t "accel."))
+   (loop factor (cons e newelements) tail (cons 'accel actions)))
+  ((or
+(string= t "poco accel."))
+   (loop factor (cons e newelements) tail (cons 'pocoAccel actions)))
+  ((or
 (string= t "poco rall.")
 (string= t "poco rit."))
(loop factor (cons e newelements) tail (cons 'pocoRall actions)))
@@ -477,25 +495,37 @@
 	 (make-music 'RestEvent 'duration (ly:make-duration len dots newnum  
newdenom))

  music)))

+   ((accel)
+   (set! ac:lastTempo ac:currentTempo)
+   (set! ac:currentTempo (ly:moment-div ac:currentTempo ac:rallFactor))
+   (let ((pset (ac:tempoChange ac:currentTempo)))
+(if (null? (cdr actions))
+ (make-sequential-music (list pset music))
+ (make-sequential-music
+  (list pset (loop (cdr actions)))
+
+   ((pocoAccel)
+   (set! ac:lastTempo ac:currentTempo)
+   (set! ac:currentTempo (ly:moment-div ac:currentTempo ac:pocoRallFactor))
+   (let ((pset (ac:tempoChange ac:currentTempo)))
+(if (null? (cdr actions))
+ (make-sequential-music (list pset music))
+ (make-sequential-music
+  (list pset (loop (cdr actions)))
+
((rall)
+   (set! ac:lastTempo ac:currentTempo)
(set! ac:currentTempo (ly:moment-mul ac:currentTempo ac:rallFactor))
-   (let ((pset (make-music 'PropertySet
-  'value
-  ac:currentTempo
-  'symbol
-  'tempoWholesPerMinute)))
+   (let ((pset (ac:tempoChange ac:currentTempo)))
 (if (null? (cdr actions))
  (make-sequential-music (list pset music))
  (make-sequential-music
   (list pset (loop (cdr actions)))

((pocoRall)
+   (set! ac:lastTempo ac:currentTempo)
(set! ac:currentTempo (ly:moment-mul ac:currentTempo ac:pocoRallFactor))
-   (let ((pset (make-music 'PropertySet
-  'value
-  ac:currentTempo
-  'symbol
-  'tempoWholesPerMinute)))
+   (let ((pset (ac:tempoChange ac:currentTempo)))
 (if (null? (cdr actions))
  (make-sequential-music (list pset music))
  (make-sequential-music
@@ -503,11 +533,8 @@

((aTempo)
(set! ac:currentTempo ac:lastTempo)
-   (let ((pset (make-music 'PropertySet
-  'value
-  ac:currentTempo
-  'symbol
-  'tempoWholesPerMinute)))
+   
+   (let ((pset (ac:tempoChange ac:currentTempo)))
 (if (null? (cdr actions))
  (make-sequential-music (list pset music))
  (make-sequential-music
@@ -621,12 +648,12 @@
  (ac:adjust-props (ly:music-property music 'symbol) music)
  music)

-(else  music))
+(else music))
  ))



-% At last ... here's the music function that aplies all the above to a
+% At last ... here's the music function that applies all the above to a
 % score.
 articulate = #(define-music-function (parser location music)
   (ly:music?)



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


dist-check failure

2012-03-26 Thread Graham Percival
ge.ja.html
file from VC not distributed:
lilypond-2.15.35/Documentation/misc/browser-language.nl.html
file from VC not distributed:
lilypond-2.15.35/input/regression/lilypond-book/include/example.ly
file from VC not distributed:
lilypond-2.15.35/input/regression/lilypond-book/include/myvar.ily
rm -rf /tmp/tmpGQR4Q7
Traceback (most recent call last):
  File "test-lily/dist-check.py", line 137, in 
main ()
  File "test-lily/dist-check.py", line 132, in main
check_files (tarball, repo)
  File "test-lily/dist-check.py", line 117, in check_files
raise Exception ('dist error found')
Exception: dist error found


- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Lilypond 2.15.34 on MacOS X

2012-03-26 Thread Eric
testing 2.15.34 on my x86 Mac with 10.7.3. So far, so good- at least,
hasn't crashed "out of the gate" and updated an in this case 2.15.18
Lilypond file (a project-in-progress of transcription/extraction, 64 bars
of it so far) without trouble. Thanks!-
Eric Schissel

On Tue, Mar 20, 2012 at 11:27 AM, Colin Hall  wrote:

>
> On Mon, Mar 19, 2012 at 02:50:41PM +, Colin Hall wrote:
> >
> > Hi All,
> >
> > You may have seen the announcement that version 2.15.34 of Lilypond has
> been released. It would be great to hear if it works for you on your
> respective platforms so that I can update the table below.
> >
> > I'll post updates as they come in.
>
> I've heard from at least one tester on each MacOS X platform now. Thanks
> very much to all the users for downloading and checking the new release.
>
> As with the previous development release we found that Lilypond 2.15.34
> works on some commonly used MacOS X releases from 10.4.11 onwards with the
> exception of MacOS X 10.4.11 on x86 hardware.
>
> |-+-++---|
> | MacOS X | x86/ppc | User   | Launches and compiles |
> | version | || on 2.15.34|
> |-+-++---|
> | 10.4.11 | ppc | Ole Schmidt| Yes   |
> | | | Valentin Villenave |   |
> | | | James Worlton  |   |
> |-+-++---|
> | 10.4.11 | x86 | Klaus Foehl| No|
> |-+-++---|
> |  10.5.8 | ppc | Stan Sanderson | Yes   |
> |-+-++---|
> |  10.5.8 | x86 | Stan Sanderson | Yes   |
> |-+-++---|
> |  10.6.8 | x86 | Ole Schmidt| Yes   |
> | | | Tim McNamara   |   |
> |-+-++---|
> |  10.7.3 | x86 | Eric Schissel  |   |
> | | | Hans Aikema| Yes   |
> | | | Brian Alliford | Yes   |
> | | | Phillipe   |   |
> | | | Hans Aberg | Yes   |
> |-+-++---|
>
> Cheers,
> Colin.
>
> --
>
> Colin Hall
>
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Directs displaying-grob-ancestry.ly to stderr (issue 5905052)

2012-03-26 Thread Graham Percival
On Mon, Mar 26, 2012 at 03:29:46PM +, markpole...@gmail.com wrote:
> I don't want to be presumptuous here, but is there any
> chance I can be credited for the original idea?  Or is
> that not typically done in the snippets directory?

We don't do this -- at least, we certainly don't have user-visible
names.  At one point I suggested that there could be a comment
"%LSR: created by XYZ" in the .ly portion inside the database, but
we would remove that from the snippet before it appeared in the
lilypond docs.

- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: volunteer for patchy new-patches

2012-03-26 Thread James
Marek,

On 23 March 2012 21:42, Marek Klein  wrote:
> 2012/3/23 Graham Percival 
>>
>> On Fri, Mar 23, 2012 at 10:31:20PM +0100, Marek Klein wrote:
>> >    I've succeeded in building lilypond. :)
>> >    test-patches.py says: No new patches to test.
>> >    What are my next steps?
>>
>> I've just set issue 2216 to Patch-new, so try running it again.
>>
>
> Trying issue 2216
> Found patch: (2216, '/home/marek/lilypond-patchy/issue5843060_6001.diff',
> 'AU: Document all options for lilypond -dhelp')
> Traceback (most recent call last):
>   File "test-patches.py", line 16, in 
>     main(issues_id)
>   File "test-patches.py", line 12, in main
>     patchy.do_check(issues)
>   File "/home/marek/lilypond-patchy/projecthosting_patches.py", line 213, in
> do_check
>     compile_lilypond_test.main(patches)
>   File "/home/marek/lilypond-patchy/compile_lilypond_test.py", line 282, in
> main
>     autoCompile.prep_for_rietveld()
>   File "/home/marek/lilypond-patchy/compile_lilypond_test.py", line 140, in
> prep_for_rietveld
>     self.update_git()
>   File "/home/marek/lilypond-patchy/compile_lilypond_test.py", line 112, in
> update_git
>     run("git fetch")
>   File "/home/marek/lilypond-patchy/compile_lilypond_test.py", line 45, in
> run
>     raise Exception("Command '%s' returned non-zero exit status %d\n%s" %
> (cmd, returncode, stderr.strip()))
> Exception: Command 'git fetch' returned non-zero exit status 128
> error: insufficient permission for adding an object to repository database
> .git/objects
>
> fatal: failed to write object
> fatal: unpack-objects failed
>

Did you get it working yet?

It seems that permissions to your $LILYPOND_GIT location or who you
are running the script as are not allowed to 'git fetch' and pull down
any changes from the current code to apply the patch to then check it.

Either you need to change the permissions somewhere (probably
unlikely) or you need to edit the files further to make sure that the
scripts are trying to 'fetch' the most up to date branch to the
correct place.

If you can let us know if you

1. Edited any of the files before you tried to run the scripts
2. If your %LILYPOND_GIT location is set - if you use LilyDev it
should already be set for you.

Regards

James

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Directs displaying-grob-ancestry.ly to stderr (issue 5905052)

2012-03-26 Thread markpolesky

Hey guys,

I don't want to be presumptuous here, but is there any
chance I can be credited for the original idea?  Or is
that not typically done in the snippets directory?

http://lists.gnu.org/archive/html/lilypond-devel/2009-07/msg00590.html

Figuring that out was a proud moment for me!

Hope you're all well.
- Mark

http://codereview.appspot.com/5905052/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


3-week absence (with GSoC exception)

2012-03-26 Thread Janek Warchoł
Hi,

i'm bad at doing many things at once.  Because of that my university
work is suffering seriously and i'm going to fail some courses unless
i change something.  Thus, i'm stopping LilyPond work for 3 weeks
(with an exception for writing/discussing GSoC application, and next
LilyPond Report).  I probably won't login to janek.lilypond account;
if there's anything urgent please contact me at
lemniskata.bernoull...@gmail.com

thanks,
Janek

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: FW: [LilyPond] Your organization application has been rejected.

2012-03-26 Thread Janek Warchoł
On Fri, Mar 16, 2012 at 10:19 PM, Julien Rioux
 wrote:
> On 16/03/2012 4:45 PM, Janek Warchoł wrote:
>>
>> On Fri, Mar 16, 2012 at 6:53 PM, Carl Sorensen  wrote:
>>>
>>> On 3/16/12 11:44 AM, "no-re...@google-melange.appspotmail.com"
>>>   wrote:
>>>
 Thank you for submitting "LilyPond" organization application to Google
 Summer of Code 2012.
 Unfortunately, we were unable to accept your organization's application
 at this time.
 We received many more applications for the program than we are able to
 accommodate,
 and we would encourage you to reapply for future instances of the
 program.
 Best regards,
  Google Open Source Programs
>>>
>>>
>>> As you can see, we did not qualify for GSOC this year.
>>
>>
>> No!!
>> :( :( :(
>> That's all they wrote?  No feedback on our application anywhere?
>
>
> There should be a possibility to email/chat with them about the application
> process and how they come to this decision. This would be the best
> indication for next year.

Damn, we missed the IRC session dedicated for that!  (friday, 23rd of March)
It was mentioned here http://www.google-melange.com/gsoc/events/google/gsoc2012
but not here 
http://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc2012/faqs#timeline
- that's why i missed it.
I don't understand why Google didn't mention it in the "rejection message".

:/
Janek

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: German translation request

2012-03-26 Thread James
Hello

On 25 March 2012 14:10, Phil Holmes  wrote:
> In Notation/wind.itely, please could the following be changed:
>
> Die Liste aller möglichen Löcher und Einstellungen eines bestimmten
> Instruments kann auf der Kommandozeile oder in einer Log-Datei
> angezeigt werden, auch wenn man sie nicht in der Notenausgabe anzeigen
> lassen kann:
>
> @lilypond[verbatim,quote]
>
> #(print-keys-verbose 'flute)
>
> @end lilypond
>
> So that we lose the lilypond fragment, but instead use an @code{} block for
> the print-keys instruction.  This has been done for the English and other
> languages, and the remaining use in the German manuals produces about 7% of
> the un-needed output from make doc.
>
> Thanks.
>


http://code.google.com/p/lilypond/issues/detail?id=2437

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Change all occurences of "echo -n" to "printf" for portability (issue 5903046)

2012-03-26 Thread dak

On 2012/03/26 06:02:09, Graham Percival wrote:

LGTM, I think this could be pushed immediately?


I would be surprised if there was any part in it that could still
benefit from further review/countdown.

http://codereview.appspot.com/5903046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel