Re: How to do proper indentation?

[Thomas Morley]

2012/11/30 Marc Hohl :
> Am 30.11.2012 02:16, schrieb Thomas Morley:
>>
>> Hi,
>>
>> reviewing
>> https://codereview.appspot.com/6850073/
>> Pál admonished to do better indentation on lists at different levels.
>>
>> Trying to minimize my lack of knowledge on this topic I searched the
>> CG about It.
>>
>> CG 10.5.3 Indentation
>> mentions possibilities for emacs and vim, but I'm not familiar with them.
>> I'm using jEdit or gedit
>>
>> Following the link in
>> CG 10.3.2 Desired file formatting
>> http://community.schemewiki.org/?scheme-style
>> doesn't help here.
>>
>> My own guess would be (file is attached, too):
>>
>> showSimpleRest =
>> #(define-scheme-function (parser location dots)
>>(string?)
>>(make-override-markup (cons 'baseline-skip 7)
>> (make-column-markup
>>  (map
>>   (lambda (style)
>>(make-line-markup [...]
>
> I think that the indentation level is 2 spaces, and function arguments are
> supposed to be aligned vertically, see the attached file.
>
> HTH,
>
> Marc
>
>
>
> ___
> lilypond-devel mailing list
> lilypond-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/lilypond-devel
>

Hi Marc,

thanks a lot.

-Harm

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Uses single algorithm for side-position spacing. (issue 6827072)

[m...@mikesolomon.org]

On 30 nov. 2012, at 22:14, k-ohara5...@oco.net wrote:

>>> Ugh...this is a really nasty cyclic dependency.
> 
> Then you could use as a test-case
> 
> which has no fingerings, no cyclic dependencies, but still shows the
> problem of confused beams.
> 
> https://codereview.appspot.com/6827072/

Good call - I'll do that first before trying to tackle the other problems. In 
general, wherever I find cyclic dependencies, calls to set_property are 
present. Grumble grumble...

Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

git-cl error message

[Aleksandr Andreev]

Hello list,

I am getting the following message when I try to run git cl upload
origin/master:

Traceback (most recent call last):
  File "/usr/bin/git-cl", line 888, in 
sys.exit(main(sys.argv))
  File "/usr/bin/git-cl", line 882, in main
return func(argv[2:])
  File "/usr/bin/git-cl", line 607, in CmdUpload
issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File "/home/sasha/git-cl/upload.py", line 1467, in RealMain
response_body = rpc_server.Send("/upload", body, content_type=ctype)
  File "/home/sasha/git-cl/upload.py", line 342, in Send
f = self.opener.open(req)
  File "/usr/lib/python2.7/urllib2.py", line 407, in open
response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 520, in http_response
'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 445, in error
return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 379, in _call_chain
result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 528, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 301: Moved Permanently

Is there something wrong with my setup or is this a network issue?

Aleksandr

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Uses single algorithm for side-position spacing. (issue 6827072)

[k-ohara5a5a]

Ugh...this is a really nasty cyclic dependency.


Then you could use as a test-case

which has no fingerings, no cyclic dependencies, but still shows the
problem of confused beams.

https://codereview.appspot.com/6827072/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: markup-commands rest-by-number and rest (issue 6850073)

[David Kastrup]

thomasmorle...@googlemail.com writes:

> On 2012/11/27 20:03:06, benko.pal wrote:
>
>> > Did you had a look on the compiled output of the new reg-tests?
>
>> no.  could you push to a dev/ branch?
>
> Sorry. I'm still a newbie in devel tasks.

If you have a branch where you checked in your changes, you can push the
current HEAD with

git push origin HEAD:refs/heads/dev/thomas

or similar.  Don't ever use a fourth argument without explicit source
and target separated via colon: git's idea of putting defaults in there
is rather absurd and can cause major headaches.

To delete a branch again, do

git push origin :refs/heads/dev/thomas

namely nothing before the colon.  That's all.

> of the mistakes were typos in git, which I couldn't correct. Two times
> I corrupted my build-directory, so I had to start from scratch.  Or I
> produced a [PATCH 1/2] and I have no clue why, or why not the next
> time I tried.  etc., etc

Huh.  The CG gives no useful information here?

> But in case this will change, do you have a hint where to look to
> learn not alone about dev/branch but to deal with git? Something like
> git for dummies would be suitable.

man git has a number of references at the bottom, both other manual
pages (under SEE ALSO) as well as further links.

-- 
David Kastrup

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Uses single algorithm for side-position spacing. (issue 6827072)

[m...@mikesolomon.org]

On 30 nov. 2012, at 20:42, Keith OHara  wrote:

> On Fri, 30 Nov 2012 01:37:48 -0800,  wrote:
> 
>> Ugh...this is a really nasty cyclic dependency.
> 
> There is sometimes a cyclic dependency message, but that is not the problem.  
> I'm pretty sure I used \stemUp to determine the stem directions and break 
> this dependency chain.
> 

I think it is still a problem insofar as no patch should knowingly add cyclic 
dependencies to the code base unless it has a surefire followup that'll remove 
them.

>> 1) note_head_x_shift
>> 2) stem direction
>> 3) beam direction
> 
> There is a problem whenever a cross-staff beam /would/ auto-knee, even if the 
> knee is prevented by overridden stem directions.  The beam is drawn as if the 
> note-heads were all on one staff.
> 

I'll be able to slog through all of these around Christmas-ish if not sooner.

Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Uses single algorithm for side-position spacing. (issue 6827072)

[Keith OHara]

On Fri, 30 Nov 2012 01:37:48 -0800,  wrote:


Ugh...this is a really nasty cyclic dependency.


There is sometimes a cyclic dependency message, but that is not the problem.  
I'm pretty sure I used \stemUp to determine the stem directions and break this 
dependency chain.


1) note_head_x_shift
2) stem direction
3) beam direction


There is a problem whenever a cross-staff beam /would/ auto-knee, even if the 
knee is prevented by overridden stem directions.  The beam is drawn as if the 
note-heads were all on one staff.


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Use define-void-function rather than define-music-function in several places (issue 6854104)

[benko . pal]

LGTM

https://codereview.appspot.com/6854104/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: How to do proper indentation?

[Marc Hohl]

Am 30.11.2012 02:16, schrieb Thomas Morley:

Hi,

reviewing
https://codereview.appspot.com/6850073/
Pál admonished to do better indentation on lists at different levels.

Trying to minimize my lack of knowledge on this topic I searched the
CG about It.

CG 10.5.3 Indentation
mentions possibilities for emacs and vim, but I'm not familiar with them.
I'm using jEdit or gedit

Following the link in
CG 10.3.2 Desired file formatting
http://community.schemewiki.org/?scheme-style
doesn't help here.

My own guess would be (file is attached, too):

showSimpleRest =
#(define-scheme-function (parser location dots)
   (string?)
   (make-override-markup (cons 'baseline-skip 7)
(make-column-markup
 (map   
  (lambda (style)
   (make-line-markup [...]

I think that the indentation level is 2 spaces, and function arguments are
supposed to be aligned vertically, see the attached file.

HTH,

Marc


showSimpleRest =
#(define-scheme-function (parser location dots) (string?)
   (make-override-markup (cons 'baseline-skip 7)
 (make-column-markup
   (map
 (lambda (style)
 (make-line-markup
   (list
 (make-pad-to-box-markup
   '(0 . 20) '(0 . 0)
(symbol->string style))
 (make-override-markup
   (cons 'line-width 60)
   (make-override-markup
 (cons 'style style)
 (make-fill-line-markup
   (map
 (lambda (duration)
 (make-rest-markup
   (if (string? duration)
   duration
   (string-append
 (number->string (expt 2 duration))
 (if (>= duration 0) dots "")
 (append '("maxima" "longa" "breve")(iota 8)
 '(default
   mensural
   neomensural
   classical
   baroque
   altdefault
   petrucci
   blackpetrucci
   semipetrucci
   kievan)
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Uses single algorithm for side-position spacing. (issue 6827072)

[mike]

On 30 nov. 2012, at 07:25, k-ohara5...@oco.net wrote:

> 'finger-chords.ly' is still in disagreement with its texidoc (therefore
> failing).  You could adjust that regtest in light of the new defaults,
> of course.
> 
> Better might be to make Fingering.add-stem-support = #only-if-beamed
> the new default.  That is in better agreement with common practice.
> Regtests come out just as good.  (Les-neréides.ly can remove a couple
> "tweaks", which seems to be how somebody was keeping score.)  Then users
> will less often want to override add-stem-support, and when they do it
> will be to the simpler ##f or ##t
> 
>>> The while(dirty) loop runs 2366 times for the last chord in
>>> 'fingering-collision.ly' but that's an extreme case.
>>> 
>> I'm not proud of this...
> 
> It is at least comprehensible; while the code it replaced was utterly
> baffling.  I simplified the loop
> 
> 

I'm OK w/ the simplification, but I'd like it in box-quarantine if possible.  
I'd like to separate the shifting algorithm from the class.  This is part of an 
effort, in general, to simplify and clarify the distinction between positioning 
algorithms and classes that use these algorithms (this is what I was doing w/ 
interval-minefield.cc as well).  Eventually, box-quarantine will be used for 
the ScriptColumn grob.

> You should at least put the filenames back to what they were, and adjust
> any tests or documentation or snippets using add-stem support, before
> pushing.
> 
> I started to test with real music.  The usual Chopin test case
> 
> has a badly broken cross-staff beam in measure 27.  I don't yet see the
> cause.
> 

Ugh...this is a really nasty cyclic dependency.  In the old algorithm, when Y 
side positioning was done, X extents weren't necessary because we just assumed 
that things had infinite X extents.  Now with the skylines, both X and Y 
extents are necessary to build the skylines.  The cyclic dependency is with 
beam directions.  The triggering chain is something to the effect of:

1) note_head_x_shift
2) stem direction
3) beam direction
4) pure y coordinates of stems to figure out auto knees
5) pure internal minimum translations via align interface
6) lots of pure heights in the axis group interface
7) pure heights of fingerings depend on new skyline side positioning algorithm
8) this algorithm needs the width of a note_head whose stem is attached to the 
same beam in (3) above, so note_head_x_shift
9) stem direction of the stem attached to that note
10) beam direction

The dependency seems breakable, but it'll require some mental gymnastics to 
figure out how.  I'm on it.

Cheers,
MS___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel