Re: lilypond-manuals.css: edit color scheme and some spacing (issue 322070043 by paulwmor...@gmail.com)
I don't feel strongly about the old design being bad. The new design looks mostly fine to me. I feel like the table of contents bar at the left is too wide. But I would be fine with it being like this. Carl https://codereview.appspot.com/322070043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add on-page-greater-than, -less-than (on-the-fly) (issue 74540044)
On 2017/06/09 13:36:53, dak wrote:
Ok, I've taken another look at something that should help with this
amount of
fine-grained definitions.
LGTM. Although I'm still new to understanding scheme macros, I
think I understand the gist of what's going on.
Do you think that the following macro markup-when
would be fine-grained enough to forego these kind of definition?
You mean so the user would use this markup-when macro to define their
own
'on-page-greater-than' and/or 'on-page-less-than' (like you've shown),
rather than
adding them to LilyPond?
If so, that seems fine to me. They seem like fairly rare use cases.
Would
make a good snippet for the LSR or docs, so it can be found and used
when needed.
I demonstrate
it for implementing on-page-greater-than but of course one may use it
directly.
Directly like this I assume? (Which works.)
\paper {
#(set-paper-size "a7landscape")
oddFooterMarkup = \markup \on-the-fly
#(markup-when ((page:page-number -1))
(> page:page-number 3))
"This is long!"
}
Its first argument is of the same style as the #:properties keyword
arg for
define-markup-command .
That's a nice consistency. I tried it out and the following works too:
#(define (onpage proc nmbr)
(markup-when ((page:page-number -1))
(proc page:page-number nmbr)))
\paper {
#(set-paper-size "a7landscape")
oddFooterMarkup = \markup \on-the-fly #(onpage > 3) "This is
long!"
}
-Paul
https://codereview.appspot.com/74540044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: lilypond-manuals.css: edit color scheme and some spacing (issue 322070043 by paulwmor...@gmail.com)
On 2017/06/10 17:58:43, pwm wrote: Footers - simplify color scheme, no need to draw attention to footers with color - language text size matches rest of footer (I'll provide a screenshot for language section which isn't in the demo site) Languages / footer screenshot posted to the sourceforge issue: https://sourceforge.net/p/testlilyissues/issues/5144/ -Paul https://codereview.appspot.com/322070043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
lilypond-manuals.css: edit color scheme and some spacing (issue 322070043 by paulwmor...@gmail.com)
Reviewers: , Message: Please review these css edits for the manuals. Here is a demo site for easier review (remove spaces after the domain to reassemble the url): http://clairnote.org /lilypond-web-demo/Documentation/web/manuals.html The biggest difference is the color scheme. There are a few minor spacing and border edits as well. I realize this is more changes in one review than is preferred, but I wanted to expedite things given the release plans for 2.20. Things to look at: Table of contents sidebars - color scheme, colors are same as the previous 2.19 footers, except for usage (now brown) and the CG is a dark grey rather than full black. - a little vertical space between top level sections Code blocks - more subtle border color to avoid distracting from their content - see Notation 1.1.1, for example "Note" boxes - color scheme, borders, see Notation 1.1.1 under accidentals "Advanced" boxes - color scheme, borders, see CG 1.2 Main/top page for a manual - simpler color scheme, some vertical spacing around the title Grey navigation bars/rows/strips - color scheme is more subtle and spacing Footers - simplify color scheme, no need to draw attention to footers with color - language text size matches rest of footer (I'll provide a screenshot for language section which isn't in the demo site) I think that covers it. -Paul Description: lilypond-manuals.css: edit color scheme and some spacing This patch simplifies and (IMHO) improves the color scheme and spacing of the manuals on the web. I will include a link to screenshots and a demo site, with more details on what's different. Please review this at https://codereview.appspot.com/322070043/ Affected files (+56, -98 lines): M Documentation/css/lilypond-manuals.css ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
