PATCHES - Countdown for June 17th

2017-06-16 Thread James 
Hello,

Here is the current patch countdown list. The next countdown will be on
June 20th.

A quick synopsis of all patches currently in the review process can be
found here:

http://philholmes.net/lilypond/allura/



Push:


5146 Don't use \line in the implementation of \concat - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/5146
http://codereview.appspot.com/325860043


5145 Allow $... to specify a markup command - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/5145
http://codereview.appspot.com/322090043


5144 lilypond-manuals.css: edit color scheme and some spacing - Paul
Morris https://sourceforge.net/p/testlilyissues/issues/5144
http://codereview.appspot.com/322070043


5141 Fix typos in \offset documentation - David Nalesnik
https://sourceforge.net/p/testlilyissues/issues/5141
http://codereview.appspot.com/322040043


1388 Support OpenType font features - Jay Anderson
https://sourceforge.net/p/testlilyissues/issues/1388
http://codereview.appspot.com/323850043


Countdown:


1228 merge simultaneous rests of the same duration - Jay Anderson
https://sourceforge.net/p/testlilyissues/issues/1228
http://codereview.appspot.com/4005046/



5147 Add whether to use OTF feature depending on Pango version -
Masamichi Hosoda https://sourceforge.net/p/testlilyissues/issues/5147
http://codereview.appspot.com/323850043



Review:

5148 Various chain-assoc-get -> #:properties - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/5148
http://codereview.appspot.com/323940043



New: No New patches at this time.


Regards

James

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Various chain-assoc-get -> #:properties (issue 323940043 by d...@gnu.org)

2017-06-16 Thread Carl . D . Sorensen 

LGTM.

One small possible change.


https://codereview.appspot.com/323940043/diff/20001/Documentation/snippets/new/three-sided-box.ly
File Documentation/snippets/new/three-sided-box.ly (right):

https://codereview.appspot.com/323940043/diff/20001/Documentation/snippets/new/three-sided-box.ly#newcode36
Documentation/snippets/new/three-sided-box.ly:36: (let* ((pad (*
(magstep font-size) box-padding))
Looks like this could now be a let instead of let*

https://codereview.appspot.com/323940043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Various chain-assoc-get -> #:properties (issue 323940043 by d...@gnu.org)

2017-06-16 Thread thomasmorley65 

LGTM

one nit:


https://codereview.appspot.com/323940043/diff/1/Documentation/snippets/three-sided-box.ly
File Documentation/snippets/three-sided-box.ly (right):

https://codereview.appspot.com/323940043/diff/1/Documentation/snippets/three-sided-box.ly#newcode45
Documentation/snippets/three-sided-box.ly:45: (m (interpret-markup
layout props arg)))
tab->spaces

https://codereview.appspot.com/323940043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel