Re: Issue 5264: fret diagram nut alignment (issue 335430043 by lilyp...@maltemeyn.de)

[thomasmorley65]

The proper approach is to introduce a property that indicates the

diagram should

be left-handed, and to make the stencil-coordinates function in
scm/fret-diagrams.scm respect that property.


That's exactly what I'm trying to do with my patch on the tracker



https://codereview.appspot.com/335430043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 5264: fret diagram nut alignment (issue 335430043 by lilyp...@maltemeyn.de)

[Carl . D . Sorensen]

On 2018/01/18 19:42:01, thomasmorley651 wrote:

I don't think this is the right approach to make left-handed

fret-diagrams work.

Ofcourse it cures a single problem while using negative

string-distance, but

other problems are shining up as already mentioned.
Instead I think we should disallow negative string-distance, or rather

(because

LilyPond does no type-checking on sub-properties) always use the (abs

..).

For the left-handed fret-diagrams, why not place strings (and frets)

correctly

right from the start and let do the already existing code all the

other work?

I'll post a patch following this route on the tracker.


I agree that the negative string-distance is not the right way to create
left-handed fret diagrams.

The proper approach is to introduce a property that indicates the
diagram should be left-handed, and to make the stencil-coordinates
function in scm/fret-diagrams.scm respect that property.



https://codereview.appspot.com/335430043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 5264: fret diagram nut alignment (issue 335430043 by lilyp...@maltemeyn.de)

[thomasmorley65]

I don't think this is the right approach to make left-handed
fret-diagrams work.
Ofcourse it cures a single problem while using negative string-distance,
but other problems are shining up as already mentioned.
Instead I think we should disallow negative string-distance, or rather
(because LilyPond does no type-checking on sub-properties) always use
the (abs ..).
For the left-handed fret-diagrams, why not place strings (and frets)
correctly right from the start and let do the already existing code all
the other work?
I'll post a patch following this route on the tracker.

https://codereview.appspot.com/335430043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Developing for Turkish Folk Music Accidental glyphs

[Emre Pınarbaşı]

Yes, we need 7 glyphs totally from this font. We can ignore the others.



iPhone’umdan gönderildi

Werner LEMBERG  şunları yazdı (18 Oca 2018 18:24):

> glyphs

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Developing for Turkish Folk Music Accidental glyphs

[Werner LEMBERG]

> As far as I can, I got the code numbers of the signs to be used.

Thanks.  Note that the mapping of

  b² → U+0077

is invalid (as are all other mappings).  Reason is that Unicode
character U+0077 is `LATIN SMALL LETTER W' and nothing else.  Whoever
built the font, she or he incorrectly assigned the accidentals to
already existing code points...

Do I understand the first image correctly that you only need the
glyphs

  b b² b³
  # #² #³
  

and nothing else for Turkish folk music?  In other words, can we
ignore the other glyphs in the YUCEL_HALK font?


Werner


PS: The correct mapping, according to the SMUFL standard, for Turkish
folk music can be found on

  
https://w3c.github.io/smufl/gitbook/tables/turkish-folk-music-accidentals.html

As can be seen, the page also describes #⁵ and b⁴ ...
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 5264: fret diagram nut alignment (issue 335430043 by lilyp...@maltemeyn.de)

[lilypond]

On 2018/01/18 14:12:30, Malte Meyn wrote:

align correctly for different size


Try this for testing:

\version "2.19.80"

\include "predefined-guitar-fretboards.ly"

\new FretBoards \with {
  \override FretBoard.size = 10
  \override FretBoard.thickness = 2
  \override FretBoard.fret-diagram-details.string-thickness-factor = 0.2
} \chordmode {
  e
}

https://codereview.appspot.com/335430043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Developing for Turkish Folk Music Accidental glyphs

[Werner LEMBERG]

> Have a nice day.  There are various styles of flat and sharp we use
> for Turkish folk music.  I send the font I used in the Finale
> program as an email attachment.  They need to be designed as a font
> for the introduction to the system and the mold file should be
> prepared.  I can prepare the template file, but I need help to
> create the font.  If someone can help me and understand this, we can
> make a contribution to Lilypond.

Thanks for the font.  However, to understand the symbols and its
function, we need a description of each glyph.  Additionally, most of
the glyphs are already present in LilyPond, as far as I can see.


Werner

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel