Re: Context regression tests (issue 348760043 by nine.fierce.ball...@gmail.com)

2018-05-07 Thread nine . fierce . ballads

On 2018/05/07 22:53:29, Dan Eble wrote:

stop relying on duplicating type+ID


Carl,

I hope that these revisions address your concerns about the tests per
se.


https://codereview.appspot.com/348760043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


PATCHES - Countdown for May 7th

2018-05-07 Thread James Lowe
Hello,

Here is the current patch countdown list. The next countdown will be on May 
10th.

A quick synopsis of all patches currently in the review process can be found 
here:

http://philholmes.net/lilypond/allura/



Push:

5317 Crash when running musicxml2ly - James Lowe
https://sourceforge.net/p/testlilyissues/issues/5317
http://codereview.appspot.com/339560043


Countdown:

5319 Make skylines reflect grob rotation - Torsten Hammerle
https://sourceforge.net/p/testlilyissues/issues/5319
http://codereview.appspot.com/342060043

5316 Clarify notation for slurs and beams - Carl Sorensen
https://sourceforge.net/p/testlilyissues/issues/5316
http://codereview.appspot.com/343060043

Review: No patches in Review at this time.

New:

5318 Context regression tests - Dan Eble
https://sourceforge.net/p/testlilyissues/issues/5318
http://codereview.appspot.com/348760043

4409 Automatic fret diagrams should include barre indications when fingerings 
are given. - Carl Sorensen
https://sourceforge.net/p/testlilyissues/issues/4409
http://codereview.appspot.com/294570043


Regards

James
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: crash during musicxml2ly

2018-05-07 Thread James Lowe
Frederic

On Wed, 02 May 2018 12:09:37 +0100 (BST), "James Lowe"  
wrote:

> Hello Frederic,
> 
> On Tue, 1 May 2018 16:47:24 +, Frédéric Gohier  
> wrote:
> 
> > hello,
> > 
> > I just push the patch on rietveld : 
> > https://codereview.appspot.com/339560043/

This has now gone through the patch review process.

Can you provided a git formatted patch based on current master and I can push 
it for you?

Thank you.

James



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel