PATCHES - Countdown for July 7th
Hello, Here is the current patch countdown list. The next countdown will be on July 9th A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5524 New function css-color (accompanying x11-color) - Urs Liska https://sourceforge.net/p/testlilyissues/issues/5524 http://codereview.appspot.com/580780043 5512 Use new syntax consistently throughout docs and examples - Valentin Villenave https://sourceforge.net/p/testlilyissues/issues/5512 http://codereview.appspot.com/572640043 Countdown: Review: 5531 NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly - James Lowe https://sourceforge.net/p/testlilyissues/issues/5531 http://codereview.appspot.com/560790043 5520 Improvements to \ambitusAfter - Malte Meyn https://sourceforge.net/p/testlilyissues/issues/5520 http://codereview.appspot.com/552740043 5303 layout-set-staff-space confuses chord note head placement in a certain situation - James Lowe https://sourceforge.net/p/testlilyissues/issues/5303 http://codereview.appspot.com/570830043 4362 Completion_heads_engraver and dotted breve - Malte Meyn https://sourceforge.net/p/testlilyissues/issues/4362 http://codereview.appspot.com/560810043 New: No new patches at this time. *** Regards, James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: stem.cc - issue 5303 - misplaced notehead (issue 570830043 by pkxgnugi...@runbox.com)
Perhaps this patch should also revert 87eb2f9fe1be3a532675fe4b7322bbba5a60ba5c since that patch was a workaround, rather than a real fix, as demonstrated during this troubleshooting thread. Carl https://codereview.appspot.com/570830043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: stem.cc - issue 5303 - misplaced notehead (issue 570830043 by pkxgnugi...@runbox.com)
On 2019/07/07 17:32:35, Lukas-Fabian Moser wrote: > The last patch reverts the rounding in stem.cc. stem.cc should be taken from the > first patch set. No, this was intentional: I agreed with David K that keeping the calculations in floats would be the most convincing solution. (It's not a revert: The original state was an (int) cast, which I first replaced by rounding+int-cast and now (finally?) by keeping the original float value. Sorry, I hadn’t noticed that the cast was gone. https://codereview.appspot.com/570830043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: stem.cc - issue 5303 - misplaced notehead (issue 570830043 by pkxgnugi...@runbox.com)
The last patch reverts the rounding in stem.cc. stem.cc should be taken from the first patch set. No, this was intentional: I agreed with David K that keeping the calculations in floats would be the most convincing solution. (It's not a revert: The original state was an (int) cast, which I first replaced by rounding+int-cast and now (finally?) by keeping the original float value. https://codereview.appspot.com/570830043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: stem.cc - issue 5303 - misplaced notehead (issue 570830043 by pkxgnugi...@runbox.com)
On 2019/07/07 16:31:47, lilypond-pkx wrote: With changes from Lukas based on dev's comments The last patch reverts the rounding in stem.cc. stem.cc should be taken from the first patch set. https://codereview.appspot.com/570830043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly (issue 560790043 by pkxgnugi...@runbox.com)
Hello everyone
About hel-arabic.ly
It seems to me that the example given is incomplete
You must write
\include "hel-arabic.ly"
\relative {
\key c \rast
c' d edb f | g a bdb c | c bb a g | f d c
}
Best regards
hassan el fatihi
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
