Some cherry-picks for stable/2.20
Hi everybody I think some commits in master should be cherry-picked for stable/2.20: git cherry-pick -x \ 6e98e7e7b0d0ac46ba7e54f4b3946228f44fc414 \ 9fb52ef2c93588192842fffa1b115c6f2d360321 \ f76997b5097f588060f823c4c87f01bac9f2fe50 \ b0300944e015b5957e50441224699e55c68c3dc3 \ a64b4dbc92ac0bbece08043349a55dccd84f4fd7 Reason: Our regression test code was broken in master and still is broken in stable/2.20. We need the fix in issue 5467, these are the last three of the five recommended commits. The last three commits change scm/framework-ps.scm and scripts/build/output-distance.py, if we also cherry-pick the first two commits we update scm/framework-ps.scm and scripts/build/output-distance.py to be identical to the code in master. There's no reason not to do so: The first commit fixes pdf metadata generation, the 2nd improves debugging output during executino of output-distance.py. Knut ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: stem.cc - issue 5303 - misplaced notehead (issue 570830043 by pkxgnugi...@runbox.com)
On 7/11/19, 11:49 AM, "Lukas-Fabian Moser" wrote:
Hi Carl,
> Perhaps this patch should also revert
> 87eb2f9fe1be3a532675fe4b7322bbba5a60ba5c
>
> since that patch was a workaround, rather than a real fix, as
> demonstrated during this troubleshooting thread.
>
> Carl
>
>
> https://codereview.appspot.com/570830043/
I'm afraid I do not understand the connection between the
overdone-notehead patch you refer to and the rounding-issue patch
regarding chord-notehead-placing. They do not seem to be linked to me.
But I noticed that your old patch 87eb2f9fe, which was supposed to fix
issue https://sourceforge.net/p/testlilyissues/issues/4693/, seems to
only fix that issue at "normal" staff sizes. See for instance:
\version "2.18"
#(set-global-staff-size 90)
\layout {
\override Score.StaffSymbol.layer = 100
}
\new Voice \with {
\override NoteHead.color = #red
} {
\relative {
f'4 a c e \bar "|."
}
}
This can never work properly, because overdone-noteheads is a metafont
parameter used in the creation of the feta noteheads. LilyPond creates feta in
only a few sizes: 11, 13, 14, 16, 18, 20, 23, and 26. All other staff sizes
are scaled from these fonts. And remember that the staff-space/staff-line
ratio varies with staff sizes, so the scaled notehead sizes will be
approximately, but not exactly, correct.
When scaling to sizes outsize the range of the generated fonts, the user is
likely to be required to override the NoteHead.font-size property to get the
noteheads to fit exactly.
I would consider this patch to be appropriate if it worked correctly for all
the given feta font staff sizes. And my testing indicates that it does.
(And, for the record, 87eb2f9fe introduced
https://sourceforge.net/p/testlilyissues/issues/5530/, as Malte reminded
us.)
o be
So it seems to me that that patch should probably be reconsidered, but I
think not without being related to issues 5303/5522 (which are what the
current patch is about).
I had assumed (without checking) that resolving the stem rounding problem in
5303/5522 would solve the problem in 5530, because Harm showed us[1] that
slightly reducing the notehead size would solve the problem of the slur
spacing. If it doesn't solve the problem then something else needs to be done
with 5530. But I can't solve it, because 5530 doesn't manifest itself on my
system, as I mentioned earlier.
Thanks,
Carl
1. https://lists.gnu.org/archive/html/lilypond-user/2019-06/msg00170.html
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Executable options style question
Thanks Hans!
JM
> Le 11 juil. 2019 à 18:01, Hans Åberg a écrit :
>
>
>> On 11 Jul 2019, at 09:32, Jacques Menu wrote:
>>
>> I’ve wondering about command line options with multiple values.
>>
>> Which one of the following in preferable in your opinion:
>>
>> DESSUS="Cor anglais"
>> xml2ly -msr-part-rename "P1 = ${DESSUS}"
>>
>> or:
>>
>> DESSUS="Cor anglais"
>> xml2ly -msr-part-rename P1 "${DESSUS}”
>
> POSIX, Guideline 8 [1] says that they should be presented as a single
> argument to the option, separated with comma or blanks within that argument.
> GNU [2] does not mention that explicitly.
>
> 1. https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap12.html
> 2. https://www.gnu.org/software/libc/manual/html_node/Argument-Syntax.html
>
>
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: stem.cc - issue 5303 - misplaced notehead (issue 570830043 by pkxgnugi...@runbox.com)
Hi Carl,
Perhaps this patch should also revert
87eb2f9fe1be3a532675fe4b7322bbba5a60ba5c
since that patch was a workaround, rather than a real fix, as
demonstrated during this troubleshooting thread.
Carl
https://codereview.appspot.com/570830043/
I'm afraid I do not understand the connection between the
overdone-notehead patch you refer to and the rounding-issue patch
regarding chord-notehead-placing. They do not seem to be linked to me.
But I noticed that your old patch 87eb2f9fe, which was supposed to fix
issue https://sourceforge.net/p/testlilyissues/issues/4693/, seems to
only fix that issue at "normal" staff sizes. See for instance:
\version "2.18"
#(set-global-staff-size 90)
\layout {
\override Score.StaffSymbol.layer = 100
}
\new Voice \with {
\override NoteHead.color = #red
} {
\relative {
f'4 a c e \bar "|."
}
}
(And, for the record, 87eb2f9fe introduced
https://sourceforge.net/p/testlilyissues/issues/5530/, as Malte reminded
us.)
So it seems to me that that patch should probably be reconsidered, but I
think not without being related to issues 5303/5522 (which are what the
current patch is about).
Best
Lukas
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: stem.cc - issue 5303 - misplaced notehead (issue 570830043 by pkxgnugi...@runbox.com)
On 7/11/19, 9:18 AM, "lilypond-devel on behalf of lukasfabianmo...@googlemail.com" wrote: As for Carl's suggestion, I'm trying now to understand the relationship between 87eb2f9fe1be3a532675fe4b7322bbba5a60ba5c and the bugs/patches under consideration. I withdraw my suggestion to revert this patch. It should not be reverted. Thanks, Carl ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCHES - Countdown for July 11th
Hello James,
Here's the equivalent of the example with do, re , misb , etc.
@lilypond[quote,verbatim]
\include "hel-arabic.ly"
\score {
\relative {
\set Staff.extraNatural = ##f
\set Staff.autoBeaming = ##f
\key d \bayati
\time 10/8
d'4 d'8 d16 [edb d c] bdb [a bdb c] d4 r8
d16 [edb c d] bdb [c] a [bdb g8] a [bdb] c [d] edb
f4 f16 [edb] edb8. [d16] d8 [edb] d [c] bdb
c4 bdb8 edb16 [d c bdb] a [c bdb a] a4 r8
}
\header {
title = "Semai Muhayer"
composer = "Jamil Bek"
}
}
@end lilypond
Best regards
hassan el fatihi
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Executable options style question
> On 11 Jul 2019, at 09:32, Jacques Menu wrote:
>
> I’ve wondering about command line options with multiple values.
>
> Which one of the following in preferable in your opinion:
>
> DESSUS="Cor anglais"
> xml2ly -msr-part-rename "P1 = ${DESSUS}"
>
> or:
>
> DESSUS="Cor anglais"
> xml2ly -msr-part-rename P1 "${DESSUS}”
POSIX, Guideline 8 [1] says that they should be presented as a single argument
to the option, separated with comma or blanks within that argument. GNU [2]
does not mention that explicitly.
1. https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap12.html
2. https://www.gnu.org/software/libc/manual/html_node/Argument-Syntax.html
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: stem.cc - issue 5303 - misplaced notehead (issue 570830043 by pkxgnugi...@runbox.com)
Thanks, Malte, for the pointers! https://sourceforge.net/p/testlilyissues/issues/5522/ (another bug that might be a duplicate of issue 5303; in that case one should test, if this fix for 5303 also fixes 5522) I can confirm that this patch set also fixes 5522 (and hence that 5522 almost certainly is a duplicate of 5303). Thanks for spotting this! As for Carl's suggestion, I'm trying now to understand the relationship between 87eb2f9fe1be3a532675fe4b7322bbba5a60ba5c and the bugs/patches under consideration. Lukas https://codereview.appspot.com/570830043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCHES - Countdown for July 11th
Hello, Here is the current patch countdown list. The next countdown will be on July 13th A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5531 NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly - James Lowe https://sourceforge.net/p/testlilyissues/issues/5531 http://codereview.appspot.com/560790043 5524 New function css-color (accompanying x11-color) - Urs Liska https://sourceforge.net/p/testlilyissues/issues/5524 http://codereview.appspot.com/580780043 5520 Improvements to \ambitusAfter - Malte Meyn https://sourceforge.net/p/testlilyissues/issues/5520 http://codereview.appspot.com/552740043 5512 Use new syntax consistently throughout docs and examples - Valentin Villenave https://sourceforge.net/p/testlilyissues/issues/5512 http://codereview.appspot.com/572640043 4362 Completion_heads_engraver and dotted breve - Malte Meyn https://sourceforge.net/p/testlilyissues/issues/4362 http://codereview.appspot.com/560810043 Countdown: 5303 layout-set-staff-space confuses chord note head placement in a certain situation - James Lowe https://sourceforge.net/p/testlilyissues/issues/5303 http://codereview.appspot.com/570830043 Review: No patches in Review at this time. New: 5532 \ottava doesn’t confuse ambitus - Malte Meyn https://sourceforge.net/p/testlilyissues/issues/5532 http://codereview.appspot.com/580890043 *** Regards, James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Executable options style question
Hello folks,
I’ve wondering about command line options with multiple values.
Which one of the following in preferable in your opinion:
DESSUS="Cor anglais"
xml2ly -msr-part-rename "P1 = ${DESSUS}"
or:
DESSUS="Cor anglais"
xml2ly -msr-part-rename P1 "${DESSUS}"
Thanks for your advice!
JM
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
