PATCHES - Countdown to September 9
Here is the current countdown report. The next countdown will begin on September 9th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !1609 Update authors.itexi - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/1609 !1608 Update vendored Pygments - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1608 !1607 slur-configuration.cc: small cleanup - Martín Rincón Botero https://gitlab.com/lilypond/lilypond/-/merge_requests/1607 !1606 Replace (ice-9 curried-definitions) with a fixed version - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1606 !1604 Clean up unused stencil commands - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1604 !1603 Improve clang-format config - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1603 !1601 Grob: make data members private - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/1601 !1600 Reduce dynamic casting - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/1600 !1599 Web: update GSoC page - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1599 !1598 Add '\bp' (big point) as unit - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/1598 !1596 doc: reference fixes and formatting - Werner Lemberg https://gitlab.com/lilypond/lilypond/-/merge_requests/1596 !1594 musicxml2ly: use \caesura command - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/1594 !1591 Enforce at most one instance of a translator type per context - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1591 !1590 Define and use ly_list - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1590 !1588 Add list of bar lines in an NR appendix (redux) - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1588 !1587 In MIDI, render lyric underties using Unicode undertie U+203F - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1587 !1544 Misc. minor output-distance cleanups - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1544 Countdown: !1612 Add more optional fallback parameters to Scheme functions - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1612 !1510 Better source locations for Scheme errors - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1510 Review: !1611 slur-configuration.cc: fine-tune penalty for dots - Martín Rincón Botero https://gitlab.com/lilypond/lilypond/-/merge_requests/1611 New: No patches in New at this time. Waiting: !1610 RFC: Require Cairo for building - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/1610 !1578 New margins by default - Martín Rincón Botero https://gitlab.com/lilypond/lilypond/-/merge_requests/1578 Cheers, Colin
Re: question about slur penalties
> Le 07/09/2022 13:02 CEST, Martín Rincón Botero > a écrit : > > > Hi, > > this question is related to my last merge request > https://gitlab.com/lilypond/lilypond/-/merge_requests/1611. To my surprise, > there seem to be strong objections against it, despite being an improvement > in all tests. I wanted to know more about penalties in > slur-configuration.cc in general. The idea for tweaking the penalty in the > case of the presence of dots is not mine at all. In the function > score_edges, amongst others, we find that the penalty (named "demerit" > here) for a specific case involving stems is tweaked so (line 464 of > current master): > > Real demerit = factor * dy; > if (state.extremes_[d].stem_ > && state.extremes_[d].stem_dir_ == state.dir_ > // TODO - Stem::get_beaming() should be precomputed. > && !Stem::get_beaming (state.extremes_[d].stem_, -d)) > * demerit /= 5;* > > To me this signals that the programmer is aware that there isn't a magical > formula to imitate hand engraving and particular cases will need a > different penalty. Is there something I'm missing? Is the penalty reduced > here in this particular case to fulfill a higher purpose or is that a case > of "last resort fix"? This kind of "tweaking" is all over the code, so it's > difficult not to interpret that as something that is a natural part of the > way penalties are handled. For any information in this regard that helps me > understand the code better I'm thankful. I can't immediately tell if this bit of code looks good or in need of improvement, but adding something similar in the case of slurs on dotted notes is solving the wrong problem. The problem is that while trying to avoid a collision with a dot, the slur pushes itself away too far from it, while it could have avoided the collision and still be much closer. Tweaking the penalty for dots means telling the slur that a collision with the dot isn't all that important, whereas what we want to tell it is that it doesn't need to go so far to avoid the dot. So it is not solving the root problem, but masking it, until the root problem reappears in a different form. (See the attachment for a more humoristic view.) Having never worked on this code, I can't give much useful information about it, sorry. (A year ago, I would have jumped into the code to try to solve the problem myself so there would be a happy ending to the criticism on the merge request, but doing that has exhausted me a few times, so I would like not to do it this time.) Thanks, Jean
Re: Lilypond build dependency tlasm
Immanuel Litzroth writes: >> On Wed, Sep 7, 2022 at 12:02 PM David Kastrup wrote: >>> >>> But "is this a good idea?" is something people should really consider >>> when coining terms that other people will have to use as a reference. > > In this case the problem seems the font used rather than in the naming. > Immanuel 1 and l are quite similar in a whole lot of fonts, so interspersing letters and digits in this particular manner is asking for trouble. I get a lot of spam that manages to bypass spam filters by relying on graphical similarities of letter glyphs and using different code points. If your target audience are humans instead of spam filters, it makes sense paying attention to such details. -- David Kastrup
question about slur penalties
Hi, this question is related to my last merge request https://gitlab.com/lilypond/lilypond/-/merge_requests/1611. To my surprise, there seem to be strong objections against it, despite being an improvement in all tests. I wanted to know more about penalties in slur-configuration.cc in general. The idea for tweaking the penalty in the case of the presence of dots is not mine at all. In the function score_edges, amongst others, we find that the penalty (named "demerit" here) for a specific case involving stems is tweaked so (line 464 of current master): Real demerit = factor * dy; if (state.extremes_[d].stem_ && state.extremes_[d].stem_dir_ == state.dir_ // TODO - Stem::get_beaming() should be precomputed. && !Stem::get_beaming (state.extremes_[d].stem_, -d)) * demerit /= 5;* To me this signals that the programmer is aware that there isn't a magical formula to imitate hand engraving and particular cases will need a different penalty. Is there something I'm missing? Is the penalty reduced here in this particular case to fulfill a higher purpose or is that a case of "last resort fix"? This kind of "tweaking" is all over the code, so it's difficult not to interpret that as something that is a natural part of the way penalties are handled. For any information in this regard that helps me understand the code better I'm thankful. Regards, Martín. -- www.martinrinconbotero.com
Re: Lilypond build dependency tlasm
In this case the problem seems the font used rather than in the naming. Immanuel On Wed, Sep 7, 2022 at 12:02 PM David Kastrup wrote: > > Lukas-Fabian Moser writes: > > > Hi Andrew, > > > > Am 07.09.22 um 10:19 schrieb Andrew Bernard: > >> I cant find out what tlasm is. It's a missing dependency for the > >> build. Google's indexing of billions of pages produces nothing, > >> unless I am dreaming. Could somebody help me understand what this > >> program is and where to find it? > >> > >> ../configure outputs: > >> > >> ERROR: Please install required programs: t1asm > > > > t1asm != tlasm (in uppercase: T1ASM != TLASM) > > There are things like imprudent naming choices that are mistakes waiting > to happen. > > I called an early utility of mine "Preview-LaTeX" and realized with the > first vanity searches that web search engines generally ignore case. > And that I was not exactly entering an empty search space. > > Well, I've dropped the capitalization since then, and clearly by now > that tool (that ended up quite elaborate partly due to a host of > contributors) dominates the search space. > > But "is this a good idea?" is something people should really consider > when coining terms that other people will have to use as a reference. > > -- > David Kastrup > -- -- A man must either resolve to point out nothing new or to become a slave to defend it. -- Sir Isaac Newton
Re: Lilypond build dependency tlasm
Lukas-Fabian Moser writes: > Hi Andrew, > > Am 07.09.22 um 10:19 schrieb Andrew Bernard: >> I cant find out what tlasm is. It's a missing dependency for the >> build. Google's indexing of billions of pages produces nothing, >> unless I am dreaming. Could somebody help me understand what this >> program is and where to find it? >> >> ../configure outputs: >> >> ERROR: Please install required programs: t1asm > > t1asm != tlasm (in uppercase: T1ASM != TLASM) There are things like imprudent naming choices that are mistakes waiting to happen. I called an early utility of mine "Preview-LaTeX" and realized with the first vanity searches that web search engines generally ignore case. And that I was not exactly entering an empty search space. Well, I've dropped the capitalization since then, and clearly by now that tool (that ended up quite elaborate partly due to a host of contributors) dominates the search space. But "is this a good idea?" is something people should really consider when coining terms that other people will have to use as a reference. -- David Kastrup
Re: Lilypond build dependency tlasm
Hi Andrew, Am 07.09.22 um 10:19 schrieb Andrew Bernard: I cant find out what tlasm is. It's a missing dependency for the build. Google's indexing of billions of pages produces nothing, unless I am dreaming. Could somebody help me understand what this program is and where to find it? ../configure outputs: ERROR: Please install required programs: t1asm t1asm != tlasm (in uppercase: T1ASM != TLASM) Lukas
Re: Lilypond build dependency tlasm
> Le 07/09/2022 10:19 CEST, Andrew Bernard a écrit > : > > > I cant find out what tlasm is. It's a missing dependency for the build. > Google's indexing of billions of pages produces nothing, unless I am > dreaming. Could somebody help me understand what this program is and > where to find it? > > ../configure outputs: > > ERROR: Please install required programs: t1asm It's not "tlasm" but "t1asm", the second character is the digit "one" (depending on the font you use, it can be barely noticeable ...). As mentioned on https://lilypond.org/doc/v2.23/Documentation/contributor/requirements-for-compiling-lilypond#other this program is part of the "Type 1 Utilities" suite, e.g. https://packages.ubuntu.com/jammy/t1utils
Re: Lilypond build dependency tlasm
I have no issues when I Google it. Did you search for tlasm or t1asm? Kevin On Wed 7 Sept 2022, 09:51 Andrew Bernard, wrote: > I cant find out what tlasm is. It's a missing dependency for the build. > Google's indexing of billions of pages produces nothing, unless I am > dreaming. Could somebody help me understand what this program is and > where to find it? > > ../configure outputs: > > ERROR: Please install required programs: t1asm > > > Andrew > > > >
Re: Lilypond build dependency tlasm
Oh dear. It's t-one-asm, not t-ell-asm. Sorry for the noise. On 7/09/2022 6:19 pm, Andrew Bernard wrote: I cant find out what tlasm is. It's a missing dependency for the build. Google's indexing of billions of pages produces nothing, unless I am dreaming. Could somebody help me understand what this program is and where to find it? ../configure outputs: ERROR: Please install required programs: t1asm Andrew
Re: Lilypond build dependency tlasm
On 2022-09-07 1:19 am, Andrew Bernard wrote: I cant find out what tlasm is. It's a missing dependency for the build. Google's indexing of billions of pages produces nothing, unless I am dreaming. Could somebody help me understand what this program is and where to find it? ../configure outputs: ERROR: Please install required programs: t1asm That's a numeral one, not a lowercase ell. t1asm [1] is for Type 1 fonts. [1]: https://linux.die.net/man/1/t1asm -- Aaron Hill
Lilypond build dependency tlasm
I cant find out what tlasm is. It's a missing dependency for the build. Google's indexing of billions of pages produces nothing, unless I am dreaming. Could somebody help me understand what this program is and where to find it? ../configure outputs: ERROR: Please install required programs: t1asm Andrew
