Re: A new home for browser-language (issue 2412). (issue 5870043)
LGTM. Somebody might complain that the translations of misc/ should go in their respective directories, but I think that's overkill, and I'd really like to get this patch in. Removing old /web/ is finally within reach! :) http://codereview.appspot.com/5870043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
A new home for browser-language (issue 2412). (issue 5870043)
http://codereview.appspot.com/5870043/diff/1/python/auxiliar/postprocess_html.py File python/auxiliar/postprocess_html.py (right): http://codereview.appspot.com/5870043/diff/1/python/auxiliar/postprocess_html.py#newcode71 python/auxiliar/postprocess_html.py:71: browser_language_url = /misc/browser-language please change to /website/misc/browser-language. I'm not 100% certain it's safe to have a /misc/ so let's avoid that potential problem for now. http://codereview.appspot.com/5870043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: A new home for browser-language (issue 2412). (issue 5870043)
On Wed, Mar 21, 2012 at 4:33 PM, gra...@percival-music.ca wrote: http://codereview.appspot.com/5870043/diff/1/python/auxiliar/postprocess_html.py File python/auxiliar/postprocess_html.py (right): http://codereview.appspot.com/5870043/diff/1/python/auxiliar/postprocess_html.py#newcode71 python/auxiliar/postprocess_html.py:71: browser_language_url = /misc/browser-language please change to /website/misc/browser-language. I'm not 100% certain it's safe to have a /misc/ so let's avoid that potential problem for now. http://codereview.appspot.com/5870043/ Sure I'll change it. Does this also apply to the other patch on countdown i.e. http://codereview.appspot.com/5843069/diff/17/Documentation/common-macros.itexi ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: A new home for browser-language (issue 2412). (issue 5870043)
On Wed, Mar 21, 2012 at 4:42 PM, Julien Rioux julien.ri...@gmail.com wrote: On Wed, Mar 21, 2012 at 4:33 PM, gra...@percival-music.ca wrote: http://codereview.appspot.com/5870043/diff/1/python/auxiliar/postprocess_html.py File python/auxiliar/postprocess_html.py (right): http://codereview.appspot.com/5870043/diff/1/python/auxiliar/postprocess_html.py#newcode71 python/auxiliar/postprocess_html.py:71: browser_language_url = /misc/browser-language please change to /website/misc/browser-language. I'm not 100% certain it's safe to have a /misc/ so let's avoid that potential problem for now. http://codereview.appspot.com/5870043/ Sure I'll change it. Does this also apply to the other patch on countdown i.e. http://codereview.appspot.com/5843069/diff/17/Documentation/common-macros.itexi Done. I'm running patch-new patchy on this. Julien ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel