Re: Add a node prefix to snippets, preventing duplicate node errors (issue 2221). (issue 5541050)

2012-01-13 Thread reinhold . kainhofer 

I had tried this very approach a while ago, but there were some
problems. Unfortunately, I can't remember which problems I encountered.

One issue might be that all links to one particular snippet will be
broken with that patch.

If you don't encounter any problems with broken links etc., then I'm
fine with the patch.

http://codereview.appspot.com/5541050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Add a node prefix to snippets, preventing duplicate node errors (issue 2221). (issue 5541050)

2012-01-12 Thread julien . rioux 

Reviewers: ,

Message:
Open for review.

Description:
Add a node prefix to snippets, preventing duplicate node errors (issue
2221).

Please review this at http://codereview.appspot.com/5541050/

Affected files:
  M Documentation/snippets.tely
  M Documentation/snippets/ancient-notation-intro.itely
  M Documentation/snippets/chords-intro.itely
  M Documentation/snippets/contexts-and-engravers-intro.itely
  M Documentation/snippets/editorial-annotations-intro.itely
  M Documentation/snippets/expressive-marks-intro.itely
  M Documentation/snippets/fretted-strings-intro.itely
  M Documentation/snippets/keyboards-intro.itely
  M Documentation/snippets/midi-intro.itely
  M Documentation/snippets/paper-and-layout-intro.itely
  M Documentation/snippets/percussion-intro.itely
  M Documentation/snippets/pitches-intro.itely
  M Documentation/snippets/repeats-intro.itely
  M Documentation/snippets/rhythms-intro.itely
  M Documentation/snippets/simultaneous-notes-intro.itely
  M Documentation/snippets/spacing-intro.itely
  M Documentation/snippets/staff-notation-intro.itely
  M Documentation/snippets/template-intro.itely
  M Documentation/snippets/text-intro.itely
  M Documentation/snippets/titles-intro.itely
  M Documentation/snippets/tweaks-and-overrides-intro.itely
  M Documentation/snippets/unfretted-strings-intro.itely
  M Documentation/snippets/vocal-music-intro.itely
  M Documentation/snippets/winds-intro.itely
  M Documentation/snippets/world-music-intro.itely
  M scripts/build/extract_texi_filenames.py


Index: Documentation/snippets.tely
diff --git a/Documentation/snippets.tely b/Documentation/snippets.tely
index  
b44f4c5a901963b59f290a0e8f4680305461e5c1..2d30fa92ae0d72617e8ea81286055a5848009853  
100644

--- a/Documentation/snippets.tely
+++ b/Documentation/snippets.tely
@@ -41,15 +41,20 @@ by the authors.
 @include macros.itexi

 @ifnothtml
+@macro nodeprefix{PRE}
+@end macro
 @macro lydoctitle{TEXT}
 @unnumberedsec \TEXT\
 @end macro
 @end ifnothtml

 @ifhtml
+@macro nodeprefix{PRE}
+@unmacro lydoctitle
 @macro lydoctitle{TEXT}
-@node \TEXT\
-@unnumberedsec \TEXT\
+@node \PRE\: \\TEXT\\
+@unnumberedsec \\TEXT\\
+@end macro
 @end macro
 @end ifhtml

Index: Documentation/snippets/ancient-notation-intro.itely
diff --git a/Documentation/snippets/ancient-notation-intro.itely  
b/Documentation/snippets/ancient-notation-intro.itely
index  
a6de3f24c603c6dc1d2ecd43dea37623a322a40d..30b13b9828f16d15fe797cfc9e918ec7c2a36507  
100644

--- a/Documentation/snippets/ancient-notation-intro.itely
+++ b/Documentation/snippets/ancient-notation-intro.itely
@@ -1,5 +1,6 @@
 @node Ancient notation
 @unnumbered Ancient notation
+@nodeprefix Ancient notation

 @ruser{Ancient notation}

Index: Documentation/snippets/chords-intro.itely
diff --git a/Documentation/snippets/chords-intro.itely  
b/Documentation/snippets/chords-intro.itely
index  
83aeaaaf25077a5ce926943fe4f726066363837e..1427e49a5bc69fb4f0fc3bf3512559c1f45e1360  
100644

--- a/Documentation/snippets/chords-intro.itely
+++ b/Documentation/snippets/chords-intro.itely
@@ -1,5 +1,6 @@
 @node Chords
 @unnumbered Chords
+@nodeprefix Chords

 @ruser{Chord notation}

Index: Documentation/snippets/contexts-and-engravers-intro.itely
diff --git a/Documentation/snippets/contexts-and-engravers-intro.itely  
b/Documentation/snippets/contexts-and-engravers-intro.itely
index  
ef796b0592511526d57ad1d251c5892b47ba7d41..e4e11670ccf26d898d56901afbdd819e9802a61c  
100644

--- a/Documentation/snippets/contexts-and-engravers-intro.itely
+++ b/Documentation/snippets/contexts-and-engravers-intro.itely
@@ -1,5 +1,6 @@
 @node Contexts and engravers
 @unnumbered Contexts and engravers
+@nodeprefix Contexts and engravers

 @c FIXME make xref more precise when the chapter has been
 @c revised in GDP
Index: Documentation/snippets/editorial-annotations-intro.itely
diff --git a/Documentation/snippets/editorial-annotations-intro.itely  
b/Documentation/snippets/editorial-annotations-intro.itely
index  
0dd710632ac2de83c62a1d04188909418be2467e..793c8570b1896be3ad9203e4475f03010334481f  
100644

--- a/Documentation/snippets/editorial-annotations-intro.itely
+++ b/Documentation/snippets/editorial-annotations-intro.itely
@@ -1,5 +1,6 @@
 @node Editorial annotations
 @unnumbered Editorial annotations
+@nodeprefix Editorial annotations

 @ruser{Editorial annotations}

Index: Documentation/snippets/expressive-marks-intro.itely
diff --git a/Documentation/snippets/expressive-marks-intro.itely  
b/Documentation/snippets/expressive-marks-intro.itely
index  
c869a5347ce731e3d12449c00dfbba458bffe156..60598e5420cf28a3368db8cba13ccfd7f2cc88c2  
100644

--- a/Documentation/snippets/expressive-marks-intro.itely
+++ b/Documentation/snippets/expressive-marks-intro.itely
@@ -1,5 +1,6 @@
 @node Expressive marks
 @unnumbered Expressive marks
+@nodeprefix Expressive marks

 @ruser{Expressive marks}

Index: Documentation/snippets/fretted-strings-intro.itely
diff --git a/Documentation/snippets/fretted-strings-intro.itely

Re: Add a node prefix to snippets, preventing duplicate node errors (issue 2221). (issue 5541050)

2012-01-12 Thread graham 

Looks Absolutely Fantastic To Me.

Please push directly to staging once Patchy has finished testing the
compile (about 30 minutes?)

http://codereview.appspot.com/5541050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel