Re: Add guile-config-1.8 etc. searching (issue 320830043 by truer...@gmail.com)

[Marco Atzeri]

On 05/04/2017 17:43, James wrote:

On Wed, 5 Apr 2017 14:13:43 +0200
Marco Atzeri  wrote:


On 05/04/2017 10:27, thomasmorle...@gmail.com wrote:

LGTM

https://codereview.appspot.com/320830043/



Detection is fine, but another piece is missing (tested on 2.19.58) :


This is not current master.

2.19.58 was 'released' 9 days ago. We're now in the testing process
for what will be 2.19.59.

Also note that the Tracker state for this issue is in 'Review' -
implying that it passed all the basic checks (including a Reg test and
a full make doc).

https://sourceforge.net/p/testlilyissues/issues/5115

Regards

James



You are right.

when building with

commit e9ae1cb3b093498ccb9d5f7348c755a3243bbccc
Author: Thomas Morley 
Date:   Sun Mar 19 14:29:04 2017 +0100

Issue 5108 Let configure find all needed files with guile-2.2

plus the proposed patch the build was fine on cygwin 64bit
and correctly detect latest guile 1.8

Regards
Marco

(cygwin package maintainer for guile and lilypond)






___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add guile-config-1.8 etc. searching (issue 320830043 by truer...@gmail.com)

[James]

On Wed, 5 Apr 2017 14:13:43 +0200
Marco Atzeri  wrote:

> On 05/04/2017 10:27, thomasmorle...@gmail.com wrote:
> > LGTM
> >
> > https://codereview.appspot.com/320830043/
> >  
> 
> Detection is fine, but another piece is missing (tested on 2.19.58) :

This is not current master.

2.19.58 was 'released' 9 days ago. We're now in the testing process
for what will be 2.19.59.

Also note that the Tracker state for this issue is in 'Review' -
implying that it passed all the basic checks (including a Reg test and
a full make doc).

https://sourceforge.net/p/testlilyissues/issues/5115

Regards

James



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add guile-config-1.8 etc. searching (issue 320830043 by truer...@gmail.com)

[Masamichi Hosoda]

> On 05/04/2017 10:27, thomasmorle...@gmail.com wrote:
>> LGTM
>>
>> https://codereview.appspot.com/320830043/
>>
> 
> Detection is fine, but another piece is missing (tested on 2.19.58) :
> 
> checking for guile... guile-1.8
> checking guile-1.8 version... 1.8.8
> checking for guile-1.8... guile-1.8
> checking for guile-1.8... /usr/bin/guile-1.8
> ...
> config.status: creating config.make
> config.status: creating config.hh
> 
> ERROR: Please install required programs: guile-config (guile-devel,
> guile-dev or libguile-dev package) GUILE-with-rational-bugfix
> 
> 
> Of course when both guile-config from 2.0.14 and guile-config-1.8 are
> present:
> 
> ERROR: Please install required programs: guile-config < 1.9.0
> (installed: 2.0.14) (guile-devel, guile-dev or libguile-dev package)
> GUILE-with-rational-bugfix

If I understand correctly, it has been fixed by the following commit.

http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=e9ae1cb3b093498ccb9d5f7348c755a3243bbccc

It will be contained in the next release 2.19.59.

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add guile-config-1.8 etc. searching (issue 320830043 by truer...@gmail.com)

[Marco Atzeri]

On 05/04/2017 10:27, thomasmorle...@gmail.com wrote:

LGTM

https://codereview.appspot.com/320830043/



Detection is fine, but another piece is missing (tested on 2.19.58) :

checking for guile... guile-1.8
checking guile-1.8 version... 1.8.8
checking for guile-1.8... guile-1.8
checking for guile-1.8... /usr/bin/guile-1.8
...
config.status: creating config.make
config.status: creating config.hh

ERROR: Please install required programs:  guile-config (guile-devel, 
guile-dev or libguile-dev package) GUILE-with-rational-bugfix



Of course when both guile-config from 2.0.14 and guile-config-1.8 are
present:

ERROR: Please install required programs:  guile-config < 1.9.0 
(installed: 2.0.14) (guile-devel, guile-dev or libguile-dev package) 
GUILE-with-rational-bugfix



Regards
Marco


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add guile-config-1.8 etc. searching (issue 320830043 by truer...@gmail.com)

[Carl . D . Sorensen]

LGTM.  And the reformatting is very nice.

Thanks

https://codereview.appspot.com/320830043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Add guile-config-1.8 etc. searching (issue 320830043 by truer...@gmail.com)

[thomasmorley65]

LGTM

https://codereview.appspot.com/320830043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel