Re: Allow event functions from partial functions or partial markups (issue 336670043 by d...@gnu.org)
On 2018/03/20 20:31:48, thomasmorley651 wrote: problem with \etc. So I vote for putting all in 2.20. I concur. https://codereview.appspot.com/336670043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Allow event functions from partial functions or partial markups (issue 336670043 by d...@gnu.org)
On 2018/03/20 12:56:37, dak wrote: On 2018/03/16 19:19:15, thomasmorley651 wrote: > Can't review this one. > Though, from description, I'd like to suggest to put up an entry in `changes'. Ugh. Documentation for \etc is sort-of sparse, and the main problem for "Changes" is "which Changes"? \etc in general is a 2.20 feature and this fits pretty well within that framework. But it's as to yet not tested all that much. Apart from wrong estimations (including my own), I don't remember any reported problem with \etc. So I vote for putting all in 2.20. https://codereview.appspot.com/336670043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Allow event functions from partial functions or partial markups (issue 336670043 by d...@gnu.org)
On 2018/03/16 19:19:15, thomasmorley651 wrote: Can't review this one. Though, from description, I'd like to suggest to put up an entry in `changes'. Ugh. Documentation for \etc is sort-of sparse, and the main problem for "Changes" is "which Changes"? \etc in general is a 2.20 feature and this fits pretty well within that framework. But it's as to yet not tested all that much. https://codereview.appspot.com/336670043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Allow event functions from partial functions or partial markups (issue 336670043 by d...@gnu.org)
Reviewers: thomasmorley651, Message: On 2018/03/16 19:19:15, thomasmorley651 wrote: Can't review this one. Though, from description, I'd like to suggest to put up an entry in `changes'. Well, yeah. Doesn't make a lot of sense without documentation and regtest either. I'll likely get them done separately. Description: Allow event functions from partial functions or partial markups This gives event functions such as ^\tweak font-size 2^\markup \huge \etc Also contains commits: Allow event functions from partial markup commands This allows event functions such as ^\markup \huge #red \etc Add Syntax::create_script This generates post-events from generic Scheme expressions. Please review this at https://codereview.appspot.com/336670043/ Affected files (+84, -30 lines): M lily/include/lily-imports.hh M lily/lily-imports.cc M lily/parser.yy M scm/ly-syntax-constructors.scm ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Allow event functions from partial functions or partial markups (issue 336670043 by d...@gnu.org)
Can't review this one. Though, from description, I'd like to suggest to put up an entry in `changes'. https://codereview.appspot.com/336670043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
