Re: CG tweak: some extra info on make doc and doc build times. (issue 6206071)

2012-05-31 Thread joseph . wakeling 

On 2012/05/31 00:01:55, dak wrote:

That's not the Google tracker issue number, but the Rietveld issue
number.



The Google tracker number would have been 2534 .


Please enter a valid google tracker issue number (or enter nothing to
create a new issue): 2534
WARNING: could not change issue labels;
please email lilypond-devel with the issue number: 2534
Tracker issue done


https://codereview.appspot.com/6206071/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG tweak: some extra info on make doc and doc build times. (issue 6206071)

2012-05-31 Thread graham 

LGTM, it can be pushed directly to staging.

http://codereview.appspot.com/6206071/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG tweak: some extra info on make doc and doc build times. (issue 6206071)

2012-05-30 Thread joseph . wakeling 

Latest patches update as suggested  The build section has a link to
4.6.2 and I've slightly tweaked the language of the latter section as
well as mentioning the doc-stage-1 build option.

https://codereview.appspot.com/6206071/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG tweak: some extra info on make doc and doc build times. (issue 6206071)

2012-05-30 Thread graham 


https://codereview.appspot.com/6206071/diff/6001/Documentation/included/compile.itexi
File Documentation/included/compile.itexi (right):

https://codereview.appspot.com/6206071/diff/6001/Documentation/included/compile.itexi#newcode646
Documentation/included/compile.itexi:646: easily take an hour or more,
so don't panic if sometimes it seems
I'm not convinced that the added text will help.  How about instead you
change it to

@warning{The first time you run @command{make@tie{}doc}, the process can
easily take an hour or more with not much output on the command-line.}

After that, @command{make...

https://codereview.appspot.com/6206071/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG tweak: some extra info on make doc and doc build times. (issue 6206071)

2012-05-30 Thread joseph . wakeling 

On 2012/05/30 16:55:17, Graham Percival wrote:

I'm not convinced that the added text will help.  How about instead

you change

it to


... done :-)

https://codereview.appspot.com/6206071/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG tweak: some extra info on make doc and doc build times. (issue 6206071)

2012-05-30 Thread graham 

ok.  The @warning{} suggestion was aimed at making it much more visible,
but if you think it's visible enough as-is then I'm not going to
complain -- if we use too many @warning{}s then they'll lose their
effectiveness.

https://codereview.appspot.com/6206071/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG tweak: some extra info on make doc and doc build times. (issue 6206071)

2012-05-30 Thread joseph . wakeling 

On 2012/05/30 21:16:09, Graham Percival wrote:

The @warning{}


... I'm blind.  Give me 2 seconds to fix that.

https://codereview.appspot.com/6206071/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG tweak: some extra info on make doc and doc build times. (issue 6206071)

2012-05-30 Thread graham 

oh, and since you didn't use our custom git-cl to upload this patch,
you'll need to manually change the relevant issue to patch-new, or else
this will never get pushed.

It would be nice if we had a dedicated mentor for you, but unfortunately
we don't so this warning is the best we can do for you.

https://codereview.appspot.com/6206071/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG tweak: some extra info on make doc and doc build times. (issue 6206071)

2012-05-30 Thread joseph . wakeling 

I have always been using git-cl but for all patches after the first I
got an error message after entering the google tracker issue number:

---
We were not able to associate this patch with a google tracker issue.
Please enter a valid google tracker issue number (or enter nothing to
create a new issue): 6206071
WARNING: could not change issue labels;
please email lilypond-devel with a general description of the problem
Server responded with: 404, issue 6206071 in project lilypond not found
Tracker issue done
---

As the patches did in fact upload, I didn't realize there was a problem.
:-(

Anyway, the warning is included and I can push this to a new issue if
it's needed to make sure it gets included.

https://codereview.appspot.com/6206071/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG tweak: some extra info on make doc and doc build times. (issue 6206071)

2012-05-30 Thread David Kastrup 
joseph.wakel...@gmail.com writes:

 I have always been using git-cl but for all patches after the first I
 got an error message after entering the google tracker issue number:

 ---
 We were not able to associate this patch with a google tracker issue.
 Please enter a valid google tracker issue number (or enter nothing to
 create a new issue): 6206071
 WARNING: could not change issue labels;

That's not the Google tracker issue number, but the Rietveld issue
number.

The Google tracker number would have been 2534 .

-- 
David Kastrup


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG tweak: some extra info on make doc and doc build times. (issue 6206071)

2012-05-30 Thread dak 

[copy of message posted to devel list]

On 2012/05/30 21:45:58, Joseph Rushton Wakeling wrote:


Please enter a valid google tracker issue number (or enter nothing to

create a

new issue): 6206071


That's not the Google tracker issue number, but the Rietveld issue
number.

The Google tracker number would have been 2534 .

https://codereview.appspot.com/6206071/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG tweak: some extra info on make doc and doc build times. (issue 6206071)

2012-05-16 Thread graham 


http://codereview.appspot.com/6206071/diff/1/Documentation/included/compile.itexi
File Documentation/included/compile.itexi (right):

http://codereview.appspot.com/6206071/diff/1/Documentation/included/compile.itexi#newcode464
Documentation/included/compile.itexi:464: or to build only the PDF
documentation,
Don't we have a different place that discusses the doc-related build
stuff?  I could have sworn that we had a dedicated section to this.

If so, perhaps this part should simply be a link to the doc-building
stuff, and put the doc-stage-1 in there?

http://codereview.appspot.com/6206071/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG tweak: some extra info on make doc and doc build times. (issue 6206071)

2012-05-16 Thread joseph . wakeling 

On 2012/05/16 12:05:19, Graham Percival wrote:

Don't we have a different place that discusses the doc-related build

stuff?

You're right; it's in Section 4.6.2.  It's not necessarily obvious/easy
to find as Section 4.6 is simply titled 'post-compilation options'.
I'll tweak as you suggest, with links.

https://codereview.appspot.com/6206071/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

CG tweak: some extra info on make doc and doc build times. (issue 6206071)

2012-05-16 Thread joseph . wakeling 

Reviewers: ,

Message:
As per earlier discussion on devel list, this patch just adds a little
bit of extra info on the make process, noting the documentation build
commands and the possible length of build times.

Basically it's to stop other people getting worried as I did when a
single step of the doc build process seemed to have hung with no
progress.

Description:
CG tweak: some extra info on make doc and doc build times.

Please review this at https://codereview.appspot.com/6206071/

Affected files:
  M Documentation/included/compile.itexi


Index: Documentation/included/compile.itexi
diff --git a/Documentation/included/compile.itexi  
b/Documentation/included/compile.itexi
index  
e95cf2629cd8122a1f7c0c909f3f8d731d5bef0e..4b87ce1fc7602edccb32592a6aa232d62ce08b74  
100644

--- a/Documentation/included/compile.itexi
+++ b/Documentation/included/compile.itexi
@@ -456,6 +456,23 @@ targets, run:
 make help
 @end example

+For example, to build documentation, you can use
+@example
+make doc
+@end example
+
+or to build only the PDF documentation,
+
+@example
+make doc-stage-1
+@end example
+
+Documentation builds can take much longer than building LilyPond itself.
+Some individual commands issued during the make process may take as long
+as an hour to complete on older single-core machines, so don't panic if
+for a long time it looks like nothing is happening!  Be patient, and the
+build will complete.
+
 TODO: Describe what @command{make} actually does.





___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel