Re: Flex on macOS
> On 1 Aug 2023, at 10:24, Jean Abou Samra wrote:
>
> pre,code,address { margin: 0px; } h1,h2,h3,h4,h5,h6 { margin-top: 0.2em;
> margin-bottom: 0.2em; } ol,ul { margin-top: 0em; margin-bottom: 0em; }
> blockquote { margin-top: 0em; margin-bottom: 0em; }
> Le lundi 31 juillet 2023 à 22:29 +0200, Hans Åberg a écrit :
>>
>>
>> Apple has patched their version of Flex so that the generated .cc file must
>> be used with their header FlexLexer.h.
>
> I don't think this is the problem. Before I installed Flex from Homebrew, the
> only Flex installation was the system one, so it must have been using the
> system FlexLexer.h.
It depends on where the compiler looks. In addition, the header has changed
between the Flex versions, for some time it was broken. The fact that
FlexLexer.h is system installed, as opposed in the source directory, as in the
case of Bison, causes problems.
Re: Flex on macOS
Le lundi 31 juillet 2023 à 22:52 +0200, Jonas Hahnfeld a écrit : > Right, it also comes up with "brew bundle cleanup"... Did you manually > install it for your environment during the weekend? Yes. > I'm relatively sure I didn't, it may have come in as a dependency in the past > (even though > I couldn't find it in the history of homebrew-core). > > But yes, then we should add it to the Brewfile, sorry for not realizing > this when doing the previous release. Ok, https://gitlab.com/lilypond/lilypond/-/merge_requests/2079 signature.asc Description: This is a digitally signed message part
Re: Flex on macOS
Le lundi 31 juillet 2023 à 22:29 +0200, Hans Åberg a écrit : > Apple has patched their version of Flex so that the generated .cc file must be > used with their header FlexLexer.h. I don't think this is the problem. Before I installed Flex from Homebrew, the only Flex installation was the system one, so it must have been using the system FlexLexer.h. signature.asc Description: This is a digitally signed message part
Re: Flex on macOS
On Mon, 2023-07-31 at 09:54 +0200, Jean Abou Samra wrote: > > Yes, but flex has always been there as a dependency of some other > > package I think, only not added in your environment variables. We can > > explicitly add it to the Brewfile if you think that's better, but it > > shouldn't change the set of already installed packages. > > Hm, I just SSHed into the MacStadium node again and ran "brew uninstall flex". > This did not uninstall any other package as depending on flex. Right, it also comes up with "brew bundle cleanup"... Did you manually install it for your environment during the weekend? I'm relatively sure I didn't, it may have come in as a dependency in the past (even though I couldn't find it in the history of homebrew-core). But yes, then we should add it to the Brewfile, sorry for not realizing this when doing the previous release. Jonas signature.asc Description: This is a digitally signed message part
Re: Flex on macOS
> On 31 Jul 2023, at 01:15, Jean Abou Samra wrote: > > I noticed that the macOS-provided flex version (on the MacStadium node > provided > by Marnen, which runs the unsupported macOS Catalina) was ~10 years old, so I > installed Flex from Homebrew (required setting CPPFLAGS + LDFLAGS + PATH as > advised in the Homebrew log messages), and it went fine. Apple has patched their version of Flex so that the generated .cc file must be used with their header FlexLexer.h.
Re: Flex on macOS
> Yes, but flex has always been there as a dependency of some other > package I think, only not added in your environment variables. We can > explicitly add it to the Brewfile if you think that's better, but it > shouldn't change the set of already installed packages. Hm, I just SSHed into the MacStadium node again and ran "brew uninstall flex". This did not uninstall any other package as depending on flex. signature.asc Description: This is a digitally signed message part
Re: Flex on macOS
On Mon, 2023-07-31 at 01:15 +0200, Jean Abou Samra wrote: > Hi, > > As a follow-up to the release: on macOS I encountered a quirk which is > that the compiler spit out build errors on the Flex-generated lexer > out/lexer.cc. (Now I find myself stupid for not saving the error messages > somewhere.) IIRC it complains about the 'register' keyword which is an error with C++17, ie since the last release. > I noticed that the macOS-provided flex version (on the MacStadium node > provided by Marnen, which runs the unsupported macOS Catalina) was > ~10 years old, so I installed Flex from Homebrew (required setting > CPPFLAGS + LDFLAGS + PATH as advised in the Homebrew log messages), > and it went fine. Should we add "flex" to release/binaries/Brewfile? > Jonas, did you already encounter that problem? Did you do the same? Yes, but flex has always been there as a dependency of some other package I think, only not added in your environment variables. We can explicitly add it to the Brewfile if you think that's better, but it shouldn't change the set of already installed packages. Jonas signature.asc Description: This is a digitally signed message part
Re: Flex on macOS
> Apart from that, even though it took me a lot of time due to having > to set up all the VMs etc., the release went quite smoothly. Thank > you Jonas for thoroughly documenting the release procedure in the > CG. Thanks to both of you! Werner
Flex on macOS
Hi, As a follow-up to the release: on macOS I encountered a quirk which is that the compiler spit out build errors on the Flex-generated lexer out/lexer.cc. (Now I find myself stupid for not saving the error messages somewhere.) I noticed that the macOS-provided flex version (on the MacStadium node provided by Marnen, which runs the unsupported macOS Catalina) was ~10 years old, so I installed Flex from Homebrew (required setting CPPFLAGS + LDFLAGS + PATH as advised in the Homebrew log messages), and it went fine. Should we add "flex" to release/binaries/Brewfile? Jonas, did you already encounter that problem? Did you do the same? (As far as I can see, we're already using Bison from Homebrew instead of the macOS-provided one, which is even older.) Apart from that, even though it took me a lot of time due to having to set up all the VMs etc., the release went quite smoothly. Thank you Jonas for thoroughly documenting the release procedure in the CG. Cheers, Jean signature.asc Description: This is a digitally signed message part
