Re: In-tree make check fails with lilypond-book include file regtest.
Graham Percival writes: > On Tue, Mar 27, 2012 at 02:18:18PM -0400, Julien Rioux wrote: >> I locally reverted your revert and could make, make test and make >> doc from scratch in the src dir after the fixes that I committed >> today. Unless there is any objections I will push the revert of the >> revert to staging. > > Please wait a day. I don't agree with David's revert of your > commit without understanding why it was happening, If one understands why something is happening, one can fix the commit instead of reverting it. A revert of non-merge commits is cheap to do and easy to revert again. In this case, the commit in question stopped "make test" in a standard setup from completing and broke the build of the release as well. It did not contain a bugfix, but rather a regtest for a fix: the fix itself stayed in LilyPond. The problem was most likely not with the regtest itself (after all, it passed the out-of-tree tests of both Patchies), but rather with the infrastructure supporting that kind of multi-file regtest. That means that a fix will meddle with infrastructure, making it a good idea to give it the normal review process, not an expedited emergency one. Reverting the problematic regtest removed the urgency for getting a fix in. When I acted without further communication, it was not done out of a whim but because the advantages of doing so very much outweighed the disadvantages in my assessment of the situation, an assessment based on more than an hour of tests of different constellations involving and not involving the commit and analyzing its impact. Julien's timely response certainly is welcome and alleviates the problem, but it still is not amiss to give the proposed fix a chance at review without having to hammer it home. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: In-tree make check fails with lilypond-book include file regtest.
On Tue, Mar 27, 2012 at 10:34:37PM +0100, Graham Percival wrote: > Let's see if current master can be built ok, and fix the dist > failures. *Then* we can add back the lilypond-book thing. oh wait, I just checked git and now see that you have a fix for dist, and have a solution for this as well. What you have done sounds like the right way to move forward. - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: In-tree make check fails with lilypond-book include file regtest.
On Tue, Mar 27, 2012 at 02:18:18PM -0400, Julien Rioux wrote: > I locally reverted your revert and could make, make test and make > doc from scratch in the src dir after the fixes that I committed > today. Unless there is any objections I will push the revert of the > revert to staging. Please wait a day. I don't agree with David's revert of your commit without understanding why it was happening, but reverting that revert without understand why it was happening will just put us back in the initial problematic state. Let's see if current master can be built ok, and fix the dist failures. *Then* we can add back the lilypond-book thing. - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: In-tree make check fails with lilypond-book include file regtest.
On 27/03/2012 9:37 AM, David Kastrup wrote: David Kastrup writes: commit ee70161485a2d2f347db3e29724a943c741ef524 Author: Julien Rioux Date: Wed Mar 21 09:13:55 2012 -0400 Regtests for lilypond-book include files located in subdir. causes the regtests to fail. Rerunning configure, make clean and make test does not help. Reverted for now. I locally reverted your revert and could make, make test and make doc from scratch in the src dir after the fixes that I committed today. Unless there is any objections I will push the revert of the revert to staging. -- Julien ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: In-tree make check fails with lilypond-book include file regtest.
David Kastrup writes: > commit ee70161485a2d2f347db3e29724a943c741ef524 > Author: Julien Rioux > Date: Wed Mar 21 09:13:55 2012 -0400 > > Regtests for lilypond-book include files located in subdir. > > > causes the regtests to fail. Rerunning configure, make clean and make > test does not help. Reverted for now. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
In-tree make check fails with lilypond-book include file regtest.
commit ee70161485a2d2f347db3e29724a943c741ef524
Author: Julien Rioux
Date: Wed Mar 21 09:13:55 2012 -0400
Regtests for lilypond-book include files located in subdir.
causes the regtests to fail. Rerunning configure, make clean and make
test does not help.
Parsing...
/usr/local/tmp/lilypond/out/lybook-db/91/lily-c3d833f7.ly:18:11: error: cannot
find file: `include/myvar.ily'
(search path:
`/usr/local/tmp/lilypond/out/lybook-db/91:/usr/local/tmp/lilypond/out/share/lilypond/current/fonts/svg/:/usr/local/tmp/lilypond/out/share/lilypond/current/fonts/type1/:/usr/local/tmp/lilypond/out/share/lilypond/current/fonts/otf/:/usr/local/tmp/lilypond/out/share/lilypond/current/scm:/usr/local/tmp/lilypond/out/share/lilypond/current/ps:/usr/local/tmp/lilypond/out/share/lilypond/current/ly:/usr/local/tmp/lilypond/out/lybook-db:../:./:./out-test:../../../input:/usr/local/tmp/lilypond/Documentation:/usr/local/tmp/lilypond/Documentation/snippets:../../../input/regression/:/usr/local/tmp/lilypond/Documentation/included/:/usr/local/tmp/lilypond/mf/out/:/usr/local/tmp/lilypond/mf/out/:/usr/local/tmp/lilypond/Documentation/pictures:/usr/local/tmp/lilypond/Documentation/pictures/./out-test:')
\include
"include/myvar.ily"
/usr/local/tmp/lilypond/out/lybook-db/91/lily-c3d833f7.ly:19:18: error: unknown
escaped string: `\myVar'
\relative c'' {
\myVar }
/usr/local/tmp/lilypond/out/lybook-db/91/lily-c3d833f7.ly:19:18: error: syntax
error, unexpected STRING
\relative c'' {
\myVar }
/usr/local/tmp/lilypond/out/lybook-db/91/lily-c3d833f7.ly:19:2: error: errors
found, ignoring music expression
\relative c'' { \myVar }
fatal error: failed files: "91/lily-c3d833f7.ly"
--
David Kastrup
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
