Re: Lilypond-book: Get rid of lilyquote option, use quote instead (issue 4921050)
passes make and reg tests http://codereview.appspot.com/4921050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Lilypond-book: Get rid of lilyquote option, use quote instead (issue 4921050)
LGTM. Please push without waiting for a countdown. (but maybe remove the parentheses first) http://codereview.appspot.com/4921050/diff/2001/python/book_texinfo.py File python/book_texinfo.py (right): http://codereview.appspot.com/4921050/diff/2001/python/book_texinfo.py#newcode250 python/book_texinfo.py:250: if (QUOTE in snippet.option_dict): On 2011/08/22 11:19:05, lemzwerg wrote: Why parentheses? Similar lines in the scripts don't use them. I think they add clarity, but I must admit that most python style guides (and examples) omit such parentheses. http://codereview.appspot.com/4921050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Lilypond-book: Get rid of lilyquote option, use quote instead (issue 4921050)
LGTM. http://codereview.appspot.com/4921050/diff/2001/python/book_texinfo.py File python/book_texinfo.py (right): http://codereview.appspot.com/4921050/diff/2001/python/book_texinfo.py#newcode250 python/book_texinfo.py:250: if (QUOTE in snippet.option_dict): Why parentheses? Similar lines in the scripts don't use them. http://codereview.appspot.com/4921050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
