PATCHES - Countdown for May 17th
Hello, Here is the current patch countdown list. The next countdown will be on May 19th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: No patches in Push at this time. Countdown: !771 Add -Wall -Wextra -Werror to CI builds - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/771 !770 Require createSpacing = ##t to create LeftEdge - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/770 !769 scm: Replace most uses of ly:format by regular format - Jonas Hahnfeld https://gitlab.com/lilypond/lilypond/-/merge_requests/769 !768 Protect Paper_book::get_system_specs () against non-stencils - Jean Abou-Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/768 !765 Make measure counts more similar to bar numbers - Jean Abou-Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/765 !761 Add fallback when attachment point for down stem is not found - Jean Abou-Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/761 Review: No patches in Review at this time. New: No patches in New at this time. Waiting: No patches in Waiting at this time. *** Regards, James OpenPGP_0x111CA298156CCB85.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature
Re: PATCHES - Countdown for May 17th
Am Sonntag, den 17.05.2020, 15:41 +0200 schrieb Jonas Hahnfeld: > Am Sonntag, den 17.05.2020, 15:18 +0200 schrieb Werner LEMBERG: > > > > I think for now it's pushing to staging. Either from the command > > > > line, or because you have set staging as your destination branch in > > > > the GUI, in which case you can use a button (usually starting by > > > > rebase). > > > > > > If using the command line, just make sure to push the rebased commit > > > to the merge request first so that GitLab marks it correctly. I > > > haven't found a way to set the "merged" state manually after the > > > commits have hit staging... > > > > It seems we should provide a small script 'lilypond-commit', to be > > used by everyone... > > Just use the UI to merge. This will probably become mandatory when > integrating CI which I'm preparing right now. Another benefit of merging via the UI is that it automatically deletes the source branch (unless you unticked the box when creating the merge request). signature.asc Description: This is a digitally signed message part
Re: PATCHES - Countdown for May 17th
Am Sonntag, den 17.05.2020, 15:50 +0200 schrieb David Kastrup: > Jonas Hahnfeld writes: > > Am Sonntag, den 17.05.2020, 15:18 +0200 schrieb Werner LEMBERG: > > > > > I think for now it's pushing to staging. Either from the command > > > > > line, or because you have set staging as your destination branch in > > > > > the GUI, in which case you can use a button (usually starting by > > > > > rebase). > > > > > > > > If using the command line, just make sure to push the rebased commit > > > > to the merge request first so that GitLab marks it correctly. I > > > > haven't found a way to set the "merged" state manually after the > > > > commits have hit staging... > > > > > > It seems we should provide a small script 'lilypond-commit', to be > > > used by everyone... > > > > Just use the UI to merge. This will probably become mandatory when > > integrating CI which I'm preparing right now. > > It is much more direct to manage one's commits/issues on the command > line. We should not lightly forego that possibility. I agree for editing commit messages and more complex rebases, but merging should be left to an entity that enforces policy. Right now this is patchy pushing from staging to master. In my book, this should be GitLab when it has CI information. signature.asc Description: This is a digitally signed message part
Re: PATCHES - Countdown for May 17th
Jonas Hahnfeld writes: > Am Sonntag, den 17.05.2020, 15:18 +0200 schrieb Werner LEMBERG: >> >> I think for now it's pushing to staging. Either from the command >> >> line, or because you have set staging as your destination branch in >> >> the GUI, in which case you can use a button (usually starting by >> >> rebase). >> > >> > If using the command line, just make sure to push the rebased commit >> > to the merge request first so that GitLab marks it correctly. I >> > haven't found a way to set the "merged" state manually after the >> > commits have hit staging... >> >> It seems we should provide a small script 'lilypond-commit', to be >> used by everyone... > > Just use the UI to merge. This will probably become mandatory when > integrating CI which I'm preparing right now. It is much more direct to manage one's commits/issues on the command line. We should not lightly forego that possibility. -- David Kastrup
Re: PATCHES - Countdown for May 17th
Am Sonntag, den 17.05.2020, 15:18 +0200 schrieb Werner LEMBERG: > >> I think for now it's pushing to staging. Either from the command > >> line, or because you have set staging as your destination branch in > >> the GUI, in which case you can use a button (usually starting by > >> rebase). > > > > If using the command line, just make sure to push the rebased commit > > to the merge request first so that GitLab marks it correctly. I > > haven't found a way to set the "merged" state manually after the > > commits have hit staging... > > It seems we should provide a small script 'lilypond-commit', to be > used by everyone... Just use the UI to merge. This will probably become mandatory when integrating CI which I'm preparing right now. Jonas signature.asc Description: This is a digitally signed message part
Re: PATCHES - Countdown for May 17th
Werner LEMBERG writes: >>> I think for now it's pushing to staging. Either from the command >>> line, or because you have set staging as your destination branch in >>> the GUI, in which case you can use a button (usually starting by >>> rebase). >> >> If using the command line, just make sure to push the rebased commit >> to the merge request first so that GitLab marks it correctly. I >> haven't found a way to set the "merged" state manually after the >> commits have hit staging... > > It seems we should provide a small script 'lilypond-commit', to be > used by everyone... There are a few small scripts on the agenda... It turns out that one can achieve a whole lot just using git commands (like with git push options) without even needing to consult a Gitlab API. Together with conventions for branch/tag naming, there is a lot of potential to achieve similar functionality to what we once did with git-cl with much much less code and work since basically all of the transport of information can be done using the git command line. -- David Kastrup
Re: PATCHES - Countdown for May 17th
>> I think for now it's pushing to staging. Either from the command >> line, or because you have set staging as your destination branch in >> the GUI, in which case you can use a button (usually starting by >> rebase). > > If using the command line, just make sure to push the rebased commit > to the merge request first so that GitLab marks it correctly. I > haven't found a way to set the "merged" state manually after the > commits have hit staging... It seems we should provide a small script 'lilypond-commit', to be used by everyone... Werner
Re: PATCHES - Countdown for May 17th
Am Sonntag, den 17.05.2020, 14:29 +0200 schrieb David Kastrup: > James Lowe writes: > > > On 17/05/2020 08:38, Han-Wen Nienhuys wrote: > > > On Sun, May 17, 2020 at 9:29 AM James Lowe wrote: > > > > Hello, > > > > > > > > Here is the current patch countdown list. The next countdown will be on > > > > May 19th. > > > > > > thanks! > > > > > > What is the procedure for pushing now that we're on gitlab? Pushing to > > > the staging branch, or do I click a button? > > > > > > > To be honest, I am still unsure (but I only have to care about > > updating merge requests). > > > > However, see the thread from the last countdown. > > > > It starts here > > > > https://lists.gnu.org/archive/html/lilypond-devel/2020-05/msg00359.html > > > > I think for now it's pushing to staging. Either from the command line, > or because you have set staging as your destination branch in the GUI, > in which case you can use a button (usually starting by rebase). If using the command line, just make sure to push the rebased commit to the merge request first so that GitLab marks it correctly. I haven't found a way to set the "merged" state manually after the commits have hit staging... Jonas signature.asc Description: This is a digitally signed message part
Re: PATCHES - Countdown for May 17th
James Lowe writes: > On 17/05/2020 08:38, Han-Wen Nienhuys wrote: >> On Sun, May 17, 2020 at 9:29 AM James Lowe wrote: >>> Hello, >>> >>> Here is the current patch countdown list. The next countdown will be on >>> May 19th. >> thanks! >> >> What is the procedure for pushing now that we're on gitlab? Pushing to >> the staging branch, or do I click a button? >> > To be honest, I am still unsure (but I only have to care about > updating merge requests). > > However, see the thread from the last countdown. > > It starts here > > https://lists.gnu.org/archive/html/lilypond-devel/2020-05/msg00359.html I think for now it's pushing to staging. Either from the command line, or because you have set staging as your destination branch in the GUI, in which case you can use a button (usually starting by rebase). -- David Kastrup
Re: PATCHES - Countdown for May 17th
On 17/05/2020 08:38, Han-Wen Nienhuys wrote: On Sun, May 17, 2020 at 9:29 AM James Lowe wrote: Hello, Here is the current patch countdown list. The next countdown will be on May 19th. thanks! What is the procedure for pushing now that we're on gitlab? Pushing to the staging branch, or do I click a button? To be honest, I am still unsure (but I only have to care about updating merge requests). However, see the thread from the last countdown. It starts here https://lists.gnu.org/archive/html/lilypond-devel/2020-05/msg00359.html James
Re: PATCHES - Countdown for May 17th
On Sun, May 17, 2020 at 9:29 AM James Lowe wrote: > > Hello, > > Here is the current patch countdown list. The next countdown will be on > May 19th. thanks! What is the procedure for pushing now that we're on gitlab? Pushing to the staging branch, or do I click a button? > > A list of all merge requests can be found here: > https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority > > > Push: > > !32 Percent_repeat_iterator: stop gratuitous use of std::string - David > Kastrup > https://gitlab.com/lilypond/lilypond/-/merge_requests/32 > > !31 Lilymidy: open midi files in binary mode - Martin Neubauer > https://gitlab.com/lilypond/lilypond/-/merge_requests/31 > > !30 Remove break-visibility handling in tablature ties - Han-Wen Nienhuys > https://gitlab.com/lilypond/lilypond/-/merge_requests/30 > > !29 Comment fixes for offset_directed - David Kastrup > https://gitlab.com/lilypond/lilypond/-/merge_requests/29 > > !28 Resolve "Use a callback for Percent_repeat_iterator's repeat action" > - David Kastrup > https://gitlab.com/lilypond/lilypond/-/merge_requests/28 > > !27 Use `-dfont-ps-resdir` for make doc - Masamichi Hosoda > https://gitlab.com/lilypond/lilypond/-/merge_requests/27 > > !26 Split glyph contours in up/down segments for skylines - Han-Wen Nienhuys > https://gitlab.com/lilypond/lilypond/-/merge_requests/26 > > !24 Cache the name => index lookup in Open_type_font - Han-Wen Nienhuys > https://gitlab.com/lilypond/lilypond/-/merge_requests/24 > > !20 Add regtest for multiple post-events wrapper behavior - Valentin > Villenave > https://gitlab.com/lilypond/lilypond/-/merge_requests/20 > > !3 Add dynamic-interface to keepAliveInterfaces - Jean Abou Samra > https://gitlab.com/lilypond/lilypond/-/merge_requests/3 > > > Countdown: > > !39 cleanup span-bar-engraver.cc - Han-Wen Nienhuys > https://gitlab.com/lilypond/lilypond/-/merge_requests/39 > > !22 Doc: remove now unnecessary dummy argument after lilypond > -dshow-available-fonts - Jean Abou Samra > https://gitlab.com/lilypond/lilypond/-/merge_requests/22 > > > Review: > > !43 Fix #5234: Avoid writing a MIDI file when there is no music - Dan Eble > https://gitlab.com/lilypond/lilypond/-/merge_requests/43 > > !42 Resolve "(*location*) returning no valid value while parsing > embedded scheme" - David Kastrup > https://gitlab.com/lilypond/lilypond/-/merge_requests/42 > > !41 Issue 5129: Bad horizontal spacing when \override LyricText > #'X-offset - Kevin Barry > https://gitlab.com/lilypond/lilypond/-/merge_requests/41 > > !38 GNUmakefile.in: remove remove-test-changed support - Han-Wen Nienhuys > https://gitlab.com/lilypond/lilypond/-/merge_requests/38 > > > New: > > !50 Remove some ancient long-unused cruft - David Kastrup > https://gitlab.com/lilypond/lilypond/-/merge_requests/50 > > !49 Remove operator= from Scheme_hash_table - Han-Wen Nienhuys > https://gitlab.com/lilypond/lilypond/-/merge_requests/49 > > !48 skyline: minor performance tweaks - Han-Wen Nienhuys > https://gitlab.com/lilypond/lilypond/-/merge_requests/48 > > !47 Stop smobifying Transform - Han-Wen Nienhuys > https://gitlab.com/lilypond/lilypond/-/merge_requests/47 > > !46 Clean up and fix glyph contour generation - Han-Wen Nienhuys > https://gitlab.com/lilypond/lilypond/-/merge_requests/46 > > !45 Remove do_break_substitution_and_fixup_refpoints() from System API - > Han-Wen Nienhuys > https://gitlab.com/lilypond/lilypond/-/merge_requests/45 > > !44 Change ly_chain_assoc_get to use eq? - Han-Wen Nienhuys > https://gitlab.com/lilypond/lilypond/-/merge_requests/44 > > > Waiting: > > No patches in Waiting at this time. > > > > > > > > > *** > > Regards, > > James > -- Han-Wen Nienhuys - hanw...@gmail.com - http://www.xs4all.nl/~hanwen
PATCHES - Countdown for May 17th
Hello, Here is the current patch countdown list. The next countdown will be on May 19th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !32 Percent_repeat_iterator: stop gratuitous use of std::string - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/32 !31 Lilymidy: open midi files in binary mode - Martin Neubauer https://gitlab.com/lilypond/lilypond/-/merge_requests/31 !30 Remove break-visibility handling in tablature ties - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/30 !29 Comment fixes for offset_directed - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/29 !28 Resolve "Use a callback for Percent_repeat_iterator's repeat action" - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/28 !27 Use `-dfont-ps-resdir` for make doc - Masamichi Hosoda https://gitlab.com/lilypond/lilypond/-/merge_requests/27 !26 Split glyph contours in up/down segments for skylines - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/26 !24 Cache the name => index lookup in Open_type_font - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/24 !20 Add regtest for multiple post-events wrapper behavior - Valentin Villenave https://gitlab.com/lilypond/lilypond/-/merge_requests/20 !3 Add dynamic-interface to keepAliveInterfaces - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/3 Countdown: !39 cleanup span-bar-engraver.cc - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/39 !22 Doc: remove now unnecessary dummy argument after lilypond -dshow-available-fonts - Jean Abou Samra https://gitlab.com/lilypond/lilypond/-/merge_requests/22 Review: !43 Fix #5234: Avoid writing a MIDI file when there is no music - Dan Eble https://gitlab.com/lilypond/lilypond/-/merge_requests/43 !42 Resolve "(*location*) returning no valid value while parsing embedded scheme" - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/42 !41 Issue 5129: Bad horizontal spacing when \override LyricText #'X-offset - Kevin Barry https://gitlab.com/lilypond/lilypond/-/merge_requests/41 !38 GNUmakefile.in: remove remove-test-changed support - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/38 New: !50 Remove some ancient long-unused cruft - David Kastrup https://gitlab.com/lilypond/lilypond/-/merge_requests/50 !49 Remove operator= from Scheme_hash_table - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/49 !48 skyline: minor performance tweaks - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/48 !47 Stop smobifying Transform - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/47 !46 Clean up and fix glyph contour generation - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/46 !45 Remove do_break_substitution_and_fixup_refpoints() from System API - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/45 !44 Change ly_chain_assoc_get to use eq? - Han-Wen Nienhuys https://gitlab.com/lilypond/lilypond/-/merge_requests/44 Waiting: No patches in Waiting at this time. *** Regards, James
PATCHES - Countdown for May 17th
Hello, Here is the current patch countdown list. The next countdown will be on May 19th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: No patches to push at this time. Countdown: No patches on countdown at this time. Review: No patches in review at this time New: 5518 Document bound-details (sub-)properties in line-spanner-cc for IR - Thomas Morley https://sourceforge.net/p/testlilyissues/issues/5518 http://codereview.appspot.com/560670043 *** Regards, James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCHES - Countdown for May 17th
Hello, Here is the current patch countdown list. The next countdown will be on May 19th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: No patches to push at this time. Countdown: No patches on countdown at this time. Review: No patches in review at this time New: 5518 Document bound-details (sub-)properties in line-spanner-cc for IR - Thomas Morley https://sourceforge.net/p/testlilyissues/issues/5518 http://codereview.appspot.com/560670043 *** Regards, James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCHES - Countdown for May 17th
Hello, Here is the current patch countdown list. The next countdown will be on May 20th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5321 Parser: E_BACKSLASH should be two backslashes - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5321 http://codereview.appspot.com/341250043 5320 beam.cc: avoid calculating an invalid reference - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5320 http://codereview.appspot.com/343160043 Countdown: 5322 simplify logging with an optional input location - Dan Eble https://sourceforge.net/p/testlilyissues/issues/5322 http://codereview.appspot.com/341270043 5318 Context regression tests - Dan Eble https://sourceforge.net/p/testlilyissues/issues/5318 http://codereview.appspot.com/348760043 4807 Wrong glissando slopes with accidental in target chord - Malte Meyn https://sourceforge.net/p/testlilyissues/issues/4807 http://codereview.appspot.com/342100043 Review: No patches in Review at this time. New: No new patches at this time. Regards James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCHES - Countdown for May 17th
Am 17.05.2017 um 09:12 schrieb James: > Hello, > > Here is the current patch countdown list. The next countdown will be on > May 20th. > > A quick synopsis of all patches currently in the review process can be > found here: > > http://philholmes.net/lilypond/allura/ > > > > > Push: No patches in Push at this time. > > > Countdown: No patches in Countdown at this time. > > > Review: No patches in Review at this time. > > > New: No New patches at this time. DOH! ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCHES - Countdown for May 17th
Hello, Here is the current patch countdown list. The next countdown will be on May 20th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: No patches in Push at this time. Countdown: No patches in Countdown at this time. Review: No patches in Review at this time. New: No New patches at this time. Regards James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCHES: Countdown for May 17th
Hello, Here is the current patch countdown list. The next countdown will be on May 20th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ __ Push: 4845 lilypond-ftplugin.vim: set makeprg locally rather than globally - gregrs-uk https://sourceforge.net/p/testlilyissues/issues/4845 http://codereview.appspot.com/292660043 Countdown: 4851 Scheme_engraver::init_acknowledgers API change - dakas https://sourceforge.net/p/testlilyissues/issues/4851 http://codereview.appspot.com/291690043 Review: No patches in Review at this time. New: 4855 Move old news from news-front to news - u-li-1973 https://sourceforge.net/p/testlilyissues/issues/4855 http://codereview.appspot.com/297300043 4854 Set minimum size dots for text spanner to be round. - cds4byu https://sourceforge.net/p/testlilyissues/issues/4854 http://codereview.appspot.com/295210043 James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
