Re: Gets rid of PostScript inbar-chords-notation-for-guitar--with-text-spanner.ly (issue 5529048)
- Original Message - From: gra...@percival-music.ca To: mts...@gmail.com Cc: re...@codereview-hr.appspotmail.com; lilypond-devel@gnu.org Sent: Monday, January 09, 2012 5:14 AM Subject: Re: Gets rid of PostScript inbar-chords-notation-for-guitar--with-text-spanner.ly (issue 5529048) LGTM I'm vaguely curious as to what's the difference between this postscript and the regtest for postscript, but that's no reason to hold up development. Besides, the lilypond markup is easier to understand than the postscript, so this is a good change to make even if it wasn't a build problem. http://codereview.appspot.com/5529048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel Whoah. This is changes to snippets in the snippet directory. It actually looks like the only substantive change if with the Documentation/snippets/bar-chords-notation-for-guitar--with-text-spanner.ly which is duplicated in snippets/new. Mike - you only need to edit the one in snippets/new - the other should be updated in the LSR, and it will appear in snippets/ when an LSR import is run. However, the snippets/new one takes priority so it shouldn't make ant difference when this is done. If this sounds right - I can do the edit and will do the import at some time. There's also 3 other files with essentially null changes to them - might be a cleaner patch if you get rid of these. I think only Graham can comment on this - could you confirm, please, GP? -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Gets rid of PostScript inbar-chords-notation-for-guitar--with-text-spanner.ly (issue 5529048)
On Mon, 9 Jan 2012 14:24:45 -, Phil Holmes wrote: - Original Message - From: gra...@percival-music.ca To: mts...@gmail.com Cc: re...@codereview-hr.appspotmail.com; lilypond-devel@gnu.org Sent: Monday, January 09, 2012 5:14 AM Subject: Re: Gets rid of PostScript inbar-chords-notation-for-guitar--with-text-spanner.ly (issue 5529048) LGTM I'm vaguely curious as to what's the difference between this postscript and the regtest for postscript, but that's no reason to hold up development. Besides, the lilypond markup is easier to understand than the postscript, so this is a good change to make even if it wasn't a build problem. http://codereview.appspot.com/5529048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel Whoah. This is changes to snippets in the snippet directory. It actually looks like the only substantive change if with the Documentation/snippets/bar-chords-notation-for-guitar--with-text-spanner.ly which is duplicated in snippets/new. Mike - you only need to edit the one in snippets/new - the other should be updated in the LSR, and it will appear in snippets/ when an LSR import is run. However, the snippets/new one takes priority so it shouldn't make ant difference when this is done. Hey Phil, I only changed the one in snippets new and then ran scripts/auxiliar/makelsr.py (this is the procedure specified in the CG). Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Gets rid of PostScript inbar-chords-notation-for-guitar--with-text-spanner.ly (issue 5529048)
On Mon, Jan 09, 2012 at 02:24:45PM -, Phil Holmes wrote: It actually looks like the only substantive change if with the Documentation/snippets/bar-chords-notation-for-guitar--with-text-spanner.ly which is duplicated in snippets/new. Mike - you only need to edit the one in snippets/new - the other should be updated in the LSR, and it will appear in snippets/ when an LSR import is run. Correct in general, but the overall goal is to let Mike build the docs again. As such, I think it's appropriate to dump the change in snippets/new/ and run makelsr himself. If this was just a doc clarification, then I'd suggest it be done the other way. If this sounds right - I can do the edit and will do the import at some time. There's also 3 other files with essentially null changes to them - might be a cleaner patch if you get rid of these. Yes... the git history would be slightly more clear if he did a local makelsr, then changed the one file in snippets/new/, then did another local makelsr. But in this case I didn't think it was worth asking for that level of bureaucracy. - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
