Re: LSR and Documentation/snippets/new
Am Mi., 11. Mai 2022 um 23:24 Uhr schrieb Thomas Morley : > > Am Di., 10. Mai 2022 um 00:27 Uhr schrieb Werner LEMBERG : > > > > > > >> All snippets are updated. > > > > > > Thanks a lot, Harm! > > > > +1. Good job! > > > > > > Werner > > The following snippets from Documentation/snippets/new (compiling with > 2.22. and not previously in LSR) are now in LSR: > aiken-head-thin-variant-noteheads.ly > ambitus-after-key-signature.ly > analysis-brackets-with-labels.ly > automatic-fretboards-barre.ly > measure-spanner.ly > moving-the-ends-of-hairpins.ly > replacing-default-midi-instrument-equalization.ly > turkish-makam-example.ly > user-defined-time-signatures.ly > > In their descriptions the texinfo-tags needed to be changed to > html-tags. For two snippets I'm not exactly sure, whether I did it > correctly > Werner, may I ask you to take a look? > ambitus-after-key-signature.ly > https://lsr.di.unimi.it/LSR/Item?u=1=1142 > and > using-marklines-in-a-frenched-score.ly > https://lsr.di.unimi.it/LSR/Item?u=1=1150 > > Next steps: > (1) Remove above files from Documentation/snippets/new > (2) Remove files from Documentation/snippets/new which are now already > in LSR (note to self: check that, before removing) > (3) Commit above > (4) Run and commit the results of makelsr.py > > Cheers, > Harm patch at: https://gitlab.com/lilypond/lilypond/-/merge_requests/1360 Cheers, Harm
Re: LSR and Documentation/snippets/new
Am Sa., 7. Mai 2022 um 00:36 Uhr schrieb Thomas Morley
:
>
> Folks,
>
> currently I'm updating all LSR-files to work with 2.22.
> One step is
> CG 7.7 Updating the LSR to a new version
> [...]
> 5. Copy relevant snippets (i.e. snippets whose version is equal to or
> less than the new version of LilyPond running on the LSR) from
> ‘Documentation/snippets/new/’ into the set of files to be used to make
> the tarball.
> [...]
>
> I've found that the majority of those files in
> ‘Documentation/snippets/new/’ _don't_ _need_ to_ _be_ there_!
> They could have been changed through LSR's web-interface.
> Changing \set instrumentName ... to \with { instrumentName ... }
> worked forever (more or less). Code cleanup for empty lines (missing
> or superfluous), code indentation, etc, etc
>
> Nothing of above warrants a new snippet.
>
> Please stop doing so, please first test, whether it compiles with
> current LSR-version, and please update the snippet _inside_ LSR. If
> you don't have an account please create one. Or please ask me, Pierre,
> Werner and others with permission to do so.
>
>
> Otherwise it exents the workload of the LSR-updater, not pretty for my
> motivation... LSR has currently already 896 files to be maintained!
And, please, _never ever_ introduce a snippet with not matching
doctitle/filename.
Thanks,
Harm
Re: LSR and Documentation/snippets/new
Am Sa., 14. Mai 2022 um 09:31 Uhr schrieb Sebastiano Vigna : > > > > > On 13 May 2022, at 22:43, Thomas Morley wrote: > > > > > > I spoke too early... > > In the tarball the snippets still print \version "2.18.0", although > > they are compiled with 2.22. > > Please have a look. > > > > Yep, I forgot to update the version string in the Constants Java class. Fixed. > > Ciao, > > seba > Works now. Thanks, Harm
Re: LSR and Documentation/snippets/new
> On 13 May 2022, at 22:43, Thomas Morley wrote: > > > I spoke too early... > In the tarball the snippets still print \version "2.18.0", although > they are compiled with 2.22. > Please have a look. > Yep, I forgot to update the version string in the Constants Java class. Fixed. Ciao, seba
Re: LSR and Documentation/snippets/new
Am Mo., 9. Mai 2022 um 23:45 Uhr schrieb Thomas Morley : > LSR-software is running 2.22. > Last LSR-problem I'm aware of (see above) is fixed. Hi Seba, I spoke too early... In the tarball the snippets still print \version "2.18.0", although they are compiled with 2.22. Please have a look. Thanks, Harm
Re: LSR and Documentation/snippets/new
Am Di., 10. Mai 2022 um 00:27 Uhr schrieb Werner LEMBERG : > > > >> All snippets are updated. > > > > Thanks a lot, Harm! > > +1. Good job! > > > Werner The following snippets from Documentation/snippets/new (compiling with 2.22. and not previously in LSR) are now in LSR: aiken-head-thin-variant-noteheads.ly ambitus-after-key-signature.ly analysis-brackets-with-labels.ly automatic-fretboards-barre.ly measure-spanner.ly moving-the-ends-of-hairpins.ly replacing-default-midi-instrument-equalization.ly turkish-makam-example.ly user-defined-time-signatures.ly In their descriptions the texinfo-tags needed to be changed to html-tags. For two snippets I'm not exactly sure, whether I did it correctly Werner, may I ask you to take a look? ambitus-after-key-signature.ly https://lsr.di.unimi.it/LSR/Item?u=1=1142 and using-marklines-in-a-frenched-score.ly https://lsr.di.unimi.it/LSR/Item?u=1=1150 Next steps: (1) Remove above files from Documentation/snippets/new (2) Remove files from Documentation/snippets/new which are now already in LSR (note to self: check that, before removing) (3) Commit above (4) Run and commit the results of makelsr.py Cheers, Harm
Re: LSR and Documentation/snippets/new
>> All snippets are updated. > > Thanks a lot, Harm! +1. Good job! Werner
Re: LSR and Documentation/snippets/new
Le 09/05/2022 à 23:45, Thomas Morley a écrit : Current state: LSR-software is running 2.22. Last LSR-problem I'm aware of (see above) is fixed. All snippets are updated. Thanks Seba! Additionally I (corrected and) approved all so far unapproved snippets (one exception). Next steps: work on ‘Documentation/snippets/new/’ as adviced in CG Thanks a lot, Harm! Cheers, Jean
Re: LSR and Documentation/snippets/new
Am Sa., 7. Mai 2022 um 16:46 Uhr schrieb Thomas Morley : > > Am Sa., 7. Mai 2022 um 16:03 Uhr schrieb Thomas Morley > : > > > > Am Sa., 7. Mai 2022 um 14:13 Uhr schrieb Werner LEMBERG : > > > > > > > > > >> I think it's not really used at the moment because the LilyPond > > > >> version is 8 years old. I at least will definitely use it more when > > > >> it gets updated to 2.22. > > > > > > > > It has been already updated. > > > > > > This is excellent news! However, > > > > > > https://lsr.di.unimi.it/LSR/html/contributing.html > > > > > > still says > > > > > > The LSR is currently running LilyPond version 2.18.2. > > > > > > An oversight? > > > > > > > The snippets haven't tho. > > > > > > It seems that Harm is actively working on this. > > > > > > > > > Werner > > > > Yep, currently running the final test... > > Hi Sebastiano, > > attached a tarball with the updated snippets, based on > lsr-snippets-all-2022-05-06.tar.gz. They are in the all-folder, other > folders are untouched. > Everything's working on my machine. > > Btw, if I edit a snippet through the lsr-web-interface, the 'preview' > is sort of broken. Meaning, the image based on the modified code is > not immediately changed as it used to be, but the next day. > Could you have a look? > > Thansk, > Harm Current state: LSR-software is running 2.22. Last LSR-problem I'm aware of (see above) is fixed. All snippets are updated. Thanks Seba! Additionally I (corrected and) approved all so far unapproved snippets (one exception). Next steps: work on ‘Documentation/snippets/new/’ as adviced in CG Cheers, Harm
Re: LSR and Documentation/snippets/new
Am Sa., 7. Mai 2022 um 14:13 Uhr schrieb Werner LEMBERG : > > > >> I think it's not really used at the moment because the LilyPond > >> version is 8 years old. I at least will definitely use it more when > >> it gets updated to 2.22. > > > > It has been already updated. > > This is excellent news! However, > > https://lsr.di.unimi.it/LSR/html/contributing.html > > still says > > The LSR is currently running LilyPond version 2.18.2. > > An oversight? > > > The snippets haven't tho. > > It seems that Harm is actively working on this. > > > Werner Yep, currently running the final test...
Re: LSR and Documentation/snippets/new
> On 7 May 2022, at 13:13, Werner LEMBERG wrote: > > >>> I think it's not really used at the moment because the LilyPond >>> version is 8 years old. I at least will definitely use it more when >>> it gets updated to 2.22. >> >> It has been already updated. > > This is excellent news! However, > > https://lsr.di.unimi.it/LSR/html/contributing.html Too many things to remember! Fixed. I should write down a procedure for the update. Or make that dynamic and dependent on the installed version. Ciao, seba
Re: LSR and Documentation/snippets/new
>> I think it's not really used at the moment because the LilyPond >> version is 8 years old. I at least will definitely use it more when >> it gets updated to 2.22. > > It has been already updated. This is excellent news! However, https://lsr.di.unimi.it/LSR/html/contributing.html still says The LSR is currently running LilyPond version 2.18.2. An oversight? > The snippets haven't tho. It seems that Harm is actively working on this. Werner
Re: LSR and Documentation/snippets/new
On May 7, 2022 11:04:41 AM GMT+01:00, Jean Abou Samra wrote: >I think it's not really used at the moment because the LilyPond >version is 8 years old. I at least will definitely use it more when >it gets updated to 2.22. It has been already updated. The snippets haven't tho. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
Re: LSR and Documentation/snippets/new
Le 07/05/2022 à 11:44, Sebastiano Vigna a écrit : On 7 May 2022, at 09:30, Jean Abou Samra wrote: - What is the LSR's bus factor? As far as I can see, 1, since while Sebastiano was inactive it remained stuck in 2.18 (I for one thought it was dead and buried, I stopped interacting with it because making snippets compatible with 2.18 was extra work, and I'm seldom seeing links to it on mailing lists these days), True, my fault. I'll try to be more responsive in the future. In this round I have revamped a lot of things that I was terrified to touch with a ten foot pole, as I thought they would break (it's been almost 20 years). "I'll try to be more responsive in the future" is appreciated, but not what I'm trying to invite. Everyone has their job, life, worries etc. Infrastructure relying on a single person is bound to know periods of bitrot. How about finding other people to share administration of the LSR? - What can be done to increase this bus factor? Well, if you see it's not really used, we can make it go to infinity by shutting it down... I think it's not really used at the moment because the LilyPond version is 8 years old. I at least will definitely use it more when it gets updated to 2.22. Jean
Re: LSR and Documentation/snippets/new
Fwiw, I like it, there's all sorts of weird edge cases in there that on occasion are quite handy L On Sat, 7 May 2022, 11:45 Sebastiano Vigna, wrote: > > > On 7 May 2022, at 09:30, Jean Abou Samra wrote: > > > > - What is the LSR's bus factor? As far as I can see, 1, > > since while Sebastiano was inactive it remained stuck > > in 2.18 (I for one thought it was dead and buried, > > I stopped interacting with it because making snippets > > compatible with 2.18 was extra work, and I'm seldom > > seeing links to it on mailing lists these days), > > True, my fault. I'll try to be more responsive in the future. In this > round I have revamped a lot of things that I was terrified to touch with a > ten foot pole, as I thought they would break (it's been almost 20 years). > > > > > - What can be done to increase this bus factor? > > Well, if you see it's not really used, we can make it go to infinity by > shutting it down... > > Ciao, > > seba > > >
Re: LSR and Documentation/snippets/new
> On 7 May 2022, at 09:30, Jean Abou Samra wrote: > > - What is the LSR's bus factor? As far as I can see, 1, > since while Sebastiano was inactive it remained stuck > in 2.18 (I for one thought it was dead and buried, > I stopped interacting with it because making snippets > compatible with 2.18 was extra work, and I'm seldom > seeing links to it on mailing lists these days), True, my fault. I'll try to be more responsive in the future. In this round I have revamped a lot of things that I was terrified to touch with a ten foot pole, as I thought they would break (it's been almost 20 years). > > - What can be done to increase this bus factor? Well, if you see it's not really used, we can make it go to infinity by shutting it down... Ciao, seba
Re: LSR and Documentation/snippets/new
Le 07/05/2022 à 01:42, Thomas Morley a écrit : Am Sa., 7. Mai 2022 um 00:36 Uhr schrieb Thomas Morley : currently I'm updating all LSR-files to work with 2.22. Btw, current state: I converted all lsr-snippets to 2.22., inserted those from Documentation/snippets/new, fixed all crashes and most warnings: No ERRORs Some 'programming error's for engravers-one-by-one.ly, on purpose, won't surpress. Some warnings for 'combining-two-parts-on-the-same-staff.ly' and 'shortening-volta-brackets.ly'. Likely (long standing) bugs, won't fix. I.e. close to finish :) Congrats! Now that this is about done, there's a couple questions I'd like to raise, which may be a little unpleasant but in my opinion are essential: - What is the LSR's bus factor? As far as I can see, 1, since while Sebastiano was inactive it remained stuck in 2.18 (I for one thought it was dead and buried, I stopped interacting with it because making snippets compatible with 2.18 was extra work, and I'm seldom seeing links to it on mailing lists these days), - What can be done to increase this bus factor? Best, Jean
Re: LSR and Documentation/snippets/new
>> currently I'm updating all LSR-files to work with 2.22. > > Btw, current state: > I converted all lsr-snippets to 2.22., inserted those from > Documentation/snippets/new, fixed all crashes and most warnings: > > No ERRORs > Some 'programming error's for engravers-one-by-one.ly, on purpose, > won't surpress. > Some warnings for 'combining-two-parts-on-the-same-staff.ly' and > 'shortening-volta-brackets.ly'. Likely (long standing) bugs, won't > fix. > > I.e. close to finish :) Excellent, thanks! Werner
Re: LSR and Documentation/snippets/new
Am Sa., 7. Mai 2022 um 00:36 Uhr schrieb Thomas Morley : > currently I'm updating all LSR-files to work with 2.22. Btw, current state: I converted all lsr-snippets to 2.22., inserted those from Documentation/snippets/new, fixed all crashes and most warnings: No ERRORs Some 'programming error's for engravers-one-by-one.ly, on purpose, won't surpress. Some warnings for 'combining-two-parts-on-the-same-staff.ly' and 'shortening-volta-brackets.ly'. Likely (long standing) bugs, won't fix. I.e. close to finish :) Cheers, Harm
Re: LSR and Documentation/snippets/new
Am Sa., 7. Mai 2022 um 00:46 Uhr schrieb David Kastrup : > > Thomas Morley writes: > > > Please stop doing so, please first test, whether it compiles with > > current LSR-version, and please update the snippet _inside_ LSR. If > > you don't have an account please create one. Or please ask me, Pierre, > > Werner and others with permission to do so. > > > > > > Otherwise it exents the workload of the LSR-updater, not pretty for my > > motivation... LSR has currently already 896 files to be maintained! > > > > We should make this a policy, even more prominent as currently. > > "even more prominent"? How is this prominent at all right now? > > -- > David Kastrup In CG 7. LSR work: 7.2 Adding and editing snippets If a new snippet created for documentation purposes compiles with LilyPond version currently on LSR, it should be added to LSR [...] If the new snippet uses new features that are not available in the current LSR version, the snippet should be added to ‘Documentation/snippets/new’ [...] This is obviously inside the LSR-section. "More prominent" probably means to clearify it as well in sections like 5. Documentation work and 10. Programming work Maybe others as well. Cheers, Harm
Re: LSR and Documentation/snippets/new
> On May 6, 2022, at 18:46, David Kastrup wrote: > > Thomas Morley writes: > >> Please stop doing so, please first test, whether it compiles with >> current LSR-version, and please update the snippet _inside_ LSR. If >> you don't have an account please create one. Or please ask me, Pierre, >> Werner and others with permission to do so. >> >> >> Otherwise it exents the workload of the LSR-updater, not pretty for my >> motivation... LSR has currently already 896 files to be maintained! >> >> We should make this a policy, even more prominent as currently. > > "even more prominent"? How is this prominent at all right now? I have found the instructions on dealing with snippets in the CG difficult to interpret. There's a lot of text and — in my experience — it has not been clear how to apply it when making specific changes to LilyPond. I have tried. — Dan
Re: LSR and Documentation/snippets/new
Thomas Morley writes: > Please stop doing so, please first test, whether it compiles with > current LSR-version, and please update the snippet _inside_ LSR. If > you don't have an account please create one. Or please ask me, Pierre, > Werner and others with permission to do so. > > > Otherwise it exents the workload of the LSR-updater, not pretty for my > motivation... LSR has currently already 896 files to be maintained! > > We should make this a policy, even more prominent as currently. "even more prominent"? How is this prominent at all right now? -- David Kastrup
