Re: Remove all uses of markup macro from scm/*.scm (issue 575930043 by d...@gnu.org)
On 2020/04/03 23:27:47, dak wrote: > On 2020/04/03 22:22:31, hanwenn wrote: > > note that this still doesn't fix the next error message for compilation which > is > > > > > > > > fatal error: Not a markup command: line > > > > which is triggered by the *definition* of the markup macro: > > > > (defmacro*-public markup (#:rest body) > > .. > > (car (compile-all-markup-expressions `(#:line ,body > > > > the markup compilation tries to lookup the 'line' markup dynamically, and > fails. > > I propose to leave this new but related piece of crock for the next issue as it > seems a bit more involved and warrants separate analysis, testing and fixing. I fully agree, I just wanted to register my insight. https://codereview.appspot.com/575930043/
Re: Remove all uses of markup macro from scm/*.scm (issue 575930043 by d...@gnu.org)
On 2020/04/03 22:22:31, hanwenn wrote: > note that this still doesn't fix the next error message for compilation which is > > > > fatal error: Not a markup command: line > > which is triggered by the *definition* of the markup macro: > > (defmacro*-public markup (#:rest body) > .. > (car (compile-all-markup-expressions `(#:line ,body > > the markup compilation tries to lookup the 'line' markup dynamically, and fails. I propose to leave this new but related piece of crock for the next issue as it seems a bit more involved and warrants separate analysis, testing and fixing. https://codereview.appspot.com/575930043/
Re: Remove all uses of markup macro from scm/*.scm (issue 575930043 by d...@gnu.org)
note that this still doesn't fix the next error message for compilation which is fatal error: Not a markup command: line which is triggered by the *definition* of the markup macro: (defmacro*-public markup (#:rest body) .. (car (compile-all-markup-expressions `(#:line ,body the markup compilation tries to lookup the 'line' markup dynamically, and fails. https://codereview.appspot.com/575930043/
Re: Remove all uses of markup macro from scm/*.scm (issue 575930043 by d...@gnu.org)
https://codereview.appspot.com/575930043/diff/561620044/scm/time-signature.scm File scm/time-signature.scm (right): https://codereview.appspot.com/575930043/diff/561620044/scm/time-signature.scm#newcode23 scm/time-signature.scm:23: (mup (if (procedure? proc) On 2020/03/30 21:15:15, hanwenn wrote: > nitpick: how about 'fraction-markup' or 'fraction' ? Done. Strictly speaking, the change was likely not necessary in the first place, but I'd hate keeping (markup ... around in a file, even though it means something entirely different here. https://codereview.appspot.com/575930043/diff/561620044/scm/titling.scm File scm/titling.scm (right): https://codereview.appspot.com/575930043/diff/561620044/scm/titling.scm#newcode102 scm/titling.scm:102: (mup (ly:output-def-lookup layout what))) On 2020/03/30 21:15:15, hanwenn wrote: > title-markup ? > Done. https://codereview.appspot.com/575930043/
Re: Remove all uses of markup macro from scm/*.scm (issue 575930043 by d...@gnu.org)
thanks! Harm, the changes only need to be done in .scm, because it's only those files that we'd be precompiling https://codereview.appspot.com/575930043/diff/561620044/scm/time-signature.scm File scm/time-signature.scm (right): https://codereview.appspot.com/575930043/diff/561620044/scm/time-signature.scm#newcode23 scm/time-signature.scm:23: (mup (if (procedure? proc) nitpick: how about 'fraction-markup' or 'fraction' ? https://codereview.appspot.com/575930043/diff/561620044/scm/titling.scm File scm/titling.scm (right): https://codereview.appspot.com/575930043/diff/561620044/scm/titling.scm#newcode102 scm/titling.scm:102: (mup (ly:output-def-lookup layout what))) title-markup ? https://codereview.appspot.com/575930043/
Re: Remove all uses of markup macro from scm/*.scm (issue 575930043 by d...@gnu.org)
LGTM https://codereview.appspot.com/575930043/
Remove all uses of markup macro from scm/*.scm (issue 575930043 by d...@gnu.org)
patch itself LGTM Ofcourse there are other folders than scm/*.scm, like snippets, snippets/new, ly-examples, Documentation... Follow up planned? https://codereview.appspot.com/575930043/
