Re: Remove thin-kern property. (issue 105560044 by markpole...@gmail.com)
Am 08.07.2014 20:20, schrieb markpole...@gmail.com: marc wrote: OK, but 'thin-kern does not seem to be an appropriate name for this property anymore IMHO. How about 'segno-kern? (patch updated accordingly) Much better! ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Remove thin-kern property. (issue 105560044 by markpole...@gmail.com)
Am 08.07.2014 02:17, schrieb Paul Morris: Thomas Morley-2 wrote But *do* we need two different variables which then are used with exactly the same value? Do we need the option to change the distance of the segno double bar line? I'd say yes. I'm always against loosing functionality, and deleting 'thin-kern would limit the tweaking-possibilities. +1 OK, but 'thin-kern does not seem to be an appropriate name for this property anymore IMHO. Marc ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Remove thin-kern property. (issue 105560044 by markpole...@gmail.com)
marc wrote: OK, but 'thin-kern does not seem to be an appropriate name for this property anymore IMHO. How about 'segno-kern? (patch updated accordingly) https://codereview.appspot.com/105560044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Remove thin-kern property. (issue 105560044 by markpole...@gmail.com)
On 2014/07/07 01:31:01, Mark Polesky wrote: On 2014/07/06 11:52:56, thomasmorley651 wrote: I disagree! 'kern and 'thin-kern _are_ used differently. But *do* we need two different variables which then are used with exactly the same value? Do we need the option to change the distance of the segno double bar line? IIRC, this is a leftover from the bar line reorganisation work, the double bar line || was formerly spaced with 'thin-kern as well, but as we implemented the stacking algorithm for bar lines, all constituents are now spaced with 'kern. I'd remove 'thin-kern entirely. In case someone wants to modify the appearance of the segno symbol, he can use a multiplier and create his own stencil easily. Okay, so then it's just a question of clarifying the misleading docstrings. How about this? kern The space between individual elements in any compound bar line. thin-kern The space between the two thin lines of the segno bar line symbol. I've updated the patch accordingly. https://codereview.appspot.com/105560044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Remove thin-kern property. (issue 105560044 by markpole...@gmail.com)
On 2014/07/07 07:25:15, marc wrote: On 2014/07/07 01:31:01, Mark Polesky wrote: On 2014/07/06 11:52:56, thomasmorley651 wrote: I disagree! 'kern and 'thin-kern _are_ used differently. But *do* we need two different variables which then are used with exactly the same value? Do we need the option to change the distance of the segno double bar line? I'd say yes. I'm always against loosing functionality, and deleting 'thin-kern would limit the tweaking-possibilities. IIRC, this is a leftover from the bar line reorganisation work, the double bar line || was formerly spaced with 'thin-kern as well, but as we implemented the stacking algorithm for bar lines, all constituents are now spaced with 'kern. Yep I'd remove 'thin-kern entirely. In case someone wants to modify the appearance of the segno symbol, he can use a multiplier and create his own stencil easily. It's very easy to create custom-bar-lines nowadays -- for us! Though, I doubt the average user has the scheme-knowledge to do so. In the NR we don't explain how to code new barline-procedures like `make-segno-bar-line' (only the hint to look into bar-line.scm) and afaik nowhere else. There's a regtest doing so, but we don't expect users to look there. Until we can come up with an interface to create new barline-procedures, which is much easier for the average user (although I've no clue right now, how it should look), we should keep all tweaking/overriding possibilities, imho. https://codereview.appspot.com/105560044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Remove thin-kern property. (issue 105560044 by markpole...@gmail.com)
Thomas Morley-2 wrote But *do* we need two different variables which then are used with exactly the same value? Do we need the option to change the distance of the segno double bar line? I'd say yes. I'm always against loosing functionality, and deleting 'thin-kern would limit the tweaking-possibilities. +1 -Paul -- View this message in context: http://lilypond.1069038.n5.nabble.com/Remove-thin-kern-property-issue-105560044-by-markpolesky-gmail-com-tp164053p164144.html Sent from the Dev mailing list archive at Nabble.com. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Remove thin-kern property. (issue 105560044 by markpole...@gmail.com)
Reviewers: ,
Message:
Hi, I'm proposing to get rid of the BarLine.thin-kern property with this
patch, so if you're opposed, let me know.
You can see my comments/rationale here:
http://code.google.com/p/lilypond/issues/detail?id=3995
Thanks,
Mark
Description:
This removes the thin-kern property, and adds a convert-ly rule to
convert `thin-kern' to `kern', since kern does what thin-kern claimed to
do anyway, and thin-kern (AFAICT) does nothing.
See http://code.google.com/p/lilypond/issues/detail?id=3995
Please review this at https://codereview.appspot.com/105560044/
Affected files (+11, -9 lines):
M python/convertrules.py
M scm/bar-line.scm
M scm/define-grob-interfaces.scm
M scm/define-grob-properties.scm
M scm/define-grobs.scm
Index: python/convertrules.py
diff --git a/python/convertrules.py b/python/convertrules.py
index
5eb2a75bfc4f17bbcea91068518c2e928b502d99..aeb9384a5529423e8e7f279e8ce41183993d7769
100644
--- a/python/convertrules.py
+++ b/python/convertrules.py
@@ -3450,7 +3450,7 @@ def conv (str):
if m.group (1):
return m.group (0)
x = m.group (2) + m.group (4)
-
+
if m.group (3):
x = x + re.sub (r(\s*)( + symbol_list + ), fn_path_replace,
m.group (3))
@@ -3718,6 +3718,11 @@ def conv(str):
str = re.sub (r'\blocalKeySignature\b', 'localAlterations', str)
return str
+@rule ((2, 19, 10), thin-kern - kern)
+def conv(str):
+str = re.sub (r'\bthin-kern\b', 'kern', str)
+return str
+
# Guidelines to write rules (please keep this at the end of this file)
#
# - keep at most one rule per version; if several conversions should be
done,
Index: scm/bar-line.scm
diff --git a/scm/bar-line.scm b/scm/bar-line.scm
index
ff2d3f29b4a35d30cee581fa8f31ac096b06acb5..77c41f5cc04973c85c092e03ad6d96a98618b2ef
100644
--- a/scm/bar-line.scm
+++ b/scm/bar-line.scm
@@ -440,14 +440,14 @@ is not used within the routine.
the segno sign is drawn over the double bar line; otherwise, it
draws the span bar variant, i.e. without the segno sign.
(let* ((line-thickness (layout-line-thickness grob))
- (thinkern (* (ly:grob-property grob 'thin-kern 1) line-thickness))
+ (kern (* (ly:grob-property grob 'kern 1) line-thickness))
(thin-stil (make-simple-bar-line grob extent))
(double-line-stil (ly:stencil-combine-at-edge
thin-stil
X
LEFT
thin-stil
-thinkern))
+kern))
(segno (ly:font-get-glyph (ly:grob-default-font grob)
scripts.varsegno))
(stencil (ly:stencil-add
@@ -459,7 +459,7 @@ draws the span bar variant, i.e. without the segno
sign.
(cons 0 0)))
(ly:stencil-translate-axis
double-line-stil
-(* 1/2 thinkern)
+(* 1/2 kern)
X
stencil))
Index: scm/define-grob-interfaces.scm
diff --git a/scm/define-grob-interfaces.scm b/scm/define-grob-interfaces.scm
index
4ffd761607c788feef67edba4b1b1e5522bf78fb..7e5fa2283f29678d788ba9cc7d92eb2ea7d4536a
100644
--- a/scm/define-grob-interfaces.scm
+++ b/scm/define-grob-interfaces.scm
@@ -59,7 +59,6 @@ found in @file{scm/bar-line.scm}.
has-span-bar
kern
rounded
- thin-kern
thick-thickness))
(ly:add-interface
Index: scm/define-grob-properties.scm
diff --git a/scm/define-grob-properties.scm b/scm/define-grob-properties.scm
index
24e8e3298abeb0d93607832d0d1422b757e83c8d..be82bd1c0c3061777bbb8e4f37457d09d9267231
100644
--- a/scm/define-grob-properties.scm
+++ b/scm/define-grob-properties.scm
@@ -531,8 +531,8 @@ slur quants to this position, and print the respective
scores.)
;;;
(keep-inside-line ,boolean? If set, this column cannot have
objects sticking into the margin.)
- (kern ,ly:dimension? Amount of extra white space to add. For
-bar lines, this is the amount of space after a thick line.)
+ (kern ,ly:dimension? The space between bar lines in any type
+of double bar)
(knee ,boolean? Is this beam kneed?)
(knee-spacing-correction ,number? Factor for the optical
correction amount for kneed beams. Set between @code{0} for no
@@ -969,7 +969,6 @@ should use @code{LEFT}.)
@code{line-thickness}.)
(thickness ,number? Line thickness, generally measured in
@code{line-thickness}.)
- (thin-kern ,number? The space after a hair-line in a bar line.)
(tie-configuration ,list? List of @code{(@var{position} .
@var{dir})} pairs, indicating the desired tie configuration, where
@var{position} is the offset from the center of the staff in staff
Index: scm/define-grobs.scm
diff --git a/scm/define-grobs.scm b/scm/define-grobs.scm
index
ddacbcb7ec1131864197462b77ef59f7dca37b4b..c6dbd325d862ab42bc1efe35a610410dfdcb950f
Re: Remove thin-kern property. (issue 105560044 by markpole...@gmail.com)
On 2014/07/06 06:46:53, Mark Polesky wrote: Hi, I'm proposing to get rid of the BarLine.thin-kern property with this patch, so if you're opposed, let me know. You can see my comments/rationale here: http://code.google.com/p/lilypond/issues/detail?id=3995 Thanks, Mark I don't see any reason to maintain two different types of kern that are never used independently, so LGTM. https://codereview.appspot.com/105560044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Remove thin-kern property. (issue 105560044 by markpole...@gmail.com)
On 2014/07/06 06:46:53, Mark Polesky wrote:
Hi, I'm proposing to get rid of the BarLine.thin-kern property with
this patch,
so if you're opposed, let me know.
You can see my comments/rationale here:
http://code.google.com/p/lilypond/issues/detail?id=3995
Thanks,
Mark
I disagree!
'kern and 'thin-kern _are_ used differently.
Look at the output from:
\version 2.19.8
\paper { ragged-right = ##f }
{
a'1
\mark default
\bar :|.S
b'
\once \override Staff.BarLine #'kern = #10
\mark 'kern 10
\bar :|.S
c'
\once \override Staff.BarLine #'thin-kern = #10
\mark 'thin-kern 10
\bar :|.S
d'
\once \override Staff.BarLine #'kern = #10
\once \override Staff.BarLine #'thin-kern = #10
\mark \markup \column { 'kern 10 'thin-kern 10 }
\bar :|.S
e'
}
More:
http://code.google.com/p/lilypond/issues/detail?id=3995
https://codereview.appspot.com/105560044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Remove thin-kern property. (issue 105560044 by markpole...@gmail.com)
On 2014/07/06 11:52:56, thomasmorley651 wrote: I disagree! 'kern and 'thin-kern _are_ used differently. Look at the output from: Harm, what am I missing? To my eye (compiling this with the latest snapshot), your example shows that thin-kern does nothing. - Mark https://codereview.appspot.com/105560044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Remove thin-kern property. (issue 105560044 by markpole...@gmail.com)
On 2014/07/06 12:53:55, Mark Polesky wrote: On 2014/07/06 11:52:56, thomasmorley651 wrote: I disagree! 'kern and 'thin-kern _are_ used differently. Look at the output from: Harm, what am I missing? To my eye (compiling this with the latest snapshot), your example shows that thin-kern does nothing. - Mark Look at the underlaying double-bar-line. I'll post an image, with a colored double-bar on the tracker. https://codereview.appspot.com/105560044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Remove thin-kern property. (issue 105560044 by markpole...@gmail.com)
Am 06.07.2014 13:52, schrieb thomasmorle...@gmail.com: On 2014/07/06 06:46:53, Mark Polesky wrote: Hi, I'm proposing to get rid of the BarLine.thin-kern property with this patch, so if you're opposed, let me know. You can see my comments/rationale here: http://code.google.com/p/lilypond/issues/detail?id=3995 Thanks, Mark I disagree! D'oh – I should have known better, having written the code for the segno bar line. Marc ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Remove thin-kern property. (issue 105560044 by markpole...@gmail.com)
On 2014/07/06 11:52:56, thomasmorley651 wrote: I disagree! 'kern and 'thin-kern _are_ used differently. Okay, so then it's just a question of clarifying the misleading docstrings. How about this? kern The space between individual elements in any compound bar line. thin-kern The space between the two thin lines of the segno bar line symbol. I've updated the patch accordingly. https://codereview.appspot.com/105560044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
