Re: Run regression tests for lilypond-book (issue 2223). (issue 5569045)
https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile File input/regression/lilypond-book/GNUmakefile (right): https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile#newcode36 input/regression/lilypond-book/GNUmakefile:36: # Prevent parallel lilypond-book instances for this subdir On 2020/02/22 22:54:40, hanwenn wrote: > I know this is a long time ago, but can you remember why this was added? As far as I can remember, lilypond-book was not free of concurrency issues with its use of a cache for snippets. Therefore the simplest to avoid any issue with make -j was to disable concurrent calls to lilypond-book. https://codereview.appspot.com/5569045/
Re: Run regression tests for lilypond-book (issue 2223). (issue 5569045)
https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile File input/regression/lilypond-book/GNUmakefile (right): https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile#newcode36 input/regression/lilypond-book/GNUmakefile:36: # Prevent parallel lilypond-book instances for this subdir I know this is a long time ago, but can you remember why this was added? https://codereview.appspot.com/5569045/
Re: Run regression tests for lilypond-book (issue 2223). (issue 5569045)
On 2012/02/07 20:05:49, Graham Percival wrote:
http://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile
File input/regression/lilypond-book/GNUmakefile (right):
http://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile#newcode19
input/regression/lilypond-book/GNUmakefile:19: OUT_TEXI_FILES +=
${TEXI_FILES:%.texi=$(outdir)/%.info}
how are the OUT_X_Y definitions used? Is there a generic rule for
OUT_X ?
other than that, I can't see how they'd have any effect?
Yes those rules are in one of two dozen files in the make folder, I
forgot which one, but they are effective. They test that the files
generated by -book are compilable to .info and .pdf (as well as .html)
Cheers,
Julien
http://codereview.appspot.com/5569045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Run regression tests for lilypond-book (issue 2223). (issue 5569045)
http://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile
File input/regression/lilypond-book/GNUmakefile (right):
http://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile#newcode19
input/regression/lilypond-book/GNUmakefile:19: OUT_TEXI_FILES +=
${TEXI_FILES:%.texi=$(outdir)/%.info}
how are the OUT_X_Y definitions used? Is there a generic rule for OUT_X
? other than that, I can't see how they'd have any effect?
http://codereview.appspot.com/5569045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Run regression tests for lilypond-book (issue 2223). (issue 5569045)
LGTM http://codereview.appspot.com/5569045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Run regression tests for lilypond-book (issue 2223). (issue 5569045)
Reviewers: , Message: Please review. Description: Run regression tests for lilypond-book (issue 2223). Re-enable running the regtests in input/regression/lilypond-book. Fix various typos, clarify what each input file tests for and how the output should look, and fix the following problems: collated-files.tely: Was linking to the input files rather than the output files generated by lilypond-book. The input files were thus not tested individually as it should but as included files. Fixed in the local GNUmakefile by an explicit rule for collated-files.list which tracks the output files. suffix-texi: Failed, was not being preprocessed by lilypond-book but simply copied to the output folder. Fixed in the local GNUmakefile by adding a specific make rule for it. tex-twocolumn: Failed, image had full-page width. Fixed in the input file by moving \twocolumn to the preamble. Column width detection in the body of the tex document is not yet implemented. texinfo-language-detection: Suspicious, had a weird @lydoctitle popping up. Fixed in the input file by defining the @lydoctitle macro. Please review this at http://codereview.appspot.com/5569045/ Affected files: M input/regression/lilypond-book/GNUmakefile M input/regression/lilypond-book/html-newline-after-tag.html M input/regression/lilypond-book/html-space-after-tag.html M input/regression/lilypond-book/html-version-newline.html M input/regression/lilypond-book/html-version.html M input/regression/lilypond-book/include3.ily M input/regression/lilypond-book/tex-comment-firstline.lytex M input/regression/lilypond-book/tex-graphics-package-added.lytex M input/regression/lilypond-book/tex-include-file.lytex M input/regression/lilypond-book/tex-include-options.lytex M input/regression/lilypond-book/tex-inline-lilypond.lytex M input/regression/lilypond-book/tex-lilypond-inside-itemize.lytex M input/regression/lilypond-book/tex-lilypond-inside-table.lytex M input/regression/lilypond-book/tex-musicxml-file-options.lytex M input/regression/lilypond-book/tex-musicxml-file.lytex M input/regression/lilypond-book/tex-paragraphs.lytex M input/regression/lilypond-book/tex-snippet-options.lytex M input/regression/lilypond-book/tex-twocolumn.lytex M input/regression/lilypond-book/tex-verbatim.lytex M input/regression/lilypond-book/tex-version.lytex M input/regression/lilypond-book/texinfo-include-language-detection.tely M input/regression/lilypond-book/texinfo-language-detection.tely M input/regression/lilypond-book/texinfo-musicxml-file-options.tely M input/regression/lilypond-book/texinfo-musicxml-file.tely A + input/regression/lilypond-book/texinfo-papersize-docs.tely ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
