Re: Various chain-assoc-get -> #:properties (issue 323940043 by d...@gnu.org)
https://codereview.appspot.com/323940043/diff/20001/Documentation/snippets/new/three-sided-box.ly File Documentation/snippets/new/three-sided-box.ly (right): https://codereview.appspot.com/323940043/diff/20001/Documentation/snippets/new/three-sided-box.ly#newcode36 Documentation/snippets/new/three-sided-box.ly:36: (let* ((pad (* (magstep font-size) box-padding)) On 2017/06/16 21:59:49, Carl wrote: Looks like this could now be a let instead of let* Done. Not going to create a new review for it though. https://codereview.appspot.com/323940043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Various chain-assoc-get -> #:properties (issue 323940043 by d...@gnu.org)
LGTM. One small possible change. https://codereview.appspot.com/323940043/diff/20001/Documentation/snippets/new/three-sided-box.ly File Documentation/snippets/new/three-sided-box.ly (right): https://codereview.appspot.com/323940043/diff/20001/Documentation/snippets/new/three-sided-box.ly#newcode36 Documentation/snippets/new/three-sided-box.ly:36: (let* ((pad (* (magstep font-size) box-padding)) Looks like this could now be a let instead of let* https://codereview.appspot.com/323940043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Various chain-assoc-get -> #:properties (issue 323940043 by d...@gnu.org)
LGTM one nit: https://codereview.appspot.com/323940043/diff/1/Documentation/snippets/three-sided-box.ly File Documentation/snippets/three-sided-box.ly (right): https://codereview.appspot.com/323940043/diff/1/Documentation/snippets/three-sided-box.ly#newcode45 Documentation/snippets/three-sided-box.ly:45: (m (interpret-markup layout props arg))) tab->spaces https://codereview.appspot.com/323940043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
