Re: changes.tely: mention Flag changes, remove duplicate "does" (issue 5540058)

2012-01-26 Thread pkx166h 

Pavel, I pushed for you.

author  Pavel Roskin  
 Thu, 26 Jan 2012 21:17:13 + (21:17 +)

committer James Lowe   
Thu, 26 Jan 2012 21:19:06 + (21:19 +)

commit  224246365f67fb44799fee4eb00e5debea5a35ec

Can you close this issue here?

James

http://codereview.appspot.com/5540058/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: changes.tely: mention Flag changes, remove duplicate "does" (issue 5540058)

2012-01-18 Thread plroskin 

On 2012/01/18 15:13:47, Neil Puttock wrote:

http://codereview.appspot.com/5540058/diff/3003/Documentation/changes.tely
Done

http://codereview.appspot.com/5540058/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: changes.tely: mention Flag changes, remove duplicate "does" (issue 5540058)

2012-01-18 Thread n . puttock 


http://codereview.appspot.com/5540058/diff/3003/Documentation/changes.tely
File Documentation/changes.tely (right):

http://codereview.appspot.com/5540058/diff/3003/Documentation/changes.tely#newcode67
Documentation/changes.tely:67: \override Flag #'color = #red g8
Please put the note on a new line.

http://codereview.appspot.com/5540058/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: changes.tely: mention Flag changes, remove duplicate "does" (issue 5540058)

2012-01-18 Thread graham 

LGTM

http://codereview.appspot.com/5540058/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: changes.tely: mention Flag changes, remove duplicate "does" (issue 5540058)

2012-01-17 Thread janek . lilypond 

lgtm

http://codereview.appspot.com/5540058/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

changes.tely: mention Flag changes, remove duplicate "does" (issue 5540058)

2012-01-17 Thread plroskin 

Reviewers: ,

Message:
The changelog doesn't mention the issue I have to deal with all the
time, namely splitting Flag from Stem.  If not that change, I would be
able to use Lilypond 2.14.2 and the development version without
convert-ly on the same sources.  It should definitely be mentioned.  An
example is added to show how the flag can be colored now.

Also, there was a duplicate "does" in the section about grace notes.

Description:
changes.tely: mention Flag changes, remove duplicate "does"

Please review this at http://codereview.appspot.com/5540058/

Affected files:
  M Documentation/changes.tely


Index: Documentation/changes.tely
diff --git a/Documentation/changes.tely b/Documentation/changes.tely
index  
50f2022cb29c087161107d3d1c074a52f692e37e..ef61eaeb8866ada482cdd598d33cc32572fe1cba  
100644

--- a/Documentation/changes.tely
+++ b/Documentation/changes.tely
@@ -208,9 +208,16 @@ c4_\< c c^\> c c1_\p


 @item
+Flags are now treated as separate objects rather than as stem parts.
+@lilypond[fragment,quote,relative=2]
+\override Flag #'color = #red g8
+@end lilypond
+
+
+@item
 Appoggiaturas and acciaccaturas now also work inside a slur, not only  
inside

 a phrasing slur. Also, a function @code{\slashedGrace} was added that does
-does not use a slur from the acciaccatura note.
+not use a slur from the acciaccatura note.
 @lilypond[fragment,quote,relative=2]
 c4( \appoggiatura e8 d4 \acciaccatura e8 d4 \slashedGrace e8 c4)
 @end lilypond





___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: changes.tely: mention Flag changes, remove duplicate "does" (issue 5540058)

2012-01-16 Thread plroskin 

OK, my mistake, I didn't read the comments on top of changes.tely.  The
fixed patch is attached as patch set 2.

http://codereview.appspot.com/5540058/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: changes.tely: mention Flag changes, remove duplicate "does" (issue 5540058)

2012-01-16 Thread pkx166h 

Well I'd say at the top. Many of the changes I have added in the last
year have
not necessarily gone in the correct 'order'; when someone mentioned that
something needed to be added, it went in on the top of the pile.

People do follow the changes, so the assumption is that it is current,
if we
have never mentioned this 'change' before, it makes sense to add it to
the top
instead of hiding it below.

I think while things are still in dev, until we release a stable the
'order'
doesn't matter that much.

http://codereview.appspot.com/5540058/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: changes.tely: mention Flag changes, remove duplicate "does" (issue 5540058)

2012-01-15 Thread Carl . D . Sorensen 

Looks good to me, but I wonder about the location.

Thanks,

Carl


http://codereview.appspot.com/5540058/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: changes.tely: mention Flag changes, remove duplicate "does" (issue 5540058)

2012-01-15 Thread Carl . D . Sorensen 

Looks good to me, but I wonder about the location.

Thanks,

Carl



http://codereview.appspot.com/5540058/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):

http://codereview.appspot.com/5540058/diff/1/Documentation/changes.tely#newcode210
Documentation/changes.tely:210: @item
I'm a bit concerned about adding this down here.  Somebody who is only
tracking the top of CHANGES wil miss this.

I assume (but haven't checked) that this is in the right place relative
to the other changes.

I'd like to get some other opinions about it -- should it go here or at
the top?

http://codereview.appspot.com/5540058/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel