Re: collision \breathe with accidentals

2020-08-07 Thread Werner LEMBERG

> Could https://gitlab.com/lilypond/lilypond/-/issues/1006 be what
> you’re looking for?

It is, thanks!


Werner


Re: collision \breathe with accidentals

2020-08-07 Thread Jean Abou Samra
   Werner,

   Could  [1]https://gitlab.com/lilypond/lilypond/-/issues/1006 be what
   you’re looking for?

   Jean

References

   1. https://gitlab.com/lilypond/lilypond/-/issues/1006


Re: collision \breathe with accidentals

2020-08-07 Thread Werner LEMBERG

>> > the breathing sign is non-musical, and the accidental is musical,
>> > so this should be prevented by the skyline distancing.  It would
>> > be interesting to see what lily thinks the skylines look like.
>>
>> Here it is.
>>
> these are the skylines for vertical spacing. You need the ones for
> horizontal spacing. Look at the commented out stencil callback for
> PaperColumn in define-grobs.scm.

Commenting this out I get the attached image.  Is this the right one?


Werner


Re: collision \breathe with accidentals

2020-08-07 Thread Han-Wen Nienhuys
On Fri, Aug 7, 2020 at 5:30 PM Werner LEMBERG  wrote:

>
> >> Look at the following code.
> >>
> >>   \relative c'' {
> >> f2 \breathe  |
> >> g2 \breathe  }
> >>
> >> As the attached images show, the breathing sign *sometimes*
> >> collides with accidentals.  Looks like a bug.  If you agree I'll
> >> add it to the tracker.
> >
> > the breathing sign is non-musical, and the accidental is musical, so
> > this should be prevented by the skyline distancing.  It would be
> > interesting to see what lily thinks the skylines look like.
>
> Here it is.
>
>
>
these are the skylines for vertical spacing. You need the ones for
horizontal spacing. Look at the commented out stencil callback for
PaperColumn in define-grobs.scm.



> Werner
>


-- 
Han-Wen Nienhuys - hanw...@gmail.com - http://www.xs4all.nl/~hanwen


Re: collision \breathe with accidentals

2020-08-07 Thread Werner LEMBERG
>> Attached I've added some more tests.  LilyPond's behaviour
>> w.r.t. accidentals looks very erratical...
> 
> Is this another manifestation of that age-old dotted rest problem
> that plagued the reg tests for years that was fixed end of last year
> (but I forget by who - Thomas?) where the dot would move sometimes
> and sometimes not affecting random reg tests?

I don't think so, but I'm just a mere mortal :-)


Werner



Re: collision \breathe with accidentals

2020-08-07 Thread Werner LEMBERG

>> Look at the following code.
>>
>>   \relative c'' {
>> f2 \breathe  |
>> g2 \breathe  }
>>
>> As the attached images show, the breathing sign *sometimes*
>> collides with accidentals.  Looks like a bug.  If you agree I'll
>> add it to the tracker.
> 
> the breathing sign is non-musical, and the accidental is musical, so
> this should be prevented by the skyline distancing.  It would be
> interesting to see what lily thinks the skylines look like.

Here it is.


Werner


Re: collision \breathe with accidentals

2020-08-07 Thread Hans Åberg


> On 7 Aug 2020, at 08:17, Werner LEMBERG  wrote:
> 
> As the attached images show, the breathing sign *sometimes* collides
> with accidentals.  Looks like a bug.  If you agree I'll add it to the
> tracker.
> 
> Any idea how to circumvent that?

In addition to that, I place the breath mark above the ledger lines, and all 
sources I could find do likewise.





Re: collision \breathe with accidentals

2020-08-07 Thread Han-Wen Nienhuys
On Fri, Aug 7, 2020 at 8:17 AM Werner LEMBERG  wrote:

>
> [lilypond e16a5ec 2020-Aug-06]
>
>
> Look at the following code.
>
>   \relative c'' {
> f2 \breathe  |
> g2 \breathe  }
>
> As the attached images show, the breathing sign *sometimes* collides
> with accidentals.  Looks like a bug.  If you agree I'll add it to the
> tracker.
>
> Any idea how to circumvent that?
>

the breathing sign is non-musical, and the accidental is musical, so this
should be prevented by the skyline distancing. It would be interesting to
see what lily thinks the skylines look like.

-- 
Han-Wen Nienhuys - hanw...@gmail.com - http://www.xs4all.nl/~hanwen


Re: collision \breathe with accidentals

2020-08-07 Thread James



On 07/08/2020 10:37, Werner LEMBERG wrote:

As the attached images show, the breathing sign *sometimes* collides
with accidentals.  Looks like a bug.

Attached I've added some more tests.  LilyPond's behaviour
w.r.t. accidentals looks very erratical...


 Werner


Is this another manifestation of that age-old dotted rest problem that 
plagued the reg tests for years that was fixed end of last year (but I 
forget by who - Thomas?) where the dot would move sometimes and 
sometimes not affecting random reg tests?


James





Re: collision \breathe with accidentals

2020-08-07 Thread Werner LEMBERG

>> As the attached images show, the breathing sign *sometimes*
>> collides with accidentals.  Looks like a bug.  If you agree I'll
>> add it to the tracker.
>>
>> Any idea how to circumvent that?
> 
> Adjusting the vertical bounds of the BreathingSign appears to help:
> 
> 
> \relative c'' {
>   \override BreathingSign.extra-spacing-height = #'(0 . 2)
>   f2 \breathe  |
>   e2 \breathe  |
>   d2 \breathe  |
>   c2 \breathe  |
>   g2 \breathe 
> }
> 

Indeed, this makes even my larger set of tests work, see attached
image.  Thanks!  Shall this be added to LilyPond's default values?


Werner


Re: collision \breathe with accidentals

2020-08-07 Thread Werner LEMBERG

> As the attached images show, the breathing sign *sometimes* collides
> with accidentals.  Looks like a bug.

Attached I've added some more tests.  LilyPond's behaviour
w.r.t. accidentals looks very erratical...


Werner
\paper {
  indent = 0
  ragged-right = ##t
}

\relative c'' {
  \omit Score.TimeSignature
  \omit Score.BarNumber

  f2 \breathe f |
  f2 \breathe g |
  f2 \breathe a |
  f2 \breathe b | \break

  f2 \breathe fis |
  f2 \breathe gis |
  f2 \breathe ais |
  f2 \breathe bis | \break

  f2 \breathe f! |
  f2 \breathe g! |
  f2 \breathe a! |
  f2 \breathe b! | \break

  f2 \breathe fes |
  f2 \breathe ges |
  f2 \breathe aes |
  f2 \breathe bes }


Re: collision \breathe with accidentals

2020-08-06 Thread Aaron Hill

On 2020-08-06 11:17 pm, Werner LEMBERG wrote:

[lilypond e16a5ec 2020-Aug-06]


Look at the following code.

  \relative c'' {
f2 \breathe  |
g2 \breathe  }

As the attached images show, the breathing sign *sometimes* collides
with accidentals.  Looks like a bug.  If you agree I'll add it to the
tracker.

Any idea how to circumvent that?


Adjusting the vertical bounds of the BreathingSign appears to help:


\relative c'' {
  \override BreathingSign.extra-spacing-height = #'(0 . 2)
  f2 \breathe  |
  e2 \breathe  |
  d2 \breathe  |
  c2 \breathe  |
  g2 \breathe 
}



-- Aaron Hill



collision \breathe with accidentals

2020-08-06 Thread Werner LEMBERG

[lilypond e16a5ec 2020-Aug-06]


Look at the following code.

  \relative c'' {
f2 \breathe  |
g2 \breathe  }

As the attached images show, the breathing sign *sometimes* collides
with accidentals.  Looks like a bug.  If you agree I'll add it to the
tracker.

Any idea how to circumvent that?


Werner