Re: Patch to fix centering of some bass figures on whole notes and longer.

[David Kastrup]

Richard Shann  writes:

> On Thu, 2017-07-13 at 12:47 +0100, James wrote:
>> > I am not top posting
>> 
>> This 'patch' does not apply to current master so I could not test it
>> even if I wanted to
>
> Ah, yes, sorry, I looked into what parameters git uses for its diff but
> didn't think about the directory you would want to run patch from.
> I've made a git clone of the repository and used git diff now to get the
> attached patch.

That doesn't help much I think.  Create an actual commit with commit
message, then format that using

git format-patch HEAD~1

or similar.

-- 
David Kastrup

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Patch to fix centering of some bass figures on whole notes and longer.

[Richard Shann]

On Thu, 2017-07-13 at 15:07 +0200, David Kastrup wrote:
> Richard Shann  writes:
> 
> > On Thu, 2017-07-13 at 12:47 +0100, James wrote:
> >> > I am not top posting
> >> 
> >> This 'patch' does not apply to current master so I could not test it
> >> even if I wanted to
> >
> > Ah, yes, sorry, I looked into what parameters git uses for its diff but
> > didn't think about the directory you would want to run patch from.
> > I've made a git clone of the repository and used git diff now to get the
> > attached patch.
> 
> That doesn't help much I think.  Create an actual commit with commit
> message, then format that using
> 
> git format-patch HEAD~1

ah, ok. That gives the attached.

Richard

From 336daa273929815ecb4b6e1a2be5a56f743b1181 Mon Sep 17 00:00:00 2001
From: Richard Shann 
Date: Thu, 13 Jul 2017 14:00:48 +0100
Subject: [PATCH] Fix centering of single figures and lone accidentals when
 occurring on whole notes and longer durations

---
 scm/translation-functions.scm | 11 ---
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/scm/translation-functions.scm b/scm/translation-functions.scm
index 0ed0def..cd78d83 100644
--- a/scm/translation-functions.scm
+++ b/scm/translation-functions.scm
@@ -184,13 +184,10 @@ way the transposition number is displayed."
   (set! alt-markup #f)))
 
 
-;; hmm, how to get figures centered between note, and
-;; lone accidentals too?
-
-;;(if (markup? fig-markup)
-;;  (set!
-;;   fig-markup (markup #:translate (cons 1.0 0)
-;;  #:center-align fig-markup)))
+(if (and (>= 0 (ly:duration-log  (ly:event-property event 'duration))) (markup? fig-markup))
+(set!
+fig-markup (markup #:translate (cons 1.0 0)
+#:center-align fig-markup)))
 
 (if alt-markup
 (set! fig-markup
-- 
2.1.4

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCHES - Countdown for July 13th

[James]

Hello,

Here is the current patch countdown list. The next countdown will be on
July 16th.

A quick synopsis of all patches currently in the review process can be
found here:

http://philholmes.net/lilypond/allura/



Push: No patches to Push at this time.


Countdown:

5152 Doc: CG: Add guideline for use of 'CSS' prefix in commit messages
- Paul Morris https://sourceforge.net/p/testlilyissues/issues/5152
http://codereview.appspot.com/325970043


Review: No patches in Review at this time.


New: No New patches at this time.




Regards

James

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Patch to fix centering of some bass figures on whole notes and longer.

[James]

> I am not top posting

This 'patch' does not apply to current master so I could not test it
even if I wanted to

--snip--
Using Git apply command

~/Desktop/issuexxx.diff error: translation-functions.scm: does not
exist in index 


using 'patch' command:

can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option? The text leading up to
this was: --
|--- ORIG_translation-functions.scm 2017-07-08
12:36:17.716097042 +0100 |+++ translation-functions.scm
2017-07-09 14:05:34.084003967 +0100 --
File to patch: 

I you want this tested can you provide a git formatted patch against
current master?

Thanks

James

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Patch to fix centering of some bass figures on whole notes and longer.

[Richard Shann]

On Thu, 2017-07-13 at 12:47 +0100, James wrote:
> > I am not top posting
> 
> This 'patch' does not apply to current master so I could not test it
> even if I wanted to

Ah, yes, sorry, I looked into what parameters git uses for its diff but
didn't think about the directory you would want to run patch from.
I've made a git clone of the repository and used git diff now to get the
attached patch.

Richard

diff --git a/scm/translation-functions.scm b/scm/translation-functions.scm
index 0ed0def..cd78d83 100644
--- a/scm/translation-functions.scm
+++ b/scm/translation-functions.scm
@@ -184,13 +184,10 @@ way the transposition number is displayed."
   (set! alt-markup #f)))
 
 
-;; hmm, how to get figures centered between note, and
-;; lone accidentals too?
-
-;;(if (markup? fig-markup)
-;;  (set!
-;;   fig-markup (markup #:translate (cons 1.0 0)
-;;  #:center-align fig-markup)))
+(if (and (>= 0 (ly:duration-log  (ly:event-property event 'duration))) (markup? fig-markup))
+(set!
+fig-markup (markup #:translate (cons 1.0 0)
+#:center-align fig-markup)))
 
 (if alt-markup
 (set! fig-markup
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel