Re: Failure to properly display appoggiatura inside a repeat volta

2022-02-16 Thread Kenneth Wolcott 
Thank you, David! So obvious, right in front of my nose.

On Wed, Feb 16, 2022 at 2:37 PM David Kastrup  wrote:
>
> Kenneth Wolcott  writes:
>
> > Hi;;
> >
> >   I'm trying to engrave the 8notes.com's Voice+Piano arrangement of
> > "Take Me Out to the Ball Game".  I decided to skip the lyrics for now
> > and replace the corresponding notes with a trumpet.
> >
> >   I'm having a problem correctly displaying appoggiatura that exists
> > inside a repeat volta.
> >
> >   The problem: The appoggiatura appears in a previous bar (all by itself).
> >
> >   I have attached screenshots of the bars in question (8-10) from the
> > original and my attempt at engraving it.
> >
> >   I've also attached the output of Lilypond 2.22.1 (no errors and no 
> > warnings).
> >
> >   I've attached the bars of Lilypond source (bars 8-10).
> >
> >   I've also attached the whole original pdf, my pdf and the entire
> > Lilypond source.
> >
> >   I've tried to reproduce this problem in an (almost) MWE, but it
> > worked just fine.
> >
> >   I must be doing something obviously stupid here, but I can't seen to find 
> > it.
>
> Issue 34.
>
> All \repeat volta statements have to start at the same time, namely
> 8. before the beat.  You do that by adding grace space.
>
> Here is the diff:
>
> --- Take_Me_Out_to_the_Ball_Game.ly.bak 2022-02-16 23:25:10.244468097 +0100
> +++ Take_Me_Out_to_the_Ball_Game.ly 2022-02-16 23:34:47.314658111 +0100
> @@ -30,7 +30,7 @@
>  %\break
>R1*3/4| % m8
>\repeat volta 2 {
> -<< { R1*3/4 } \\ { \appoggiatura { s8. } s2. } >>  % m9
> +\grace s8. R1*3/4 |  % m9
>  R1*3/4  | % m10
>}
>\repeat volta 2 {
> @@ -234,7 +234,7 @@
>  %\break
>4 r r| % m8
>\repeat volta 2 {
> -\appoggiatura { s8. } s2.  | % m9
> +\grace s8. s2. | % m9
>  s2.| % m10
>}
>\repeat volta 2 {
> @@ -336,6 +336,7 @@
>  %\break
>d4 s2  | % m8
>\repeat volta 2 {
> +\grace s8.
>  4 r r  | % m9
>  4 r r| % m10
>}
> @@ -438,6 +439,7 @@
>  %\break
>d,4 r r  | % m8
>\repeat volta 2 {
> +\grace s8.
>  s2.| % m9
>  s2.| % m10
>}
>
> Note that you don't use \appoggiatura but rather \grace when you don't
> want the associated slur to be typeset as well.
>
> Here is the completed variant:
>
>
>
> --
> David Kastrup

Re: Failure to properly display appoggiatura inside a repeat volta

2022-02-16 Thread Kenneth Wolcott 
Thank you, Leo! So obvious, right in front of my nose.

On Wed, Feb 16, 2022 at 2:42 PM Leo Correia de Verdier
 wrote:
>
> It’s the most classic of lilypond issues showing up again. Insert s16*3 in 
> the same place in the other staves and it will go away. (What happens is that 
> piano right hand has the repeat bar three gracenote sixteenths earlier than 
> the other staves, so it shows up in both places)
>
> > 16 feb. 2022 kl. 22:56 skrev Kenneth Wolcott :
> >
> > Hi;;
> >
> >  I'm trying to engrave the 8notes.com's Voice+Piano arrangement of
> > "Take Me Out to the Ball Game".  I decided to skip the lyrics for now
> > and replace the corresponding notes with a trumpet.
> >
> >  I'm having a problem correctly displaying appoggiatura that exists
> > inside a repeat volta.
> >
> >  The problem: The appoggiatura appears in a previous bar (all by itself).
> >
> >  I have attached screenshots of the bars in question (8-10) from the
> > original and my attempt at engraving it.
> >
> >  I've also attached the output of Lilypond 2.22.1 (no errors and no 
> > warnings).
> >
> >  I've attached the bars of Lilypond source (bars 8-10).
> >
> >  I've also attached the whole original pdf, my pdf and the entire
> > Lilypond source.
> >
> >  I've tried to reproduce this problem in an (almost) MWE, but it
> > worked just fine.
> >
> >  I must be doing something obviously stupid here, but I can't seen to find 
> > it.
> >
> > Thanks,
> > Ken Wolcott

Re: Failure to properly display appoggiatura inside a repeat volta

2022-02-16 Thread David Kastrup 
Kenneth Wolcott  writes:

> Hi;;
>
>   I'm trying to engrave the 8notes.com's Voice+Piano arrangement of
> "Take Me Out to the Ball Game".  I decided to skip the lyrics for now
> and replace the corresponding notes with a trumpet.
>
>   I'm having a problem correctly displaying appoggiatura that exists
> inside a repeat volta.
>
>   The problem: The appoggiatura appears in a previous bar (all by itself).
>
>   I have attached screenshots of the bars in question (8-10) from the
> original and my attempt at engraving it.
>
>   I've also attached the output of Lilypond 2.22.1 (no errors and no 
> warnings).
>
>   I've attached the bars of Lilypond source (bars 8-10).
>
>   I've also attached the whole original pdf, my pdf and the entire
> Lilypond source.
>
>   I've tried to reproduce this problem in an (almost) MWE, but it
> worked just fine.
>
>   I must be doing something obviously stupid here, but I can't seen to find 
> it.

Issue 34.

All \repeat volta statements have to start at the same time, namely
8. before the beat.  You do that by adding grace space.

Here is the diff:

--- Take_Me_Out_to_the_Ball_Game.ly.bak 2022-02-16 23:25:10.244468097 +0100
+++ Take_Me_Out_to_the_Ball_Game.ly 2022-02-16 23:34:47.314658111 +0100
@@ -30,7 +30,7 @@
 %\break
   R1*3/4| % m8
   \repeat volta 2 {
-<< { R1*3/4 } \\ { \appoggiatura { s8. } s2. } >>  % m9
+\grace s8. R1*3/4 |  % m9
 R1*3/4  | % m10
   }
   \repeat volta 2 {
@@ -234,7 +234,7 @@
 %\break
   4 r r| % m8
   \repeat volta 2 {
-\appoggiatura { s8. } s2.  | % m9
+\grace s8. s2. | % m9
 s2.| % m10
   }
   \repeat volta 2 {
@@ -336,6 +336,7 @@
 %\break
   d4 s2  | % m8
   \repeat volta 2 {
+\grace s8.
 4 r r  | % m9
 4 r r| % m10
   }
@@ -438,6 +439,7 @@
 %\break
   d,4 r r  | % m8
   \repeat volta 2 {
+\grace s8.
 s2.| % m9
 s2.| % m10
   }

Note that you don't use \appoggiatura but rather \grace when you don't
want the associated slur to be typeset as well.

Here is the completed variant:

\version "2.22.0"

% Take Me Out to the Ball Game

\header {
  title = "Take Me Out to the Ball Game"
  composer = "Albert von Tilzer"
  arranger = "arr. David Bruce"
}

global = {
  \language "english"
  \time 3/4
  \key d \major
  \tempo "Tempo di valse" 4=120
  \partial 4
}

trumpet = {
  \global
  \clef treble
  r4  | % m0
  R1*3/4  | % m1
  R1*3/4  | % m2
  R1*3/4  | % m3
  R1*3/4  | % m4
  R1*3/4  | % m5
  R1*3/4  | % m6
  R1*3/4  | % m7
%\break
  R1*3/4| % m8
  \repeat volta 2 {
\grace s8. R1*3/4 |  % m9
R1*3/4  | % m10
  }
  \repeat volta 2 {
a'2\f a'4   | % m11
a'4 g' fs'  | % m12
a'2 a'4 | % m13
a'2.| % m14
%\break
b'2 b'4| % m15
b'4 a' g'  | % m16
b'2 b'4| % m17
b'2.   | % m18
cs''2 cs''4| % m19
cs''4 d'' e''  | % m20
b'2 b'4| % m21
%\break
b'4 cs'' e''  | % m22
b'2. ~| % m23
b'4 cs'' e''  | % m24
a'2. ~| % m25
a'2 r4| % m26
a'2 a'4   | % m27
a'4 g' fs'| % m28
%\break
a'2 a'4| % m29
a'2.   | % m30
b'2 b'4| % m31
b'4 a' g'  | % m32
b'2 b'4| % m33
b'2 a'4| % m34
gs'2 gs'4  | % m35
%\break
gs'4 a' b'   | % m36
cs''2 a'4| % m37
e'2 e'4  | % m38
fs'4 gs' a'  | % m39
b'2 cs''4| % m40
a'2. ~   | % m41
a'2 r4   | % m42
%\break
d'2_> d''4  | % m43
b'4 a' fs'  | % m44
a'2.| % m45
e'2.| % m46
d'2_> d''4  | % m47
b'4 a' fs'  | % m48
a'2. ~  | % m49
%\break
a'2 r4| % m50
b'4 as' b'| % m51
fs'4 g' a'| % m52
b'2 g'4   | % m53
e'2.  | % m54
b'2 b'4   | % m55
b'4 cs'' d''  | % m56
%\break
e''4 cs'' b'  | % m57
a' fs' e' | % m58
d'2_> d''4| % m59
b'4 a' fs'| % m60
a'2.  | % m61
e'2 e'4   | % m62
d'2 e'4   | % m63
%\break
fs'4 g' a'| % m64
b'2. ~| % m65
b'4 b' cs''   | % m66
d''2. | % m67
d''2. | % m68
d''4 cs'' b'  | % m69
%\break
a'4 gs' a'  | % m70
b'2.| % m71
cs''2.  | % m72
  }
  \alternative {
{
  d''2. ~   | % m73
  d''4 r r  | % m74
}
{
  d''2. ~   | % m75
  d''4 r r  | % m76
}
  }
}

rh_one = {
  \global
  \clef treble
  b'8\f c'' | % m0
  d''2.^>   | % m1
  d''2.^>   | % m2
  d''4 cs'' b'  | % m3
  a'4 gs' a'| % m4
  b'2.  | % m5
  2.| % m6
  2. ~  | % m7
%\break
4 s2  | % m8
  \repeat volta 2 {
\appoggiatura { a16 b cs' } d'4  q  | % m9
r4  q   | % m10
  }
  \repeat volta 2 {
a'2\pp a'4| % m11
a'4 g' fs'