[PATCH v2 1/2] usb: gadget: add max_speed to usb_composite_driver

2011-06-29 Thread Tatyana Brokhman 
This field is used by the Gadget drivers to specify
the maximum speed they support, meaning: the maximum
speed they can provide descriptors for.

The driver speed will be set in consideration of this
value.

Signed-off-by: Tatyana Brokhman tlin...@codeaurora.org

---
 drivers/usb/gadget/audio.c|1 +
 drivers/usb/gadget/cdc2.c |1 +
 drivers/usb/gadget/composite.c|2 ++
 drivers/usb/gadget/ether.c|1 +
 drivers/usb/gadget/g_ffs.c|1 +
 drivers/usb/gadget/hid.c  |1 +
 drivers/usb/gadget/mass_storage.c |1 +
 drivers/usb/gadget/multi.c|1 +
 drivers/usb/gadget/ncm.c  |1 +
 drivers/usb/gadget/nokia.c|1 +
 drivers/usb/gadget/serial.c   |1 +
 drivers/usb/gadget/webcam.c   |1 +
 drivers/usb/gadget/zero.c |1 +
 include/linux/usb/composite.h |2 ++
 14 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/gadget/audio.c b/drivers/usb/gadget/audio.c
index 93b999e..9d89ae47 100644
--- a/drivers/usb/gadget/audio.c
+++ b/drivers/usb/gadget/audio.c
@@ -165,6 +165,7 @@ static struct usb_composite_driver audio_driver = {
.name   = g_audio,
.dev= device_desc,
.strings= audio_strings,
+   .max_speed  = USB_SPEED_HIGH,
.unbind = __exit_p(audio_unbind),
 };
 
diff --git a/drivers/usb/gadget/cdc2.c b/drivers/usb/gadget/cdc2.c
index 2720ab0..b1c1afb 100644
--- a/drivers/usb/gadget/cdc2.c
+++ b/drivers/usb/gadget/cdc2.c
@@ -244,6 +244,7 @@ static struct usb_composite_driver cdc_driver = {
.name   = g_cdc,
.dev= device_desc,
.strings= dev_strings,
+   .max_speed  = USB_SPEED_HIGH,
.unbind = __exit_p(cdc_unbind),
 };
 
diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index ed8a70f..0009916 100644
--- a/drivers/usb/gadget/composite.c
+++ b/drivers/usb/gadget/composite.c
@@ -1386,6 +1386,8 @@ int usb_composite_probe(struct usb_composite_driver 
*driver,
driver-iProduct = driver-name;
composite_driver.function =  (char *) driver-name;
composite_driver.driver.name = driver-name;
+   composite_driver.speed = min_t(u8, composite_driver.speed,
+  driver-max_speed);
composite = driver;
composite_gadget_bind = bind;
 
diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
index 1690c9d..ac41858 100644
--- a/drivers/usb/gadget/ether.c
+++ b/drivers/usb/gadget/ether.c
@@ -401,6 +401,7 @@ static struct usb_composite_driver eth_driver = {
.name   = g_ether,
.dev= device_desc,
.strings= dev_strings,
+   .max_speed  = USB_SPEED_HIGH,
.unbind = __exit_p(eth_unbind),
 };
 
diff --git a/drivers/usb/gadget/g_ffs.c b/drivers/usb/gadget/g_ffs.c
index ebf6970..704c280 100644
--- a/drivers/usb/gadget/g_ffs.c
+++ b/drivers/usb/gadget/g_ffs.c
@@ -162,6 +162,7 @@ static struct usb_composite_driver gfs_driver = {
.name   = DRIVER_NAME,
.dev= gfs_dev_desc,
.strings= gfs_dev_strings,
+   .max_speed  = USB_SPEED_HIGH,
.unbind = gfs_unbind,
.iProduct   = DRIVER_DESC,
 };
diff --git a/drivers/usb/gadget/hid.c b/drivers/usb/gadget/hid.c
index 2523e54..9fb5750 100644
--- a/drivers/usb/gadget/hid.c
+++ b/drivers/usb/gadget/hid.c
@@ -255,6 +255,7 @@ static struct usb_composite_driver hidg_driver = {
.name   = g_hid,
.dev= device_desc,
.strings= dev_strings,
+   .max_speed  = USB_SPEED_HIGH,
.unbind = __exit_p(hid_unbind),
 };
 
diff --git a/drivers/usb/gadget/mass_storage.c 
b/drivers/usb/gadget/mass_storage.c
index 0182242..d3eb274 100644
--- a/drivers/usb/gadget/mass_storage.c
+++ b/drivers/usb/gadget/mass_storage.c
@@ -169,6 +169,7 @@ static struct usb_composite_driver msg_driver = {
.name   = g_mass_storage,
.dev= msg_device_desc,
.iProduct   = DRIVER_DESC,
+   .max_speed  = USB_SPEED_HIGH,
.needs_serial   = 1,
 };
 
diff --git a/drivers/usb/gadget/multi.c b/drivers/usb/gadget/multi.c
index d9feced..8c7b747 100644
--- a/drivers/usb/gadget/multi.c
+++ b/drivers/usb/gadget/multi.c
@@ -351,6 +351,7 @@ static struct usb_composite_driver multi_driver = {
.name   = g_multi,
.dev= device_desc,
.strings= dev_strings,
+   .max_speed  = USB_SPEED_HIGH,
.unbind = __exit_p(multi_unbind),
.iProduct   = DRIVER_DESC,
.needs_serial   = 1,
diff --git a/drivers/usb/gadget/ncm.c b/drivers/usb/gadget/ncm.c
index 99c179a..62ee508 100644
--- a/drivers/usb/gadget/ncm.c
+++ b/drivers/usb/gadget/ncm.c
@@ -228,6 +228,7 @@ static struct usb_composite_driver

[PATCH v2 2/2] usb: gadget: add SuperSpeed support to the Gadget Framework

2011-06-29 Thread Tatyana Brokhman 
SuperSpeed USB has defined a new descriptor, called
the Binary Device Object Store (BOS) Descriptor. It
has also changed a bit the definition of SET_FEATURE
and GET_STATUS requests to add USB3-specific details.

This patch implements both changes to the Composite
Gadget Framework.

Signed-off-by: Tatyana Brokhman tlin...@codeaurora.org

---
 drivers/usb/gadget/Kconfig  |6 +
 drivers/usb/gadget/composite.c  |  257 ---
 drivers/usb/gadget/epautoconf.c |6 +-
 include/linux/usb/composite.h   |   14 ++
 include/linux/usb/gadget.h  |   31 +
 5 files changed, 293 insertions(+), 21 deletions(-)

diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index 22e43ff..a23e291 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -666,6 +666,12 @@ config USB_GADGET_DUALSPEED
bool
depends on USB_GADGET
 
+# Selected by UDC drivers that support super-speed opperation
+config USB_GADGET_SUPERSPEED
+   bool
+   depends on USB_GADGET
+   depends on USB_GADGET_DUALSPEED
+
 #
 # USB Gadget Drivers
 #
diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index 0009916..d02247a 100644
--- a/drivers/usb/gadget/composite.c
+++ b/drivers/usb/gadget/composite.c
@@ -27,7 +27,7 @@
 #include linux/utsname.h
 
 #include linux/usb/composite.h
-
+#include asm/unaligned.h
 
 /*
  * The code in this file is utility code, used to build a gadget driver
@@ -128,6 +128,9 @@ int config_ep_by_speed(struct usb_gadget *g,
struct usb_endpoint_descriptor *chosen_desc = NULL;
struct usb_descriptor_header **speed_desc = NULL;
 
+   struct usb_ss_ep_comp_descriptor *comp_desc = NULL;
+   int want_comp_desc = 0;
+
struct usb_descriptor_header **d_spd; /* cursor for speed desc */
 
if (!g || !f || !_ep)
@@ -135,6 +138,13 @@ int config_ep_by_speed(struct usb_gadget *g,
 
/* select desired speed */
switch (g-speed) {
+   case USB_SPEED_SUPER:
+   if (gadget_is_superspeed(g)) {
+   speed_desc = f-ss_descriptors;
+   want_comp_desc = 1;
+   break;
+   }
+   /* else: Fall trough */
case USB_SPEED_HIGH:
if (gadget_is_dualspeed(g)) {
speed_desc = f-hs_descriptors;
@@ -156,7 +166,36 @@ ep_found:
/* commit results */
_ep-maxpacket = le16_to_cpu(chosen_desc-wMaxPacketSize);
_ep-desc = chosen_desc;
+   _ep-comp_desc = NULL;
+   _ep-maxburst = 0;
+   _ep-mult = 0;
+   if (!want_comp_desc)
+   return 0;
 
+   /*
+* Companion descriptor should follow EP descriptor
+* USB 3.0 spec, #9.6.7
+*/
+   comp_desc = (struct usb_ss_ep_comp_descriptor *)*(++d_spd);
+   if (!comp_desc ||
+   (comp_desc-bDescriptorType != USB_DT_SS_ENDPOINT_COMP))
+   return -EIO;
+   _ep-comp_desc = comp_desc;
+   if (g-speed == USB_SPEED_SUPER) {
+   switch (usb_endpoint_type(_ep-desc)) {
+   case USB_ENDPOINT_XFER_BULK:
+   case USB_ENDPOINT_XFER_INT:
+   _ep-maxburst = comp_desc-bMaxBurst;
+   break;
+   case USB_ENDPOINT_XFER_ISOC:
+   /* mult: bits 1:0 of bmAttributes */
+   _ep-mult = comp_desc-bmAttributes  0x3;
+   break;
+   default:
+   /* Do nothing for control endpoints */
+   break;
+   }
+   }
return 0;
 }
 
@@ -208,6 +247,8 @@ int usb_add_function(struct usb_configuration *config,
config-fullspeed = true;
if (!config-highspeed  function-hs_descriptors)
config-highspeed = true;
+   if (!config-superspeed  function-ss_descriptors)
+   config-superspeed = true;
 
 done:
if (value)
@@ -351,10 +392,17 @@ static int config_buf(struct usb_configuration *config,
list_for_each_entry(f, config-functions, list) {
struct usb_descriptor_header **descriptors;
 
-   if (speed == USB_SPEED_HIGH)
+   switch (speed) {
+   case USB_SPEED_SUPER:
+   descriptors = f-ss_descriptors;
+   break;
+   case USB_SPEED_HIGH:
descriptors = f-hs_descriptors;
-   else
+   break;
+   default:
descriptors = f-descriptors;
+   }
+
if (!descriptors)
continue;
status = usb_descriptor_fillbuf(next, len,
@@ -377,9 +425,10 @@ static int config_desc(struct usb_composite_dev *cdev, 
unsigned w_value)
u8  type = w_value  8;
enum usb_device_speed   speed =

Re: [PATCH v2 2/2] usb: gadget: add SuperSpeed support to the Gadget Framework

2011-06-29 Thread Felipe Balbi 
On Wed, Jun 29, 2011 at 03:34:56PM +0300, Tatyana Brokhman wrote:
 SuperSpeed USB has defined a new descriptor, called
 the Binary Device Object Store (BOS) Descriptor. It
 has also changed a bit the definition of SET_FEATURE
 and GET_STATUS requests to add USB3-specific details.
 
 This patch implements both changes to the Composite
 Gadget Framework.
 
 Signed-off-by: Tatyana Brokhman tlin...@codeaurora.org

had already fixed this one too..

-- 
balbi


signature.asc
Description: Digital signature

Re: [PATCH v2 1/2] usb: gadget: add max_speed to usb_composite_driver

2011-06-29 Thread Felipe Balbi 
Hi,

On Wed, Jun 29, 2011 at 03:45:35PM +0300, Tanya Brokhman wrote:
  I have already fixed this one myself ;-)
  
 
 Oh, ok :) Thank you!

it might take a while for kernel.org to replicate things, maybe that's
why you didn't see before ;-)

give it a few more minutes and check my gadget branch to see if it's all
good, I'm going to test it again on beagleboard to be sure nothing is
broken.

-- 
balbi


signature.asc
Description: Digital signature

RE: [PATCH v2 1/2] usb: gadget: add max_speed to usb_composite_driver

2011-06-29 Thread Tanya Brokhman 

 it might take a while for kernel.org to replicate things, maybe that's
 why you didn't see before ;-)
 
 give it a few more minutes and check my gadget branch to see if it's
 all good, I'm going to test it again on beagleboard to be sure nothing
 is broken.
 

Hi Felipe

I went over the emails and all is ok. Thanks!
One question: Greg/Alan mentioned that the compilation warning should be
fixed by __maybe_unused. I wasn't aware such thing existed. Just looked it
up. 
Do you want me to send you a patch that fixes that or have you done it
already and I missed it again :) ?


Thanks,
Tanya Brokhman
---
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.





--
To unsubscribe from this list: send the line unsubscribe linux-arm-msm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V1] led: pm8xxx: Add pm8xxx leds driver

2011-06-29 Thread Stephen Boyd 
On 06/22/2011 03:49 AM, Anirudh Ghayal wrote:
 +
 +/**
 + * struct pm8xxx_led_data - internal led data structure
 + * @led_classdev - led class device
 + * @id - led index
 + * @led_brightness - led brightness levels
 + * @work - workqueue for led
 + * @lock - to protect the transactions
 + * @reg - cached value of led register
 + */

This isn't kerneldoc notation.

 +fail_id_check:
 + if (i  0) {
 + for (i = i - 1; i = 0; i--) {
 + int index = pdata-leds[i].flags;
 + mutex_destroy(led[index].lock);
 + led_classdev_unregister(led[index].cdev);
 + }
 + }

if (i  0) is redundant here.

 +/**
 + * enum pm8xxx_leds - PMIC8XXX supported led ids
 + * @PM8XXX_ID_LED_KB_LIGHT - keyboard backlight led
 + * @PM8XXX_ID_LED_0 - First low current led
 + * @PM8XXX_ID_LED_1 - Second low current led
 + * @PM8XXX_ID_LED_2 - Third low current led
 + * @PM8XXX_ID_FLASH_LED_0 - First flash led
 + * @PM8XXX_ID_FLASH_LED_0 - Second flash led
 + */
 +

This isn't kerneldoc notation.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line unsubscribe linux-arm-msm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] arm: platsmp: Allow secondary cpu hotplug with maxcpus=1

2011-06-29 Thread Stephen Boyd 
If an ARM system has multiple cpus in the same socket and the
kernel is booted with maxcpus=1, secondary cpus are possible but
not present due to how platform_smp_prepare_cpus() is called.
Fix this by always calling platform_smp_prepare_cpus() as long as
max_cpus is non-zero (0 means no SMP) to allow platform code to
decide if any non-boot cpus are present in the system. Since
all current platform code doesn't support physical hotplug we
have a situation where possible == present and thus we can
simply copy the possible map to the present map.

With this patch it's possible to boot an ARM system with
maxcpus=1 on the command line and then hotplug in secondary cpus
via sysfs. This is more in line with how x86 works with maxcpus=1
on the command line.

Signed-off-by: Stephen Boyd sb...@codeaurora.org
---

This patch was tested along with an MSM patch:

  https://lkml.org/lkml/2011/4/7/354

I don't have any non-MSM hardware to test on so Acks and
tested-bys are welcome.

 arch/arm/kernel/smp.c |3 +--
 arch/arm/mach-exynos4/platsmp.c   |5 +
 arch/arm/mach-msm/platsmp.c   |5 +
 arch/arm/mach-omap2/omap-smp.c|5 +
 arch/arm/mach-realview/platsmp.c  |5 +
 arch/arm/mach-shmobile/platsmp.c  |5 +
 arch/arm/mach-tegra/platsmp.c |5 +
 arch/arm/mach-ux500/platsmp.c |5 +
 arch/arm/mach-vexpress/ct-ca9x4.c |5 +
 9 files changed, 9 insertions(+), 34 deletions(-)

diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
index e7f92a4..fbaa24a 100644
--- a/arch/arm/kernel/smp.c
+++ b/arch/arm/kernel/smp.c
@@ -365,8 +365,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
 */
if (max_cpus  ncores)
max_cpus = ncores;
-
-   if (max_cpus  1) {
+   if (ncores  1  max_cpus) {
/*
 * Enable the local timer or broadcast device for the
 * boot CPU, but only if we have more than one CPU.
diff --git a/arch/arm/mach-exynos4/platsmp.c b/arch/arm/mach-exynos4/platsmp.c
index c5e65a0..3f870d2 100644
--- a/arch/arm/mach-exynos4/platsmp.c
+++ b/arch/arm/mach-exynos4/platsmp.c
@@ -154,14 +154,11 @@ void __init smp_init_cpus(void)
 
 void __init platform_smp_prepare_cpus(unsigned int max_cpus)
 {
-   int i;
-
/*
 * Initialise the present map, which describes the set of CPUs
 * actually populated at the present time.
 */
-   for (i = 0; i  max_cpus; i++)
-   set_cpu_present(i, true);
+   init_cpu_present(cpu_possible_map);
 
scu_enable(scu_base_addr());
 
diff --git a/arch/arm/mach-msm/platsmp.c b/arch/arm/mach-msm/platsmp.c
index 2034098..84e293f 100644
--- a/arch/arm/mach-msm/platsmp.c
+++ b/arch/arm/mach-msm/platsmp.c
@@ -157,12 +157,9 @@ void __init smp_init_cpus(void)
 
 void __init platform_smp_prepare_cpus(unsigned int max_cpus)
 {
-   int i;
-
/*
 * Initialise the present map, which describes the set of CPUs
 * actually populated at the present time.
 */
-   for (i = 0; i  max_cpus; i++)
-   set_cpu_present(i, true);
+   init_cpu_present(cpu_possible_map);
 }
diff --git a/arch/arm/mach-omap2/omap-smp.c b/arch/arm/mach-omap2/omap-smp.c
index ecfe93c..5895d19 100644
--- a/arch/arm/mach-omap2/omap-smp.c
+++ b/arch/arm/mach-omap2/omap-smp.c
@@ -125,14 +125,11 @@ void __init smp_init_cpus(void)
 
 void __init platform_smp_prepare_cpus(unsigned int max_cpus)
 {
-   int i;
-
/*
 * Initialise the present map, which describes the set of CPUs
 * actually populated at the present time.
 */
-   for (i = 0; i  max_cpus; i++)
-   set_cpu_present(i, true);
+   init_cpu_present(cpu_possible_map);
 
/*
 * Initialise the SCU and wake up the secondary core using
diff --git a/arch/arm/mach-realview/platsmp.c b/arch/arm/mach-realview/platsmp.c
index 963bf0d..00666be 100644
--- a/arch/arm/mach-realview/platsmp.c
+++ b/arch/arm/mach-realview/platsmp.c
@@ -68,14 +68,11 @@ void __init smp_init_cpus(void)
 
 void __init platform_smp_prepare_cpus(unsigned int max_cpus)
 {
-   int i;
-
/*
 * Initialise the present map, which describes the set of CPUs
 * actually populated at the present time.
 */
-   for (i = 0; i  max_cpus; i++)
-   set_cpu_present(i, true);
+   init_cpu_present(cpu_possible_map);
 
scu_enable(scu_base_addr());
 
diff --git a/arch/arm/mach-shmobile/platsmp.c b/arch/arm/mach-shmobile/platsmp.c
index f3888fe..ca5b523 100644
--- a/arch/arm/mach-shmobile/platsmp.c
+++ b/arch/arm/mach-shmobile/platsmp.c
@@ -64,10 +64,7 @@ void __init smp_init_cpus(void)
 
 void __init platform_smp_prepare_cpus(unsigned int max_cpus)
 {
-   int i;
-
-   for (i = 0; i  max_cpus; i++)
-   set_cpu_present(i, true);
+   init_cpu_present(cpu_possible_map);
 
shmobile_smp_prepare_cpus();
 }
diff --git

Re: [PATCH v2 1/2] usb: gadget: add max_speed to usb_composite_driver

2011-06-29 Thread Felipe Balbi 
Hi,

On Wed, Jun 29, 2011 at 08:27:17PM +0300, Tanya Brokhman wrote:
  it might take a while for kernel.org to replicate things, maybe that's
  why you didn't see before ;-)
  
  give it a few more minutes and check my gadget branch to see if it's
  all good, I'm going to test it again on beagleboard to be sure nothing
  is broken.
  
 
 I went over the emails and all is ok. Thanks!
 One question: Greg/Alan mentioned that the compilation warning should be
 fixed by __maybe_unused. I wasn't aware such thing existed. Just looked it
 up. 
 Do you want me to send you a patch that fixes that or have you done it
 already and I missed it again :) ?

Oops, I didn't. You can send a differential patch (just this change in
particular) and I'll merge into the original.

-- 
balbi


signature.asc
Description: Digital signature

[PATCH] usb: gadget: Compilation warning fix

2011-06-29 Thread Tatyana Brokhman 
A compilation warning was added by the patch
usb: gadget: use config_ep_by_speed() instead of ep_choose().
This patch fixed it.

Signed-off-by: Tatyana Brokhman tlin...@codeaurora.org

---
 drivers/usb/gadget/storage_common.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/gadget/storage_common.c 
b/drivers/usb/gadget/storage_common.c
index 1fa4f70..544e6b3 100644
--- a/drivers/usb/gadget/storage_common.c
+++ b/drivers/usb/gadget/storage_common.c
@@ -494,7 +494,7 @@ static struct usb_descriptor_header *fsg_hs_function[] = {
 };
 
 /* Maxpacket and other transfer characteristics vary by speed. */
-static struct usb_endpoint_descriptor *
+__maybe_unused static struct usb_endpoint_descriptor *
 fsg_ep_desc(struct usb_gadget *g, struct usb_endpoint_descriptor *fs,
struct usb_endpoint_descriptor *hs)
 {
-- 
1.7.3.3

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line unsubscribe linux-arm-msm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/2] usb: gadget: add max_speed to usb_composite_driver

2011-06-29 Thread Greg KH 
On Thu, Jun 30, 2011 at 08:14:15AM +0300, Tanya Brokhman wrote:
 Good morning Felipe,
 
   I went over the emails and all is ok. Thanks!
   One question: Greg/Alan mentioned that the compilation warning should
   be fixed by __maybe_unused. I wasn't aware such thing existed. Just
   looked it up.
   Do you want me to send you a patch that fixes that or have you done
  it
   already and I missed it again :) ?
  
  Oops, I didn't. You can send a differential patch (just this change in
  particular) and I'll merge into the original.
 
 Just emailed you the fixing patch.
 Just one thing. Greg already merged the patch that caused the compilation
 warning into his tree so perhaps you can't merge the fix into the original
 patch and need to post the fix as a different patch

Nope, you can't, I need just a single patch that resolves this.  I'll
queue up the patch you just sent, thanks.

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-arm-msm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v2 1/2] usb: gadget: add max_speed to usb_composite_driver

2011-06-29 Thread Tanya Brokhman 
 
  Just emailed you the fixing patch.
  Just one thing. Greg already merged the patch that caused the
 compilation
  warning into his tree so perhaps you can't merge the fix into the
 original
  patch and need to post the fix as a different patch
 
 Nope, you can't, I need just a single patch that resolves this.  I'll
 queue up the patch you just sent, thanks.
 

One sec! I just found out that I was running checkpatch.pl from a wrong
location. There is a checkpatch warning. I'll send you the fix in a few
minutes.
Sorry.


Thanks,
Tanya Brokhman
---
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.




--
To unsubscribe from this list: send the line unsubscribe linux-arm-msm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2] usb: gadget: Compilation warning fix

2011-06-29 Thread Tatyana Brokhman 
A compilation warning was added by the patch
usb: gadget: use config_ep_by_speed() instead of ep_choose().
This patch fixed it.

Signed-off-by: Tatyana Brokhman tlin...@codeaurora.org

---
 drivers/usb/gadget/storage_common.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/gadget/storage_common.c 
b/drivers/usb/gadget/storage_common.c
index 1fa4f70..d3dd227 100644
--- a/drivers/usb/gadget/storage_common.c
+++ b/drivers/usb/gadget/storage_common.c
@@ -494,7 +494,7 @@ static struct usb_descriptor_header *fsg_hs_function[] = {
 };
 
 /* Maxpacket and other transfer characteristics vary by speed. */
-static struct usb_endpoint_descriptor *
+static __maybe_unused struct usb_endpoint_descriptor *
 fsg_ep_desc(struct usb_gadget *g, struct usb_endpoint_descriptor *fs,
struct usb_endpoint_descriptor *hs)
 {
-- 
1.7.3.3

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line unsubscribe linux-arm-msm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v2 1/2] usb: gadget: add max_speed to usb_composite_driver

2011-06-29 Thread Tanya Brokhman 
 
 One sec! I just found out that I was running checkpatch.pl from a wrong
 location. There is a checkpatch warning. I'll send you the fix in a few
 minutes.
 Sorry.
 


Done! Please pick up [PATCH v2] usb: gadget: Compilation warning fix.
Sorry for the trouble...


Thanks,
Tanya Brokhman
---
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.




--
To unsubscribe from this list: send the line unsubscribe linux-arm-msm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html