Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver
On Tue, Aug 02, 2011 at 02:30:18PM +0530, Anirudh Ghayal wrote: Hi Dmitry, On 8/2/2011 12:11 PM, Dmitry Torokhov wrote: On Tue, Aug 02, 2011 at 11:57:13AM +0530, Anirudh Ghayal wrote: Yes should have been dev_err. Dmitry, would you like me to submit another patch for this? I can make the @work change as well. Or would you make this minor change as well. Thank you. Anirudh, I made this plus a few more cosmetic changes, if you could try the patch below and let me know if it still works I will commit it for the next merge window. Thank you for making changes. I have tested the patch and it works fine. Thank you, I queued it for 3.2. -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver
Hi Shubhrajyoti,
Thanks for the review.
On 8/2/2011 11:34 AM, Shubhrajyoti Datta wrote:
Hi Amy,
On Tue, Aug 2, 2011 at 9:43 AM, Anirudh Ghayal agha...@codeaurora.org
mailto:agha...@codeaurora.org wrote:
From: Amy Maloche amalo...@codeaurora.org
mailto:amalo...@codeaurora.org
Add support for pm8xx based vibrator to facilitate haptics.
This module uses the ff-memless framework.
Cc: Dmitry Torokhov dmitry.torok...@gmail.com
mailto:dmitry.torok...@gmail.com
Signed-off-by: Amy Maloche amalo...@codeaurora.org
mailto:amalo...@codeaurora.org
Signed-off-by: Anirudh Ghayal agha...@codeaurora.org
mailto:agha...@codeaurora.org
---
Changes:
Addressed Dmitry's comments from the previous RFC submission.
lkml.org/lkml/2011/2/2/53 http://lkml.org/lkml/2011/2/2/53
drivers/input/misc/Kconfig | 12 ++
drivers/input/misc/Makefile |1 +
drivers/input/misc/pm8xxx-vibrator.c | 309
++
3 files changed, 322 insertions(+), 0 deletions(-)
create mode 100644 drivers/input/misc/pm8xxx-vibrator.c
diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index c9104bb..50b9e1b 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -74,6 +74,18 @@ config INPUT_PCSPKR
To compile this driver as a module, choose M here: the
module will be called pcspkr.
+config INPUT_PM8XXX_VIBRATOR
+ tristate Qualcomm PM8XXX vibrator support
You may want to specify the part number here. Just in case there is
another
vibrator with PM8XXX .
Here, we are only driving a signal out of the PMIC. You can have any
vibrator installed there. This is a common pin across all the PM8xxx PMICs.
+ depends on MFD_PM8XXX
+ select INPUT_FF_MEMLESS
+ help
+ This option enables device driver support for the vibrator
+ on Qualcomm PM8xxx chip. This driver supports ff-memless
interface
+ from input framework.
+
+ To compile this driver as module, choose M here: the
+ module will be called pm8xxx-vibrator.
+
config INPUT_SPARCSPKR
tristate SPARC Speaker support
depends on PCI SPARC64
diff --git a/drivers/input/misc/Makefile b/drivers/input/misc/Makefile
index 299ad5e..40ebe2b 100644
--- a/drivers/input/misc/Makefile
+++ b/drivers/input/misc/Makefile
@@ -34,6 +34,7 @@ obj-$(CONFIG_INPUT_PCAP) += pcap_keys.o
obj-$(CONFIG_INPUT_PCF50633_PMU) += pcf50633-input.o
obj-$(CONFIG_INPUT_PCF8574)+= pcf8574_keypad.o
obj-$(CONFIG_INPUT_PCSPKR) += pcspkr.o
+obj-$(CONFIG_INPUT_PM8XXX_VIBRATOR)+= pm8xxx-vibrator.o
obj-$(CONFIG_INPUT_POWERMATE) += powermate.o
obj-$(CONFIG_INPUT_PWM_BEEPER) += pwm-beeper.o
obj-$(CONFIG_INPUT_PMIC8XXX_PWRKEY)+= pmic8xxx-pwrkey.o
diff --git a/drivers/input/misc/pm8xxx-vibrator.c
b/drivers/input/misc/pm8xxx-vibrator.c
new file mode 100644
index 000..cb2d3ad
--- /dev/null
+++ b/drivers/input/misc/pm8xxx-vibrator.c
@@ -0,0 +1,309 @@
+/* Copyright (c) 2010-2011, Code Aurora Forum. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 and
+ * only version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include linux/module.h
+#include linux/init.h
+#include linux/kernel.h
+#include linux/errno.h
+#include linux/platform_device.h
+#include linux/input.h
+#include linux/slab.h
+#include linux/mfd/pm8xxx/core.h
+
+#define VIB_DRV0x4A
+
+#define VIB_DRV_SEL_MASK 0xf8
+#define VIB_DRV_SEL_SHIFT 0x03
+#define VIB_DRV_EN_MANUAL_MASK 0xfc
+
+#define VIB_MAX_LEVEL_mV (3100)
+#define VIB_MIN_LEVEL_mV (1200)
+#define VIB_MAX_LEVELS (VIB_MAX_LEVEL_mV - VIB_MIN_LEVEL_mV)
+
+#define MAX_FF_SPEED 0xff
+
+/*
+ * struct pm8xxx_vib - structure to hold vibrator data
+ * @vib_input_dev: input device supporting force feedback
+ * @vwork: work structure to set the vibration parameters
+ * @dev: device supporting force feedback
+ * @speed: speed of vibration set from userland
+ * @state: state of vibrator
+ * @level: level of vibration to set in the chip
+ * @reg_vib_drv: VIB_DRV register value
+ *
+ */
+struct pm8xxx_vib {
+
Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver
On Tue, Aug 02, 2011 at 11:57:13AM +0530, Anirudh Ghayal wrote: Yes should have been dev_err. Dmitry, would you like me to submit another patch for this? I can make the @work change as well. Or would you make this minor change as well. Thank you. Anirudh, I made this plus a few more cosmetic changes, if you could try the patch below and let me know if it still works I will commit it for the next merge window. Thanks. -- Dmitry Input: misc - Add support for pm8xxx based vibrator driver From: Amy Maloche amalo...@codeaurora.org Add support for pm8xx based vibrator to facilitate haptics. This module uses the ff-memless framework. Signed-off-by: Amy Maloche amalo...@codeaurora.org Signed-off-by: Anirudh Ghayal agha...@codeaurora.org Reviewed-by: Wanlong Gao gaowanl...@cn.fujitsu.com Signed-off-by: Dmitry Torokhov d...@mail.ru --- drivers/input/misc/Kconfig | 34 +++- drivers/input/misc/Makefile |3 drivers/input/misc/pm8xxx-vibrator.c | 296 ++ 3 files changed, 321 insertions(+), 12 deletions(-) create mode 100644 drivers/input/misc/pm8xxx-vibrator.c diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig index 7ec4a20..bc53df5 100644 --- a/drivers/input/misc/Kconfig +++ b/drivers/input/misc/Kconfig @@ -74,6 +74,29 @@ config INPUT_PCSPKR To compile this driver as a module, choose M here: the module will be called pcspkr. +config INPUT_PM8XXX_VIBRATOR + tristate Qualcomm PM8XXX vibrator support + depends on MFD_PM8XXX + select INPUT_FF_MEMLESS + help + This option enables device driver support for the vibrator + on Qualcomm PM8xxx chip. This driver supports ff-memless interface + from input framework. + + To compile this driver as module, choose M here: the + module will be called pm8xxx-vibrator. + +config INPUT_PMIC8XXX_PWRKEY + tristate PMIC8XXX power key support + depends on MFD_PM8XXX + help + Say Y here if you want support for the PMIC8XXX power key. + + If unsure, say N. + + To compile this driver as a module, choose M here: the + module will be called pmic8xxx-pwrkey. + config INPUT_SPARCSPKR tristate SPARC Speaker support depends on PCI SPARC64 @@ -368,17 +391,6 @@ config INPUT_PWM_BEEPER To compile this driver as a module, choose M here: the module will be called pwm-beeper. -config INPUT_PMIC8XXX_PWRKEY - tristate PMIC8XXX power key support - depends on MFD_PM8XXX - help - Say Y here if you want support for the PMIC8XXX power key. - - If unsure, say N. - - To compile this driver as a module, choose M here: the - module will be called pmic8xxx-pwrkey. - config INPUT_GPIO_ROTARY_ENCODER tristate Rotary encoders connected to GPIO pins depends on GPIOLIB GENERIC_GPIO diff --git a/drivers/input/misc/Makefile b/drivers/input/misc/Makefile index b56b9bf..3dc2a5f 100644 --- a/drivers/input/misc/Makefile +++ b/drivers/input/misc/Makefile @@ -34,9 +34,10 @@ obj-$(CONFIG_INPUT_PCAP) += pcap_keys.o obj-$(CONFIG_INPUT_PCF50633_PMU) += pcf50633-input.o obj-$(CONFIG_INPUT_PCF8574)+= pcf8574_keypad.o obj-$(CONFIG_INPUT_PCSPKR) += pcspkr.o +obj-$(CONFIG_INPUT_PM8XXX_VIBRATOR)+= pm8xxx-vibrator.o +obj-$(CONFIG_INPUT_PMIC8XXX_PWRKEY)+= pmic8xxx-pwrkey.o obj-$(CONFIG_INPUT_POWERMATE) += powermate.o obj-$(CONFIG_INPUT_PWM_BEEPER) += pwm-beeper.o -obj-$(CONFIG_INPUT_PMIC8XXX_PWRKEY)+= pmic8xxx-pwrkey.o obj-$(CONFIG_INPUT_RB532_BUTTON) += rb532_button.o obj-$(CONFIG_INPUT_GPIO_ROTARY_ENCODER)+= rotary_encoder.o obj-$(CONFIG_INPUT_SGI_BTNS) += sgi_btns.o diff --git a/drivers/input/misc/pm8xxx-vibrator.c b/drivers/input/misc/pm8xxx-vibrator.c new file mode 100644 index 000..58c72c5 --- /dev/null +++ b/drivers/input/misc/pm8xxx-vibrator.c @@ -0,0 +1,296 @@ +/* Copyright (c) 2010-2011, Code Aurora Forum. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 and + * only version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include linux/module.h +#include linux/init.h +#include linux/kernel.h +#include linux/errno.h +#include linux/platform_device.h +#include linux/input.h +#include linux/slab.h +#include linux/mfd/pm8xxx/core.h + +#define VIB_DRV0x4A + +#define VIB_DRV_SEL_MASK 0xf8 +#define VIB_DRV_SEL_SHIFT 0x03 +#define VIB_DRV_EN_MANUAL_MASK 0xfc + +#define VIB_MAX_LEVEL_mV
Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver
Hi Dmitry, On 8/2/2011 12:11 PM, Dmitry Torokhov wrote: On Tue, Aug 02, 2011 at 11:57:13AM +0530, Anirudh Ghayal wrote: Yes should have been dev_err. Dmitry, would you like me to submit another patch for this? I can make the @work change as well. Or would you make this minor change as well. Thank you. Anirudh, I made this plus a few more cosmetic changes, if you could try the patch below and let me know if it still works I will commit it for the next merge window. Thank you for making changes. I have tested the patch and it works fine. Thank you, ~Anirudh Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] input: misc: Add support for pm8xxx based vibrator driver
From: Amy Maloche amalo...@codeaurora.org
Add support for pm8xx based vibrator to facilitate haptics.
This module uses the ff-memless framework.
Cc: Dmitry Torokhov dmitry.torok...@gmail.com
Signed-off-by: Amy Maloche amalo...@codeaurora.org
Signed-off-by: Anirudh Ghayal agha...@codeaurora.org
---
Changes:
Addressed Dmitry's comments from the previous RFC submission.
lkml.org/lkml/2011/2/2/53
drivers/input/misc/Kconfig | 12 ++
drivers/input/misc/Makefile |1 +
drivers/input/misc/pm8xxx-vibrator.c | 309 ++
3 files changed, 322 insertions(+), 0 deletions(-)
create mode 100644 drivers/input/misc/pm8xxx-vibrator.c
diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index c9104bb..50b9e1b 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -74,6 +74,18 @@ config INPUT_PCSPKR
To compile this driver as a module, choose M here: the
module will be called pcspkr.
+config INPUT_PM8XXX_VIBRATOR
+ tristate Qualcomm PM8XXX vibrator support
+ depends on MFD_PM8XXX
+ select INPUT_FF_MEMLESS
+ help
+ This option enables device driver support for the vibrator
+ on Qualcomm PM8xxx chip. This driver supports ff-memless interface
+ from input framework.
+
+ To compile this driver as module, choose M here: the
+ module will be called pm8xxx-vibrator.
+
config INPUT_SPARCSPKR
tristate SPARC Speaker support
depends on PCI SPARC64
diff --git a/drivers/input/misc/Makefile b/drivers/input/misc/Makefile
index 299ad5e..40ebe2b 100644
--- a/drivers/input/misc/Makefile
+++ b/drivers/input/misc/Makefile
@@ -34,6 +34,7 @@ obj-$(CONFIG_INPUT_PCAP) += pcap_keys.o
obj-$(CONFIG_INPUT_PCF50633_PMU) += pcf50633-input.o
obj-$(CONFIG_INPUT_PCF8574)+= pcf8574_keypad.o
obj-$(CONFIG_INPUT_PCSPKR) += pcspkr.o
+obj-$(CONFIG_INPUT_PM8XXX_VIBRATOR)+= pm8xxx-vibrator.o
obj-$(CONFIG_INPUT_POWERMATE) += powermate.o
obj-$(CONFIG_INPUT_PWM_BEEPER) += pwm-beeper.o
obj-$(CONFIG_INPUT_PMIC8XXX_PWRKEY)+= pmic8xxx-pwrkey.o
diff --git a/drivers/input/misc/pm8xxx-vibrator.c
b/drivers/input/misc/pm8xxx-vibrator.c
new file mode 100644
index 000..cb2d3ad
--- /dev/null
+++ b/drivers/input/misc/pm8xxx-vibrator.c
@@ -0,0 +1,309 @@
+/* Copyright (c) 2010-2011, Code Aurora Forum. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 and
+ * only version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include linux/module.h
+#include linux/init.h
+#include linux/kernel.h
+#include linux/errno.h
+#include linux/platform_device.h
+#include linux/input.h
+#include linux/slab.h
+#include linux/mfd/pm8xxx/core.h
+
+#define VIB_DRV0x4A
+
+#define VIB_DRV_SEL_MASK 0xf8
+#define VIB_DRV_SEL_SHIFT 0x03
+#define VIB_DRV_EN_MANUAL_MASK 0xfc
+
+#define VIB_MAX_LEVEL_mV (3100)
+#define VIB_MIN_LEVEL_mV (1200)
+#define VIB_MAX_LEVELS (VIB_MAX_LEVEL_mV - VIB_MIN_LEVEL_mV)
+
+#define MAX_FF_SPEED 0xff
+
+/*
+ * struct pm8xxx_vib - structure to hold vibrator data
+ * @vib_input_dev: input device supporting force feedback
+ * @vwork: work structure to set the vibration parameters
+ * @dev: device supporting force feedback
+ * @speed: speed of vibration set from userland
+ * @state: state of vibrator
+ * @level: level of vibration to set in the chip
+ * @reg_vib_drv: VIB_DRV register value
+ *
+ */
+struct pm8xxx_vib {
+ struct input_dev *vib_input_dev;
+ struct work_struct work;
+ struct device *dev;
+ int speed;
+ int state;
+ int level;
+ u8 reg_vib_drv;
+};
+
+/*
+ * pm8xxx_vib_read_u8 - helper to read a byte from pmic chip
+ * @vib: pointer to vibrator structure
+ * @data: placeholder for data to be read
+ * @reg: register address
+ *
+ */
+static int pm8xxx_vib_read_u8(struct pm8xxx_vib *vib,
+u8 *data, u16 reg)
+{
+ int rc;
+
+ rc = pm8xxx_readb(vib-dev-parent, reg, data);
+ if (rc 0)
+ dev_warn(vib-dev, Error reading pm8xxx reg 0x%x(0x%x)\n,
+ reg, rc);
+ return rc;
+}
+
+/*
+ * pm8xxx_vib_write_u8 - helper to write a byte to pmic chip
+ * @vib: pointer to vibrator structure
+ * @data: data to write
+ * @reg: register address
+ *
+ */
+static int pm8xxx_vib_write_u8(struct pm8xxx_vib *vib,
+u8 data, u16 reg)
+{
+ int rc;
+
+ rc = pm8xxx_writeb(vib-dev-parent, reg, data);
+
Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver
On 08/02/2011 12:13 PM, Anirudh Ghayal wrote: From: Amy Malocheamalo...@codeaurora.org Add support for pm8xx based vibrator to facilitate haptics. This module uses the ff-memless framework. Cc: Dmitry Torokhovdmitry.torok...@gmail.com Signed-off-by: Amy Malocheamalo...@codeaurora.org Signed-off-by: Anirudh Ghayalagha...@codeaurora.org --- Changes: Addressed Dmitry's comments from the previous RFC submission. lkml.org/lkml/2011/2/2/53 drivers/input/misc/Kconfig | 12 ++ drivers/input/misc/Makefile |1 + drivers/input/misc/pm8xxx-vibrator.c | 309 ++ 3 files changed, 322 insertions(+), 0 deletions(-) create mode 100644 drivers/input/misc/pm8xxx-vibrator.c diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig index c9104bb..50b9e1b 100644 --- a/drivers/input/misc/Kconfig +++ b/drivers/input/misc/Kconfig @@ -74,6 +74,18 @@ config INPUT_PCSPKR To compile this driver as a module, choose M here: the module will be called pcspkr. +config INPUT_PM8XXX_VIBRATOR + tristate Qualcomm PM8XXX vibrator support + depends on MFD_PM8XXX + select INPUT_FF_MEMLESS + help + This option enables device driver support for the vibrator + on Qualcomm PM8xxx chip. This driver supports ff-memless interface + from input framework. + + To compile this driver as module, choose M here: the + module will be called pm8xxx-vibrator. + config INPUT_SPARCSPKR tristate SPARC Speaker support depends on PCI SPARC64 diff --git a/drivers/input/misc/Makefile b/drivers/input/misc/Makefile index 299ad5e..40ebe2b 100644 --- a/drivers/input/misc/Makefile +++ b/drivers/input/misc/Makefile @@ -34,6 +34,7 @@ obj-$(CONFIG_INPUT_PCAP) += pcap_keys.o obj-$(CONFIG_INPUT_PCF50633_PMU) += pcf50633-input.o obj-$(CONFIG_INPUT_PCF8574) += pcf8574_keypad.o obj-$(CONFIG_INPUT_PCSPKR)+= pcspkr.o +obj-$(CONFIG_INPUT_PM8XXX_VIBRATOR)+= pm8xxx-vibrator.o obj-$(CONFIG_INPUT_POWERMATE) += powermate.o obj-$(CONFIG_INPUT_PWM_BEEPER)+= pwm-beeper.o obj-$(CONFIG_INPUT_PMIC8XXX_PWRKEY) += pmic8xxx-pwrkey.o diff --git a/drivers/input/misc/pm8xxx-vibrator.c b/drivers/input/misc/pm8xxx-vibrator.c new file mode 100644 index 000..cb2d3ad --- /dev/null +++ b/drivers/input/misc/pm8xxx-vibrator.c @@ -0,0 +1,309 @@ +/* Copyright (c) 2010-2011, Code Aurora Forum. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 and + * only version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#includelinux/module.h +#includelinux/init.h +#includelinux/kernel.h +#includelinux/errno.h +#includelinux/platform_device.h +#includelinux/input.h +#includelinux/slab.h +#includelinux/mfd/pm8xxx/core.h + +#define VIB_DRV0x4A + +#define VIB_DRV_SEL_MASK 0xf8 +#define VIB_DRV_SEL_SHIFT 0x03 +#define VIB_DRV_EN_MANUAL_MASK 0xfc + +#define VIB_MAX_LEVEL_mV (3100) +#define VIB_MIN_LEVEL_mV (1200) +#define VIB_MAX_LEVELS (VIB_MAX_LEVEL_mV - VIB_MIN_LEVEL_mV) + +#define MAX_FF_SPEED 0xff + +/* + * struct pm8xxx_vib - structure to hold vibrator data + * @vib_input_dev: input device supporting force feedback + * @vwork: work structure to set the vibration parameters Anirudh, It's should be @work? + * @dev: device supporting force feedback + * @speed: speed of vibration set from userland + * @state: state of vibrator + * @level: level of vibration to set in the chip + * @reg_vib_drv: VIB_DRV register value + * + */ Thanks Best Regards Wanlong Gao -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver
On Tue, Aug 02, 2011 at 12:42:43PM +0800, Wanlong Gao wrote: On 08/02/2011 12:13 PM, Anirudh Ghayal wrote: +/* + * struct pm8xxx_vib - structure to hold vibrator data + * @vib_input_dev: input device supporting force feedback + * @vwork: work structure to set the vibration parameters Anirudh, It's should be @work? Looks like it, I can fix it up locally, no need to resubmit. BTW, please do not hesitate to add your Reviewed-by or Acked-by if you are mostly satisfied with the patch (sans a few minor issues that you should point out). I can't guarantee that I will always add your tags (depends on when I commit the patch to my one of my public branches) but I will try to do so. Thanks. -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver
On 08/02/2011 01:11 PM, Dmitry Torokhov wrote: On Tue, Aug 02, 2011 at 12:42:43PM +0800, Wanlong Gao wrote: On 08/02/2011 12:13 PM, Anirudh Ghayal wrote: +/* + * struct pm8xxx_vib - structure to hold vibrator data + * @vib_input_dev: input device supporting force feedback + * @vwork: work structure to set the vibration parameters Anirudh, It's should be @work? Looks like it, I can fix it up locally, no need to resubmit. BTW, please do not hesitate to add your Reviewed-by or Acked-by if you are mostly satisfied with the patch (sans a few minor issues that you should point out). I can't guarantee that I will always add your tags (depends on when I commit the patch to my one of my public branches) but I will try to do so. Thanks. Sure, I see, thanks Dmitry. Wanlong Gao -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver
On Tue, Aug 02, 2011 at 01:18:46PM +0800, Wanlong Gao wrote: On 08/02/2011 01:11 PM, Dmitry Torokhov wrote: On Tue, Aug 02, 2011 at 12:42:43PM +0800, Wanlong Gao wrote: On 08/02/2011 12:13 PM, Anirudh Ghayal wrote: +/* + * struct pm8xxx_vib - structure to hold vibrator data + * @vib_input_dev: input device supporting force feedback + * @vwork: work structure to set the vibration parameters Anirudh, It's should be @work? Looks like it, I can fix it up locally, no need to resubmit. BTW, please do not hesitate to add your Reviewed-by or Acked-by if you are mostly satisfied with the patch (sans a few minor issues that you should point out). I can't guarantee that I will always add your tags (depends on when I commit the patch to my one of my public branches) but I will try to do so. Thanks. Sure, I see, thanks Dmitry. So was this reviewed-by? ;) -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver
On 08/02/2011 01:26 PM, Dmitry Torokhov wrote: On Tue, Aug 02, 2011 at 01:18:46PM +0800, Wanlong Gao wrote: On 08/02/2011 01:11 PM, Dmitry Torokhov wrote: On Tue, Aug 02, 2011 at 12:42:43PM +0800, Wanlong Gao wrote: On 08/02/2011 12:13 PM, Anirudh Ghayal wrote: +/* + * struct pm8xxx_vib - structure to hold vibrator data + * @vib_input_dev: input device supporting force feedback + * @vwork: work structure to set the vibration parameters Anirudh, It's should be @work? Looks like it, I can fix it up locally, no need to resubmit. BTW, please do not hesitate to add your Reviewed-by or Acked-by if you are mostly satisfied with the patch (sans a few minor issues that you should point out). I can't guarantee that I will always add your tags (depends on when I commit the patch to my one of my public branches) but I will try to do so. Thanks. Sure, I see, thanks Dmitry. So was this reviewed-by? ;) Sure. Reviewed-by: Wanlong Gao gaowanl...@cn.fujitsu.com Sorry. ;) Thanks Best Regards Wanlong Gao -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
