Re: [PATCH v3 12/13] usb: phy: msm: Properly check core interrupt number

2013-10-15 Thread Ivan T. Ivanov 
On Mon, 2013-10-14 at 17:59 -0500, Felipe Balbi wrote: 
 On Mon, Oct 14, 2013 at 06:24:39PM +0300, Ivan T. Ivanov wrote:
  From: Ivan T. Ivanov iiva...@mm-sol.com
  
  IRQ with number 0 is valid case, so check for negative
 
 not entirelly correct... IRQ 0 isn't supposed to be used as a linux IRQ
 number IIRC.

I am not really sure. NO_IRQ is -1 at least on ARM. Also when
taking into account irqdomain's zero as interrupt number is valid??

 
  numbers instead.
  
  Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com
  ---
   drivers/usb/phy/phy-msm-usb.c |2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
  
  diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
  index ca2abe6..f34c8a9 100644
  --- a/drivers/usb/phy/phy-msm-usb.c
  +++ b/drivers/usb/phy/phy-msm-usb.c
  @@ -1415,7 +1415,7 @@ static int __init msm_otg_probe(struct 
  platform_device *pdev)
  dev_info(pdev-dev, OTG regs = %p\n, motg-regs);
   
  motg-irq = platform_get_irq(pdev, 0);
  -   if (!motg-irq) {
  +   if (motg-irq  0) {
 
 this check is correct though, since platform_get_irq() will return
 -ENXIO if it doesn't find IRQ resource.
 

Thanks,
Ivan

--
To unsubscribe from this list: send the line unsubscribe linux-arm-msm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 12/13] usb: phy: msm: Properly check core interrupt number

2013-10-14 Thread Ivan T. Ivanov 
From: Ivan T. Ivanov iiva...@mm-sol.com

IRQ with number 0 is valid case, so check for negative
numbers instead.

Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com
---
 drivers/usb/phy/phy-msm-usb.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index ca2abe6..f34c8a9 100644
--- a/drivers/usb/phy/phy-msm-usb.c
+++ b/drivers/usb/phy/phy-msm-usb.c
@@ -1415,7 +1415,7 @@ static int __init msm_otg_probe(struct platform_device 
*pdev)
dev_info(pdev-dev, OTG regs = %p\n, motg-regs);
 
motg-irq = platform_get_irq(pdev, 0);
-   if (!motg-irq) {
+   if (motg-irq  0) {
dev_err(pdev-dev, platform_get_irq failed\n);
return motg-irq;
}
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-arm-msm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 12/13] usb: phy: msm: Properly check core interrupt number

2013-10-14 Thread Felipe Balbi 
On Mon, Oct 14, 2013 at 06:24:39PM +0300, Ivan T. Ivanov wrote:
 From: Ivan T. Ivanov iiva...@mm-sol.com
 
 IRQ with number 0 is valid case, so check for negative

not entirelly correct... IRQ 0 isn't supposed to be used as a linux IRQ
number IIRC.

 numbers instead.
 
 Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com
 ---
  drivers/usb/phy/phy-msm-usb.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
 index ca2abe6..f34c8a9 100644
 --- a/drivers/usb/phy/phy-msm-usb.c
 +++ b/drivers/usb/phy/phy-msm-usb.c
 @@ -1415,7 +1415,7 @@ static int __init msm_otg_probe(struct platform_device 
 *pdev)
   dev_info(pdev-dev, OTG regs = %p\n, motg-regs);
  
   motg-irq = platform_get_irq(pdev, 0);
 - if (!motg-irq) {
 + if (motg-irq  0) {

this check is correct though, since platform_get_irq() will return
-ENXIO if it doesn't find IRQ resource.

-- 
balbi


signature.asc
Description: Digital signature