Re: [RFC/PATCH v4 0/3] UAS Gadget Driver.
* Shimrit Malichi | 2011-12-07 09:34:33 [-0800]: Hi guys, Hi, Thanks for all your inputs. The good thing is that we now have a better understanding of the UASP implementation that was done offline, and as balbi mentioned, probably avoid duplicate work. We will coordinate with Sebastian regarding the next phases. Just posted RFC of something that works at HS. It was tested against dummy_hcd so nobody is required to use real hardware :) Shimrit Sebastian -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC/PATCH v4 0/3] UAS Gadget Driver.
On Tue, Dec 06, 2011 at 09:09:55AM -0800, Greg KH wrote: On Tue, Dec 06, 2011 at 08:39:58AM -0800, Shimrit Malichi wrote: On Sun, Dec 04, 2011 at 10:18:14PM +0200, Shimrit Malichi wrote: This patch series implements the UAS gadget driver. It has been tested using the following: 1. Linux UAS host driver 2. Internaly developed unittests framework The device is functional. More stress tests are needed. TODO: Further testing De-register the gadget if the main thread dies. What about all of the review comments you seem to be ignoring that have been made for this driver in the past? greg k-h We addressed most of the comments. One of them was indeed to use the target framework, however when we asked an additional information about how to use this framework we didn't get a detailed reply. Sebastian gave an answer on how to use it yesterday. We will study his answer, and come up with a new code. No one is going to normally give you such a detailed answer as he did. You were told to go use that interface, and Sebastian did just that, why couldn't you have done that in the first place, saving you, and everyone else here, time and effort of telling you to go do that again? other than that, it's just waste of time if you go write new code, now that Sebastian already has that almost ready. Save yourself sometime and just help Sebastian finishing what he's already done. Even testing is welcome at this stage. -- balbi signature.asc Description: Digital signature
Re: [RFC/PATCH v4 0/3] UAS Gadget Driver.
On Tue, Dec 06, 2011 at 09:09:55AM -0800, Greg KH wrote: On Tue, Dec 06, 2011 at 08:39:58AM -0800, Shimrit Malichi wrote: On Sun, Dec 04, 2011 at 10:18:14PM +0200, Shimrit Malichi wrote: This patch series implements the UAS gadget driver. It has been tested using the following: 1. Linux UAS host driver 2. Internaly developed unittests framework The device is functional. More stress tests are needed. TODO: Further testing De-register the gadget if the main thread dies. What about all of the review comments you seem to be ignoring that have been made for this driver in the past? greg k-h We addressed most of the comments. One of them was indeed to use the target framework, however when we asked an additional information about how to use this framework we didn't get a detailed reply. Sebastian gave an answer on how to use it yesterday. We will study his answer, and come up with a new code. No one is going to normally give you such a detailed answer as he did. You were told to go use that interface, and Sebastian did just that, why couldn't you have done that in the first place, saving you, and everyone else here, time and effort of telling you to go do that again? other than that, it's just waste of time if you go write new code, now that Sebastian already has that almost ready. Save yourself sometime and just help Sebastian finishing what he's already done. Even testing is welcome at this stage. -- balbi Hi guys, Thanks for all your inputs. The good thing is that we now have a better understanding of the UASP implementation that was done offline, and as balbi mentioned, probably avoid duplicate work. We will coordinate with Sebastian regarding the next phases. Shimrit -- Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC/PATCH v4 0/3] UAS Gadget Driver.
On Tue, Dec 06, 2011 at 08:39:58AM -0800, Shimrit Malichi wrote: On Sun, Dec 04, 2011 at 10:18:14PM +0200, Shimrit Malichi wrote: This patch series implements the UAS gadget driver. It has been tested using the following: 1. Linux UAS host driver 2. Internaly developed unittests framework The device is functional. More stress tests are needed. TODO: Further testing De-register the gadget if the main thread dies. What about all of the review comments you seem to be ignoring that have been made for this driver in the past? greg k-h We addressed most of the comments. One of them was indeed to use the target framework, however when we asked an additional information about how to use this framework we didn't get a detailed reply. Sebastian gave an answer on how to use it yesterday. We will study his answer, and come up with a new code. No one is going to normally give you such a detailed answer as he did. You were told to go use that interface, and Sebastian did just that, why couldn't you have done that in the first place, saving you, and everyone else here, time and effort of telling you to go do that again? greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC/PATCH v4 0/3] UAS Gadget Driver.
On Sun, Dec 04, 2011 at 10:18:14PM +0200, Shimrit Malichi wrote: This patch series implements the UAS gadget driver. It has been tested using the following: 1. Linux UAS host driver 2. Internaly developed unittests framework The device is functional. More stress tests are needed. TODO: Further testing De-register the gadget if the main thread dies. What about all of the review comments you seem to be ignoring that have been made for this driver in the past? greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFC/PATCH v4 0/3] UAS Gadget Driver.
This patch series implements the UAS gadget driver. It has been tested using the following: 1. Linux UAS host driver 2. Internaly developed unittests framework The device is functional. More stress tests are needed. TODO: Further testing De-register the gadget if the main thread dies. Shimrit Malichi (3): uas: MS UAS Gadget driver - Infrastructure uas: MS UAS Gadget driver - Implementation uas: Supporting UAS and BOT configuration. drivers/usb/gadget/f_mass_storage.c | 66 +- drivers/usb/gadget/f_uasp.c | 2583 +++ drivers/usb/gadget/f_uasp.h | 524 +++ drivers/usb/gadget/mass_storage.c | 75 +- drivers/usb/gadget/storage_common.c | 90 ++- drivers/usb/gadget/uasp_cmdiu.c | 1898 + drivers/usb/gadget/uasp_tmiu.c | 528 +++ 7 files changed, 5687 insertions(+), 77 deletions(-) create mode 100644 drivers/usb/gadget/f_uasp.c create mode 100644 drivers/usb/gadget/f_uasp.h create mode 100644 drivers/usb/gadget/uasp_cmdiu.c create mode 100644 drivers/usb/gadget/uasp_tmiu.c -- 1.7.6 -- Sent by a Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
