Re: [PATCH v2 3/7] coresight: etm4x: Use task_is_in_init_pid_ns()

2021-12-14 Thread Balbir Singh
On Wed, Dec 08, 2021 at 04:33:16PM +0800, Leo Yan wrote:
> This patch replaces open code with task_is_in_init_pid_ns() to check if
> a task is in root PID namespace.
> 
> Signed-off-by: Leo Yan 
> ---
>  drivers/hwtracing/coresight/coresight-etm4x-sysfs.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c 
> b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c
> index a0640fa5c55b..10ef2a29006e 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c
> @@ -1890,7 +1890,7 @@ static ssize_t ctxid_pid_show(struct device *dev,
>* Don't use contextID tracing if coming from a PID namespace.  See
>* comment in ctxid_pid_store().
>*/
> - if (task_active_pid_ns(current) != _pid_ns)
> + if (!task_is_in_init_pid_ns(current))
>   return -EINVAL;
>  
>   spin_lock(>spinlock);
> @@ -1918,7 +1918,7 @@ static ssize_t ctxid_pid_store(struct device *dev,
>* As such refuse to use the feature if @current is not in the initial
>* PID namespace.
>*/
> - if (task_active_pid_ns(current) != _pid_ns)
> + if (!task_is_in_init_pid_ns(current))
>   return -EINVAL;
>  
>   /*
> @@ -1951,7 +1951,7 @@ static ssize_t ctxid_masks_show(struct device *dev,
>* Don't use contextID tracing if coming from a PID namespace.  See
>* comment in ctxid_pid_store().
>*/
> - if (task_active_pid_ns(current) != _pid_ns)
> + if (!task_is_in_init_pid_ns(current))
>   return -EINVAL;
>  
>   spin_lock(>spinlock);
> @@ -1975,7 +1975,7 @@ static ssize_t ctxid_masks_store(struct device *dev,
>* Don't use contextID tracing if coming from a PID namespace.  See
>* comment in ctxid_pid_store().
>*/
> - if (task_active_pid_ns(current) != _pid_ns)
> + if (!task_is_in_init_pid_ns(current))
>   return -EINVAL;
>  
>   /*

Acked-by: Balbir Singh 

--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit



Re: [PATCH v2 3/7] coresight: etm4x: Use task_is_in_init_pid_ns()

2021-12-08 Thread Suzuki K Poulose

On 08/12/2021 08:33, Leo Yan wrote:

This patch replaces open code with task_is_in_init_pid_ns() to check if
a task is in root PID namespace.

Signed-off-by: Leo Yan 
---



Reviewed-by: Suzuki K Poulose 

--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit