Re: [PATCH] blktests: remove unused null_blk parameter for _init_null_blk in block/016

[Omar Sandoval]

On Sat, Aug 25, 2018 at 06:06:19PM +0800, Yi Zhang wrote:
> Signed-off-by: Yi Zhang 
> ---
>  tests/block/016 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/block/016 b/tests/block/016
> index 0e6f2e1..e0a63ad 100755
> --- a/tests/block/016
> +++ b/tests/block/016
> @@ -32,7 +32,7 @@ requires() {
>  test() {
>   echo "Running ${TEST_NAME}"
>  
> - if ! _init_null_blk null_blk queue_mode=2 irqmode=2 
> completion_nsec=20; then
> + if ! _init_null_blk queue_mode=2 irqmode=2 completion_nsec=20; 
> then
>   return 1
>   fi

Applied, thanks!

Re: [PATCH] blktests: remove unused null_blk parameter for _init_null_blk in block/016

[Gi-Oh Kim]

looks good to me
Reviewed-by: Gioh Kim 



On Sat, Aug 25, 2018 at 12:06 PM, Yi Zhang  wrote:
> Signed-off-by: Yi Zhang 
> ---
>  tests/block/016 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/block/016 b/tests/block/016
> index 0e6f2e1..e0a63ad 100755
> --- a/tests/block/016
> +++ b/tests/block/016
> @@ -32,7 +32,7 @@ requires() {
>  test() {
> echo "Running ${TEST_NAME}"
>
> -   if ! _init_null_blk null_blk queue_mode=2 irqmode=2 
> completion_nsec=20; then
> +   if ! _init_null_blk queue_mode=2 irqmode=2 
> completion_nsec=20; then
> return 1
> fi
>
> --
> 2.17.1
>



-- 
GIOH KIM
Linux Kernel Entwickler

ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin

Tel:   +49 176 2697 8962
Fax:  +49 30 577 008 299
Email:gi-oh@profitbricks.com
URL:  https://www.profitbricks.de

Sitz der Gesellschaft: Berlin
Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
Geschäftsführer: Achim Weiss, Matthias Steinberg, Christoph Steffens

[PATCH] blktests: remove unused null_blk parameter for _init_null_blk in block/016

[Yi Zhang]

Signed-off-by: Yi Zhang 
---
 tests/block/016 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/block/016 b/tests/block/016
index 0e6f2e1..e0a63ad 100755
--- a/tests/block/016
+++ b/tests/block/016
@@ -32,7 +32,7 @@ requires() {
 test() {
echo "Running ${TEST_NAME}"
 
-   if ! _init_null_blk null_blk queue_mode=2 irqmode=2 
completion_nsec=20; then
+   if ! _init_null_blk queue_mode=2 irqmode=2 completion_nsec=20; 
then
return 1
fi
 
-- 
2.17.1