Re: [PATCH] block: add documentation for io_timeout

2018-11-28 Thread Bart Van Assche
On Thu, 2018-11-29 at 00:54 +0800, Weiping Zhang wrote:
> add documentation for /sys/block//queue/io_timeout
> 
> Signed-off-by: Weiping Zhang 
> ---
>  Documentation/ABI/testing/sysfs-block | 9 +
>  Documentation/block/queue-sysfs.txt   | 6 ++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-block 
> b/Documentation/ABI/testing/sysfs-block
> index dea212db9df3..f37cca16 100644
> --- a/Documentation/ABI/testing/sysfs-block
> +++ b/Documentation/ABI/testing/sysfs-block
> @@ -271,3 +271,12 @@ Description:
>   size of 512B sectors of the zones of the device, with
>   the eventual exception of the last zone of the device
>   which may be smaller.
> +
> +What:/sys/block//queue/io_timeout
> +Date:November 2018
> +Contact: Weiping Zhang 
> +Description:
> + io_timeout is the timeout in millisecods of a request in
> + block layer. The block layer will start a timer when low
> + level device driver start the request, and cancle timer
> + when request completes.
> diff --git a/Documentation/block/queue-sysfs.txt 
> b/Documentation/block/queue-sysfs.txt
> index 2c1e67058fd3..cbd44fe056fa 100644
> --- a/Documentation/block/queue-sysfs.txt
> +++ b/Documentation/block/queue-sysfs.txt
> @@ -67,6 +67,12 @@ If set to a value larger than 0, the kernel will put the 
> process issuing
>  IO to sleep for this amont of microseconds before entering classic
>  polling.
>  
> +io_timeout (RW)
> +---
> +This is the timeout in millisecods of a request in block layer.
> +The block layer will start a timer when low level device driver start
> +the request, and cancle timer when request completes.
> +
>  iostats (RW)
>  -
>  This file is used to control (on/off) the iostats accounting of the

Please run this patch through a spelling checker. I think "millisecods" should
be changed into "milliseconds" and also that "cancle" should be changed into
"cancel".

Thanks,

Bart.


[PATCH] block: add documentation for io_timeout

2018-11-28 Thread Weiping Zhang
add documentation for /sys/block//queue/io_timeout

Signed-off-by: Weiping Zhang 
---
 Documentation/ABI/testing/sysfs-block | 9 +
 Documentation/block/queue-sysfs.txt   | 6 ++
 2 files changed, 15 insertions(+)

diff --git a/Documentation/ABI/testing/sysfs-block 
b/Documentation/ABI/testing/sysfs-block
index dea212db9df3..f37cca16 100644
--- a/Documentation/ABI/testing/sysfs-block
+++ b/Documentation/ABI/testing/sysfs-block
@@ -271,3 +271,12 @@ Description:
size of 512B sectors of the zones of the device, with
the eventual exception of the last zone of the device
which may be smaller.
+
+What:  /sys/block//queue/io_timeout
+Date:  November 2018
+Contact:   Weiping Zhang 
+Description:
+   io_timeout is the timeout in millisecods of a request in
+   block layer. The block layer will start a timer when low
+   level device driver start the request, and cancle timer
+   when request completes.
diff --git a/Documentation/block/queue-sysfs.txt 
b/Documentation/block/queue-sysfs.txt
index 2c1e67058fd3..cbd44fe056fa 100644
--- a/Documentation/block/queue-sysfs.txt
+++ b/Documentation/block/queue-sysfs.txt
@@ -67,6 +67,12 @@ If set to a value larger than 0, the kernel will put the 
process issuing
 IO to sleep for this amont of microseconds before entering classic
 polling.
 
+io_timeout (RW)
+---
+This is the timeout in millisecods of a request in block layer.
+The block layer will start a timer when low level device driver start
+the request, and cancle timer when request completes.
+
 iostats (RW)
 -
 This file is used to control (on/off) the iostats accounting of the
-- 
2.14.1