On Tue, Jun 19, 2018 at 01:23:44PM -0700, Bart Van Assche wrote:
> Hello Omar,
>
> Since I noticed that several useful shellcheck warnings are suppressed in the
> blktests project, I came up with this patch series that reenables all
> shellcheck warnings and also suppresses false positive shellcheck reports. It
> would be appreciated if you could have a look at this patch series.
>
> Thanks,
>
> Bart.
> Bart Van Assche (9):
> common/rc: Fix _have_tracepoint()
> Annotate include statements in shell scripts where the source file is
> a variable
> check, tests/meta/012: Use array["index"] instead of array[index]
Applied these.
> Suppress shellcheck complaints about global variables
> check: Avoid that shellcheck complains that $FULL appears unused
These are definitely useful warnings that would be good to reenable, but
I'm not a huge fan of this fix. Adding boilerplate for the sake of
appeasing the linter is... meh. I think what we can do is make the
tests/foo/group and common/rc sourcing explicit and put the workaround
stuff in common/rc. Still boilerplate but it at least appears to serve a
real purpose. I'll work on that.
> Multiple tests: remove unused and undefined variables
Applied this one.
> Avoid passing tests/block/002 arguments to _init_scsi_debug
This warning is stupid, I'd prefer to keep it disabled.
> check: Suppress a shellcheck warning about the DMESG_FILTER
> initialization
This warning is also pretty pointless, but the fix is so trivial that I
applied it anyways.
> Makefile: Do not suppress useful shellcheck warnings
Of course, I had to replace this patch since I kept some of the warnings
in.
Thanks for the cleanup!
> Makefile | 15 +-
> check | 53 ++-
> common/cpuhotplug | 2 ++
> common/fio| 2 ++
> common/iopoll | 2 ++
> common/loop | 1 +
> common/nbd| 2 ++
> common/nvme | 2 ++
> common/rc | 2 ++
> common/scsi | 2 ++
> common/scsi_debug | 3 +++
> common/shellcheck | 4
> new | 1 +
> tests/block/001 | 1 +
> tests/block/002 | 3 ++-
> tests/block/003 | 2 ++
> tests/block/004 | 2 ++
> tests/block/005 | 2 ++
> tests/block/006 | 2 ++
> tests/block/007 | 1 +
> tests/block/009 | 1 +
> tests/block/010 | 2 ++
> tests/block/011 | 2 ++
> tests/block/012 | 2 ++
> tests/block/013 | 2 ++
> tests/block/014 | 2 ++
> tests/block/015 | 2 ++
> tests/block/016 | 2 ++
> tests/block/017 | 2 ++
> tests/block/018 | 2 ++
> tests/block/019 | 2 ++
> tests/block/020 | 2 ++
> tests/block/021 | 2 ++
> tests/loop/001| 2 ++
> tests/loop/003| 5 ++---
> tests/loop/005| 2 ++
> tests/meta/001| 2 ++
> tests/meta/002| 2 ++
> tests/meta/003| 2 ++
> tests/meta/004| 2 ++
> tests/meta/005| 2 ++
> tests/meta/006| 2 ++
> tests/meta/007| 2 ++
> tests/meta/008| 2 ++
> tests/meta/009| 2 ++
> tests/meta/010| 2 ++
> tests/meta/011| 2 ++
> tests/meta/012| 6 --
> tests/nbd/001 | 2 ++
> tests/nbd/002 | 2 ++
> tests/nvme/001| 2 ++
> tests/nvme/002| 2 ++
> tests/nvme/003| 2 ++
> tests/nvme/004| 2 ++
> tests/nvme/005| 2 ++
> tests/nvme/006| 2 ++
> tests/nvme/007| 2 ++
> tests/nvme/008| 2 ++
> tests/nvme/009| 2 ++
> tests/nvme/010| 5 +++--
> tests/nvme/011| 5 +++--
> tests/nvme/012| 3 ++-
> tests/nvme/013| 3 ++-
> tests/scsi/001| 2 ++
> tests/scsi/002| 2 ++
> tests/scsi/003| 2 ++
> tests/scsi/004| 1 +
> 67 files changed, 161 insertions(+), 50 deletions(-)
> create mode 100644 common/shellcheck
>
> --
> 2.17.1
>
