Re: [PATCH 2/9] Annotate include statements in shell scripts where the source file is a variable

2018-06-25 Thread Johannes Thumshirn
Looks good,
Reviewed-by: Johannes Thumshirn 
-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850


[PATCH 2/9] Annotate include statements in shell scripts where the source file is a variable

2018-06-19 Thread Bart Van Assche
This causes shellcheck to stop complaining about these include statements.

Signed-off-by: Bart Van Assche 
---
 check | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/check b/check
index 4baa8dde2436..5e1ba7bc8401 100755
--- a/check
+++ b/check
@@ -23,6 +23,7 @@ _found_test() {
 
unset DESCRIPTION QUICK TIMED requires device_requires test test_device
 
+   # shellcheck disable=SC1090
if ! . "tests/${test_name}"; then
return 1
fi
@@ -392,6 +393,7 @@ _run_test() {
CHECK_DMESG=1
DMESG_FILTER=cat
 
+   # shellcheck disable=SC1090
. "tests/${TEST_NAME}"
 
if declare -fF test >/dev/null; then
@@ -432,6 +434,7 @@ _run_group() {
local tests=("$@")
local group="${tests[0]%/*}"
 
+   # shellcheck disable=SC1090
. "tests/${group}/group"
 
if declare -fF group_requires >/dev/null && ! group_requires; then
-- 
2.17.1