Re: [PATCH 8/9] check: Suppress a shellcheck warning about the DMESG_FILTER initialization

2018-06-25 Thread Johannes Thumshirn
Looks good,
Reviewed-by: Johannes Thumshirn 
-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850


[PATCH 8/9] check: Suppress a shellcheck warning about the DMESG_FILTER initialization

2018-06-19 Thread Bart Van Assche
Avoid that shellcheck reports the following:

check:396:2: warning: Use var=$(command) to assign output (or quote to assign 
string). [SC2209]

Signed-off-by: Bart Van Assche 
---
 check | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/check b/check
index f1feb96b293e..e7439e163884 100755
--- a/check
+++ b/check
@@ -393,7 +393,7 @@ _call_test() {
 _run_test() {
TEST_NAME="$1"
CHECK_DMESG=1
-   DMESG_FILTER=cat
+   DMESG_FILTER="cat"
 
# shellcheck disable=SC1090
. "tests/${TEST_NAME}"
-- 
2.17.1