Re: [PATCH blktests 0/3] Add NVMeOF multipath tests

2018-10-05 Thread Omar Sandoval
On Thu, Sep 27, 2018 at 04:26:42PM -0700, Bart Van Assche wrote:
> On Tue, 2018-09-18 at 17:18 -0700, Omar Sandoval wrote:
> > On Tue, Sep 18, 2018 at 05:02:47PM -0700, Bart Van Assche wrote:
> > > On 9/18/18 4:24 PM, Omar Sandoval wrote:
> > > > On Tue, Sep 18, 2018 at 02:20:59PM -0700, Bart Van Assche wrote:
> > > > > Can you have a look at the updated master branch of
> > > > > https://github.com/bvanassche/blktests? That code should no longer 
> > > > > fail if
> > > > > unloading the nvme kernel module fails. Please note that you will need
> > > > > kernel v4.18 to test these scripts - a KASAN complaint appears if I 
> > > > > run
> > > > > these tests against kernel v4.19-rc4.
> > > > 
> > > > Thanks, these pass now. Is it expected that my nvme device gets a
> > > > multipath device configured after running these tests?
> > > > 
> > > > $ lsblk
> > > > NAME MAJ:MIN RM SIZE RO TYPE  MOUNTPOINT
> > > > vda  254:00  16G  0 disk
> > > > └─vda1   254:10  16G  0 part  /
> > > > vdb  254:16   0   8G  0 disk
> > > > vdc  254:32   0   8G  0 disk
> > > > vdd  254:48   0   8G  0 disk
> > > > nvme0n1  259:00   8G  0 disk
> > > > └─mpatha 253:00   8G  0 mpath
> > > 
> > > No, all multipath devices that were created during a test should be 
> > > removed
> > > before that test finishes. I will look into this.
> > > 
> > > > Also, can you please fix:
> > > > 
> > > > _have_kernel_option NVME_MULTIPATH && exit 1
> > > > 
> > > > to not exit on failure? It should use SKIP_REASON and return 1. You
> > > > might need to add something like _dont_have_kernel_option to properly
> > > > handle the case where the config is not found.
> > > 
> > > OK, I will change this.
> > > 
> > > > Side note which isn't a blocker for merging is that there's a lot of
> > > > duplicated code between these helpers and the srp helpers. How hard
> > > > would it be to refactor that?
> > > 
> > > Are you perhaps referring to the code that is shared between the
> > > tests/srp/rc tests/nvmeof-mp/rc shell scripts?
> > 
> > Yes, those.
> > 
> > > The hardest part is probably
> > > to chose a location where to store these functions. Should I create a file
> > > with common code under common/, under tests/srp/, under tests/nvmeof-mp/ 
> > > or
> > > perhaps somewhere else?
> > 
> > Just put it under common.
> 
> Hi Omar,
> 
> All feedback mentioned above has been addressed. The following pull request 
> has
> been updated: https://github.com/osandov/blktests/pull/33. Please let me know
> if you want me to post these patches on the linux-block mailing list.
> 
> Note: neither the upstream kernel v4.18 nor v4.19-rc4 are stable enough to 
> pass
> all nvmeof-mp tests if kernel debugging options like KASAN are enabled.
> Additionally, the NVMe device_add_disk() race condition often causes 
> multipathd
> to refuse to consider /dev/nvme... devices. The output on my test setup is as
> follows (all tests pass):
> 
> # ./check -q nvmeof-mp
> nvmeof-mp/001 (Log in and log out)   [passed]
> runtime  1.528s  ...  1.909s
> nvmeof-mp/002 (File I/O on top of multipath concurrently with logout and 
> login (mq)) [
> passed]time  38.968s  ...
> runtime  38.968s  ...  38.571s
> nvmeof-mp/004 (File I/O on top of multipath concurrently with logout and 
> login (sq-on-
> nvmeof-mp/004 (File I/O on top of multipath concurrently with logout and 
> login (sq-on-
> mq)) [passed]38.632s  ...
> runtime  38.632s  ...  37.529s
> nvmeof-mp/005 (Direct I/O with large transfer sizes and bs=4M) [passed]
> runtime  13.382s  ...  13.684s
> nvmeof-mp/006 (Direct I/O with large transfer sizes and bs=8M) [passed]
> runtime  13.511s  ...  13.480s
> nvmeof-mp/009 (Buffered I/O with large transfer sizes and bs=4M) [passed]
> runtime  13.665s  ...  13.763s
> nvmeof-mp/010 (Buffered I/O with large transfer sizes and bs=8M) [passed]
> runtime  13.442s  ...  13.900s
> nvmeof-mp/011 (Block I/O on top of multipath concurrently with logout and 
> login) [pass
> ed] runtime  37.988s  ...
> runtime  37.988s  ...  37.945s
> nvmeof-mp/012 (dm-mpath on top of multiple I/O schedulers)   [passed]
> runtime  21.659s  ...  21.733s

Thanks, Bart, merged.


Re: [PATCH blktests 0/3] Add NVMeOF multipath tests

2018-09-27 Thread Bart Van Assche
On Tue, 2018-09-18 at 17:18 -0700, Omar Sandoval wrote:
> On Tue, Sep 18, 2018 at 05:02:47PM -0700, Bart Van Assche wrote:
> > On 9/18/18 4:24 PM, Omar Sandoval wrote:
> > > On Tue, Sep 18, 2018 at 02:20:59PM -0700, Bart Van Assche wrote:
> > > > Can you have a look at the updated master branch of
> > > > https://github.com/bvanassche/blktests? That code should no longer fail 
> > > > if
> > > > unloading the nvme kernel module fails. Please note that you will need
> > > > kernel v4.18 to test these scripts - a KASAN complaint appears if I run
> > > > these tests against kernel v4.19-rc4.
> > > 
> > > Thanks, these pass now. Is it expected that my nvme device gets a
> > > multipath device configured after running these tests?
> > > 
> > > $ lsblk
> > > NAME MAJ:MIN RM SIZE RO TYPE  MOUNTPOINT
> > > vda  254:00  16G  0 disk
> > > └─vda1   254:10  16G  0 part  /
> > > vdb  254:16   0   8G  0 disk
> > > vdc  254:32   0   8G  0 disk
> > > vdd  254:48   0   8G  0 disk
> > > nvme0n1  259:00   8G  0 disk
> > > └─mpatha 253:00   8G  0 mpath
> > 
> > No, all multipath devices that were created during a test should be removed
> > before that test finishes. I will look into this.
> > 
> > > Also, can you please fix:
> > > 
> > >   _have_kernel_option NVME_MULTIPATH && exit 1
> > > 
> > > to not exit on failure? It should use SKIP_REASON and return 1. You
> > > might need to add something like _dont_have_kernel_option to properly
> > > handle the case where the config is not found.
> > 
> > OK, I will change this.
> > 
> > > Side note which isn't a blocker for merging is that there's a lot of
> > > duplicated code between these helpers and the srp helpers. How hard
> > > would it be to refactor that?
> > 
> > Are you perhaps referring to the code that is shared between the
> > tests/srp/rc tests/nvmeof-mp/rc shell scripts?
> 
> Yes, those.
> 
> > The hardest part is probably
> > to chose a location where to store these functions. Should I create a file
> > with common code under common/, under tests/srp/, under tests/nvmeof-mp/ or
> > perhaps somewhere else?
> 
> Just put it under common.

Hi Omar,

All feedback mentioned above has been addressed. The following pull request has
been updated: https://github.com/osandov/blktests/pull/33. Please let me know
if you want me to post these patches on the linux-block mailing list.

Note: neither the upstream kernel v4.18 nor v4.19-rc4 are stable enough to pass
all nvmeof-mp tests if kernel debugging options like KASAN are enabled.
Additionally, the NVMe device_add_disk() race condition often causes multipathd
to refuse to consider /dev/nvme... devices. The output on my test setup is as
follows (all tests pass):

# ./check -q nvmeof-mp
nvmeof-mp/001 (Log in and log out)   [passed]
runtime  1.528s  ...  1.909s
nvmeof-mp/002 (File I/O on top of multipath concurrently with logout and login 
(mq)) [
passed]time  38.968s  ...
runtime  38.968s  ...  38.571s
nvmeof-mp/004 (File I/O on top of multipath concurrently with logout and login 
(sq-on-
nvmeof-mp/004 (File I/O on top of multipath concurrently with logout and login 
(sq-on-
mq)) [passed]38.632s  ...
runtime  38.632s  ...  37.529s
nvmeof-mp/005 (Direct I/O with large transfer sizes and bs=4M) [passed]
runtime  13.382s  ...  13.684s
nvmeof-mp/006 (Direct I/O with large transfer sizes and bs=8M) [passed]
runtime  13.511s  ...  13.480s
nvmeof-mp/009 (Buffered I/O with large transfer sizes and bs=4M) [passed]
runtime  13.665s  ...  13.763s
nvmeof-mp/010 (Buffered I/O with large transfer sizes and bs=8M) [passed]
runtime  13.442s  ...  13.900s
nvmeof-mp/011 (Block I/O on top of multipath concurrently with logout and 
login) [pass
ed] runtime  37.988s  ...
runtime  37.988s  ...  37.945s
nvmeof-mp/012 (dm-mpath on top of multiple I/O schedulers)   [passed]
runtime  21.659s  ...  21.733s

Thanks,

Bart.



Re: [PATCH blktests 0/3] Add NVMeOF multipath tests

2018-09-18 Thread Omar Sandoval
On Tue, Sep 18, 2018 at 05:02:47PM -0700, Bart Van Assche wrote:
> On 9/18/18 4:24 PM, Omar Sandoval wrote:
> > On Tue, Sep 18, 2018 at 02:20:59PM -0700, Bart Van Assche wrote:
> > > Can you have a look at the updated master branch of
> > > https://github.com/bvanassche/blktests? That code should no longer fail if
> > > unloading the nvme kernel module fails. Please note that you will need
> > > kernel v4.18 to test these scripts - a KASAN complaint appears if I run
> > > these tests against kernel v4.19-rc4.
> > 
> > Thanks, these pass now. Is it expected that my nvme device gets a
> > multipath device configured after running these tests?
> > 
> > $ lsblk
> > NAME MAJ:MIN RM SIZE RO TYPE  MOUNTPOINT
> > vda  254:00  16G  0 disk
> > └─vda1   254:10  16G  0 part  /
> > vdb  254:16   0   8G  0 disk
> > vdc  254:32   0   8G  0 disk
> > vdd  254:48   0   8G  0 disk
> > nvme0n1  259:00   8G  0 disk
> > └─mpatha 253:00   8G  0 mpath
> 
> No, all multipath devices that were created during a test should be removed
> before that test finishes. I will look into this.
> 
> > Also, can you please fix:
> > 
> > _have_kernel_option NVME_MULTIPATH && exit 1
> > 
> > to not exit on failure? It should use SKIP_REASON and return 1. You
> > might need to add something like _dont_have_kernel_option to properly
> > handle the case where the config is not found.
> 
> OK, I will change this.
> 
> > Side note which isn't a blocker for merging is that there's a lot of
> > duplicated code between these helpers and the srp helpers. How hard
> > would it be to refactor that?
> 
> Are you perhaps referring to the code that is shared between the
> tests/srp/rc tests/nvmeof-mp/rc shell scripts?

Yes, those.

> The hardest part is probably
> to chose a location where to store these functions. Should I create a file
> with common code under common/, under tests/srp/, under tests/nvmeof-mp/ or
> perhaps somewhere else?

Just put it under common.

Thanks!


Re: [PATCH blktests 0/3] Add NVMeOF multipath tests

2018-09-18 Thread Bart Van Assche

On 9/18/18 4:24 PM, Omar Sandoval wrote:

On Tue, Sep 18, 2018 at 02:20:59PM -0700, Bart Van Assche wrote:

Can you have a look at the updated master branch of
https://github.com/bvanassche/blktests? That code should no longer fail if
unloading the nvme kernel module fails. Please note that you will need
kernel v4.18 to test these scripts - a KASAN complaint appears if I run
these tests against kernel v4.19-rc4.


Thanks, these pass now. Is it expected that my nvme device gets a
multipath device configured after running these tests?

$ lsblk
NAME MAJ:MIN RM SIZE RO TYPE  MOUNTPOINT
vda  254:00  16G  0 disk
└─vda1   254:10  16G  0 part  /
vdb  254:16   0   8G  0 disk
vdc  254:32   0   8G  0 disk
vdd  254:48   0   8G  0 disk
nvme0n1  259:00   8G  0 disk
└─mpatha 253:00   8G  0 mpath


No, all multipath devices that were created during a test should be 
removed before that test finishes. I will look into this.



Also, can you please fix:

_have_kernel_option NVME_MULTIPATH && exit 1

to not exit on failure? It should use SKIP_REASON and return 1. You
might need to add something like _dont_have_kernel_option to properly
handle the case where the config is not found.


OK, I will change this.


Side note which isn't a blocker for merging is that there's a lot of
duplicated code between these helpers and the srp helpers. How hard
would it be to refactor that?


Are you perhaps referring to the code that is shared between the 
tests/srp/rc tests/nvmeof-mp/rc shell scripts? The hardest part is 
probably to chose a location where to store these functions. Should I 
create a file with common code under common/, under tests/srp/, under 
tests/nvmeof-mp/ or perhaps somewhere else?


Thanks,

Bart.




Re: [PATCH blktests 0/3] Add NVMeOF multipath tests

2018-09-18 Thread Omar Sandoval
On Tue, Sep 18, 2018 at 02:20:59PM -0700, Bart Van Assche wrote:
> On 8/23/18 5:21 PM, Omar Sandoval wrote:
> > On Thu, Aug 23, 2018 at 01:53:33AM +, Bart Van Assche wrote:
> > > On Tue, 2018-08-21 at 08:46 +0200, Johannes Thumshirn wrote:
> > > > On Mon, Aug 20, 2018 at 03:46:45PM +, Bart Van Assche wrote:
> > > > > Moving these tests into the nvme directory is possible but will make 
> > > > > it
> > > > > harder to run the NVMeOF multipath tests separately. Are you fine 
> > > > > with this?
> > > > 
> > > > Both way's have it's up and downsides, I agree.
> > > > 
> > > > Having two distinct groups requires to run './check nvme nvmeof-mp' to
> > > > run full coverage with nvme.
> > > > 
> > > > Having it all in one group would require to run './check nvme 18 19 20
> > > > 21 22 23 24 ...' to get only the dm-mpath ones.
> > > > 
> > > > Honestly I hate both but your's (the two distinct groups) is probably
> > > > easier to handle in the end, I have to admit.
> > > 
> > > Omar, do you have a preference for one of the two aforementioned 
> > > approaches?
> > 
> > Let's keep it in a separate category, since lots of people running nvme
> > tests probably aren't interested in testing multipath.
> > 
> > A bunch of the tests failed with
> > 
> > modprobe: FATAL: Module nvme is in use.
> > 
> > Maybe related to my test VM having an nvme device?
> 
> Hello Omar,
> 
> Can you have a look at the updated master branch of
> https://github.com/bvanassche/blktests? That code should no longer fail if
> unloading the nvme kernel module fails. Please note that you will need
> kernel v4.18 to test these scripts - a KASAN complaint appears if I run
> these tests against kernel v4.19-rc4.

Thanks, these pass now. Is it expected that my nvme device gets a
multipath device configured after running these tests?

$ lsblk
NAME MAJ:MIN RM SIZE RO TYPE  MOUNTPOINT
vda  254:00  16G  0 disk
└─vda1   254:10  16G  0 part  /
vdb  254:16   0   8G  0 disk
vdc  254:32   0   8G  0 disk
vdd  254:48   0   8G  0 disk
nvme0n1  259:00   8G  0 disk
└─mpatha 253:00   8G  0 mpath

Also, can you please fix:

_have_kernel_option NVME_MULTIPATH && exit 1

to not exit on failure? It should use SKIP_REASON and return 1. You
might need to add something like _dont_have_kernel_option to properly
handle the case where the config is not found.

Side note which isn't a blocker for merging is that there's a lot of
duplicated code between these helpers and the srp helpers. How hard
would it be to refactor that?


Re: [PATCH blktests 0/3] Add NVMeOF multipath tests

2018-09-18 Thread Bart Van Assche

On 8/23/18 5:21 PM, Omar Sandoval wrote:

On Thu, Aug 23, 2018 at 01:53:33AM +, Bart Van Assche wrote:

On Tue, 2018-08-21 at 08:46 +0200, Johannes Thumshirn wrote:

On Mon, Aug 20, 2018 at 03:46:45PM +, Bart Van Assche wrote:

Moving these tests into the nvme directory is possible but will make it
harder to run the NVMeOF multipath tests separately. Are you fine with this?


Both way's have it's up and downsides, I agree.

Having two distinct groups requires to run './check nvme nvmeof-mp' to
run full coverage with nvme.

Having it all in one group would require to run './check nvme 18 19 20
21 22 23 24 ...' to get only the dm-mpath ones.

Honestly I hate both but your's (the two distinct groups) is probably
easier to handle in the end, I have to admit.


Omar, do you have a preference for one of the two aforementioned approaches?


Let's keep it in a separate category, since lots of people running nvme
tests probably aren't interested in testing multipath.

A bunch of the tests failed with

modprobe: FATAL: Module nvme is in use.

Maybe related to my test VM having an nvme device?


Hello Omar,

Can you have a look at the updated master branch of 
https://github.com/bvanassche/blktests? That code should no longer fail 
if unloading the nvme kernel module fails. Please note that you will 
need kernel v4.18 to test these scripts - a KASAN complaint appears if I 
run these tests against kernel v4.19-rc4.


Thanks,

Bart.



Re: [PATCH blktests 0/3] Add NVMeOF multipath tests

2018-09-15 Thread Bart Van Assche

On 09/12/18 18:06, Omar Sandoval wrote:

Ping, Bart, can you look into this? It'd be nice to get this in.


Hello Omar,

I will repost this patch series as soon as I have the time. I have been 
more busy than usual during the past four weeks.


Best regards,

Bart.




Re: [PATCH blktests 0/3] Add NVMeOF multipath tests

2018-09-12 Thread Omar Sandoval
On Thu, Aug 23, 2018 at 05:21:33PM -0700, Omar Sandoval wrote:
> On Thu, Aug 23, 2018 at 01:53:33AM +, Bart Van Assche wrote:
> > On Tue, 2018-08-21 at 08:46 +0200, Johannes Thumshirn wrote:
> > > On Mon, Aug 20, 2018 at 03:46:45PM +, Bart Van Assche wrote:
> > > > Moving these tests into the nvme directory is possible but will make it
> > > > harder to run the NVMeOF multipath tests separately. Are you fine with 
> > > > this?
> > > 
> > > Both way's have it's up and downsides, I agree.
> > > 
> > > Having two distinct groups requires to run './check nvme nvmeof-mp' to
> > > run full coverage with nvme.
> > > 
> > > Having it all in one group would require to run './check nvme 18 19 20
> > > 21 22 23 24 ...' to get only the dm-mpath ones.
> > > 
> > > Honestly I hate both but your's (the two distinct groups) is probably
> > > easier to handle in the end, I have to admit.
> > 
> > Omar, do you have a preference for one of the two aforementioned approaches?
> > 
> > Thanks,
> > 
> > Bart.
> > 
> 
> Let's keep it in a separate category, since lots of people running nvme
> tests probably aren't interested in testing multipath.
> 
> A bunch of the tests failed with
> 
> modprobe: FATAL: Module nvme is in use.
> 
> Maybe related to my test VM having an nvme device?

Ping, Bart, can you look into this? It'd be nice to get this in.


Re: [PATCH blktests 0/3] Add NVMeOF multipath tests

2018-08-23 Thread Omar Sandoval
On Thu, Aug 23, 2018 at 01:53:33AM +, Bart Van Assche wrote:
> On Tue, 2018-08-21 at 08:46 +0200, Johannes Thumshirn wrote:
> > On Mon, Aug 20, 2018 at 03:46:45PM +, Bart Van Assche wrote:
> > > Moving these tests into the nvme directory is possible but will make it
> > > harder to run the NVMeOF multipath tests separately. Are you fine with 
> > > this?
> > 
> > Both way's have it's up and downsides, I agree.
> > 
> > Having two distinct groups requires to run './check nvme nvmeof-mp' to
> > run full coverage with nvme.
> > 
> > Having it all in one group would require to run './check nvme 18 19 20
> > 21 22 23 24 ...' to get only the dm-mpath ones.
> > 
> > Honestly I hate both but your's (the two distinct groups) is probably
> > easier to handle in the end, I have to admit.
> 
> Omar, do you have a preference for one of the two aforementioned approaches?
> 
> Thanks,
> 
> Bart.
> 

Let's keep it in a separate category, since lots of people running nvme
tests probably aren't interested in testing multipath.

A bunch of the tests failed with

modprobe: FATAL: Module nvme is in use.

Maybe related to my test VM having an nvme device?


Re: [PATCH blktests 0/3] Add NVMeOF multipath tests

2018-08-22 Thread Bart Van Assche
On Tue, 2018-08-21 at 08:46 +0200, Johannes Thumshirn wrote:
> On Mon, Aug 20, 2018 at 03:46:45PM +, Bart Van Assche wrote:
> > Moving these tests into the nvme directory is possible but will make it
> > harder to run the NVMeOF multipath tests separately. Are you fine with this?
> 
> Both way's have it's up and downsides, I agree.
> 
> Having two distinct groups requires to run './check nvme nvmeof-mp' to
> run full coverage with nvme.
> 
> Having it all in one group would require to run './check nvme 18 19 20
> 21 22 23 24 ...' to get only the dm-mpath ones.
> 
> Honestly I hate both but your's (the two distinct groups) is probably
> easier to handle in the end, I have to admit.

Omar, do you have a preference for one of the two aforementioned approaches?

Thanks,

Bart.



Re: [PATCH blktests 0/3] Add NVMeOF multipath tests

2018-08-21 Thread Johannes Thumshirn
On Mon, Aug 20, 2018 at 03:46:45PM +, Bart Van Assche wrote:
> Moving these tests into the nvme directory is possible but will make it
> harder to run the NVMeOF multipath tests separately. Are you fine with this?

Both way's have it's up and downsides, I agree.

Having two distinct groups requires to run './check nvme nvmeof-mp' to
run full coverage with nvme.

Having it all in one group would require to run './check nvme 18 19 20
21 22 23 24 ...' to get only the dm-mpath ones.

Honestly I hate both but your's (the two distinct groups) is probably
easier to handle in the end, I have to admit.

Thanks,
Johannes
-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850


Re: [PATCH blktests 0/3] Add NVMeOF multipath tests

2018-08-20 Thread Bart Van Assche
On Mon, 2018-08-20 at 09:31 +0200, Johannes Thumshirn wrote:
> On Wed, Aug 15, 2018 at 01:37:25PM -0700, Bart Van Assche wrote:
> > Hello Omar,
> > 
> > The three patches in this series add several NVMeOF multipath tests. These
> > tests are similar in nature to the SRP tests. Please consider these patches
> > for the upstream blktests repository.
> 
> Hi Bart,
> 
> is there a special reason this isn't in the nvme category? I don't
> really see a blocker here.

Hello Johannes,

Moving these tests into the nvme directory is possible but will make it
harder to run the NVMeOF multipath tests separately. Are you fine with this?

Bart.



Re: [PATCH blktests 0/3] Add NVMeOF multipath tests

2018-08-20 Thread Johannes Thumshirn
On Wed, Aug 15, 2018 at 01:37:25PM -0700, Bart Van Assche wrote:
> Hello Omar,
> 
> The three patches in this series add several NVMeOF multipath tests. These
> tests are similar in nature to the SRP tests. Please consider these patches
> for the upstream blktests repository.

Hi Bart,

is there a special reason this isn't in the nvme category? I don't
really see a blocker here.

Thanks,
Johannes
-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850


[PATCH blktests 0/3] Add NVMeOF multipath tests

2018-08-15 Thread Bart Van Assche
Hello Omar,

The three patches in this series add several NVMeOF multipath tests. These
tests are similar in nature to the SRP tests. Please consider these patches
for the upstream blktests repository.

Thanks,

Bart.

Bart Van Assche (3):
  tests/srp: Remove unused code
  tests/srp: Remove /etc/multipath.conf after a test has finished
  Add NVMeOF dm-mpath tests

 tests/nvmeof-mp/.gitignore|   1 +
 tests/nvmeof-mp/001   |  50 ++
 tests/nvmeof-mp/001.out   |   3 +
 tests/nvmeof-mp/002   |  50 ++
 tests/nvmeof-mp/002.out   |   2 +
 tests/nvmeof-mp/004   |  50 ++
 tests/nvmeof-mp/004.out   |   2 +
 tests/nvmeof-mp/005   |  40 ++
 tests/nvmeof-mp/005.out   |   2 +
 tests/nvmeof-mp/006   |  40 ++
 tests/nvmeof-mp/006.out   |   2 +
 tests/nvmeof-mp/009   |  40 ++
 tests/nvmeof-mp/009.out   |   2 +
 tests/nvmeof-mp/010   |  40 ++
 tests/nvmeof-mp/010.out   |   2 +
 tests/nvmeof-mp/011   |  46 ++
 tests/nvmeof-mp/011.out   |   2 +
 tests/nvmeof-mp/012   |  53 ++
 tests/nvmeof-mp/012.out   |   2 +
 tests/nvmeof-mp/getuid_callout|  11 +
 tests/nvmeof-mp/multipath.conf.in |  28 +
 tests/nvmeof-mp/rc| 936 ++
 tests/srp/001 |  19 +-
 tests/srp/002 |   2 +-
 tests/srp/003 |   2 +-
 tests/srp/004 |   2 +-
 tests/srp/011 |   2 +-
 tests/srp/rc  | 236 +---
 28 files changed, 1435 insertions(+), 232 deletions(-)
 create mode 100644 tests/nvmeof-mp/.gitignore
 create mode 100755 tests/nvmeof-mp/001
 create mode 100644 tests/nvmeof-mp/001.out
 create mode 100755 tests/nvmeof-mp/002
 create mode 100644 tests/nvmeof-mp/002.out
 create mode 100755 tests/nvmeof-mp/004
 create mode 100644 tests/nvmeof-mp/004.out
 create mode 100755 tests/nvmeof-mp/005
 create mode 100644 tests/nvmeof-mp/005.out
 create mode 100755 tests/nvmeof-mp/006
 create mode 100644 tests/nvmeof-mp/006.out
 create mode 100755 tests/nvmeof-mp/009
 create mode 100644 tests/nvmeof-mp/009.out
 create mode 100755 tests/nvmeof-mp/010
 create mode 100644 tests/nvmeof-mp/010.out
 create mode 100755 tests/nvmeof-mp/011
 create mode 100644 tests/nvmeof-mp/011.out
 create mode 100755 tests/nvmeof-mp/012
 create mode 100644 tests/nvmeof-mp/012.out
 create mode 100755 tests/nvmeof-mp/getuid_callout
 create mode 100644 tests/nvmeof-mp/multipath.conf.in
 create mode 100755 tests/nvmeof-mp/rc

-- 
2.18.0