Re: [PATCH 5/7] aio: Fix fallback I/O priority value

[Adam Manzanares]

On Mon, 2018-11-19 at 12:51 +0900, Damien Le Moal wrote:
> For cases when the application does not specify aio_reqprio for an
> aio,
> fallback to use get_current_ioprio() to obtain the task I/O priority
> last set using ioprio_set() rather than the hardcoded
> IOPRIO_CLASS_NONE
> value.
> 
> Signed-off-by: Damien Le Moal 

Looks good,

Reviewed-by: Adam Manzanares 

> ---
>  fs/aio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/aio.c b/fs/aio.c
> index 301e6314183b..b984918be4b7 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -1441,7 +1441,7 @@ static int aio_prep_rw(struct kiocb *req,
> struct iocb *iocb)
>  
>   req->ki_ioprio = iocb->aio_reqprio;
>   } else
> - req->ki_ioprio = IOPRIO_PRIO_VALUE(IOPRIO_CLASS_NONE,
> 0);
> + req->ki_ioprio = get_current_ioprio();
>  
>   ret = kiocb_set_rw_flags(req, iocb->aio_rw_flags);
>   if (unlikely(ret))

Re: [PATCH 5/7] aio: Fix fallback I/O priority value

[Johannes Thumshirn]

Looks good,
Reiewed-by: Johannes Thumshirn 

-- 
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Re: [PATCH 5/7] aio: Fix fallback I/O priority value

[Christoph Hellwig]

On Mon, Nov 19, 2018 at 12:51:29PM +0900, Damien Le Moal wrote:
> For cases when the application does not specify aio_reqprio for an aio,
> fallback to use get_current_ioprio() to obtain the task I/O priority
> last set using ioprio_set() rather than the hardcoded IOPRIO_CLASS_NONE
> value.
> 
> Signed-off-by: Damien Le Moal 

Looks good,

Reviewed-by: Christoph Hellwig