Re: [PATCH] btrfs: Remove extra parentheses from condition in copy_items()

[Christoph Hellwig]

> - if ((i == (nr - 1)))
> + if (i == (nr - 1))

Please remove the other set of redundant parentheses as well if you
change that line.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] btrfs: Remove extra parentheses from condition in copy_items()

[Matthias Kaehlcke]

There is no need for the extra pair of parentheses, remove it. This
fixes the following warning when building with clang:

fs/btrfs/tree-log.c:3694:10: warning: equality comparison with extraneous
  parentheses [-Wparentheses-equality]
if ((i == (nr - 1)))
 ~~^~~

Signed-off-by: Matthias Kaehlcke 
---
 fs/btrfs/tree-log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
index f20ef211a73d..b92408a3f834 100644
--- a/fs/btrfs/tree-log.c
+++ b/fs/btrfs/tree-log.c
@@ -3691,7 +3691,7 @@ static noinline int copy_items(struct btrfs_trans_handle 
*trans,
 
src_offset = btrfs_item_ptr_offset(src, start_slot + i);
 
-   if ((i == (nr - 1)))
+   if (i == (nr - 1))
last_key = ins_keys[i];
 
if (ins_keys[i].type == BTRFS_INODE_ITEM_KEY) {
-- 
2.14.0.rc0.400.g1c36432dff-goog

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html